Complex classes like BaseJobManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use BaseJobManager, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | abstract class BaseJobManager extends PriorityJobManager |
||
17 | { |
||
18 | /** Number of jobs to prune / reset / gather at a time */ |
||
19 | const FETCH_COUNT = 100; |
||
20 | |||
21 | /** Number of seconds before a job is considered stalled if the runner is no longer active */ |
||
22 | const STALLED_SECONDS = 1800; |
||
23 | protected $objectManager; |
||
24 | protected $objectName; |
||
25 | protected $archiveObjectName; |
||
26 | protected $runClass; |
||
27 | protected $runArchiveClass; |
||
28 | |||
29 | /** |
||
30 | * @param string $objectName |
||
31 | * @param string $archiveObjectName |
||
32 | * @param string $runClass |
||
33 | * @param string $runArchiveClass |
||
34 | */ |
||
35 | 11 | public function __construct(ObjectManager $objectManager, |
|
47 | |||
48 | /** |
||
49 | * @return ObjectManager |
||
50 | */ |
||
51 | 36 | public function getObjectManager() |
|
55 | |||
56 | /** |
||
57 | * @return string |
||
58 | */ |
||
59 | 34 | public function getObjectName() |
|
63 | |||
64 | /** |
||
65 | * @return string |
||
66 | */ |
||
67 | 22 | public function getArchiveObjectName() |
|
71 | |||
72 | /** |
||
73 | * @return string |
||
74 | */ |
||
75 | 4 | public function getRunClass() |
|
79 | |||
80 | /** |
||
81 | * @return string |
||
82 | */ |
||
83 | 5 | public function getRunArchiveClass() |
|
87 | |||
88 | /** |
||
89 | * @return ObjectRepository |
||
90 | */ |
||
91 | 27 | public function getRepository() |
|
95 | |||
96 | /** |
||
97 | * @param string $objectName |
||
98 | */ |
||
99 | abstract protected function countJobsByStatus($objectName, $status, $workerName = null, $method = null); |
||
100 | |||
101 | 2 | public function resetErroneousJobs($workerName = null, $method = null) |
|
102 | { |
||
103 | 2 | $count = $this->countJobsByStatus($this->getArchiveObjectName(), Job::STATUS_ERROR, $workerName, $method); |
|
104 | |||
105 | 2 | $criterion = ['status' => Job::STATUS_ERROR]; |
|
106 | 2 | $this->addWorkerNameMethod($criterion, $workerName, $method); |
|
107 | |||
108 | 2 | $countProcessed = 0; |
|
109 | 2 | for ($i = 0; $i < $count; $i += static::FETCH_COUNT) { |
|
110 | 2 | $countProcessed += $this->resetJobsByCriterion( |
|
111 | 2 | $criterion, static::FETCH_COUNT, $i); |
|
112 | 2 | } |
|
113 | |||
114 | 2 | return $countProcessed; |
|
115 | } |
||
116 | |||
117 | /** |
||
118 | * Sets the status to Job::STATUS_EXPIRED for those jobs that are expired. |
||
119 | * |
||
120 | * @param null $workerName |
||
121 | * @param null $method |
||
122 | * |
||
123 | * @return mixed |
||
124 | */ |
||
125 | abstract protected function updateExpired($workerName = null, $method = null); |
||
126 | |||
127 | 9 | protected function addWorkerNameMethod(array &$criterion, $workerName = null, $method = null) |
|
136 | |||
137 | 3 | public function pruneExpiredJobs($workerName = null, $method = null) |
|
160 | |||
161 | 8 | protected function flush() |
|
165 | |||
166 | 4 | protected function getStalledJobs($workerName = null, $method = null) |
|
177 | |||
178 | 4 | protected function findRunningJobs($criterion, $count) |
|
179 | { |
||
180 | 4 | $repository = $this->getRepository(); |
|
181 | 4 | $runningJobsById = []; |
|
182 | |||
183 | 4 | for ($i = 0; $i < $count; $i += static::FETCH_COUNT) { |
|
184 | 4 | $runningJobs = $repository->findBy($criterion, null, static::FETCH_COUNT, $i); |
|
185 | 4 | if (!empty($runningJobs)) { |
|
186 | 4 | foreach ($runningJobs as $job) { |
|
187 | /** @var RetryableJob $job */ |
||
188 | 4 | if (null !== $runId = $job->getRunId()) { |
|
189 | 4 | $runningJobsById[$runId][] = $job; |
|
190 | 4 | } |
|
191 | 4 | } |
|
192 | 4 | } |
|
193 | 4 | } |
|
194 | |||
195 | 4 | return $runningJobsById; |
|
196 | } |
||
197 | |||
198 | 4 | protected function extractStalledJobs(array $runningJobsById) |
|
199 | { |
||
200 | 4 | $objectManager = $this->getObjectManager(); |
|
201 | 4 | $runRepository = $objectManager->getRepository($this->runClass); |
|
202 | /** @var EntityRepository|DocumentRepository $runArchiveRepository */ |
||
203 | 4 | $runArchiveRepository = $objectManager->getRepository($this->runArchiveClass); |
|
204 | |||
205 | 4 | $stalledJobs = []; |
|
206 | 4 | foreach (array_keys($runningJobsById) as $runId) { |
|
207 | 4 | if ($runRepository->find($runId)) { |
|
208 | continue; |
||
209 | } |
||
210 | /** @var Run $run */ |
||
211 | 4 | if ($run = $runArchiveRepository->find($runId)) { |
|
212 | 4 | if ($endTime = $run->getEndedAt()) { |
|
213 | // Did it end over an hour ago |
||
214 | 4 | if ((time() - $endTime->getTimestamp()) > static::STALLED_SECONDS) { |
|
215 | 4 | $stalledJobs = array_merge($stalledJobs, $runningJobsById[$runId]); |
|
216 | 4 | } |
|
217 | 4 | } |
|
218 | 4 | } |
|
219 | 4 | } |
|
220 | |||
221 | 4 | return $stalledJobs; |
|
222 | } |
||
223 | |||
224 | 6 | protected function updateMaxStatus(RetryableJob $job, $status, $max = null, $count = 0) |
|
234 | |||
235 | 2 | public function resetStalledJobs($workerName = null, $method = null) |
|
236 | { |
||
237 | 2 | $stalledJobs = $this->getStalledJobs($workerName, $method); |
|
238 | |||
239 | 2 | $objectManager = $this->getObjectManager(); |
|
240 | |||
241 | 2 | $countProcessed = 0; |
|
242 | 2 | for ($i = 0, $count = count($stalledJobs); $i < $count; $i += static::FETCH_COUNT) { |
|
243 | 2 | for ($j = $i, $max = $i + static::FETCH_COUNT; $j < $max && $j < $count; ++$j) { |
|
244 | 2 | $job = $stalledJobs[$j]; |
|
245 | /* RetryableJob $job */ |
||
246 | 2 | $job->setStalledCount($job->getStalledCount() + 1); |
|
247 | 2 | if ($this->updateMaxStatus($job, RetryableJob::STATUS_MAX_STALLED, $job->getMaxStalled(), $job->getStalledCount())) { |
|
248 | $objectManager->remove($job); |
||
249 | continue; |
||
250 | 2 | } elseif ($this->updateMaxStatus($job, RetryableJob::STATUS_MAX_RETRIES, $job->getMaxRetries(), $job->getRetries())) { |
|
251 | $objectManager->remove($job); |
||
252 | continue; |
||
253 | } |
||
254 | |||
255 | 2 | $job->setRetries($job->getRetries() + 1); |
|
256 | 2 | $job->setStatus(BaseJob::STATUS_NEW); |
|
257 | 2 | $job->setLocked(null); |
|
258 | 2 | $job->setLockedAt(null); |
|
259 | 2 | $objectManager->persist($job); |
|
260 | 2 | ++$countProcessed; |
|
261 | 2 | } |
|
262 | 2 | $this->flush(); |
|
263 | 2 | } |
|
264 | |||
265 | 2 | return $countProcessed; |
|
266 | } |
||
267 | |||
268 | /** |
||
269 | * @param string $workerName |
||
270 | * @param string $method |
||
271 | */ |
||
272 | 2 | public function pruneStalledJobs($workerName = null, $method = null) |
|
273 | { |
||
274 | 2 | $stalledJobs = $this->getStalledJobs($workerName, $method); |
|
275 | 2 | $objectManager = $this->getObjectManager(); |
|
276 | |||
277 | 2 | $countProcessed = 0; |
|
278 | 2 | for ($i = 0, $count = count($stalledJobs); $i < $count; $i += static::FETCH_COUNT) { |
|
279 | 2 | for ($j = $i, $max = $i + static::FETCH_COUNT; $j < $max && $j < $count; ++$j) { |
|
280 | /** @var RetryableJob $job */ |
||
281 | 2 | $job = $stalledJobs[$j]; |
|
282 | 2 | $job->setStalledCount($job->getStalledCount() + 1); |
|
283 | 2 | $job->setStatus(BaseJob::STATUS_ERROR); |
|
284 | 2 | $job->setMessage('stalled'); |
|
285 | 2 | $this->updateMaxStatus($job, RetryableJob::STATUS_MAX_STALLED, $job->getMaxStalled(), $job->getStalledCount()); |
|
286 | 2 | $objectManager->remove($job); |
|
287 | 2 | ++$countProcessed; |
|
288 | 2 | } |
|
289 | 2 | $this->flush(); |
|
290 | 2 | } |
|
291 | |||
292 | 2 | return $countProcessed; |
|
293 | } |
||
294 | |||
295 | 10 | public function deleteJob(\Dtc\QueueBundle\Model\Job $job) |
|
301 | |||
302 | 2 | public function saveHistory(\Dtc\QueueBundle\Model\Job $job) |
|
306 | |||
307 | 31 | protected function prioritySave(\Dtc\QueueBundle\Model\Job $job) |
|
308 | { |
||
309 | // Generate crc hash for the job |
||
310 | 31 | $hashValues = array($job->getClassName(), $job->getMethod(), $job->getWorkerName(), $job->getArgs()); |
|
311 | 31 | $crcHash = hash('sha256', serialize($hashValues)); |
|
312 | 31 | $job->setCrcHash($crcHash); |
|
313 | 31 | $objectManager = $this->getObjectManager(); |
|
314 | |||
315 | 31 | if (true === $job->getBatch()) { |
|
316 | 2 | $oldJob = $this->updateNearestBatch($job); |
|
317 | 2 | if ($oldJob) { |
|
318 | 2 | return $oldJob; |
|
319 | } |
||
320 | } |
||
321 | |||
322 | // Just save a new job |
||
323 | 31 | $this->resetSaveOk(__FUNCTION__); |
|
324 | 31 | $objectManager->persist($job); |
|
325 | 31 | $objectManager->flush(); |
|
326 | |||
327 | 31 | return $job; |
|
328 | } |
||
329 | |||
330 | abstract protected function updateNearestBatch(Job $job); |
||
331 | |||
332 | /** |
||
333 | * @param string $objectName |
||
334 | */ |
||
335 | abstract protected function stopIdGenerator($objectName); |
||
336 | |||
337 | abstract protected function restoreIdGenerator($objectName); |
||
338 | |||
339 | /** |
||
340 | * @param array $criterion |
||
341 | * @param int $limit |
||
342 | * @param int $offset |
||
343 | */ |
||
344 | 2 | private function resetJobsByCriterion( |
|
345 | array $criterion, |
||
346 | $limit, |
||
347 | $offset) |
||
348 | { |
||
349 | 2 | $objectManager = $this->getObjectManager(); |
|
350 | 2 | $this->resetSaveOk(__FUNCTION__); |
|
351 | 2 | $objectName = $this->getObjectName(); |
|
352 | 2 | $archiveObjectName = $this->getArchiveObjectName(); |
|
353 | 2 | $jobRepository = $objectManager->getRepository($objectName); |
|
354 | 2 | $jobArchiveRepository = $objectManager->getRepository($archiveObjectName); |
|
355 | 2 | $className = $jobRepository->getClassName(); |
|
356 | 2 | $metadata = $objectManager->getClassMetadata($className); |
|
357 | 2 | $this->stopIdGenerator($objectName); |
|
358 | 2 | $identifierData = $metadata->getIdentifier(); |
|
359 | 2 | $idColumn = isset($identifierData[0]) ? $identifierData[0] : 'id'; |
|
360 | 2 | $results = $jobArchiveRepository->findBy($criterion, [$idColumn => 'ASC'], $limit, $offset); |
|
361 | 2 | $countProcessed = 0; |
|
362 | |||
363 | 2 | foreach ($results as $jobArchive) { |
|
364 | 2 | $this->resetJob($jobArchive, $className, $countProcessed); |
|
365 | 2 | } |
|
366 | 2 | $objectManager->flush(); |
|
367 | |||
368 | 2 | $this->restoreIdGenerator($objectName); |
|
369 | |||
370 | 2 | return $countProcessed; |
|
371 | } |
||
372 | |||
373 | 17 | protected function resetSaveOk($function) |
|
376 | |||
377 | /** |
||
378 | * @param RetryableJob $jobArchive |
||
379 | * @param $className |
||
380 | * @param $countProcessed |
||
381 | */ |
||
382 | 2 | protected function resetJob(RetryableJob $jobArchive, $className, &$countProcessed) |
|
408 | } |
||
409 |