JobTest - Code Metrics - Inspection of "update a few things per scrutinizer" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf1f19...1204eb )

by Matthew

created 2017-11-11 16:43 UTC

JobTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	6
lcom	1
cbo	5
dl	0
loc	56
rs	10
c	1
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
B	testSetArgs()	24	3
A	testGettersSetters()	4	1
A	testChainJobCall()	21	2

<?php

namespace Dtc\QueueBundle\Tests\Model;

use Dtc\QueueBundle\Model\Job;
use Dtc\QueueBundle\Tests\FibonacciWorker;
use Dtc\QueueBundle\Tests\GetterSetterTrait;
use Dtc\QueueBundle\Tests\StaticJobManager;
use PHPUnit\Framework\TestCase;

class JobTest extends TestCase
{
    use GetterSetterTrait;

    public function testSetArgs()
    {
        $worker = new FibonacciWorker();
        $job = new Job($worker, false, null);
        $job->setArgs(array(1));
        $job->setArgs(array(1, array(1, 2)));

        $failed = false;
        try {
            $job->setArgs(array($job));
            $failed = true;
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
        self::assertFalse($failed);

        try {
            $job->setArgs(array(1, array($job)));
            $failed = true;
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
        self::assertFalse($failed);
    }

    public function testGettersSetters()
    {
        $this->runGetterSetterTests('\Dtc\QueueBundle\Model\Job');
    }

    public function testChainJobCall()
    {
        $jobManager = new StaticJobManager();
        $worker = new FibonacciWorker();
        $worker->setJobManager($jobManager);

        $job = new Job($worker, false, null);
        self::assertNull($job->getId(), 'Job id should be null');

        $job->fibonacci(1);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        self::assertNotNull($job->getId(), 'Job id should be generated');

        $failed = false;
        try {
            $job->invalidFunctionCall();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $failed = true;
        } catch (\Exception $e) {
            self::assertTrue(true);
        }
        self::assertFalse($failed);
    }
}


1			<?php
2
3			namespace Dtc\QueueBundle\Tests\Model;
4
5			use Dtc\QueueBundle\Model\Job;
6			use Dtc\QueueBundle\Tests\FibonacciWorker;
7			use Dtc\QueueBundle\Tests\GetterSetterTrait;
8			use Dtc\QueueBundle\Tests\StaticJobManager;
9			use PHPUnit\Framework\TestCase;
10
11			class JobTest extends TestCase
12			{
13			use GetterSetterTrait;
14
15			public function testSetArgs()
16			{
17			$worker = new FibonacciWorker();
18			$job = new Job($worker, false, null);
19			$job->setArgs(array(1));
20			$job->setArgs(array(1, array(1, 2)));
21
22			$failed = false;
23			try {
24			$job->setArgs(array($job));
25			$failed = true;
26			} catch (\Exception $e) {
27			self::assertTrue(true);
28			}
29			self::assertFalse($failed);
30
31			try {
32			$job->setArgs(array(1, array($job)));
33			$failed = true;
34			} catch (\Exception $e) {
35			self::assertTrue(true);
36			}
37			self::assertFalse($failed);
38			}
39
40			public function testGettersSetters()
41			{
42			$this->runGetterSetterTests('\Dtc\QueueBundle\Model\Job');
43			}
44
45			public function testChainJobCall()
46			{
47			$jobManager = new StaticJobManager();
48			$worker = new FibonacciWorker();
49			$worker->setJobManager($jobManager);
50
51			$job = new Job($worker, false, null);
52			self::assertNull($job->getId(), 'Job id should be null');
53
54			$job->fibonacci(1);
			0 ignored issues – show Documentation Bug introduced 2016-01-27 22:30 UTC by Report Bug Copy Issue Report The method `fibonacci` does not exist on `object<Dtc\QueueBundle\Model\Job>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
55			self::assertNotNull($job->getId(), 'Job id should be generated');
56
57			$failed = false;
58			try {
59			$job->invalidFunctionCall();
			0 ignored issues – show Documentation Bug introduced 2017-10-27 02:58 UTC by Report Bug Copy Issue Report The method `invalidFunctionCall` does not exist on `object<Dtc\QueueBundle\Model\Job>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
60			$failed = true;
61			} catch (\Exception $e) {
62			self::assertTrue(true);
63			}
64			self::assertFalse($failed);
65			}
66			}
67

mmucklo / DtcQueueBundle

Push — master ( bf1f19...1204eb )

JobTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like