Predis::zPop() - Code Metrics - Inspection of "4.0 release" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Matthew

created 2018-01-07 02:22 UTC

Predis::zPop() B

↳ Parent: Predis

Complexity

Conditions	3
Paths	2

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	24
ccs	0
cts	20
cp	0
rs	8.9713
c	0
b	0
f	0
cc	3
eloc	15
nc	2
nop	1
crap	12

<?php

namespace Dtc\QueueBundle\Redis;

use Predis\Client;

class Predis implements RedisInterface
{
    protected $predis;
    protected $maxRetries;

    public function __construct(Client $predis, $maxRetries = 5)
    {
        $this->predis = $predis;
        $this->maxRetries = $maxRetries;
    }

    public function zAdd($zkey, $score, $value)
    {
        return $this->predis->zadd($zkey, [$value => $score]);
    }

    public function set($key, $value)
    {
        return $this->predis->set($key, $value);
    }

    public function get($key)
    {
        return $this->predis->get($key);
    }

    public function setEx($key, $seconds, $value)
    {
        return $this->predis->setex($key, $seconds, $value);
    }

    public function lRem($lKey, $count, $value)
    {
        return $this->predis->lrem($lKey, $count, $value);
    }

    public function lPush($lKey, array $values)
    {
        return $this->predis->lpush($lKey, $values);
    }

    public function lRange($lKey, $start, $stop)
    {
        return $this->predis->lrange($lKey, $start, $stop);
    }

    public function del(array $keys)
    {
        return $this->predis->del($keys);
    }

    public function zRem($zkey, $value)
    {
        return $this->predis->zrem($zkey, $value);
    }

    public function zPop($key)
    {
        $element = null;
        $options = [
            'cas' => true,
            'watch' => $key,
            'retry' => $this->maxRetries,
        ];

        try {
            $this->predis->transaction($options, function ($tx) use ($key, &$element) {
                @list($element) = $tx->zrange($key, 0, 0);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

                if (isset($element)) {
                    $tx->multi();
                    $tx->zrem($key, $element);
                }
            });
        } catch (\Exception $exception) {
            return null;
        }

        return $element;
    }

    public function zPopByMaxScore($key, $max)
    {
        $element = null;
        $options = [
            'cas' => true,
            'watch' => $key,
            'retry' => $this->maxRetries,
        ];

        try {
            $this->predis->transaction($options, function ($tx) use ($key, $max, &$element) {
                @list($element) = $tx->zrangebyscore($key, 0, $max, ['LIMIT' => [0, 1]]);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

                if (isset($element)) {
                    $tx->multi();
                    $tx->zrem($key, $element);
                }
            });
        } catch (\Exception $exception) {
            return null;
        }

        return $element;
    }
}


1			<?php
2
3			namespace Dtc\QueueBundle\Redis;
4
5			use Predis\Client;
6
7			class Predis implements RedisInterface
8			{
9			protected $predis;
10			protected $maxRetries;
11
12			public function __construct(Client $predis, $maxRetries = 5)
13			{
14			$this->predis = $predis;
15			$this->maxRetries = $maxRetries;
16			}
17
18			public function zAdd($zkey, $score, $value)
19			{
20			return $this->predis->zadd($zkey, [$value => $score]);
21			}
22
23			public function set($key, $value)
24			{
25			return $this->predis->set($key, $value);
26			}
27
28			public function get($key)
29			{
30			return $this->predis->get($key);
31			}
32
33			public function setEx($key, $seconds, $value)
34			{
35			return $this->predis->setex($key, $seconds, $value);
36			}
37
38			public function lRem($lKey, $count, $value)
39			{
40			return $this->predis->lrem($lKey, $count, $value);
41			}
42
43			public function lPush($lKey, array $values)
44			{
45			return $this->predis->lpush($lKey, $values);
46			}
47
48			public function lRange($lKey, $start, $stop)
49			{
50			return $this->predis->lrange($lKey, $start, $stop);
51			}
52
53			public function del(array $keys)
54			{
55			return $this->predis->del($keys);
56			}
57
58			public function zRem($zkey, $value)
59			{
60			return $this->predis->zrem($zkey, $value);
61			}
62
63			public function zPop($key)
64			{
65			$element = null;
66			$options = [
67			'cas' => true,
68			'watch' => $key,
69			'retry' => $this->maxRetries,
70			];
71
72			try {
73			$this->predis->transaction($options, function ($tx) use ($key, &$element) {
74			@list($element) = $tx->zrange($key, 0, 0);
			0 ignored issues – show Security Best Practice introduced 2018-01-07 01:22 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
75
76			if (isset($element)) {
77			$tx->multi();
78			$tx->zrem($key, $element);
79			}
80			});
81			} catch (\Exception $exception) {
82			return null;
83			}
84
85			return $element;
86			}
87
88			public function zPopByMaxScore($key, $max)
89			{
90			$element = null;
91			$options = [
92			'cas' => true,
93			'watch' => $key,
94			'retry' => $this->maxRetries,
95			];
96
97			try {
98			$this->predis->transaction($options, function ($tx) use ($key, $max, &$element) {
99			@list($element) = $tx->zrangebyscore($key, 0, $max, ['LIMIT' => [0, 1]]);
			0 ignored issues – show Security Best Practice introduced 2018-01-07 01:22 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
100
101			if (isset($element)) {
102			$tx->multi();
103			$tx->zrem($key, $element);
104			}
105			});
106			} catch (\Exception $exception) {
107			return null;
108			}
109
110			return $element;
111			}
112			}
113

mmucklo / DtcQueueBundle

Pull Request — master (#30)

Predis::zPop() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like