mmucklo / DtcQueueBundle

Documents/JobManager.php

Doc Comments +3 added lines

@@ -11,6 +11,9 @@
     protected $dm;
     protected $documentName;
 
+    /**
+     * @param string $documentName
+     */
     public function __construct(DocumentManager $dm, $documentName)
     {
         $this->dm = $dm;

Braces +1 added lines, -2 removed lines

@@ -179,8 +179,7 @@
 
         if ($prioritize) {
             $qb->sort('priority', 'asc');
-        }
-        else {
+        } else {
             $qb->sort('when', 'asc');
         }
 

Model/Worker.php

Doc Comments +12 added lines, -2 removed lines

@@ -16,7 +16,7 @@ 
     }
 
     /**
-     * @param field_type $jobClass
+     * @param string $jobClass
      */
     public function setJobClass($jobClass)
     {
@@ -29,7 +29,7 @@ 
     }
 
     /**
-     * @return the $jobManager
+     * @return JobManagerInterface $jobManager
      */
     public function getJobManager()
     {
@@ -53,6 +53,9 @@ 
         return new $this->jobClass($this, $batch, $priority, $dateTime);
     }
 
+    /**
+     * @param integer $priority
+     */
     public function later($delay = 0, $priority = null)
     {
         $job = $this->at(time() + $delay, false, $priority);
@@ -60,6 +63,9 @@ 
         return $job;
     }
 
+    /**
+     * @param integer $priority
+     */
     public function batchLater($delay = 0, $priority = null)
     {
         $job = $this->at($delay, true, $priority);
@@ -67,6 +73,10 @@ 
         return $job;
     }
 
+    /**
+     * @param integer $time
+     * @param integer $priority
+     */
     public function batchAt($time = null, $priority = null)
     {
         return $this->at($time, true, $priority);

Braces +1 added lines, -2 removed lines

@@ -45,8 +45,7 @@
         if ($time) {
             $dateTime = new \DateTime();
             $dateTime->setTimestamp($time);
-        }
-        else {
+        } else {
             $dateTime = null;
         }
 

RabbitMQ/JobManager.php

Doc Comments +3 added lines

@@ -33,6 +33,9 @@
         return $job;
     }
 
+    /**
+     * @param string $workerName
+     */
     public function getJob($workerName = null, $methodName = null, $prioritize = true)
     {
         if ($methodName) {

Braces +1 added lines, -2 removed lines

@@ -67,8 +67,7 @@
         if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
             $this->beanstalkd
                 ->delete($job);
-        }
-        else {
+        } else {
             $this->beanstalkd
                 ->bury($job);
         }

Tests/Model/WorkerTest.php

Doc Comments +5 added lines

@@ -104,6 +104,11 @@
         }
     }
 
+    /**
+     * @param integer|null $time
+     * @param string $method
+     * @param integer $priority
+     */
     protected function assertJob(Job $job, $time, $method, $priority = null) {
         $this->assertNotEmpty($job->getId(), "Job should have an id");
 

Braces +1 added lines, -2 removed lines

@@ -115,8 +115,7 @@
         if ($priority) {
             $this->assertEquals($priority, $job->getPriority(),
                     "Priority should be the same.");
-        }
-        else {
+        } else {
             $this->assertNull($job->getPriority(), "Priority should be null");
         }
 

BeanStalkd/JobManager.php

Braces +1 added lines, -2 removed lines

@@ -57,8 +57,7 @@
         if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
             $this->beanstalkd
                 ->delete($job);
-        }
-        else {
+        } else {
             $this->beanstalkd
                 ->bury($job);
         }

Model/Job.php

Braces +1 added lines, -2 removed lines

@@ -259,8 +259,7 @@
             }
 
             return true;
-        }
-        else {
+        } else {
             return !is_object($args);
         }
     }

Model/WorkerManager.php

Braces +1 added lines, -2 removed lines

@@ -73,8 +73,7 @@
 			// Job finshed successfuly... do we remove the job from database?
 			$job->setStatus(Job::STATUS_SUCCESS);
 			$job->setMessage(null);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			if ($this->logger) {
 				$this->logger->debug("Failed: {$job->getClassName()}->{$job->getMethod()}\n{$e->getMessage()}");
 			}

Tests/FibonacciWorker.php

Braces +11 added lines, -6 removed lines

@@ -20,12 +20,17 @@
 
     public function fibonacci($n)
     {
-        if($n == 0)
-            return 0; //F0
-        elseif ($n == 1)
-            return 1; //F1
-        else
-            return $this->fibonacci($n - 1) + $this->fibonacci($n - 2);
+        if($n == 0) {
+                    return 0;
+        }
+        //F0
+        elseif ($n == 1) {
+                    return 1;
+        }
+        //F1
+        else {
+                    return $this->fibonacci($n - 1) + $this->fibonacci($n - 2);
+        }
     }
 
     public function getName() {