Complex classes like Loop often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Loop, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class Loop |
||
| 18 | { |
||
| 19 | /** @var OutputInterface */ |
||
| 20 | protected $output; |
||
| 21 | |||
| 22 | /** @var LoggerInterface */ |
||
| 23 | protected $logger; |
||
| 24 | |||
| 25 | /** @var WorkerManager */ |
||
| 26 | protected $workerManager; |
||
| 27 | |||
| 28 | /** @var JobManagerInterface */ |
||
| 29 | protected $jobManager; |
||
| 30 | |||
| 31 | /** @var RunManager */ |
||
| 32 | protected $runManager; |
||
| 33 | |||
| 34 | /** @var int */ |
||
| 35 | protected $processTimeout; |
||
| 36 | |||
| 37 | /** @var Run */ |
||
| 38 | protected $lastRun; |
||
| 39 | |||
| 40 | 1 | public function __construct( |
|
| 49 | |||
| 50 | /** |
||
| 51 | * @return Run|null |
||
| 52 | */ |
||
| 53 | 1 | public function getLastRun() |
|
| 57 | |||
| 58 | /** |
||
| 59 | * @return int |
||
| 60 | */ |
||
| 61 | public function getProcessTimeout() |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @param int $processTimeout |
||
| 68 | */ |
||
| 69 | public function setProcessTimeout(int $processTimeout) |
||
| 73 | |||
| 74 | public function setLogger(LoggerInterface $logger) |
||
| 78 | |||
| 79 | 1 | public function setOutput(OutputInterface $output) |
|
| 83 | |||
| 84 | /** |
||
| 85 | * @param float $start |
||
| 86 | */ |
||
| 87 | public function runJobById($start, $jobId) |
||
| 88 | { |
||
| 89 | $run = $this->runManager->runStart($start, null, null, $this->processTimeout); |
||
| 90 | $this->lastRun = $run; |
||
| 91 | |||
| 92 | if (!$this->jobManager instanceof BaseJobManager) { |
||
| 93 | throw new ClassNotSubclassException("Can't get job by id when not using a database/datastore backed queue (such as mongodb or an RDBMS)"); |
||
| 94 | } |
||
| 95 | |||
| 96 | /** @var Job $job */ |
||
| 97 | $job = $this->jobManager->getRepository()->find($jobId); |
||
| 98 | if (!$job) { |
||
| 99 | $this->log('error', "Job id is not found: {$jobId}"); |
||
| 100 | $this->runManager->runStop($run, $start); |
||
| 101 | |||
| 102 | return; |
||
| 103 | } |
||
| 104 | |||
| 105 | $job = $this->workerManager->runJob($job); |
||
| 106 | $this->reportJob($job); |
||
| 107 | $run->setProcessed(1); |
||
| 108 | $this->runManager->runStop($run, $start); |
||
| 109 | $this->log('info', 'Ended with 1 job processed over '.strval($run->getElapsed()).' seconds.'); |
||
| 110 | |||
| 111 | return; |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @param float $start |
||
| 116 | * @param int $nanoSleep |
||
| 117 | * @param null|int $maxCount |
||
| 118 | * @param null|int $duration |
||
| 119 | */ |
||
| 120 | 1 | public function runLoop($start, $workerName, $methodName, $maxCount, $duration = null, $nanoSleep = 500000000) |
|
| 121 | { |
||
| 122 | 1 | $this->checkParameters($nanoSleep, $maxCount, $duration); |
|
| 123 | 1 | $this->workerManager->setLoggingFunc([$this, 'log']); |
|
| 124 | 1 | $run = $this->runManager->runStart($start, $maxCount, $duration, $this->processTimeout); |
|
| 125 | 1 | $this->lastRun = $run; |
|
| 126 | try { |
||
| 127 | 1 | $this->log('info', 'Staring up a new job...'); |
|
| 128 | |||
| 129 | 1 | $endTime = $this->getEndTime($run, $duration); |
|
| 130 | 1 | $currentJob = 1; |
|
| 131 | 1 | $noMoreJobsToRun = false; |
|
| 132 | do { |
||
| 133 | 1 | $job = $this->workerManager->run($workerName, $methodName, true, $run->getId()); |
|
| 134 | $this->runManager->recordHeartbeat($run, $start, $job); |
||
| 135 | $this->runCurrentJob($run, $job, $noMoreJobsToRun, $currentJob, $duration, $nanoSleep); |
||
| 136 | } while (!$this->isFinished($maxCount, $endTime, $currentJob, $noMoreJobsToRun)); |
||
| 137 | 1 | } catch (\Exception $e) { |
|
| 138 | // Uncaught error: possibly with QueueBundle itself |
||
| 139 | 1 | $this->log('critical', $e->getMessage(), $e->getTrace()); |
|
| 140 | } |
||
| 141 | 1 | $this->runManager->runStop($run, $start); |
|
| 142 | 1 | $this->log('info', 'Ended with '.$run->getProcessed().' job(s) processed over '.strval($run->getElapsed()).' seconds.'); |
|
| 143 | |||
| 144 | 1 | return 0; |
|
| 145 | } |
||
| 146 | |||
| 147 | /** |
||
| 148 | * @param int $nanoSleep |
||
| 149 | * @param null|int $maxCount |
||
| 150 | * @param null|int $duration |
||
| 151 | * |
||
| 152 | * @throws \InvalidArgumentException |
||
| 153 | */ |
||
| 154 | 1 | private function checkParameters(&$nanoSleep, &$maxCount, &$duration) |
|
| 163 | |||
| 164 | /** |
||
| 165 | * @param int|null $maxCount |
||
| 166 | * @param int|null $duration |
||
| 167 | * |
||
| 168 | * @throws \InvalidArgumentException |
||
| 169 | */ |
||
| 170 | 1 | protected function validateMaxCountDuration($maxCount, $duration) |
|
| 179 | |||
| 180 | /** |
||
| 181 | * @param int|null $nanoSleep |
||
| 182 | * |
||
| 183 | * @throws \InvalidArgumentException |
||
| 184 | */ |
||
| 185 | 1 | protected function validateNanoSleep($nanoSleep) |
|
| 191 | |||
| 192 | /** |
||
| 193 | * @param int|null $duration |
||
| 194 | * |
||
| 195 | * @return null|\DateTime |
||
| 196 | */ |
||
| 197 | 1 | protected function getEndTime(Run $run, $duration) |
|
| 198 | { |
||
| 199 | 1 | $endTime = null; |
|
| 200 | 1 | if (null !== $duration) { |
|
| 201 | $interval = new \DateInterval("PT${duration}S"); |
||
| 202 | $endTime = clone $run->getStartedAt(); |
||
| 203 | $endTime->add($interval); |
||
| 204 | } |
||
| 205 | |||
| 206 | return $endTime; |
||
| 207 | } |
||
| 208 | |||
| 209 | /** |
||
| 210 | * @param Run $run |
||
| 211 | * @param Job|null $job |
||
| 212 | * @param bool $noMoreJobsToRun |
||
| 213 | * @param int $currentJob |
||
| 214 | * @param int|null $duration |
||
| 215 | * @param int $nanoSleep |
||
| 216 | */ |
||
| 217 | protected function runCurrentJob($run, $job, &$noMoreJobsToRun, &$currentJob, $duration, $nanoSleep) |
||
| 218 | { |
||
| 219 | if (null !== $job) { |
||
| 220 | $noMoreJobsToRun = false; |
||
| 221 | $this->reportJob($job); |
||
| 222 | $this->runManager->updateProcessed($run, $currentJob); |
||
| 223 | ++$currentJob; |
||
| 224 | } else { |
||
| 225 | if (!$noMoreJobsToRun) { |
||
| 226 | $this->log('info', 'No more jobs to run ('.($currentJob - 1).' processed so far).'); |
||
| 227 | $noMoreJobsToRun = true; |
||
| 228 | } |
||
| 229 | if (null !== $duration) { |
||
| 230 | $nanoSleepTime = function_exists('random_int') ? random_int(0, $nanoSleep) : mt_rand(0, $nanoSleep); |
||
| 231 | time_nanosleep(0, $nanoSleepTime); |
||
| 232 | } |
||
| 233 | } |
||
| 234 | } |
||
| 235 | |||
| 236 | /** |
||
| 237 | * @param $maxCount |
||
| 238 | * @param $duration |
||
| 239 | * @param $processTimeout |
||
| 240 | */ |
||
| 241 | public function checkMaxCountDuration(&$maxCount, &$duration, &$processTimeout) |
||
| 252 | |||
| 253 | /** |
||
| 254 | * Determine if the run loop is finished. |
||
| 255 | * |
||
| 256 | * @param int|null $maxCount |
||
| 257 | * @param int $currentJob |
||
| 258 | * @param \DateTime|null $endTime |
||
| 259 | * @param bool $noMoreJobsToRun |
||
| 260 | * |
||
| 261 | * @return bool |
||
| 262 | */ |
||
| 263 | protected function isFinished($maxCount, $endTime, $currentJob, $noMoreJobsToRun) |
||
| 264 | { |
||
| 265 | if (null === $maxCount) { |
||
| 266 | return $this->isFinishedEndTime($endTime); |
||
|
|
|||
| 267 | } |
||
| 268 | if ($currentJob <= $maxCount) { |
||
| 269 | return $this->isFinishedJobs($endTime, $noMoreJobsToRun); |
||
| 270 | } |
||
| 271 | |||
| 272 | return true; |
||
| 273 | } |
||
| 274 | |||
| 275 | /** |
||
| 276 | * @param \DateTime|null $endTime |
||
| 277 | * @param bool $noMoreJobsToRun |
||
| 278 | * |
||
| 279 | * @return bool |
||
| 280 | */ |
||
| 281 | protected function isFinishedJobs($endTime, $noMoreJobsToRun) |
||
| 282 | { |
||
| 283 | if (null === $endTime) { // This means that there is a $maxCount as we force one or the other to be not null |
||
| 284 | if ($noMoreJobsToRun) { |
||
| 285 | return true; |
||
| 286 | } |
||
| 287 | |||
| 288 | return false; |
||
| 289 | } |
||
| 290 | |||
| 291 | return $this->isFinishedEndTime($endTime); |
||
| 292 | } |
||
| 293 | |||
| 294 | /** |
||
| 295 | * @param \DateTime $endTime |
||
| 296 | * |
||
| 297 | * @return bool |
||
| 298 | */ |
||
| 299 | protected function isFinishedEndTime(\DateTime $endTime) |
||
| 300 | { |
||
| 301 | $now = new \DateTime(); |
||
| 302 | if ($endTime > $now) { |
||
| 303 | return false; |
||
| 304 | } |
||
| 305 | |||
| 306 | return true; |
||
| 307 | } |
||
| 308 | |||
| 309 | /** |
||
| 310 | * @param Job $job |
||
| 311 | */ |
||
| 312 | protected function reportJob(Job $job) |
||
| 313 | { |
||
| 314 | $this->runManager->recordJobRun($job); |
||
| 315 | |||
| 316 | if (BaseJob::STATUS_ERROR == $job->getStatus()) { |
||
| 317 | $message = "Error with job id: {$job->getId()}\n".$job->getMessage(); |
||
| 318 | $this->log('error', $message); |
||
| 319 | } |
||
| 320 | |||
| 321 | $message = "Finished job id: {$job->getId()} in {$job->getElapsed()} seconds\n"; |
||
| 322 | $this->log('info', $message); |
||
| 323 | } |
||
| 324 | |||
| 325 | /** |
||
| 326 | * @param string $level |
||
| 327 | */ |
||
| 328 | public function log($level, $msg, array $context = []) |
||
| 345 | } |
||
| 346 |
It seems like you allow that null is being passed for a parameter, however the function which is called does not seem to accept null.
We recommend to add an additional type check (or disallow null for the parameter):