JobManager::addWorkerNameCriterion() - Code Metrics - Inspection of "remove transactions from getJob() to avoid content..." - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bb6e51...a4d149 )

by Matthew

created 2017-11-15 05:10 UTC

JobManager::addWorkerNameCriterion() A

↳ Parent: JobManager

Complexity

Conditions	3
Paths	4

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	6
cts	6
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	4
nop	3
crap	3

<?php

namespace Dtc\QueueBundle\ORM;

use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\QueryBuilder;
use Dtc\QueueBundle\Doctrine\BaseJobManager;
use Dtc\QueueBundle\Entity\Job;
use Dtc\QueueBundle\Model\BaseJob;
use Dtc\QueueBundle\Model\RetryableJob;
use Symfony\Component\Process\Exception\LogicException;

class JobManager extends BaseJobManager
{
    use CommonTrait;
    protected static $saveInsertCalled = null;
    protected static $resetInsertCalled = null;

    public function countJobsByStatus($objectName, $status, $workerName = null, $method = null)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();

        $queryBuilder = $objectManager
            ->createQueryBuilder()
            ->select('count(a.id)')
            ->from($objectName, 'a')
            ->where('a.status = :status');

        if (null !== $workerName) {
            $queryBuilder->andWhere('a.workerName = :workerName')
                ->setParameter(':workerName', $workerName);
        }

        if (null !== $method) {
            $queryBuilder->andWhere('a.method = :method')
                ->setParameter(':method', $workerName);
        }

        $count = $queryBuilder->setParameter(':status', $status)
            ->getQuery()->getSingleScalarResult();

        if (!$count) {
            return 0;
        }

        return $count;
    }

    /**
     * @param string|null $workerName
     * @param string|null $method
     *
     * @return int Count of jobs pruned
     */
    public function pruneErroneousJobs($workerName = null, $method = null)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $queryBuilder = $objectManager->createQueryBuilder()->delete($this->getArchiveObjectName(), 'j');
        $queryBuilder->where('j.status = :status')
            ->setParameter(':status', BaseJob::STATUS_ERROR);

        $this->addWorkerNameCriterion($queryBuilder, $workerName, $method);
        $query = $queryBuilder->getQuery();

        return intval($query->execute());
    }

    protected function resetSaveOk($function)
    {
        $objectManager = $this->getObjectManager();
        $splObjectHash = spl_object_hash($objectManager);

        if ('save' === $function) {
            $compare = static::$resetInsertCalled;
        } else {
            $compare = static::$saveInsertCalled;
        }

        if ($splObjectHash === $compare) {
            // Insert SQL is cached...
            $msg = "Can't call save and reset within the same process cycle (or using the same EntityManager)";
            throw new LogicException($msg);
        }

        if ('save' === $function) {
            static::$saveInsertCalled = spl_object_hash($objectManager);
        } else {
            static::$resetInsertCalled = spl_object_hash($objectManager);
        }
    }

    /**
     * @param string $workerName
     * @param string $method
     */
    protected function addWorkerNameCriterion(QueryBuilder $queryBuilder, $workerName = null, $method = null)
    {
        if (null !== $workerName) {
            $queryBuilder->andWhere('j.workerName = :workerName')->setParameter(':workerName', $workerName);
        }

        if (null !== $method) {
            $queryBuilder->andWhere('j.method = :method')->setParameter(':method', $method);
        }
    }

    protected function updateExpired($workerName = null, $method = null)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $queryBuilder = $objectManager->createQueryBuilder()->update($this->getObjectName(), 'j');
        $queryBuilder->set('j.status', ':newStatus');
        $queryBuilder->where('j.expiresAt <= :expiresAt')
            ->setParameter(':expiresAt', new \DateTime());
        $queryBuilder->andWhere('j.status = :status')
            ->setParameter(':status', BaseJob::STATUS_NEW)
            ->setParameter(':newStatus', Job::STATUS_EXPIRED);

        $this->addWorkerNameCriterion($queryBuilder, $workerName, $method);
        $query = $queryBuilder->getQuery();

        return intval($query->execute());
    }

    protected function getJobCurrentStatus(\Dtc\QueueBundle\Model\Job $job)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $queryBuilder = $objectManager->createQueryBuilder()->select('j.status')->from($this->getObjectName(), 'j');
        $queryBuilder->where('j.id = :id')->setParameter(':id', $job->getId());

        return $queryBuilder->getQuery()->getSingleScalarResult();
    }

    /**
     * Removes archived jobs older than $olderThan.
     *
     * @param \DateTime $olderThan
     */
    public function pruneArchivedJobs(\DateTime $olderThan)
    {
        return $this->removeOlderThan($this->getArchiveObjectName(),
                'updatedAt',
                $olderThan);
    }

    public function getJobCount($workerName = null, $method = null)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $queryBuilder = $objectManager->createQueryBuilder();

        $queryBuilder = $queryBuilder->select('count(j)')->from($this->getObjectName(), 'j');

        $where = 'where';
        if (null !== $workerName) {
            if (null !== $method) {
                $queryBuilder->where($queryBuilder->expr()->andX(
                    $queryBuilder->expr()->eq('j.workerName', ':workerName'),
                                                $queryBuilder->expr()->eq('j.method', ':method')
                ))
                    ->setParameter(':method', $method);
            } else {
                $queryBuilder->where('j.workerName = :workerName');
            }
            $queryBuilder->setParameter(':workerName', $workerName);
            $where = 'andWhere';
        } elseif (null !== $method) {
            $queryBuilder->where('j.method = :method')->setParameter(':method', $method);
            $where = 'andWhere';
        }

        $dateTime = new \DateTime();
        // Filter
        $queryBuilder
            ->$where($queryBuilder->expr()->orX(
                $queryBuilder->expr()->isNull('j.whenAt'),
                                        $queryBuilder->expr()->lte('j.whenAt', ':whenAt')
            ))
            ->andWhere($queryBuilder->expr()->orX(
                $queryBuilder->expr()->isNull('j.expiresAt'),
                $queryBuilder->expr()->gt('j.expiresAt', ':expiresAt')
            ))
            ->andWhere('j.locked is NULL')
            ->setParameter(':whenAt', $dateTime)
            ->setParameter(':expiresAt', $dateTime);

        $query = $queryBuilder->getQuery();

        return $query->getSingleScalarResult();
    }

    /**
     * For ORM it's prudent to wrap things in a transaction.
     *
     * @param $i
     * @param $count
     * @param array $stalledJobs
     * @param $countProcessed
     */
    protected function runStalledLoop($i, $count, array $stalledJobs, &$countProcessed)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        try {
            $objectManager->beginTransaction();
            parent::runStalledLoop($i, $count, $stalledJobs, $countProcessed);
            $objectManager->commit();
        } catch (\Exception $exception) {
            $objectManager->rollback();

            // Try again
            parent::runStalledLoop($i, $count, $stalledJobs, $countProcessed);
        }
    }

    /**
     * Get Jobs statuses.
     */
    public function getStatus()
    {
        $result = [];
        $this->getStatusByEntityName($this->getObjectName(), $result);
        $this->getStatusByEntityName($this->getArchiveObjectName(), $result);

        $finalResult = [];
        foreach ($result as $key => $item) {
            ksort($item);
            foreach ($item as $status => $count) {
                if (isset($finalResult[$key][$status])) {
                    $finalResult[$key][$status] += $count;
                } else {
                    $finalResult[$key][$status] = $count;
                }
            }
        }

        return $finalResult;
    }

    /**
     * @param string $entityName
     */
    protected function getStatusByEntityName($entityName, array &$result)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $result1 = $objectManager->getRepository($entityName)->createQueryBuilder('j')->select('j.workerName, j.method, j.status, count(j) as c')
            ->groupBy('j.workerName, j.method, j.status')->getQuery()->getArrayResult();

        foreach ($result1 as $item) {
            $method = $item['workerName'].'->'.$item['method'].'()';
            if (!isset($result[$method])) {
                $result[$method] = [BaseJob::STATUS_NEW => 0,
                    BaseJob::STATUS_RUNNING => 0,
                    RetryableJob::STATUS_EXPIRED => 0,
                    RetryableJob::STATUS_MAX_ERROR => 0,
                    RetryableJob::STATUS_MAX_STALLED => 0,
                    RetryableJob::STATUS_MAX_RETRIES => 0,
                    BaseJob::STATUS_SUCCESS => 0,
                    BaseJob::STATUS_ERROR => 0, ];
            }
            $result[$method][$item['status']] += intval($item['c']);
        }
    }

    /**
     * Get the next job to run (can be filtered by workername and method name).
     *
     * @param string $workerName
     * @param string $methodName
     * @param bool   $prioritize
     *
     * @return Job|null
     */
    public function getJob($workerName = null, $methodName = null, $prioritize = true, $runId = null)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        /** @var EntityRepository $repository */
        $repository = $this->getRepository();
        $queryBuilder = $repository->createQueryBuilder('j');
        $dateTime = new \DateTime();
        $queryBuilder
            ->select('j.id')
            ->where('j.status = :status')->setParameter(':status', BaseJob::STATUS_NEW)
            ->andWhere('j.locked is NULL')
            ->andWhere($queryBuilder->expr()->orX(
                $queryBuilder->expr()->isNull('j.whenAt'),
                        $queryBuilder->expr()->lte('j.whenAt', ':whenAt')
            ))
            ->andWhere($queryBuilder->expr()->orX(
                $queryBuilder->expr()->isNull('j.expiresAt'),
                        $queryBuilder->expr()->gt('j.expiresAt', ':expiresAt')
            ))
            ->setParameter(':whenAt', $dateTime)
            ->setParameter(':expiresAt', $dateTime);

        $this->addWorkerNameCriterion($queryBuilder, $workerName, $methodName);

        if ($prioritize) {
            $queryBuilder->add('orderBy', 'j.priority DESC, j.whenAt ASC');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $queryBuilder->orderBy('j.whenAt', 'ASC');
        }
        $queryBuilder->setMaxResults(1);

        /** @var QueryBuilder $queryBuilder */
        $query = $queryBuilder->getQuery();
        $jobs = $query->getResult();
        if (isset($jobs[0]['id'])) {
            return $this->takeJob($jobs[0]['id'], $runId);
        }

        return null;
    }

    protected function takeJob($jobId, $runId = null)
    {
        if ($jobId) {
            $repository = $this->getRepository();
            $queryBuilder = $repository->createQueryBuilder('j');
            $queryBuilder
                ->update()
                ->set('j.locked', ':locked')
                ->setParameter(':locked', true)
                ->set('j.lockedAt', ':lockedAt')
                ->setParameter(':lockedAt', new \DateTime())
                ->set('j.status', ':status')
                ->setParameter(':status', BaseJob::STATUS_RUNNING);
            if (null !== $runId) {
                $queryBuilder
                    ->set(':runId', $runId);
            }
            $queryBuilder->where('j.id = :id');
            $queryBuilder->andWhere('j.locked is NULL');
            $queryBuilder->setParameter(':id', $jobId);
            $resultCount = $queryBuilder->getQuery()->execute();

            if (1 === $resultCount) {
                return $repository->find($jobId);
            }
        }

        return null;
    }

    /**
     * Tries to update the nearest job as a batch.
     *
     * @param \Dtc\QueueBundle\Model\Job $job
     *
     * @return mixed|null
     */
    public function updateNearestBatch(\Dtc\QueueBundle\Model\Job $job)
    {
        $oldJob = null;
        $retries = 0;
        do {
            try {
                /** @var EntityManager $entityManager */
                $entityManager = $this->getObjectManager();
                $entityManager->beginTransaction();

                /** @var QueryBuilder $queryBuilder */
                $queryBuilder = $this->getRepository()->createQueryBuilder('j');
                $queryBuilder->select()
                    ->where('j.crcHash = :crcHash')
                    ->andWhere('j.status = :status')
                    ->setParameter(':status', BaseJob::STATUS_NEW)
                    ->setParameter(':crcHash', $job->getCrcHash())
                    ->orderBy('j.whenAt', 'ASC')
                    ->setMaxResults(1);
                $oldJobs = $queryBuilder->getQuery()->execute();

                if (empty($oldJobs)) {
                    return null;
                }
                $oldJob = $oldJobs[0];

                $oldJob->setPriority(max($job->getPriority(), $oldJob->getPriority()));
                $oldJob->setWhenAt(min($job->getWhenAt(), $oldJob->getWhenAt()));

                $entityManager->persist($oldJob);
                $entityManager->commit();
                $this->flush();
            } catch (\Exception $exception) {
                ++$retries;
                $entityManager->rollback();
            }
        } while (null === $oldJob && $retries < 5); // After 5 retries assume database is down or too much contention

        return $oldJob;
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\ORM;
4
5		use Doctrine\ORM\EntityManager;
6		use Doctrine\ORM\EntityRepository;
7		use Doctrine\ORM\QueryBuilder;
8		use Dtc\QueueBundle\Doctrine\BaseJobManager;
9		use Dtc\QueueBundle\Entity\Job;
10		use Dtc\QueueBundle\Model\BaseJob;
11		use Dtc\QueueBundle\Model\RetryableJob;
12		use Symfony\Component\Process\Exception\LogicException;
13
14		class JobManager extends BaseJobManager
15		{
16		use CommonTrait;
17		protected static $saveInsertCalled = null;
18		protected static $resetInsertCalled = null;
19
20	3	public function countJobsByStatus($objectName, $status, $workerName = null, $method = null)
21		{
22		/** @var EntityManager $objectManager */
23	3	$objectManager = $this->getObjectManager();
24
25		$queryBuilder = $objectManager
26	3	->createQueryBuilder()
27	3	->select('count(a.id)')
28	3	->from($objectName, 'a')
29	3	->where('a.status = :status');
30
31	3	if (null !== $workerName) {
32	1	$queryBuilder->andWhere('a.workerName = :workerName')
33	1	->setParameter(':workerName', $workerName);
34		}
35
36	3	if (null !== $method) {
37	1	$queryBuilder->andWhere('a.method = :method')
38	1	->setParameter(':method', $workerName);
39		}
40
41	3	$count = $queryBuilder->setParameter(':status', $status)
42	3	->getQuery()->getSingleScalarResult();
43
44	3	if (!$count) {
45	1	return 0;
46		}
47
48	3	return $count;
49		}
50
51		/**
52		* @param string\|null $workerName
53		* @param string\|null $method
54		*
55		* @return int Count of jobs pruned
56		*/
57	1	public function pruneErroneousJobs($workerName = null, $method = null)
58		{
59		/** @var EntityManager $objectManager */
60	1	$objectManager = $this->getObjectManager();
61	1	$queryBuilder = $objectManager->createQueryBuilder()->delete($this->getArchiveObjectName(), 'j');
62	1	$queryBuilder->where('j.status = :status')
63	1	->setParameter(':status', BaseJob::STATUS_ERROR);
64
65	1	$this->addWorkerNameCriterion($queryBuilder, $workerName, $method);
66	1	$query = $queryBuilder->getQuery();
67
68	1	return intval($query->execute());
69		}
70
71	14	protected function resetSaveOk($function)
72		{
73	14	$objectManager = $this->getObjectManager();
74	14	$splObjectHash = spl_object_hash($objectManager);
75
76	14	if ('save' === $function) {
77		$compare = static::$resetInsertCalled;
78		} else {
79	14	$compare = static::$saveInsertCalled;
80		}
81
82	14	if ($splObjectHash === $compare) {
83		// Insert SQL is cached...
84		$msg = "Can't call save and reset within the same process cycle (or using the same EntityManager)";
85		throw new LogicException($msg);
86		}
87
88	14	if ('save' === $function) {
89		static::$saveInsertCalled = spl_object_hash($objectManager);
90		} else {
91	14	static::$resetInsertCalled = spl_object_hash($objectManager);
92		}
93	14	}
94
95		/**
96		* @param string $workerName
97		* @param string $method
98		*/
99	8	protected function addWorkerNameCriterion(QueryBuilder $queryBuilder, $workerName = null, $method = null)
100		{
101	8	if (null !== $workerName) {
102	3	$queryBuilder->andWhere('j.workerName = :workerName')->setParameter(':workerName', $workerName);
103		}
104
105	8	if (null !== $method) {
106	2	$queryBuilder->andWhere('j.method = :method')->setParameter(':method', $method);
107		}
108	8	}
109
110	1	protected function updateExpired($workerName = null, $method = null)
111		{
112		/** @var EntityManager $objectManager */
113	1	$objectManager = $this->getObjectManager();
114	1	$queryBuilder = $objectManager->createQueryBuilder()->update($this->getObjectName(), 'j');
115	1	$queryBuilder->set('j.status', ':newStatus');
116	1	$queryBuilder->where('j.expiresAt <= :expiresAt')
117	1	->setParameter(':expiresAt', new \DateTime());
118	1	$queryBuilder->andWhere('j.status = :status')
119	1	->setParameter(':status', BaseJob::STATUS_NEW)
120	1	->setParameter(':newStatus', Job::STATUS_EXPIRED);
121
122	1	$this->addWorkerNameCriterion($queryBuilder, $workerName, $method);
123	1	$query = $queryBuilder->getQuery();
124
125	1	return intval($query->execute());
126		}
127
128	1	protected function getJobCurrentStatus(\Dtc\QueueBundle\Model\Job $job)
129		{
130		/** @var EntityManager $objectManager */
131	1	$objectManager = $this->getObjectManager();
132	1	$queryBuilder = $objectManager->createQueryBuilder()->select('j.status')->from($this->getObjectName(), 'j');
133	1	$queryBuilder->where('j.id = :id')->setParameter(':id', $job->getId());
134
135	1	return $queryBuilder->getQuery()->getSingleScalarResult();
136		}
137
138		/**
139		* Removes archived jobs older than $olderThan.
140		*
141		* @param \DateTime $olderThan
142		*/
143	1	public function pruneArchivedJobs(\DateTime $olderThan)
144		{
145	1	return $this->removeOlderThan($this->getArchiveObjectName(),
146	1	'updatedAt',
147	1	$olderThan);
148		}
149
150	2	public function getJobCount($workerName = null, $method = null)
151		{
152		/** @var EntityManager $objectManager */
153	2	$objectManager = $this->getObjectManager();
154	2	$queryBuilder = $objectManager->createQueryBuilder();
155
156	2	$queryBuilder = $queryBuilder->select('count(j)')->from($this->getObjectName(), 'j');
157
158	2	$where = 'where';
159	2	if (null !== $workerName) {
160		if (null !== $method) {
161		$queryBuilder->where($queryBuilder->expr()->andX(
162		$queryBuilder->expr()->eq('j.workerName', ':workerName'),
163		$queryBuilder->expr()->eq('j.method', ':method')
164		))
165		->setParameter(':method', $method);
166		} else {
167		$queryBuilder->where('j.workerName = :workerName');
168		}
169		$queryBuilder->setParameter(':workerName', $workerName);
170		$where = 'andWhere';
171	2	} elseif (null !== $method) {
172		$queryBuilder->where('j.method = :method')->setParameter(':method', $method);
173		$where = 'andWhere';
174		}
175
176	2	$dateTime = new \DateTime();
177		// Filter
178		$queryBuilder
179	2	->$where($queryBuilder->expr()->orX(
180	2	$queryBuilder->expr()->isNull('j.whenAt'),
181	2	$queryBuilder->expr()->lte('j.whenAt', ':whenAt')
182		))
183	2	->andWhere($queryBuilder->expr()->orX(
184	2	$queryBuilder->expr()->isNull('j.expiresAt'),
185	2	$queryBuilder->expr()->gt('j.expiresAt', ':expiresAt')
186		))
187	2	->andWhere('j.locked is NULL')
188	2	->setParameter(':whenAt', $dateTime)
189	2	->setParameter(':expiresAt', $dateTime);
190
191	2	$query = $queryBuilder->getQuery();
192
193	2	return $query->getSingleScalarResult();
194		}
195
196		/**
197		* For ORM it's prudent to wrap things in a transaction.
198		*
199		* @param $i
200		* @param $count
201		* @param array $stalledJobs
202		* @param $countProcessed
203		*/
204	1	protected function runStalledLoop($i, $count, array $stalledJobs, &$countProcessed)
205		{
206		/** @var EntityManager $objectManager */
207	1	$objectManager = $this->getObjectManager();
208		try {
209	1	$objectManager->beginTransaction();
210	1	parent::runStalledLoop($i, $count, $stalledJobs, $countProcessed);
211	1	$objectManager->commit();
212		} catch (\Exception $exception) {
213		$objectManager->rollback();
214
215		// Try again
216		parent::runStalledLoop($i, $count, $stalledJobs, $countProcessed);
217		}
218	1	}
219
220		/**
221		* Get Jobs statuses.
222		*/
223	2	public function getStatus()
224		{
225	2	$result = [];
226	2	$this->getStatusByEntityName($this->getObjectName(), $result);
227	2	$this->getStatusByEntityName($this->getArchiveObjectName(), $result);
228
229	2	$finalResult = [];
230	2	foreach ($result as $key => $item) {
231	1	ksort($item);
232	1	foreach ($item as $status => $count) {
233	1	if (isset($finalResult[$key][$status])) {
234		$finalResult[$key][$status] += $count;
235		} else {
236	1	$finalResult[$key][$status] = $count;
237		}
238		}
239		}
240
241	2	return $finalResult;
242		}
243
244		/**
245		* @param string $entityName
246		*/
247	2	protected function getStatusByEntityName($entityName, array &$result)
248		{
249		/** @var EntityManager $objectManager */
250	2	$objectManager = $this->getObjectManager();
251	2	$result1 = $objectManager->getRepository($entityName)->createQueryBuilder('j')->select('j.workerName, j.method, j.status, count(j) as c')
252	2	->groupBy('j.workerName, j.method, j.status')->getQuery()->getArrayResult();
253
254	2	foreach ($result1 as $item) {
255	1	$method = $item['workerName'].'->'.$item['method'].'()';
256	1	if (!isset($result[$method])) {
257	1	$result[$method] = [BaseJob::STATUS_NEW => 0,
258		BaseJob::STATUS_RUNNING => 0,
259		RetryableJob::STATUS_EXPIRED => 0,
260		RetryableJob::STATUS_MAX_ERROR => 0,
261		RetryableJob::STATUS_MAX_STALLED => 0,
262		RetryableJob::STATUS_MAX_RETRIES => 0,
263		BaseJob::STATUS_SUCCESS => 0,
264		BaseJob::STATUS_ERROR => 0, ];
265		}
266	1	$result[$method][$item['status']] += intval($item['c']);
267		}
268	2	}
269
270		/**
271		* Get the next job to run (can be filtered by workername and method name).
272		*
273		* @param string $workerName
274		* @param string $methodName
275		* @param bool $prioritize
276		*
277		* @return Job\|null
278		*/
279	6	public function getJob($workerName = null, $methodName = null, $prioritize = true, $runId = null)
280		{
281		/** @var EntityManager $objectManager */
282	6	$objectManager = $this->getObjectManager();
		0 ignored issues – show Unused Code introduced 2017-11-11 21:59 UTC by Report Bug Copy Issue Report `$objectManager` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
283
284		/** @var EntityRepository $repository */
285	6	$repository = $this->getRepository();
286	6	$queryBuilder = $repository->createQueryBuilder('j');
287	6	$dateTime = new \DateTime();
288		$queryBuilder
289	6	->select('j.id')
290	6	->where('j.status = :status')->setParameter(':status', BaseJob::STATUS_NEW)
291	6	->andWhere('j.locked is NULL')
292	6	->andWhere($queryBuilder->expr()->orX(
293	6	$queryBuilder->expr()->isNull('j.whenAt'),
294	6	$queryBuilder->expr()->lte('j.whenAt', ':whenAt')
295		))
296	6	->andWhere($queryBuilder->expr()->orX(
297	6	$queryBuilder->expr()->isNull('j.expiresAt'),
298	6	$queryBuilder->expr()->gt('j.expiresAt', ':expiresAt')
299		))
300	6	->setParameter(':whenAt', $dateTime)
301	6	->setParameter(':expiresAt', $dateTime);
302
303	6	$this->addWorkerNameCriterion($queryBuilder, $workerName, $methodName);
304
305	6	if ($prioritize) {
306	6	$queryBuilder->add('orderBy', 'j.priority DESC, j.whenAt ASC');
		0 ignored issues – show Documentation introduced 2017-11-15 05:16 UTC by Report Bug Copy Issue Report `'j.priority DESC, j.whenAt ASC'` is of type `string`, but the function expects a `object<Doctrine\ORM\Query\Expr\Base>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
307		} else {
308		$queryBuilder->orderBy('j.whenAt', 'ASC');
309		}
310	6	$queryBuilder->setMaxResults(1);
311
312		/** @var QueryBuilder $queryBuilder */
313	6	$query = $queryBuilder->getQuery();
314	6	$jobs = $query->getResult();
315	6	if (isset($jobs[0]['id'])) {
316	5	return $this->takeJob($jobs[0]['id'], $runId);
317		}
318
319	3	return null;
320		}
321
322	5	protected function takeJob($jobId, $runId = null)
323		{
324	5	if ($jobId) {
325	5	$repository = $this->getRepository();
326	5	$queryBuilder = $repository->createQueryBuilder('j');
327		$queryBuilder
328	5	->update()
329	5	->set('j.locked', ':locked')
330	5	->setParameter(':locked', true)
331	5	->set('j.lockedAt', ':lockedAt')
332	5	->setParameter(':lockedAt', new \DateTime())
333	5	->set('j.status', ':status')
334	5	->setParameter(':status', BaseJob::STATUS_RUNNING);
335	5	if (null !== $runId) {
336		$queryBuilder
337		->set(':runId', $runId);
338		}
339	5	$queryBuilder->where('j.id = :id');
340	5	$queryBuilder->andWhere('j.locked is NULL');
341	5	$queryBuilder->setParameter(':id', $jobId);
342	5	$resultCount = $queryBuilder->getQuery()->execute();
343
344	5	if (1 === $resultCount) {
345	5	return $repository->find($jobId);
346		}
347		}
348
349		return null;
350		}
351
352		/**
353		* Tries to update the nearest job as a batch.
354		*
355		* @param \Dtc\QueueBundle\Model\Job $job
356		*
357		* @return mixed\|null
358		*/
359	1	public function updateNearestBatch(\Dtc\QueueBundle\Model\Job $job)
360		{
361	1	$oldJob = null;
362	1	$retries = 0;
363		do {
364		try {
365		/** @var EntityManager $entityManager */
366	1	$entityManager = $this->getObjectManager();
367	1	$entityManager->beginTransaction();
368
369		/** @var QueryBuilder $queryBuilder */
370	1	$queryBuilder = $this->getRepository()->createQueryBuilder('j');
371	1	$queryBuilder->select()
372	1	->where('j.crcHash = :crcHash')
373	1	->andWhere('j.status = :status')
374	1	->setParameter(':status', BaseJob::STATUS_NEW)
375	1	->setParameter(':crcHash', $job->getCrcHash())
376	1	->orderBy('j.whenAt', 'ASC')
377	1	->setMaxResults(1);
378	1	$oldJobs = $queryBuilder->getQuery()->execute();
379
380	1	if (empty($oldJobs)) {
381		return null;
382		}
383	1	$oldJob = $oldJobs[0];
384
385	1	$oldJob->setPriority(max($job->getPriority(), $oldJob->getPriority()));
386	1	$oldJob->setWhenAt(min($job->getWhenAt(), $oldJob->getWhenAt()));
387
388	1	$entityManager->persist($oldJob);
389	1	$entityManager->commit();
390	1	$this->flush();
391		} catch (\Exception $exception) {
392		++$retries;
393		$entityManager->rollback();
394		}
395	1	} while (null === $oldJob && $retries < 5); // After 5 retries assume database is down or too much contention
396
397	1	return $oldJob;
398		}
399		}
400

mmucklo / DtcQueueBundle

Push — master ( bb6e51...a4d149 )

JobManager::addWorkerNameCriterion() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like