Worker::at() - Code Metrics - Inspection of "fix issue #126 by setting timezone correctly" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 90bd67...742cd1 )

by Matthew

created 2020-03-18 09:08 UTC

Worker::at() C

↳ Parent: Worker

Complexity

Conditions	12
Paths	39

Size

Total Lines	56
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	28
CRAP Score	12.2812

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	12
eloc	40
nc	39
nop	3
dl	0
loc	56
ccs	28
cts	32
cp	0.875
crap	12.2812
rs	6.9666
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Dtc\QueueBundle\Model;

use Dtc\QueueBundle\Manager\JobManagerInterface;
use Dtc\QueueBundle\Util\Util;

abstract class Worker
{
    const RESULT_SUCCESS = 0;
    const RESULT_FAILURE = 1;

    /** @var JobManagerInterface */
    private $jobManager;
    private $currentJob;

    public function setCurrentJob(BaseJob $job)
    {
        $this->currentJob = $job;
    }

    public function getCurrentJob()
    {
        return $this->currentJob;
    }

    public function setJobManager(JobManagerInterface $jobManager)
    {
        $this->jobManager = $jobManager;
    }

    /**
     * @return
     */
    public function getJobManager()
    {
        return $this->jobManager;
    }

    /**
     * @param int|null $time
     * @param bool     $batch
     * @param int|null $priority
     * @throws \Exception
     */
    public function at($time = null, $batch = false, $priority = null)
    {
        $timeU = $time;
        if (null === $time) {
            $timeU = Util::getMicrotimeStr();
            $dateTime = \DateTime::createFromFormat(
                'U.u',
                $timeU
            );
            if (!$dateTime) {
                throw new \Exception("Could not create DateTime object from $timeU");
            }
            $dateTime->setTimezone(new \DateTimeZone(date_default_timezone_get()));
        } else {
            $localeInfo = localeconv();
            $decimalPoint = isset($localeInfo['decimal_point']) ? $localeInfo['decimal_point'] : '.';
            $hasDecimalPoint = false !== strpos(strval($time), $decimalPoint);
            $hasEnDecimalPoint = '.' === $decimalPoint ? $hasDecimalPoint : strpos(strval($time), '.');
            if (!$hasEnDecimalPoint) {
                if ($hasDecimalPoint) {
                    $dateTime = \DateTime::createFromFormat(
                        'U'.$decimalPoint.'u',
                        strval($timeU)
                    );
                    if (!$dateTime) {
                        throw new \Exception("Could not create DateTime object from $timeU");
                    }
                    $dateTime->setTimezone(new \DateTimeZone(date_default_timezone_get()));
                } else {
                    $dateTime = \DateTime::createFromFormat(
                        'U',
                        strval($timeU)
                    );
                    if (!$dateTime) {
                        throw new \Exception("Could not create DateTime object from $timeU");
                    }
                    $dateTime->setTimezone(new \DateTimeZone(date_default_timezone_get()));
                }
            } else {
                $dateTime = \DateTime::createFromFormat(
                    'U.u',
                    strval($timeU)
                );
                if (!$dateTime) {
                    throw new \Exception("Could not create DateTime object from $timeU");
                }
                $dateTime->setTimezone(new \DateTimeZone(date_default_timezone_get()));
            }
        }

        if (!($dateTime instanceof \DateTime)) {

            throw new \InvalidArgumentException("Invalid time: $time".($timeU != $time ? " - (micro: $timeU)" : ''));
        }
        $jobClass = $this->jobManager->getJobClass();

        return new $jobClass($this, $batch, $priority, $dateTime);
    }

    /**
     * @param int      $delay    Amount of time to delay
     * @param int|null $priority
     */
    public function later($delay = 0, $priority = null)
    {
        return $this->batchOrLaterDelay($delay, false, $priority);
    }

    public function batchOrLaterDelay($delay = 0, $batch = false, $priority = null)
    {
        $timing = Util::getMicrotimeStr();
        $parts = explode('.', $timing);
        $parts[0] = strval(intval($parts[0]) + intval($delay));
        $localeInfo = localeconv();
        $decimalPoint = isset($localeInfo['decimal_point']) ? $localeInfo['decimal_point'] : '.';

        $job = $this->at(implode($decimalPoint, $parts), $batch, $priority);
        $job = $this->at(/** @scrutinizer ignore-type */ implode($decimalPoint, $parts), $batch, $priority);
        $job->setDelay($delay);

        return $job;
    }

    /**
     * @param int      $delay    Amount of time to delay
     * @param int|null $priority
     */
    public function batchLater($delay = 0, $priority = null)
    {
        return $this->batchOrLaterDelay($delay, true, $priority);
    }

    /**
     * @param int|null $time
     * @param int|null $priority
     */
    public function batchAt($time = null, $priority = null)
    {
        return $this->at($time, true, $priority);
    }

    abstract public function getName();
}


mmucklo / DtcQueueBundle

Push — master ( 90bd67...742cd1 )

Worker::at() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like