CommonTrait::stopIdGenerator() - Code Metrics - Inspection of "Merge branch 'master' of github.com:mmucklo/DtcQue..." - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d4f4f0...01653d )

by Matthew

created 2017-11-01 09:18 UTC

CommonTrait::stopIdGenerator() A

↳ Parent: CommonTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1
crap	2

<?php

namespace Dtc\QueueBundle\ORM;

use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Id\AssignedGenerator;
use Doctrine\ORM\Mapping\ClassMetadata;

trait CommonTrait
{
    /**
     * @param ObjectManager $entityManager
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string        $objectName
     * @param string        $field
     * @param \DateTime     $olderThan
     *
     * @return int
     */
    protected function removeOlderThan(ObjectManager $objectManager, $objectName, $field, \DateTime $olderThan)
    {
        /** @var EntityManager $objectManager */
        $qb = $objectManager->createQueryBuilder()->delete($objectName, 'j');
        $qb = $qb
            ->where('j.'.$field.' < :'.$field)
            ->setParameter(':'.$field, $olderThan);

        $query = $qb->getQuery();

        return $query->execute();
    }

    public function stopIdGenerator($objectName)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $repository = $objectManager->getRepository($objectName);
        /** @var ClassMetadata $metadata */
        $metadata = $objectManager->getClassMetadata($repository->getClassName());
        $this->formerIdGenerators[$objectName]['generator'] = $metadata->idGenerator;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->formerIdGenerators[$objectName]['type'] = $metadata->generatorType;
        $metadata->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_NONE);
        $metadata->setIdGenerator(new AssignedGenerator());
    }

    public function restoreIdGenerator($objectName)
    {
        $objectManager = $this->getObjectManager();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $repository = $objectManager->getRepository($objectName);
        /** @var ClassMetadata $metadata */
        $metadata = $objectManager->getClassMetadata($repository->getClassName());
        $generator = $this->formerIdGenerators[$objectName]['generator'];
        $type = $this->formerIdGenerators[$objectName]['type'];
        $metadata->setIdGeneratorType($type);
        $metadata->setIdGenerator($generator);
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\ORM;
4
5		use Doctrine\Common\Persistence\ObjectManager;
6		use Doctrine\ORM\EntityManager;
7		use Doctrine\ORM\Id\AssignedGenerator;
8		use Doctrine\ORM\Mapping\ClassMetadata;
9
10		trait CommonTrait
11		{
12		/**
13		* @param ObjectManager $entityManager
		0 ignored issues – show Bug introduced 2017-11-01 09:22 UTC by Report Bug Copy Issue Report There is no parameter named `$entityManager`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
14		* @param string $objectName
15		* @param string $field
16		* @param \DateTime $olderThan
17	1	*
18		* @return int
19	1	*/
20		protected function removeOlderThan(ObjectManager $objectManager, $objectName, $field, \DateTime $olderThan)
21	1	{
22	1	/** @var EntityManager $objectManager */
23		$qb = $objectManager->createQueryBuilder()->delete($objectName, 'j');
24	1	$qb = $qb
25		->where('j.'.$field.' < :'.$field)
26	1	->setParameter(':'.$field, $olderThan);
27
28		$query = $qb->getQuery();
29
30		return $query->execute();
31		}
32
33		public function stopIdGenerator($objectName)
34		{
35		/** @var EntityManager $objectManager */
36		$objectManager = $this->getObjectManager();
		0 ignored issues – show Bug introduced 2017-11-01 09:22 UTC by Report Bug Copy Issue Report It seems like `getObjectManager()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37		$repository = $objectManager->getRepository($objectName);
38		/** @var ClassMetadata $metadata */
39		$metadata = $objectManager->getClassMetadata($repository->getClassName());
40		$this->formerIdGenerators[$objectName]['generator'] = $metadata->idGenerator;
		0 ignored issues – show Bug introduced 2017-11-01 09:22 UTC by Report Bug Copy Issue Report The property `formerIdGenerators` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
41		$this->formerIdGenerators[$objectName]['type'] = $metadata->generatorType;
42		$metadata->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_NONE);
43		$metadata->setIdGenerator(new AssignedGenerator());
44		}
45
46		public function restoreIdGenerator($objectName)
47		{
48		$objectManager = $this->getObjectManager();
		0 ignored issues – show Bug introduced 2017-11-01 09:22 UTC by Report Bug Copy Issue Report It seems like `getObjectManager()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49		$repository = $objectManager->getRepository($objectName);
50		/** @var ClassMetadata $metadata */
51		$metadata = $objectManager->getClassMetadata($repository->getClassName());
52		$generator = $this->formerIdGenerators[$objectName]['generator'];
53		$type = $this->formerIdGenerators[$objectName]['type'];
54		$metadata->setIdGeneratorType($type);
55		$metadata->setIdGenerator($generator);
56		}
57		}
58

mmucklo / DtcQueueBundle

Push — master ( d4f4f0...01653d )

CommonTrait::stopIdGenerator() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like