Dtc\QueueBundle\Tests\Controller\QueueControllerTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	102
Duplicated Lines	37.25 %

Coupling/Cohesion

Components	1
Dependencies	19

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setUpBeforeClass()	0	4	1
A	testStatusAction()	10	10	1
B	getContainer()	0	42	1
A	testJobsAction()	9	9	1
A	testJobsRunningAction()	9	9	1
A	testWorkersAction()	10	10	1
A	testArchiveJobsAction()	0	9	1

<?php

namespace Dtc\QueueBundle\Tests\Controller;

use Doctrine\Common\Annotations\AnnotationReader;
use Dtc\GridBundle\Grid\Renderer\RendererFactory;
use Dtc\GridBundle\Grid\Source\EntityGridSource;
use Dtc\GridBundle\Manager\GridSourceManager;
use Dtc\QueueBundle\Controller\QueueController;
use Dtc\QueueBundle\Entity\Job;
use Dtc\QueueBundle\Entity\JobArchive;
use Dtc\QueueBundle\Entity\Run;
use Dtc\QueueBundle\Entity\RunArchive;
use Dtc\QueueBundle\EventDispatcher\EventDispatcher;
use Dtc\QueueBundle\Model\WorkerManager;
use Dtc\QueueBundle\ORM\LiveJobsGridSource;
use Dtc\QueueBundle\Tests\ORM\JobManagerTest;
use PHPUnit\Framework\TestCase;
use Symfony\Bundle\TwigBundle\TwigEngine;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\StreamedResponse;
use Symfony\Component\Routing\Loader\YamlFileLoader;
use Symfony\Component\Routing\Router;
use Symfony\Component\Templating\TemplateNameParser;
use Twig\Environment;

class QueueControllerTest extends TestCase
{
    public static function setUpBeforeClass()
    {
        JobManagerTest::setUpBeforeClass();
    }

    public function testStatusAction()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer();
        $queueController = new QueueController();
        $queueController->setContainer($container);
        $response = $queueController->statusAction();
        self::assertArrayHasKey('status', $response);
        self::assertArrayHasKey('css', $response);
        self::assertArrayHasKey('js', $response);
    }

    protected function getContainer()
    {
        $container = new Container();
        $container->setParameter('dtc_grid.theme.css', []);
        $container->setParameter('dtc_grid.theme.js', []);
        $container->setParameter('dtc_grid.jquery', []);
        $container->setParameter('dtc_queue.class_job', Job::class);
        $container->setParameter('dtc_queue.class_job_archive', JobArchive::class);
        $container->setParameter('dtc_queue.class_run', Run::class);
        $container->setParameter('dtc_queue.class_run_archive', RunArchive::class);
        $container->setParameter('dtc_queue.admin.chartjs', '');
        $container->setParameter('dtc_queue.default_manager', 'orm');
        $container->set('dtc_queue.job_manager', JobManagerTest::$jobManager);
        $container->set('dtc_queue.worker_manager', new WorkerManager(JobManagerTest::$jobManager, new EventDispatcher()));
        $rendererFactory = new RendererFactory(
            new Router(new YamlFileLoader(new FileLocator(__DIR__)), 'test.yml'),
            [
                'theme.css' => [],
                'theme.js' => [],
                'page_div_style' => 'somestyle',
                'jquery' => [],
                'purl' => [],
                'datatables.css' => [],
                'datatables.js' => [],
                'jq_grid.css' => [],
                'jq_grid.js' => [], ]
        );
        $twigEngine = new TwigEngine(new Environment(new \Twig_Loader_Array()), new TemplateNameParser(), new FileLocator(__DIR__));
        $rendererFactory->setTwigEngine($twigEngine);
        $container->set('dtc_grid.renderer.factory', $rendererFactory);
        $liveJobsGridSource = new LiveJobsGridSource(JobManagerTest::$jobManager);

\Dtc\QueueBundle\Tests\ORM\JobManagerTest::$jobManager of type object<Dtc\QueueBundle\Model\JobManagerInterface> is not a sub-type of object<Dtc\QueueBundle\ORM\JobManager>. It seems like you assume a concrete implementation of the interface Dtc\QueueBundle\Model\JobManagerInterface to be always present.

        $container->set('dtc_queue.grid_source.jobs_waiting.orm', $liveJobsGridSource);
        $liveJobsGridSource = new LiveJobsGridSource(JobManagerTest::$jobManager);

\Dtc\QueueBundle\Tests\ORM\JobManagerTest::$jobManager of type object<Dtc\QueueBundle\Model\JobManagerInterface> is not a sub-type of object<Dtc\QueueBundle\ORM\JobManager>. It seems like you assume a concrete implementation of the interface Dtc\QueueBundle\Model\JobManagerInterface to be always present.

        $liveJobsGridSource->setRunning(true);
        $container->set('dtc_queue.grid_source.jobs_running.orm', $liveJobsGridSource);
        $container->set('dtc_queue.job_manager', JobManagerTest::$jobManager);
        $gridSourceManager = new GridSourceManager(new AnnotationReader(), __DIR__);
        $container->set('dtc_grid.manager.source', $gridSourceManager);
        $gridSourceManager->add(Job::class, new EntityGridSource(JobManagerTest::$jobManager->getObjectManager(), Job::class));

It seems like you code against a concrete implementation and not the interface Dtc\QueueBundle\Model\JobManagerInterface as the method getObjectManager() does only exist in the following implementations of said interface: Dtc\QueueBundle\Doctrine\BaseJobManager, Dtc\QueueBundle\ODM\JobManager, Dtc\QueueBundle\ORM\JobManager.

        return $container;
    }

    public function testJobsAction()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer();
        $queueController = new QueueController();
        $queueController->setContainer($container);
        $response = $queueController->jobsAction();
        self::assertArrayHasKey('css', $response);
        self::assertArrayHasKey('js', $response);
    }

    public function testJobsRunningAction()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer();
        $queueController = new QueueController();
        $queueController->setContainer($container);
        $response = $queueController->runningJobsAction();
        self::assertArrayHasKey('css', $response);
        self::assertArrayHasKey('js', $response);
    }

    public function testWorkersAction()

This method seems to be duplicated in your project.

    {
        $container = $this->getContainer();
        $queueController = new QueueController();
        $queueController->setContainer($container);
        $response = $queueController->workersAction();
        self::assertArrayHasKey('workers', $response);
        self::assertArrayHasKey('css', $response);
        self::assertArrayHasKey('js', $response);
    }

    public function testArchiveJobsAction()
    {
        $container = $this->getContainer();
        $queueController = new QueueController();
        $queueController->setContainer($container);
        $response = $queueController->archiveAction(new Request());
        self::assertNotNull($response);
        self::assertTrue($response instanceof StreamedResponse);
    }
}