Dtc\QueueBundle\Redis\Predis

Complexity

Total Complexity

16

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

78.72%

Importance

Changes	1
Bugs	0	Features	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	set()	0	4	1
A	get()	0	4	1
A	setEx()	0	4	1
A	lRem()	0	4	1
A	lPush()	0	4	1
A	lRange()	0	4	1
A	del()	0	4	1
A	__construct()	0	5	1
A	zAdd()	0	4	1
A	zRem()	0	4	1
B	zPop()	0	24	3
B	zPopByMaxScore()	0	24	3

<?php

namespace Dtc\QueueBundle\Redis;

use Predis\Client;

class Predis implements RedisInterface
{
    protected $predis;
    protected $maxRetries;

    public function __construct(Client $predis, $maxRetries = 5)
    {
        $this->predis = $predis;
        $this->maxRetries = $maxRetries;
    }

    public function zAdd($zkey, $score, $value)
    {
        return $this->predis->zadd($zkey, [$value => $score]);
    }

    public function set($key, $value)
    {
        return $this->predis->set($key, $value);
    }

    public function get($key)
    {
        return $this->predis->get($key);
    }

    public function setEx($key, $seconds, $value)
    {
        return $this->predis->setex($key, $seconds, $value);
    }

    public function lRem($lKey, $count, $value)
    {
        return $this->predis->lrem($lKey, $count, $value);
    }

    public function lPush($lKey, array $values)
    {
        return $this->predis->lpush($lKey, $values);
    }

    public function lRange($lKey, $start, $stop)
    {
        return $this->predis->lrange($lKey, $start, $stop);
    }

    public function del(array $keys)
    {
        return $this->predis->del($keys);
    }

    public function zRem($zkey, $value)
    {
        return $this->predis->zrem($zkey, $value);
    }

    public function zPop($key)
    {
        $element = null;
        $options = [
            'cas' => true,
            'watch' => $key,
            'retry' => $this->maxRetries,
        ];

        try {
            $this->predis->transaction($options, function ($tx) use ($key, &$element) {
                @list($element) = $tx->zrange($key, 0, 0);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                if (isset($element)) {
                    $tx->multi();
                    $tx->zrem($key, $element);
                }
            });
        } catch (\Exception $exception) {
            return null;
        }

        return $element;
    }

    public function zPopByMaxScore($key, $max)
    {
        $element = null;
        $options = [
            'cas' => true,
            'watch' => $key,
            'retry' => $this->maxRetries,
        ];

        try {
            $this->predis->transaction($options, function ($tx) use ($key, $max, &$element) {
                @list($element) = $tx->zrangebyscore($key, 0, $max, ['LIMIT' => [0, 1]]);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                if (isset($element)) {
                    $tx->multi();
                    $tx->zrem($key, $element);
                }
            });
        } catch (\Exception $exception) {
            return null;
        }

        return $element;
    }
}