Completed
Push — master ( 386cc0...5fe2ea )
by Matthew
05:36
created

QueueController::calculateTimings()   C

Complexity

Conditions 12
Paths 54

Size

Total Lines 61
Code Lines 40

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 156

Importance

Changes 0
Metric Value
dl 0
loc 61
ccs 0
cts 53
cp 0
rs 6.2855
c 0
b 0
f 0
cc 12
eloc 40
nc 54
nop 3
crap 156

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
namespace Dtc\QueueBundle\Controller;
4
5
use Dtc\QueueBundle\Model\Worker;
6
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
7
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
8
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
9
10
class QueueController extends Controller
11
{
12
    use ControllerTrait;
13
14
    /**
15
     * Summary stats.
16
     *
17
     * @Route("/")
18
     * @Route("/status/")
19
     * @Template("@DtcQueue/Queue/status.html.twig")
20
     */
21
    public function statusAction()
22
    {
23
        $params = array();
24
        $jobManager = $this->get('dtc_queue.job_manager');
25
26
        $params['status'] = $jobManager->getStatus();
27
        $this->addCssJs($params);
28
29
        return $params;
30
    }
31
32
    /**
33
     * List jobs in system by default.
34
     *
35
     * @Route("/jobs_all", name="dtc_queue_jobs_all")
36
     */
37 View Code Duplication
    public function jobsAllAction()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
38
    {
39
        $this->validateManagerType('dtc_queue.default_manager');
40
        $class1 = $this->container->getParameter('dtc_queue.class_job');
41
        $class2 = $this->container->getParameter('dtc_queue.class_job_archive');
42
        $label1 = 'Non-Archived Jobs';
43
        $label2 = 'Archived Jobs';
44
45
        $params = $this->getDualGridParams($class1, $class2, $label1, $label2);
46
47
        return $this->render('@DtcQueue/Queue/grid.html.twig', $params);
48
    }
49
50
    /**
51
     * List jobs in system by default.
52
     *
53
     * @Template("@DtcQueue/Queue/jobs.html.twig")
54
     * @Route("/jobs", name="dtc_queue_jobs")
55
     */
56
    public function jobsAction()
57
    {
58
        $this->validateManagerType('dtc_queue.default_manager');
59
        $managerType = $this->container->getParameter('dtc_queue.default_manager');
60
        $rendererFactory = $this->get('dtc_grid.renderer.factory');
61
        $renderer = $rendererFactory->create('datatables');
62
        $gridSource = $this->get('dtc_queue.grid_source.live_jobs.'.('mongodb' === $managerType ? 'odm' : $managerType));
63
        $renderer->bind($gridSource);
64
        $params = $renderer->getParams();
65
        $this->addCssJs($params);
66
67
        return $params;
68
    }
69
70
    /**
71
     * @param string $class1
72
     * @param string $class2
73
     * @param string $label1
74
     * @param string $label2
75
     *
76
     * @return \Symfony\Component\HttpFoundation\Response
77
     *
78
     * @throws \Exception
79
     */
80
    protected function getDualGridParams($class1, $class2, $label1, $label2)
81
    {
82
        $rendererFactory = $this->get('dtc_grid.renderer.factory');
83
        $renderer = $rendererFactory->create('datatables');
84
        $gridSource = $this->get('dtc_grid.manager.source')->get($class1);
85
        $renderer->bind($gridSource);
86
        $params = $renderer->getParams();
87
88
        $renderer2 = $rendererFactory->create('datatables');
89
        $gridSource = $this->get('dtc_grid.manager.source')->get($class2);
90
        $renderer2->bind($gridSource);
91
        $params2 = $renderer2->getParams();
92
93
        $params['archive_grid'] = $params2['dtc_grid'];
94
95
        $params['dtc_queue_grid_label1'] = $label1;
96
        $params['dtc_queue_grid_label2'] = $label2;
97
        $this->addCssJs($params);
98
99
        return $params;
100
    }
101
102
    /**
103
     * List jobs in system by default.
104
     *
105
     * @Route("/runs", name="dtc_queue_runs")
106
     */
107 View Code Duplication
    public function runsAction()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
108
    {
109
        $this->validateRunManager();
110
        $class1 = $this->container->getParameter('dtc_queue.class_run');
111
        $class2 = $this->container->getParameter('dtc_queue.class_run_archive');
112
        $label1 = 'Live Runs';
113
        $label2 = 'Archived Runs';
114
115
        $params = $this->getDualGridParams($class1, $class2, $label1, $label2);
116
117
        return $this->render('@DtcQueue/Queue/grid.html.twig', $params);
118
    }
119
120
    /**
121
     * List registered workers in the system.
122
     *
123
     * @Route("/workers", name="dtc_queue_workers")
124
     * @Template("@DtcQueue/Queue/workers.html.twig")
125
     */
126
    public function workersAction()
127
    {
128
        $workerManager = $this->get('dtc_queue.worker_manager');
129
        $workers = $workerManager->getWorkers();
130
131
        $workerList = [];
132
        foreach ($workers as $workerName => $worker) {
133
            /* @var Worker $worker */
134
            $workerList[$workerName] = get_class($worker);
135
        }
136
        $params = ['workers' => $workerList];
137
        $this->addCssJs($params);
138
139
        return $params;
140
    }
141
}
142