JobManager::saveHistory() - Code Metrics - Inspection of "Update beanstalk, rabbitmq, many minor fixes, incl..." - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#7)

by Matthew

created 2017-08-17 16:45 UTC

JobManager::saveHistory() A

↳ Parent: JobManager

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace Dtc\QueueBundle\Beanstalkd;

use Dtc\QueueBundle\Model\Job as BaseJob;
use Dtc\QueueBundle\Model\JobManagerInterface;
use Pheanstalk\Pheanstalk;

class JobManager implements JobManagerInterface
{
    const DEFAULT_RESERVE_TIMEOUT = 5; // seconds

    /** @var Pheanstalk */
    protected $beanstalkd;

    protected $tube;

    protected $reserveTimeout = self::DEFAULT_RESERVE_TIMEOUT;

    public function setBeanstalkd(Pheanstalk $beanstalkd)
    {
        $this->beanstalkd = $beanstalkd;
    }

    public function setTube($tube)
    {
        $this->tube = $tube;
    }

    public function setReserveTimeout($timeout)
    {
        $this->reserveTimeout = $timeout;
    }

    public function save(\Dtc\QueueBundle\Model\Job $job)
    {
        /** @var Job $job */
        $arguments = [$job->toMessage(), $job->getPriority(), $job->getDelay(), $job->getTtr()];
        $method = 'put';
        if ($this->tube) {
            array_unshift($arguments, $this->tube);
            $method .= 'InTube';
        }
        var_dump(get_class($this->beanstalkd));

        var_dump($method);
        $jobId = call_user_func_array([$this->beanstalkd, $method], $arguments);
        $job->setId($jobId);

        return $job;
    }

    public function getJob($workerName = null, $methodName = null, $prioritize = true)
    {
        if ($methodName) {
            throw new \Exception('Unsupported');
        }

        $beanJob = $this->beanstalkd;
        if ($this->tube) {
            $beanJob = $beanJob->watch($this->tube);
        }

        $beanJob = $beanJob->reserve($this->reserveTimeout);
        if ($beanJob) {
            $job = new Job();
            $job->fromMessage($beanJob->getData());
            $job->setId($beanJob->getId());

            return $job;
        }
    }

    public function deleteJob(\Dtc\QueueBundle\Model\Job $job)
    {
        $this->beanstalkd
            ->delete($job);
    }

    // Save History get called upon completion of the job
    public function saveHistory(\Dtc\QueueBundle\Model\Job $job)
    {
        if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
            $this->beanstalkd
                ->delete($job);
        }

        // @Todo Need a strategy for buried jobs, if any?

//        else {
//            $this->beanstalkd
//                ->bury($job);
//        }
    }

    public function getJobCount($workerName = null, $methodName = null)

    {
        if ($methodName) {
            throw new \Exception('Unsupported');
        }

        if ($workerName) {
            throw new \Exception('Unsupported');
        }

        // @Todo - use statistics
    }

    public function getStats()
    {
        return $this->beanstalkd->stats();
    }

    public function resetErroneousJobs($workerName = null, $methodName = null)
    {
        throw new \Exception('Unsupported');
    }

    public function pruneErroneousJobs($workerName = null, $methodName = null)
    {
        throw new \Exception('Unsupported');
    }

    public function getStatus()
    {
        throw new \Exception('Unsupported');
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\Beanstalkd;
4
5		use Dtc\QueueBundle\Model\Job as BaseJob;
6		use Dtc\QueueBundle\Model\JobManagerInterface;
7		use Pheanstalk\Pheanstalk;
8
9		class JobManager implements JobManagerInterface
10		{
11		const DEFAULT_RESERVE_TIMEOUT = 5; // seconds
12
13		/** @var Pheanstalk */
14		protected $beanstalkd;
15
16		protected $tube;
17
18		protected $reserveTimeout = self::DEFAULT_RESERVE_TIMEOUT;
19
20		public function setBeanstalkd(Pheanstalk $beanstalkd)
21		{
22		$this->beanstalkd = $beanstalkd;
23		}
24
25		public function setTube($tube)
26		{
27		$this->tube = $tube;
28		}
29
30		public function setReserveTimeout($timeout)
31		{
32		$this->reserveTimeout = $timeout;
33		}
34
35		public function save(\Dtc\QueueBundle\Model\Job $job)
36		{
37		/** @var Job $job */
38		$arguments = [$job->toMessage(), $job->getPriority(), $job->getDelay(), $job->getTtr()];
39		$method = 'put';
40		if ($this->tube) {
41		array_unshift($arguments, $this->tube);
42		$method .= 'InTube';
43		}
44		var_dump(get_class($this->beanstalkd));
		0 ignored issues – show Security Debugging Code introduced 2017-08-17 16:59 UTC by Report Bug Copy Issue Report `var_dump(get_class($this->beanstalkd));` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
45		var_dump($method);
46		$jobId = call_user_func_array([$this->beanstalkd, $method], $arguments);
47		$job->setId($jobId);
48
49		return $job;
50		}
51
52		public function getJob($workerName = null, $methodName = null, $prioritize = true)
53		{
54		if ($methodName) {
55		throw new \Exception('Unsupported');
56		}
57
58		$beanJob = $this->beanstalkd;
59		if ($this->tube) {
60		$beanJob = $beanJob->watch($this->tube);
61		}
62
63		$beanJob = $beanJob->reserve($this->reserveTimeout);
64		if ($beanJob) {
65		$job = new Job();
66		$job->fromMessage($beanJob->getData());
67		$job->setId($beanJob->getId());
68
69		return $job;
70		}
71		}
72
73		public function deleteJob(\Dtc\QueueBundle\Model\Job $job)
74		{
75		$this->beanstalkd
76		->delete($job);
77		}
78
79		// Save History get called upon completion of the job
80		public function saveHistory(\Dtc\QueueBundle\Model\Job $job)
81		{
82		if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
83		$this->beanstalkd
84		->delete($job);
85		}
86
87		// @Todo Need a strategy for buried jobs, if any?
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-17 16:59 UTC by Report Bug Copy Issue Report `36%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
88		// else {
89		// $this->beanstalkd
90		// ->bury($job);
91		// }
92		}
93
94	View Code Duplication	public function getJobCount($workerName = null, $methodName = null)
		0 ignored issues – show Duplication introduced 2017-08-17 16:59 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		{
96		if ($methodName) {
97		throw new \Exception('Unsupported');
98		}
99
100		if ($workerName) {
101		throw new \Exception('Unsupported');
102		}
103
104		// @Todo - use statistics
105		}
106
107		public function getStats()
108		{
109		return $this->beanstalkd->stats();
110		}
111
112		public function resetErroneousJobs($workerName = null, $methodName = null)
113		{
114		throw new \Exception('Unsupported');
115		}
116
117		public function pruneErroneousJobs($workerName = null, $methodName = null)
118		{
119		throw new \Exception('Unsupported');
120		}
121
122		public function getStatus()
123		{
124		throw new \Exception('Unsupported');
125		}
126		}
127

mmucklo / DtcQueueBundle

Pull Request — master (#7)

JobManager::saveHistory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like