Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class QueueController extends Controller |
||
17 | { |
||
18 | use ControllerTrait; |
||
19 | |||
20 | /** |
||
21 | * Summary stats. |
||
22 | * |
||
23 | * @Route("/") |
||
24 | 1 | * @Route("/status/") |
|
25 | * @Template("@DtcQueue/Queue/status.html.twig") |
||
26 | 1 | */ |
|
27 | 1 | public function statusAction() |
|
37 | |||
38 | /** |
||
39 | * List jobs in system by default. |
||
40 | 1 | * |
|
41 | * @Route("/jobs_all", name="dtc_queue_jobs_all") |
||
42 | 1 | * |
|
43 | 1 | * @throws UnsupportedException |
|
44 | 1 | */ |
|
45 | 1 | View Code Duplication | public function jobsAllAction() |
57 | 1 | ||
58 | /** |
||
59 | 1 | * @Route("/archive", name="dtc_queue_archive") |
|
60 | 1 | * @Method({"POST"}) |
|
61 | * |
||
62 | 1 | * @throws UnsupportedException |
|
63 | */ |
||
64 | public function archiveAction(Request $request) |
||
68 | |||
69 | 1 | /** |
|
70 | * @Route("/reset-stalled", name="dtc_queue_reset_stalled") |
||
71 | * |
||
72 | * @param Request $request |
||
73 | * |
||
74 | * @return StreamedResponse |
||
75 | * |
||
76 | * @throws UnsupportedException |
||
77 | 1 | */ |
|
78 | 1 | public function resetStalledAction(Request $request) |
|
82 | |||
83 | /** |
||
84 | * @Route("/prune-stalled", name="dtc_queue_prune_stalled") |
||
85 | * |
||
86 | * @param Request $request |
||
87 | * |
||
88 | * @return StreamedResponse |
||
89 | 1 | * |
|
90 | * @throws UnsupportedException |
||
91 | 1 | */ |
|
92 | 1 | public function pruneStalledAction(Request $request) |
|
96 | 1 | ||
97 | 1 | /** |
|
98 | 1 | * @param Request $request |
|
99 | * @param $functionName |
||
100 | 1 | * |
|
101 | * @return StreamedResponse |
||
102 | 1 | * |
|
103 | * @throws UnsupportedException |
||
104 | */ |
||
105 | public function streamResults(Request $request, $functionName) |
||
118 | 1 | ||
119 | 1 | /** |
|
120 | 1 | * @param Request $request |
|
121 | * @param string $functionName |
||
122 | 1 | * |
|
123 | * @return \Closure |
||
124 | */ |
||
125 | protected function getStreamFunction(Request $request, $functionName) |
||
162 | 1 | ||
163 | /** |
||
164 | 1 | * List jobs in system by default. |
|
165 | 1 | * |
|
166 | 1 | * @Template("@DtcQueue/Queue/jobs.html.twig") |
|
167 | 1 | * @Route("/jobs", name="dtc_queue_jobs") |
|
168 | 1 | * |
|
169 | * @throws UnsupportedException |
||
170 | 1 | */ |
|
171 | View Code Duplication | public function jobsAction() |
|
187 | 1 | ||
188 | /** |
||
189 | * List jobs in system by default. |
||
190 | 1 | * |
|
191 | 1 | * @Template("@DtcQueue/Queue/jobs_running.html.twig") |
|
192 | 1 | * @Route("/jobs_running", name="dtc_queue_jobs_running") |
|
193 | */ |
||
194 | 1 | View Code Duplication | public function runningJobsAction() |
210 | |||
211 | /** |
||
212 | * @param string $class1 |
||
213 | * @param string $class2 |
||
214 | * @param string $label1 |
||
215 | * @param string $label2 |
||
216 | * |
||
217 | * @return \Symfony\Component\HttpFoundation\Response |
||
218 | * |
||
219 | * @throws \Exception |
||
220 | */ |
||
221 | protected function getDualGridParams($class1, $class2, $label1, $label2) |
||
242 | |||
243 | /** |
||
244 | * List jobs in system by default. |
||
245 | * |
||
246 | * @Route("/runs", name="dtc_queue_runs") |
||
247 | */ |
||
248 | View Code Duplication | public function runsAction() |
|
260 | |||
261 | /** |
||
262 | * List registered workers in the system. |
||
263 | * |
||
264 | * @Route("/workers", name="dtc_queue_workers") |
||
265 | * @Template("@DtcQueue/Queue/workers.html.twig") |
||
266 | */ |
||
267 | public function workersAction() |
||
282 | } |
||
283 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.