for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
namespace Dtc\QueueBundle\Controller;
use Dtc\QueueBundle\Exception\UnsupportedException;
trait ControllerTrait
{
protected function validateJobTimingManager()
if ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
$this->validateManagerType('dtc_queue.manager.job_timing');
} elseif ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
container
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
class MyClass { } $x = new MyClass(); $x->foo = true;
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:
class MyClass { public $foo; } $x = new MyClass(); $x->foo = true;
$this->validateManagerType('dtc_queue.manager.run');
} else {
$this->validateManagerType('dtc_queue.manager.job');
}
protected function validateRunManager()
if ($this->container->hasParameter('dtc_queue.job_timing_manager')) {
/**
* @param string $type
*/
protected function validateManagerType($type)
$managerType = $this->container->getParameter($type);
if ('mongodb' !== $managerType && 'orm' != $managerType && 'odm' != $managerType) {
throw new UnsupportedException("Unsupported manager type: $managerType");
protected function addCssJs(array &$params)
$params['css'] = $this->container->getParameter('dtc_grid.theme.css');
$params['js'] = $this->container->getParameter('dtc_grid.theme.js');
$jQuery = $this->container->getParameter('dtc_grid.jquery');
array_unshift($params['js'], $jQuery['url']);
$params['chartjs'] = $this->container->getParameter('dtc_queue.admin.chartjs');
mmucklo /
DtcQueueBundle
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: