ControllerTrait::validateManagerType() - Code Metrics - Inspection of "4.0 release" - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Matthew

created 2018-01-15 04:55 UTC

ControllerTrait::validateManagerType() A

↳ Parent: ControllerTrait

Complexity

Conditions	4
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	4.128

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	5
cp	0.8
rs	9.2
c	0
b	0
f	0
cc	4
eloc	4
nc	2
nop	1
crap	4.128

<?php

namespace Dtc\QueueBundle\Controller;

use Dtc\QueueBundle\Exception\UnsupportedException;

trait ControllerTrait
{
    protected function validateJobTimingManager()
    {
        if ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
            $this->validateManagerType('dtc_queue.manager.job_timing');
        } elseif ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->validateManagerType('dtc_queue.manager.run');
        } else {
            $this->validateManagerType('dtc_queue.manager.job');
        }
    }

    protected function validateRunManager()
    {
        if ($this->container->hasParameter('dtc_queue.job_timing_manager')) {
            $this->validateManagerType('dtc_queue.manager.run');
        } else {
            $this->validateManagerType('dtc_queue.manager.job');
        }
    }

    /**
     * @param string $type
     */
    protected function validateManagerType($type)
    {
        $managerType = $this->container->getParameter($type);
        if ('mongodb' !== $managerType && 'orm' != $managerType && 'odm' != $managerType) {
            throw new UnsupportedException("Unsupported manager type: $managerType");
        }
    }

    protected function addCssJs(array &$params)
    {
        $params['css'] = $this->container->getParameter('dtc_grid.theme.css');
        $params['js'] = $this->container->getParameter('dtc_grid.theme.js');
        $jQuery = $this->container->getParameter('dtc_grid.jquery');
        array_unshift($params['js'], $jQuery['url']);
        $params['chartjs'] = $this->container->getParameter('dtc_queue.admin.chartjs');
    }
}


1		<?php
2
3		namespace Dtc\QueueBundle\Controller;
4
5		use Dtc\QueueBundle\Exception\UnsupportedException;
6
7		trait ControllerTrait
8		{
9	1	protected function validateJobTimingManager()
10		{
11	1	if ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
12		$this->validateManagerType('dtc_queue.manager.job_timing');
13	1	} elseif ($this->container->hasParameter('dtc_queue.manager.job_timing')) {
		0 ignored issues – show Bug introduced 2018-01-07 01:22 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14		$this->validateManagerType('dtc_queue.manager.run');
15		} else {
16	1	$this->validateManagerType('dtc_queue.manager.job');
17		}
18	1	}
19
20	1	protected function validateRunManager()
21		{
22	1	if ($this->container->hasParameter('dtc_queue.job_timing_manager')) {
23		$this->validateManagerType('dtc_queue.manager.run');
24		} else {
25	1	$this->validateManagerType('dtc_queue.manager.job');
26		}
27	1	}
28
29		/**
30		* @param string $type
31		*/
32	5	protected function validateManagerType($type)
33		{
34	5	$managerType = $this->container->getParameter($type);
35	5	if ('mongodb' !== $managerType && 'orm' != $managerType && 'odm' != $managerType) {
36		throw new UnsupportedException("Unsupported manager type: $managerType");
37		}
38	5	}
39
40	7	protected function addCssJs(array &$params)
41		{
42	7	$params['css'] = $this->container->getParameter('dtc_grid.theme.css');
43	7	$params['js'] = $this->container->getParameter('dtc_grid.theme.js');
44	7	$jQuery = $this->container->getParameter('dtc_grid.jquery');
45	7	array_unshift($params['js'], $jQuery['url']);
46	7	$params['chartjs'] = $this->container->getParameter('dtc_queue.admin.chartjs');
47	7	}
48		}
49

mmucklo / DtcQueueBundle

Pull Request — master (#30)

ControllerTrait::validateManagerType() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like