mmucklo / DtcQueueBundle

Tests/Doctrine/DoctrineJobManagerTest.php

Spacing +1 added lines, -1 removed lines

@@ -286,7 +286,7 @@
         self::assertEquals(1, $count);
         $allCount = $this->runCountQuery($jobManager->getJobClass());
         $counter = 0;
-        $countJobs = function ($count) use (&$counter) {
+        $countJobs = function($count) use (&$counter) {
             $counter += $count;
         };
         $jobManager->archiveAllJobs(null, null, $countJobs);

Controller/QueueController.php

Spacing +2 added lines, -2 removed lines

@@ -60,13 +60,13 @@
         $methodName = $request->get('method');
 
         $jobManager = $this->get('dtc_queue.manager.job');
-        $callback = function ($count) {
+        $callback = function($count) {
             echo json_encode(['count' => $count]);
             echo "\n";
             flush();
         };
 
-        $streamingResponse = new StreamedResponse(function () use ($jobManager, $callback, $workerName, $methodName) {
+        $streamingResponse = new StreamedResponse(function() use ($jobManager, $callback, $workerName, $methodName) {
             $total = $jobManager->countLiveJobs($workerName, $methodName);
             echo json_encode(['total' => $total]);
             echo "\n";

Redis/JobManager.php

Doc Comments +24 added lines, -1 removed lines

@@ -26,6 +26,9 @@ 
     protected $hostname;
     protected $pid;
 
+    /**
+     * @param string $cacheKeyPrefix
+     */
     public function __construct(RunManager $runManager, JobTimingManager $jobTimingManager, $jobClass, $cacheKeyPrefix)
     {
         $this->cacheKeyPrefix = $cacheKeyPrefix;
@@ -45,6 +48,9 @@ 
         return $this->cacheKeyPrefix.'_job_'.$jobId;
     }
 
+    /**
+     * @param string $jobCrc
+     */
     protected function getJobCrcHashKey($jobCrc)
     {
         return $this->cacheKeyPrefix.'_job_crc_'.$jobCrc;
@@ -102,6 +108,10 @@ 
         return null;
     }
 
+    /**
+     * @param string $foundJobCacheKey
+     * @param boolean $foundJobMessage
+     */
     protected function batchFoundJob(\Dtc\QueueBundle\Redis\Job $job, $foundJobCacheKey, $foundJobMessage)
     {
         $when = $job->getWhenUs();
@@ -127,6 +137,10 @@ 
         return $this->finishBatchFoundJob($foundJob, $foundJobCacheKey, $crcCacheKey, $newFoundWhen, $newFoundPriority);
     }
 
+    /**
+     * @param string $crcCacheKey
+     * @param integer|null $newFoundPriority
+     */
     protected function finishBatchFoundJob(Job $foundJob, $foundJobCacheKey, $crcCacheKey, $newFoundWhen, $newFoundPriority)
     {
         // Now how do we adjust this job's priority or time?
@@ -146,6 +160,9 @@ 
         return $this->addFoundJob($adjust, $foundJob, $foundJobCacheKey, $crcCacheKey);
     }
 
+    /**
+     * @param boolean $adjust
+     */
     protected function addFoundJob($adjust, Job $foundJob, $foundJobCacheKey, $crcCacheKey)
     {
         $whenQueue = $this->getWhenQueueCacheKey();
@@ -163,6 +180,9 @@ 
         return $result ?: false;
     }
 
+    /**
+     * @param string $queue
+     */
     private function adjustJob($adjust, $queue, Job $foundJob, $foundJobCacheKey, $crcCacheKey, $zScore)
     {
         if ($adjust && $this->redis->zRem($queue, $foundJob->getId()) > 0) {
@@ -183,7 +203,7 @@ 
     /**
      * @param \Dtc\QueueBundle\Model\Job $job
      *
-     * @return \Dtc\QueueBundle\Model\Job
+     * @return null|Job
      *
      * @throws ClassNotSubclassException
      */
@@ -302,6 +322,9 @@ 
         }
     }
 
+    /**
+     * @param string $workerName
+     */
     protected function verifyGetJobArgs($workerName = null, $methodName = null, $prioritize = true)
     {
         if (null !== $workerName || null !== $methodName || (null !== $this->maxPriority && true !== $prioritize)) {

Manager/RetryableJobManager.php

Doc Comments +8 added lines, -6 removed lines

@@ -20,7 +20,7 @@ 
 
     /**
      * @param RetryableJob $job
-     * @param $retry bool
+     * @param boolean $retry bool
      *
      * @return
      */
@@ -44,7 +44,6 @@ 
     /**
      * @return bool true if retry
      *
-     * @param bool $retry true if the job was retried, false if not
      */
     public function saveHistory(Job $job)
     {
@@ -67,6 +66,10 @@ 
         return $this->updateJobMax($job, 'Exceptions', RetryableJob::STATUS_MAX_EXCEPTIONS, $this->autoRetryOnException);
     }
 
+    /**
+     * @param string $type
+     * @param boolean $autoRetry
+     */
     protected function updateJobMax(RetryableJob $job, $type, $maxStatus, $autoRetry)
     {
         $setMethod = 'set'.$type;
@@ -121,7 +124,6 @@ 
     }
 
     /**
-     * @param RetryableJob $retryableJob
      *
      * @return bool true if the job was successfully "reset", i.e. re-queued
      */
@@ -157,7 +159,7 @@ 
     }
 
     /**
-     * @param int|null $defaultMaxRetry
+     * @param integer|null $defaultMaxRetries
      */
     public function setDefaultMaxRetries($defaultMaxRetries)
     {
@@ -173,7 +175,7 @@ 
     }
 
     /**
-     * @param int|null $defaultMaxFailure
+     * @param integer|null $defaultMaxFailures
      */
     public function setDefaultMaxFailures($defaultMaxFailures)
     {
@@ -221,7 +223,7 @@ 
     }
 
     /**
-     * @param int|null $defaultMaxException
+     * @param integer|null $defaultMaxExceptions
      */
     public function setDefaultMaxExceptions($defaultMaxExceptions)
     {

Manager/StallableJobManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
     }
 
     /**
-     * @param int|null $defaultMaxStalled
+     * @param integer|null $defaultMaxStalls
      */
     public function setDefaultMaxStalls($defaultMaxStalls)
     {