mmucklo / DtcQueueBundle

Tests/RabbitMQ/JobManager.php

Unused Use Statements -5 removed lines

@@ -3,14 +3,9 @@
 
 use Dtc\QueueBundle\RabbitMQ\JobManager;
 use Dtc\QueueBundle\Model\Job;
-use Dtc\QueueBundle\Model\WorkerManager;
-
 use Dtc\QueueBundle\Tests\FibonacciWorker;
-use Dtc\QueueBundle\Tests\StaticJobManager;
 use Dtc\QueueBundle\Tests\Model\BaseJobManagerTest;
-
 use PhpAmqpLib\Connection\AMQPConnection;
-use PhpAmqpLib\Message\AMQPMessage;
 
 /**
  * @author David

BeanStalkd/JobManager.php

Braces +1 added lines, -2 removed lines

@@ -57,8 +57,7 @@
         if ($job->getStatus() === BaseJob::STATUS_SUCCESS) {
             $this->beanstalkd
                 ->delete($job);
-        }
-        else {
+        } else {
             $this->beanstalkd
                 ->bury($job);
         }

DependencyInjection/DtcQueueExtension.php

Indentation +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 {
     public function load(array $configs, ContainerBuilder $container)
     {
-    	$documentName = 'Dtc\QueueBundle\Documents\Job';
+        $documentName = 'Dtc\QueueBundle\Documents\Job';
         $processor = new Processor();
         $configuration = new Configuration();
 

DtcQueueBundle.php

Indentation +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 
 class DtcQueueBundle
-	extends Bundle
+    extends Bundle
 {
     public function build(ContainerBuilder $container)
     {

EventDispatcher/EventDispatcher.php

Spacing +2 added lines, -2 removed lines

@@ -15,7 +15,7 @@ 
 
     public function hasListeners($eventName)
     {
-        if ( ! isset($this->listeners[$eventName])) {
+        if (!isset($this->listeners[$eventName])) {
             return false;
         }
 
@@ -24,7 +24,7 @@ 
 
     public function dispatch($eventName, Event $event)
     {
-        if ( ! isset($this->listeners[$eventName])) {
+        if (!isset($this->listeners[$eventName])) {
             return;
         }
 

Model/Job.php

Indentation +15 added lines, -15 removed lines

@@ -383,19 +383,19 @@
     {
         $this->worker = $worker;
     }
-	/**
-	 * @return the $elapsed
-	 */
-	public function getElapsed()
-	{
-		return $this->elapsed;
-	}
-
-	/**
-	 * @param field_type $elapsed
-	 */
-	public function setElapsed($elapsed)
-	{
-		$this->elapsed = $elapsed;
-	}
+    /**
+     * @return the $elapsed
+     */
+    public function getElapsed()
+    {
+        return $this->elapsed;
+    }
+
+    /**
+     * @param field_type $elapsed
+     */
+    public function setElapsed($elapsed)
+    {
+        $this->elapsed = $elapsed;
+    }
 }

Braces +1 added lines, -2 removed lines

@@ -259,8 +259,7 @@
             }
 
             return true;
-        }
-        else {
+        } else {
             return !is_object($args);
         }
     }

Doc Comments +5 added lines, -5 removed lines

@@ -127,7 +127,7 @@ 
     }
 
     /**
-     * @return the $className
+     * @return string $className
      */
     public function getClassName()
     {
@@ -298,7 +298,7 @@ 
     }
 
     /**
-     * @param field_type $createdAt
+     * @param \DateTime $createdAt
      */
     public function setCreatedAt($createdAt)
     {
@@ -306,7 +306,7 @@ 
     }
 
     /**
-     * @param field_type $updatedAt
+     * @param \DateTime $updatedAt
      */
     public function setUpdatedAt($updatedAt)
     {
@@ -361,7 +361,7 @@ 
     }
 
     /**
-     * @return the $worker
+     * @return null|Worker $worker
      */
     public function getWorker()
     {
@@ -392,7 +392,7 @@ 
 	}
 
 	/**
-	 * @param field_type $elapsed
+	 * @param double $elapsed
 	 */
 	public function setElapsed($elapsed)
 	{

Unused Use Statements -2 removed lines

@@ -1,8 +1,6 @@
 <?php
 namespace Dtc\QueueBundle\Model;
 
-use Doctrine\ODM\MongoDB\Mapping\Annotations as ODM;
-
 class Job
 {
     const STATUS_SUCCESS = 'success';

Model/Worker.php

Braces +1 added lines, -2 removed lines

@@ -45,8 +45,7 @@
         if ($time) {
             $dateTime = new \DateTime();
             $dateTime->setTimestamp($time);
-        }
-        else {
+        } else {
             $dateTime = null;
         }
 

Doc Comments +10 added lines

@@ -53,6 +53,9 @@ 
         return new $this->jobClass($this, $batch, $priority, $dateTime);
     }
 
+    /**
+     * @param integer $priority
+     */
     public function later($delay = 0, $priority = null)
     {
         $job = $this->at(time() + $delay, false, $priority);
@@ -60,6 +63,9 @@ 
         return $job;
     }
 
+    /**
+     * @param integer $priority
+     */
     public function batchLater($delay = 0, $priority = null)
     {
         $job = $this->at($delay, true, $priority);
@@ -67,6 +73,10 @@ 
         return $job;
     }
 
+    /**
+     * @param integer $time
+     * @param integer $priority
+     */
     public function batchAt($time = null, $priority = null)
     {
         return $this->at($time, true, $priority);

Model/WorkerManager.php

Indentation +72 added lines, -72 removed lines

@@ -7,94 +7,94 @@
 
 class WorkerManager
 {
-	protected $workers;
-	protected $jobManager;
-	protected $logger;
+    protected $workers;
+    protected $jobManager;
+    protected $logger;
     protected $eventDispatcher;
 
-	public function __construct(JobManagerInterface $jobManager, EventDispatcher $eventDispatcher, Logger $logger = null) {
-		$this->workers = array();
-		$this->jobManager = $jobManager;
-		$this->logger = $logger;
+    public function __construct(JobManagerInterface $jobManager, EventDispatcher $eventDispatcher, Logger $logger = null) {
+        $this->workers = array();
+        $this->jobManager = $jobManager;
+        $this->logger = $logger;
         $this->eventDispatcher = $eventDispatcher;
-	}
+    }
 
-	public function addWorker(Worker $worker) {
-		if ($this->logger) {
-			$this->logger->debug("Added worker: {$worker->getName()}");
-		}
+    public function addWorker(Worker $worker) {
+        if ($this->logger) {
+            $this->logger->debug("Added worker: {$worker->getName()}");
+        }
 
-		if (isset($this->workers[$worker->getName()])) {
-			throw new \Exception("{$worker->getName()} already exists in worker manager");
-		}
+        if (isset($this->workers[$worker->getName()])) {
+            throw new \Exception("{$worker->getName()} already exists in worker manager");
+        }
 
-		$this->workers[$worker->getName()] = $worker;
-	}
+        $this->workers[$worker->getName()] = $worker;
+    }
 
-	public function getWorker($name) {
-		if (isset($this->workers[$name])) {
-			return $this->workers[$name];
-		}
+    public function getWorker($name) {
+        if (isset($this->workers[$name])) {
+            return $this->workers[$name];
+        }
 
-		return null;
-	}
+        return null;
+    }
 
-	public function getWorkers() {
-		return $this->workers;
-	}
+    public function getWorkers() {
+        return $this->workers;
+    }
 
-	public function run($workerName = null, $methodName = null, $prioritize = true)
-	{
-		$job = $this->jobManager->getJob($workerName, $methodName, $prioritize);
-		if (!$job) {
-			if ($this->logger) {
-				$this->logger->debug("No job to run");
-			}
+    public function run($workerName = null, $methodName = null, $prioritize = true)
+    {
+        $job = $this->jobManager->getJob($workerName, $methodName, $prioritize);
+        if (!$job) {
+            if ($this->logger) {
+                $this->logger->debug("No job to run");
+            }
 
-			return;        // no job to run
-		}
+            return;        // no job to run
+        }
 
-		return $this->runJob($job);
-	}
+        return $this->runJob($job);
+    }
 
-	public function runJob(Job $job) {
+    public function runJob(Job $job) {
         $event = new Event($job);
         $this->eventDispatcher->dispatch(Event::PRE_JOB, $event);
 
-		try {
-			$start = microtime(true);
-			$worker = $this->getWorker($job->getWorkerName());
-			if ($this->logger) {
-				$this->logger->debug("Start: {$job->getClassName()}->{$job->getMethod()}", $job->getArgs());
-			}
-
-			call_user_func_array(array($worker, $job->getMethod()), $job->getArgs());
-
-			// Job finshed successfuly... do we remove the job from database?
-			$job->setStatus(Job::STATUS_SUCCESS);
-			$job->setMessage(null);
-		}
-		catch (\Exception $e) {
-			if ($this->logger) {
-				$this->logger->debug("Failed: {$job->getClassName()}->{$job->getMethod()}\n{$e->getMessage()}");
-			}
-
-			$job->setStatus(Job::STATUS_ERROR);
-			$job->setMessage($e->getMessage() . "\n" .$e->getTraceAsString());
-		}
-
-		// save Job history
-		$elapsed = microtime(true) - $start;
-		$job->setElapsed($elapsed);
-
-		if ($this->logger) {
-			$this->logger->debug("Finished: {$job->getClassName()}->{$job->getMethod()} in {$elapsed} micro-seconds");
-			$this->logger->debug("Save job history: {$job->getId()}");
-		}
-
-		$this->jobManager->saveHistory($job);
+        try {
+            $start = microtime(true);
+            $worker = $this->getWorker($job->getWorkerName());
+            if ($this->logger) {
+                $this->logger->debug("Start: {$job->getClassName()}->{$job->getMethod()}", $job->getArgs());
+            }
+
+            call_user_func_array(array($worker, $job->getMethod()), $job->getArgs());
+
+            // Job finshed successfuly... do we remove the job from database?
+            $job->setStatus(Job::STATUS_SUCCESS);
+            $job->setMessage(null);
+        }
+        catch (\Exception $e) {
+            if ($this->logger) {
+                $this->logger->debug("Failed: {$job->getClassName()}->{$job->getMethod()}\n{$e->getMessage()}");
+            }
+
+            $job->setStatus(Job::STATUS_ERROR);
+            $job->setMessage($e->getMessage() . "\n" .$e->getTraceAsString());
+        }
+
+        // save Job history
+        $elapsed = microtime(true) - $start;
+        $job->setElapsed($elapsed);
+
+        if ($this->logger) {
+            $this->logger->debug("Finished: {$job->getClassName()}->{$job->getMethod()} in {$elapsed} micro-seconds");
+            $this->logger->debug("Save job history: {$job->getId()}");
+        }
+
+        $this->jobManager->saveHistory($job);
         $this->eventDispatcher->dispatch(Event::POST_JOB, $event);
 
-		return $job;
-	}
+        return $job;
+    }
 }

Braces +1 added lines, -2 removed lines

@@ -73,8 +73,7 @@
 			// Job finshed successfuly... do we remove the job from database?
 			$job->setStatus(Job::STATUS_SUCCESS);
 			$job->setMessage(null);
-		}
-		catch (\Exception $e) {
+		} catch (\Exception $e) {
 			if ($this->logger) {
 				$this->logger->debug("Failed: {$job->getClassName()}->{$job->getMethod()}\n{$e->getMessage()}");
 			}

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
 				$this->logger->debug("No job to run");
 			}
 
-			return;        // no job to run
+			return; // no job to run
 		}
 
 		return $this->runJob($job);
@@ -80,7 +80,7 @@ 
 			}
 
 			$job->setStatus(Job::STATUS_ERROR);
-			$job->setMessage($e->getMessage() . "\n" .$e->getTraceAsString());
+			$job->setMessage($e->getMessage()."\n".$e->getTraceAsString());
 		}
 
 		// save Job history

Tests/FibonacciWorker.php

Spacing +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 
     public function fibonacci($n)
     {
-        if($n == 0)
+        if ($n == 0)
             return 0; //F0
         elseif ($n == 1)
             return 1; //F1

Braces +11 added lines, -6 removed lines

@@ -20,12 +20,17 @@
 
     public function fibonacci($n)
     {
-        if($n == 0)
-            return 0; //F0
-        elseif ($n == 1)
-            return 1; //F1
-        else
-            return $this->fibonacci($n - 1) + $this->fibonacci($n - 2);
+        if($n == 0) {
+                    return 0;
+        }
+        //F0
+        elseif ($n == 1) {
+                    return 1;
+        }
+        //F1
+        else {
+                    return $this->fibonacci($n - 1) + $this->fibonacci($n - 2);
+        }
     }
 
     public function getName() {