CommonTrait::setRegistry() - Code Metrics - Inspection of "Attempt at fixing issue #51 - reset the entity man..." - mmucklo/DtcQueueBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#53)

by Matthew

created 2018-01-28 08:48 UTC

CommonTrait::setRegistry() A

↳ Parent: CommonTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	3
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace Dtc\QueueBundle\ORM;

use Doctrine\Bundle\DoctrineBundle\Registry;
use Doctrine\Common\Persistence\ObjectManager;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\Id\AssignedGenerator;
use Doctrine\ORM\Mapping\ClassMetadata;

trait CommonTrait
{
    protected $formerIdGenerators;

    /** @var string */
    protected $entityManagerName;

    /** @var Registry */
    protected $registry;

    public function setEntityManagerName($name = 'default')
    {
        $this->entityManagerName = $name;
    }

    public function setRegistry(Registry $registry)
    {
        $this->registry = $registry;
    }

    /**
     * @param $currentObjectManager
     *
     * @return EntityManager
     */
    public function getObjectManagerReset()
    {
        $currentObjectManager = parent::getObjectManager();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        if (!$currentObjectManager->isOpen() && $this->registry) {
            if (($currentObjectManager = $this->registry->getManager($this->entityManagerName)) && $currentObjectManager->isOpen()) {
                return $this->objectManager = $currentObjectManager;
class MyClass { }

$x = new MyClass();
$x->foo = true;
            }

            return $this->objectManager = $this->registry->resetManager($this->entityManagerName);
        }

        return $currentObjectManager;
    }

    /**
     * @param string    $objectName
     * @param string    $field
     * @param \DateTime $olderThan
     *
     * @return int
     */
    protected function removeOlderThan($objectName, $field, \DateTime $olderThan)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $qb = $objectManager->createQueryBuilder()->delete($objectName, 'j');
        $qb = $qb
            ->where('j.'.$field.' < :'.$field)
            ->setParameter(':'.$field, $olderThan);

        $query = $qb->getQuery();

        return $query->execute();
    }

    public function stopIdGenerator($objectName)
    {
        /** @var EntityManager $objectManager */
        $objectManager = $this->getObjectManager();
        $repository = $objectManager->getRepository($objectName);
        /** @var ClassMetadata $metadata */
        $metadata = $objectManager->getClassMetadata($repository->getClassName());
        $this->formerIdGenerators[$objectName]['generator'] = $metadata->idGenerator;
        $this->formerIdGenerators[$objectName]['type'] = $metadata->generatorType;
        $metadata->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_NONE);
        $metadata->setIdGenerator(new AssignedGenerator());
    }

    public function restoreIdGenerator($objectName)
    {
        $objectManager = $this->getObjectManager();
        $repository = $objectManager->getRepository($objectName);
        /** @var ClassMetadata $metadata */
        $metadata = $objectManager->getClassMetadata($repository->getClassName());
        $generator = $this->formerIdGenerators[$objectName]['generator'];
        $type = $this->formerIdGenerators[$objectName]['type'];
        $metadata->setIdGeneratorType($type);
        $metadata->setIdGenerator($generator);
    }

    /**
     * @return ObjectManager
     */
    abstract public function getObjectManager();
}


1		<?php
2
3		namespace Dtc\QueueBundle\ORM;
4
5		use Doctrine\Bundle\DoctrineBundle\Registry;
6		use Doctrine\Common\Persistence\ObjectManager;
7		use Doctrine\ORM\EntityManager;
8		use Doctrine\ORM\Id\AssignedGenerator;
9		use Doctrine\ORM\Mapping\ClassMetadata;
10
11		trait CommonTrait
12		{
13		protected $formerIdGenerators;
14
15		/** @var string */
16		protected $entityManagerName;
17
18		/** @var Registry */
19		protected $registry;
20
21		public function setEntityManagerName($name = 'default')
22		{
23		$this->entityManagerName = $name;
24		}
25
26		public function setRegistry(Registry $registry)
27		{
28		$this->registry = $registry;
29		}
30
31		/**
32		* @param $currentObjectManager
33		*
34		* @return EntityManager
35		*/
36	32	public function getObjectManagerReset()
37		{
38	32	$currentObjectManager = parent::getObjectManager();
		0 ignored issues – show Comprehensibility Bug introduced 2018-01-28 08:56 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getObjectManager()` instead of `getObjectManagerReset()`). Are you sure this is correct? If so, you might want to change this to `$this->getObjectManager()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
39	32	if (!$currentObjectManager->isOpen() && $this->registry) {
40		if (($currentObjectManager = $this->registry->getManager($this->entityManagerName)) && $currentObjectManager->isOpen()) {
41		return $this->objectManager = $currentObjectManager;
		0 ignored issues – show Bug introduced 2018-01-28 08:29 UTC by Report Bug Copy Issue Report The property `objectManager` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42		}
43
44		return $this->objectManager = $this->registry->resetManager($this->entityManagerName);
45		}
46
47	32	return $currentObjectManager;
48		}
49
50		/**
51		* @param string $objectName
52		* @param string $field
53		* @param \DateTime $olderThan
54		*
55		* @return int
56		*/
57	1	protected function removeOlderThan($objectName, $field, \DateTime $olderThan)
58		{
59		/** @var EntityManager $objectManager */
60	1	$objectManager = $this->getObjectManager();
61	1	$qb = $objectManager->createQueryBuilder()->delete($objectName, 'j');
62		$qb = $qb
63	1	->where('j.'.$field.' < :'.$field)
64	1	->setParameter(':'.$field, $olderThan);
65
66	1	$query = $qb->getQuery();
67
68	1	return $query->execute();
69		}
70
71	1	public function stopIdGenerator($objectName)
72		{
73		/** @var EntityManager $objectManager */
74	1	$objectManager = $this->getObjectManager();
75	1	$repository = $objectManager->getRepository($objectName);
76		/** @var ClassMetadata $metadata */
77	1	$metadata = $objectManager->getClassMetadata($repository->getClassName());
78	1	$this->formerIdGenerators[$objectName]['generator'] = $metadata->idGenerator;
79	1	$this->formerIdGenerators[$objectName]['type'] = $metadata->generatorType;
80	1	$metadata->setIdGeneratorType(ClassMetadata::GENERATOR_TYPE_NONE);
81	1	$metadata->setIdGenerator(new AssignedGenerator());
82	1	}
83
84	1	public function restoreIdGenerator($objectName)
85		{
86	1	$objectManager = $this->getObjectManager();
87	1	$repository = $objectManager->getRepository($objectName);
88		/** @var ClassMetadata $metadata */
89	1	$metadata = $objectManager->getClassMetadata($repository->getClassName());
90	1	$generator = $this->formerIdGenerators[$objectName]['generator'];
91	1	$type = $this->formerIdGenerators[$objectName]['type'];
92	1	$metadata->setIdGeneratorType($type);
93	1	$metadata->setIdGenerator($generator);
94	1	}
95
96		/**
97		* @return ObjectManager
98		*/
99		abstract public function getObjectManager();
100		}
101

mmucklo / DtcQueueBundle

Pull Request — master (#53)

CommonTrait::setRegistry() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like