Dtc\QueueBundle\Redis\StatusTrait

Complexity

Total Complexity

12

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

82.5%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	collateStatusResults()	0	15	3
B	extractStatusResults()	0	17	5
A	extractStatusHashResults()	0	14	4

<?php

namespace Dtc\QueueBundle\Redis;

use Dtc\QueueBundle\Model\BaseJob;

trait StatusTrait
{
    protected function collateStatusResults(array &$results, $cacheKey)
    {
        $cursor = null;
        while ($jobs = $this->redis->zScan($cacheKey, $cursor, '', 100)) {

The property redis does not exist. Did you maybe forget to declare it?

            $jobs = $this->redis->mget(array_map(function ($item) {
                return $this->getJobCacheKey($item);

It seems like getJobCacheKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }, array_keys($jobs)));
            $this->extractStatusResults($jobs, $results);
            if (0 === $cursor) {
                break;
            }
        }

        return $results;
    }

    protected function extractStatusResults(array $jobs, array &$results)
    {
        foreach ($jobs as $jobMessage) {
            if (is_string($jobMessage)) {
                $job = new Job();
                $job->fromMessage($jobMessage);
                $resultHashKey = $job->getWorkerName().'->'.$job->getMethod().'()';
                if (!isset($results[$resultHashKey][BaseJob::STATUS_NEW])) {
                    $results[$resultHashKey] = static::getAllStatuses();
                }
                if (!isset($results[$resultHashKey][BaseJob::STATUS_NEW])) {
                    $results[$resultHashKey][BaseJob::STATUS_NEW] = 0;
                }
                ++$results[$resultHashKey][BaseJob::STATUS_NEW];
            }
        }
    }

    protected function extractStatusHashResults(array $hResults, array &$results)
    {
        foreach ($hResults as $key => $value) {
            list($workerName, $method, $status) = explode(',', $key);
            $resultHashKey = $workerName.'->'.$method.'()';
            if (!isset($results[$resultHashKey])) {
                $results[$resultHashKey] = static::getAllStatuses();
            }
            if (!isset($results[$resultHashKey][$status])) {
                $results[$resultHashKey][$status] = 0;
            }
            $results[$resultHashKey][$status] += $value;
        }
    }
}