mmucklo /
DtcGridBundle
| Conditions | 14 |
| Paths | 1538 |
| Total Lines | 58 |
| Code Lines | 35 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 55 | public function create($type) |
||
| 56 | { |
||
| 57 | $twigEngine = $this->getTwigEngine(); |
||
| 58 | if (!$twigEngine) { |
||
| 59 | throw new \Exception('Twig Engine not found. Please see README.md for instructions.'); |
||
| 60 | } |
||
| 61 | switch ($type) { |
||
| 62 | case 'datatables': |
||
| 63 | $renderer = new DataTablesRenderer($this->twigEngine, $this->router); |
||
| 64 | break; |
||
| 65 | case 'jq_grid': |
||
| 66 | $renderer = new JQGridRenderer($this->twigEngine, $this->router); |
||
| 67 | break; |
||
| 68 | case 'table': |
||
| 69 | $renderer = new TableGridRenderer($this->twigEngine, $this->router); |
||
| 70 | break; |
||
| 71 | default: |
||
| 72 | throw new \Exception("No renderer for type '$type''"); |
||
| 73 | } |
||
| 74 | |||
| 75 | if (method_exists($renderer, 'setThemeCss')) { |
||
| 76 | $renderer->setThemeCss($this->themeCss); |
||
| 77 | } |
||
| 78 | |||
| 79 | if (method_exists($renderer, 'setThemeJs')) { |
||
| 80 | $renderer->setThemeJs($this->themeJs); |
||
| 81 | } |
||
| 82 | |||
| 83 | if (method_exists($renderer, 'setJQuery')) { |
||
| 84 | $renderer->setJQuery($this->jQuery); |
||
| 85 | } |
||
| 86 | |||
| 87 | if (method_exists($renderer, 'setPurl')) { |
||
| 88 | $renderer->setPurl($this->purl); |
||
| 89 | } |
||
| 90 | |||
| 91 | if (method_exists($renderer, 'setPageDivStyle')) { |
||
| 92 | $renderer->setPageDivStyle($this->pageDivStyle); |
||
| 93 | } |
||
| 94 | |||
| 95 | if (method_exists($renderer, 'setJqGridCss')) { |
||
| 96 | $renderer->setJqGridCss($this->jqGridCss); |
||
| 97 | } |
||
| 98 | |||
| 99 | if (method_exists($renderer, 'setJqGridJs')) { |
||
| 100 | $renderer->setJqGridJs($this->jqGridJs); |
||
| 101 | } |
||
| 102 | |||
| 103 | if (method_exists($renderer, 'setDataTablesCss')) { |
||
| 104 | $renderer->setDataTablesCss($this->dataTablesCss); |
||
| 105 | } |
||
| 106 | |||
| 107 | if (method_exists($renderer, 'setDataTablesJs')) { |
||
| 108 | $renderer->setDataTablesJs($this->dataTablesJs); |
||
| 109 | } |
||
| 110 | |||
| 111 | return $renderer; |
||
| 112 | } |
||
| 113 | } |
||
| 114 |
