Issues in jodel-web.php (master) - Issues in master - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1191)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

php/jodel-web.php (6 issues)

Labels

Severity

Informational 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

include 'php/DatabaseConnect.php';
include 'php/Location.php';
include 'php/JodelAccount.php';
include 'php/Jodel.php';
include 'php/View.php';

include 'php/Requests/AbstractRequest.php';
include 'php/Requests/CreateUser.php';
include 'php/Requests/GetPosts.php';
include 'php/Requests/GetKarma.php';
include 'php/Requests/UpdateLocation.php';
include 'php/Requests/Upvote.php';
include 'php/Requests/Downvote.php';
include 'php/Requests/GetPostDetails.php';
include 'php/Requests/SendJodel.php';
include 'php/Requests/GetCaptcha.php';
include 'php/Requests/PostCaptcha.php';
include 'php/Requests/GetUserConfig.php';
include 'php/Requests/GetChannel.php';

require_once 'php/Requests/libary/Requests.php';
Requests::register_autoloader();

$config = parse_ini_file('config/config.ini.php');
$baseUrl = $config['Url'];
$buildViewError = '';

$location = new Location();
$location->setLat($config['default_lat']);
$location->setLng($config['default_lng']);
$location->setCityName($config['default_location']);
//What is dude doing with my Server?
if($_SERVER['REMOTE_ADDR'] == '94.231.103.52')
{
	echo('You are flooting my Server! Pls enable Cookies in your script and contact me: [email protected]');
	die();
}

if(isset($_GET['solution']) && isset($_GET['key']) && isset($_GET['deviceUid']))
{
	$jodelAccount = new JodelAccount($_GET['deviceUid']);
	$response = array("success" => $jodelAccount->verifyCaptcha());
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	echo json_encode($response);

	die();
}

function user_log($msg)
{
    $log  = $msg . PHP_EOL;
    file_put_contents(realpath(__DIR__ . '/..') . '/logs/user_log-' . date("Y.n.j") . '.txt', $log, FILE_APPEND);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
}

function isUserBot()
{
    preg_match('/bot|spider|google|twitter/i', $_SERVER['HTTP_USER_AGENT'], $matches);

    return (isset($matches[0])) ? true : false;
}

function configPropertyExists($config, $property)
{
    if(!array_key_exists($property, $config) || !isset($config[$property]) || $config[$property] == '' || $config[$property] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
    {
        return FALSE;
    }
    else
    {
        return TRUE;
    }
}

function isUserVoter()
{
	if(isset($_COOKIE['JodelVoterPassword']))
	{	
		$db = new DatabaseConnect();

		$result = $db->query("SELECT id FROM users WHERE user_token = '" . $_COOKIE['JodelVoterPassword'] . "'");
		if($result->num_rows == 0)
		{
			$db->close();
			return FALSE;
		}
		else
		{
			$db->close();
			return TRUE;
		}
	}
	else
	{
		return FALSE;
	}
}

function isUserAdmin()
{
	global $config;
	if (isset($_COOKIE['JodelAdminPassword']) && configPropertyExists($config, 'pw') && $config['pw'] == $_COOKIE['JodelAdminPassword'])
	{
		return TRUE;
	}
	else
	{
		return FALSE;
	}
}

function isDeviceUidInDatabase($deviceUid)
{
    $db = new DatabaseConnect();  

    $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");

    if ($result->num_rows > 0)
    {
    	$db->close();
        return TRUE;
    }
    else
    {
    	$db->close();
        return FALSE;
    }
}

	//Check if it's a Spider or Google Bot
	if(configPropertyExists($config, 'botDeviceUid') && isUserBot())
	{
		user_log('Spider or Bot checked in!');
		
		$jodelAccountForView = new JodelAccount($config['botDeviceUid'], TRUE);
	}
	else
	{
		if(!isset($_COOKIE['JodelDeviceId']) || !isDeviceUidInDatabase($_COOKIE['JodelDeviceId']))
		{
			$jodelAccountForView = new JodelAccount();
			setcookie('JodelDeviceId', $jodelAccountForView->deviceUid, time()+60*60*24*365*10);
			user_log('Created account with JodelDeviceId:' . $jodelAccountForView->deviceUid .  ' for [' . $_SERVER ['HTTP_USER_AGENT'] . ']');
			
		}
		else
		{
			$jodelAccountForView = new JodelAccount($_COOKIE['JodelDeviceId']);
		}
		
	}
	
	if(configPropertyExists($config, 'karmaDeviceUid'))
    {
    	$jodelAccountForKarma = new JodelAccount($config['karmaDeviceUid']);
    }
    else
    {
    	error_log("No Karma deviceUid set in config file");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$jodelAccountForKarma = new JodelAccount($deviceUid);
    }

	/*
	 * Cunstruct View
	 */

	$hashtag = '';

	if(isset($_GET['search']))
	{

		user_log('User with JodelDeviceId:' . $jodelAccountForView->deviceUid .  ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] searched for ' . $_GET['search']);

		if(substr($_GET['search'], 0, 1) === "#")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		{
			if(strrpos($_GET['search'], ' ') == NULL)
			{
				$hashtag = substr($_GET['search'], 1);
			}
			else
			{
				$hashtag = substr($_GET['search'], 1, strrpos($_GET['search'], ' '));

				$city = substr($_GET['search'],
						strrpos($_GET['search'], ' ') + 1,
						strlen($_GET['search']));

				if($city != NULL && $city != '')
				{
					$_GET['city'] = $city;
				}
			}
		}
		else
		{
			$_GET['city'] = $_GET['search'];
		}
	}
	$hashtag = trim($hashtag);

	if($hashtag == '')
	{
		if(isset($_GET['hashtag']))
		{
			$hashtag = $_GET['hashtag'];
		}
		else
		{
			$hashtag = '#all';
		}
	}
	
	//Set Location
	if(isset($_GET['city']) && $_GET['city'] != '' && !$jodelAccountForView->locationEquals($_GET['city']))
	{
		$cityName = $jodelAccountForView->setLocation();
	}
	else
	{
		$cityName = $jodelAccountForView->location->getCityName();
	}


	
	if(isset($_GET['view']))
	{
		switch ($_GET['view']) {
			case 'discussed':
				$view = 'discussed';
				break;
			
			case 'popular':
				$view = 'popular';
				break;

			default:
				$view = 'combo';
				break;
		}
	}
	else
	{
		$view = 'combo';
	}

	if(isset($_GET['postId']))
	{
		$view = new View($baseUrl, 'DE', $cityName, $hashtag, $view, $_GET['postId']);
	}
	else
	{
		$view = new View($baseUrl, 'DE', $cityName, $hashtag, $view);
	}
	
	$newPositionStatus = '';
	if($hashtag != '#all')
	{
		$newPositionStatus = '#' . $hashtag . ' ';
	}
	$newPositionStatus .= $cityName;

	//Verify Account
	if(isset($_GET['solution']) && isset($_GET['key']) && isset($_GET['deviceUid']))
	{
		$jodelAccountForVerify = new JodelAccount($_GET['deviceUid']);
		$jodelAccountForVerify->verifyCaptcha();
	}
	
	//SendJodel
	if(isset($_POST['message']))
	{
		$errorMsg = $jodelAccountForView->sendJodel($jodelAccountForView->location, $view);
	}
?>

1		<?php
2
3		include 'php/DatabaseConnect.php';
4		include 'php/Location.php';
5		include 'php/JodelAccount.php';
6		include 'php/Jodel.php';
7		include 'php/View.php';
8
9		include 'php/Requests/AbstractRequest.php';
10		include 'php/Requests/CreateUser.php';
11		include 'php/Requests/GetPosts.php';
12		include 'php/Requests/GetKarma.php';
13		include 'php/Requests/UpdateLocation.php';
14		include 'php/Requests/Upvote.php';
15		include 'php/Requests/Downvote.php';
16		include 'php/Requests/GetPostDetails.php';
17		include 'php/Requests/SendJodel.php';
18		include 'php/Requests/GetCaptcha.php';
19		include 'php/Requests/PostCaptcha.php';
20		include 'php/Requests/GetUserConfig.php';
21		include 'php/Requests/GetChannel.php';
22
23		require_once 'php/Requests/libary/Requests.php';
24		Requests::register_autoloader();
25
26		$config = parse_ini_file('config/config.ini.php');
27		$baseUrl = $config['Url'];
28		$buildViewError = '';
29
30		$location = new Location();
31		$location->setLat($config['default_lat']);
32		$location->setLng($config['default_lng']);
33		$location->setCityName($config['default_location']);
34		//What is dude doing with my Server?
35		if($_SERVER['REMOTE_ADDR'] == '94.231.103.52')
36		{
37		echo('You are flooting my Server! Pls enable Cookies in your script and contact me: [email protected]');
38		die();
39		}
40
41	View Code Duplication	if(isset($_GET['solution']) && isset($_GET['key']) && isset($_GET['deviceUid']))
42		{
43		$jodelAccount = new JodelAccount($_GET['deviceUid']);
44		$response = array("success" => $jodelAccount->verifyCaptcha());
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-02 17:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `success` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
45		echo json_encode($response);
46
47		die();
48		}
49
50		function user_log($msg)
51		{
52		$log = $msg . PHP_EOL;
53		file_put_contents(realpath(__DIR__ . '/..') . '/logs/user_log-' . date("Y.n.j") . '.txt', $log, FILE_APPEND);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-05-10 00:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `Y.n.j` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
54		}
55
56		function isUserBot()
57		{
58		preg_match('/bot\|spider\|google\|twitter/i', $_SERVER['HTTP_USER_AGENT'], $matches);
59
60		return (isset($matches[0])) ? true : false;
61		}
62
63		function configPropertyExists($config, $property)
64		{
65		if(!array_key_exists($property, $config) \|\| !isset($config[$property]) \|\| $config[$property] == '' \|\| $config[$property] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
66		{
67		return FALSE;
68		}
69		else
70		{
71		return TRUE;
72		}
73		}
74
75		function isUserVoter()
76		{
77		if(isset($_COOKIE['JodelVoterPassword']))
78		{
79		$db = new DatabaseConnect();
		0 ignored issues – show Comprehensibility introduced 2017-04-20 22:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
80		$result = $db->query("SELECT id FROM users WHERE user_token = '" . $_COOKIE['JodelVoterPassword'] . "'");
81	View Code Duplication	if($result->num_rows == 0)
82		{
83		$db->close();
84		return FALSE;
85		}
86		else
87		{
88		$db->close();
89		return TRUE;
90		}
91		}
92		else
93		{
94		return FALSE;
95		}
96		}
97
98		function isUserAdmin()
99		{
100		global $config;
101		if (isset($_COOKIE['JodelAdminPassword']) && configPropertyExists($config, 'pw') && $config['pw'] == $_COOKIE['JodelAdminPassword'])
102		{
103		return TRUE;
104		}
105		else
106		{
107		return FALSE;
108		}
109		}
110
111		function isDeviceUidInDatabase($deviceUid)
112		{
113		$db = new DatabaseConnect();
		0 ignored issues – show Comprehensibility introduced 2017-03-04 16:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
114		$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid . "'");
115
116	View Code Duplication	if ($result->num_rows > 0)
117		{
118		$db->close();
119		return TRUE;
120		}
121		else
122		{
123		$db->close();
124		return FALSE;
125		}
126		}
127
128		//Check if it's a Spider or Google Bot
129		if(configPropertyExists($config, 'botDeviceUid') && isUserBot())
130		{
131		user_log('Spider or Bot checked in!');
132
133		$jodelAccountForView = new JodelAccount($config['botDeviceUid'], TRUE);
134		}
135		else
136		{
137		if(!isset($_COOKIE['JodelDeviceId']) \|\| !isDeviceUidInDatabase($_COOKIE['JodelDeviceId']))
138		{
139		$jodelAccountForView = new JodelAccount();
140		setcookie('JodelDeviceId', $jodelAccountForView->deviceUid, time()+60602436510);
141		user_log('Created account with JodelDeviceId:' . $jodelAccountForView->deviceUid . ' for [' . $_SERVER ['HTTP_USER_AGENT'] . ']');
142
143		}
144		else
145		{
146		$jodelAccountForView = new JodelAccount($_COOKIE['JodelDeviceId']);
147		}
148
149		}
150
151		if(configPropertyExists($config, 'karmaDeviceUid'))
152		{
153		$jodelAccountForKarma = new JodelAccount($config['karmaDeviceUid']);
154		}
155		else
156		{
157		error_log("No Karma deviceUid set in config file");
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `No Karma deviceUid set in config file` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
158		$jodelAccountForKarma = new JodelAccount($deviceUid);
159		}
160
161		/*
162		* Cunstruct View
163		*/
164
165		$hashtag = '';
166
167		if(isset($_GET['search']))
168		{
169
170		user_log('User with JodelDeviceId:' . $jodelAccountForView->deviceUid . ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] searched for ' . $_GET['search']);
171
172		if(substr($_GET['search'], 0, 1) === "#")
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-15 03:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `#` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
173		{
174		if(strrpos($_GET['search'], ' ') == NULL)
175		{
176		$hashtag = substr($_GET['search'], 1);
177		}
178		else
179		{
180		$hashtag = substr($_GET['search'], 1, strrpos($_GET['search'], ' '));
181
182		$city = substr($_GET['search'],
183		strrpos($_GET['search'], ' ') + 1,
184		strlen($_GET['search']));
185
186		if($city != NULL && $city != '')
187		{
188		$_GET['city'] = $city;
189		}
190		}
191		}
192		else
193		{
194		$_GET['city'] = $_GET['search'];
195		}
196		}
197		$hashtag = trim($hashtag);
198
199		if($hashtag == '')
200		{
201		if(isset($_GET['hashtag']))
202		{
203		$hashtag = $_GET['hashtag'];
204		}
205		else
206		{
207		$hashtag = '#all';
208		}
209		}
210
211		//Set Location
212		if(isset($_GET['city']) && $_GET['city'] != '' && !$jodelAccountForView->locationEquals($_GET['city']))
213		{
214		$cityName = $jodelAccountForView->setLocation();
215		}
216		else
217		{
218		$cityName = $jodelAccountForView->location->getCityName();
219		}
220
221
222
223		if(isset($_GET['view']))
224		{
225		switch ($_GET['view']) {
226		case 'discussed':
227		$view = 'discussed';
228		break;
229
230		case 'popular':
231		$view = 'popular';
232		break;
233
234		default:
235		$view = 'combo';
236		break;
237		}
238		}
239		else
240		{
241		$view = 'combo';
242		}
243
244		if(isset($_GET['postId']))
245		{
246		$view = new View($baseUrl, 'DE', $cityName, $hashtag, $view, $_GET['postId']);
247		}
248		else
249		{
250		$view = new View($baseUrl, 'DE', $cityName, $hashtag, $view);
251		}
252
253		$newPositionStatus = '';
254		if($hashtag != '#all')
255		{
256		$newPositionStatus = '#' . $hashtag . ' ';
257		}
258		$newPositionStatus .= $cityName;
259
260		//Verify Account
261		if(isset($_GET['solution']) && isset($_GET['key']) && isset($_GET['deviceUid']))
262		{
263		$jodelAccountForVerify = new JodelAccount($_GET['deviceUid']);
264		$jodelAccountForVerify->verifyCaptcha();
265		}
266
267		//SendJodel
268		if(isset($_POST['message']))
269		{
270		$errorMsg = $jodelAccountForView->sendJodel($jodelAccountForView->location, $view);
271		}
272		?>

mmainstreet / jodel-web

Issues (1191)

Security Analysis not enabled

php/jodel-web.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like