Issues in AbstractRequest.php (master) - Issues in master - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1191)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

php/Requests/AbstractRequest.php (68 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

abstract class AbstractRequest
namespace YourVendor;

class YourClass { }
{	

    const CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
    const APIURL = 'https://api.go-tellm.com/api';
$a = "a";
$ab = "ab";
$abc = "abc";

    const SECRET = 'hyTBJcvtpDLSgGUWjybbYUNKSSoVvMcfdjtjiQvf';
$a = "a";
$ab = "ab";
$abc = "abc";
    const USERAGENT = 'Jodel/4.47.0 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )';
$a = "a";
$ab = "ab";
$abc = "abc";
    const CLIENT_TYPE = 'android_4.47.0';
    
    private $accessToken = null;
    private $payLoad;
    public $expects = '';
$a = "a";
$ab = "ab";
$abc = "abc";
    public $version = 'v2';
$a = "a";
$ab = "ab";
$abc = "abc";
    public $hasPayload = FALSE;

    public function execute()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $result = new \stdClass();
		        
		$this->payLoad = $this->getPayload();
		$device_uid = '';
$a = "a";
$ab = "ab";
$abc = "abc";
		if(isset($this->payLoad['device_uid'])) {
			$device_uid = $this->payLoad['device_uid'];
		}
				
				
        $this->payLoad = json_encode($this->payLoad);
        $header = $this->getSignHeaders();
$a = "a";
$ab = "ab";
$abc = "abc";
        $url = $this->getFullUrl();
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($this->getAccessToken()) {
            $header['Authorization'] = "Bearer " . $this->getAccessToken();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        //Comment out to debug the Request:

        /*

        printf("URL: ");
        var_dump($url);
        echo "<br />";
        printf("Header: ");
        var_dump($header);
        echo "<br />";
        printf("Payload: ");
        var_dump($this->payLoad);
        echo "<br />";
        */
        /*

        $options = array(
            'timeout' => 100,
            'connect_timeout' => 100,
            'proxy' => '186.103.169.165:8080',
        );*/

        switch ($this->getMethod()) {
            case 'POST':
                $result = Requests::post($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
            case 'GET':
                if($this->hasPayload)
                {
                    $result = Requests::get($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }
                else
                {
                    $result = Requests::get($url, $header);
                }
                break;
            case 'PUT':
                $result = Requests::put($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
        }

        http_response_code($result->status_code);

        switch ($result->status_code) {
            case 200:
                $result = json_decode($result->body, true);
                break;
            case 204:
                $result = 'Success';
                http_response_code(200);
                break;
            case 400:

                $result = json_decode($result->body, true);
                error_log('Error 400 - ' . print_r($result, true));
                break;
            case 401:
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                if($result == "Unauthorized")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                {
                    error_log("Error 401: Unauthorized");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
                else
                {
                    $result = json_decode($result->body, true);

                    if(is_array($result) && $result['error'] == 'length')
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                    {

                    }
                    else
                    {
                        error_log('Error 401 - ' . print_r($result, true));
                    }
                }


                break;
            case 404:
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;


                error_log('Error 404 - ' . print_r($result, true));
                $result = json_decode($result->body, true);

                if(array_key_exists('error', $result) && $result['error'] == 'post_blocked')
                {
                    header('HTTP/1.0 404 Not Found');
                    include('error-pages/404.php');
                    exit();

                }

                break;
			case 477:

                $result = json_decode($result->body, true);
                error_log('Error 477 - ' . print_r($result, true));
                break;
            case 429:

                error_log('Error 429 - Too Many Requests' . print_r(json_decode($result->body, true), true));
            	exit("Error 429: Too Many Requests");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            	break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 403:
                error_log('Error 403 - Access denied:' . print_r(json_decode($result->body, true), true));
                $result = json_decode($result->body, true);
                break;
            case 502:
                error_log('Error 502 - ' . print_r($result, true));
                $result = json_decode($result->body, true);
                header('location:'.$_SERVER['PHP_SELF']);
                break;
            case 503:

                error_log('Error 503 - ' . print_r($result, true));
                $result = json_decode($result->body, true);

                if(array_key_exists('error', $result) && $result['error'] == 'Service Unavailable')
                {
                    header('location:'.$_SERVER['PHP_SELF']); 
                }
                break;
            default:
                error_log('Error '.$result->status_code.' - unknown error');
                $result = json_decode($result->body, true);
        }

        //important for account refresh
        if($device_uid != '')
        {
			$result[0] = $result;
			$result[1] = $device_uid;
        }

        
        /*

        var_dump($result);
        */
        
        return $result;
    }
    abstract function getPayload();

    /**
     * Gets Sign headers
     * @return array headers

     */
    private function getSignHeaders()
    {
			if($this->getAccessToken() == null) {
				$payload_accessToken = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else {
				$payload_accessToken = $this->getAccessToken();
			}
			
			
        $headers = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            "Connection" => "keep-alive",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Accept-Encoding" => "gzip",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Content-Type" => "application/json; charset=UTF-8",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "User-Agent" => self::USERAGENT
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
        $timestamp = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = $timestamp->format(DateTime::ATOM);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = substr($timestamp, 0, -6);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp .= "Z";
$a = "a";
$ab = "ab";
$abc = "abc";
        $urlParts = parse_url($this->getFullUrl());
$a = "a";
$ab = "ab";
$abc = "abc";
        $url2 = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        $req = [$this->getMethod(),
$a = "a";
$ab = "ab";
$abc = "abc";
            $urlParts['host'],
            "443",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $urlParts['path'],
            $payload_accessToken,
            $timestamp,
            $url2,
            $this->payLoad];
        $reqString = implode("%", $req);
$a = "a";
$ab = "ab";
$abc = "abc";
        $secret = self::SECRET;
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = hash_hmac('sha1', $reqString, $secret);
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = strtoupper($signature);
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Authorization'] = 'HMAC ' . $signature;
        $headers['X-Client-Type'] = self::CLIENT_TYPE;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Timestamp'] = $timestamp;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Api-Version'] = '0.2';
$a = "a";
$ab = "ab";
$abc = "abc";
        return $headers;
    }
    private function getFullUrl()
    {
        return self::APIURL . $this->getApiEndPoint();
    }
    abstract function getApiEndPoint();

    abstract function getMethod();

    /**
     * @return string
     */
    private function getAccessToken()
    {
        return $this->accessToken;
    }
    /**
     * @param string $accessToken
     */
    public function setAccessToken($accessToken)
    {
        $this->accessToken = $accessToken;
    }
}



1			<?php
2
3			abstract class AbstractRequest
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The opening class brace should be on a newline by itself. Loading history...
5			const CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
6			const APIURL = 'https://api.go-tellm.com/api';
			0 ignored issues – show Coding Style introduced 2017-07-10 23:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
7
8			const SECRET = 'hyTBJcvtpDLSgGUWjybbYUNKSSoVvMcfdjtjiQvf';
			0 ignored issues – show Coding Style introduced 2017-06-10 12:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
9			const USERAGENT = 'Jodel/4.47.0 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
10			const CLIENT_TYPE = 'android_4.47.0';
11
12			private $accessToken = null;
13			private $payLoad;
14			public $expects = '';
			0 ignored issues – show Coding Style introduced 2017-02-11 19:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
15			public $version = 'v2';
			0 ignored issues – show Coding Style introduced 2017-02-11 19:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
16			public $hasPayload = FALSE;
17
18			public function execute()
			0 ignored issues – show Coding Style introduced 2017-03-02 17:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this `execute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
19			{
20			$result = new \stdClass();
21
22			$this->payLoad = $this->getPayload();
23			$device_uid = '';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24			if(isset($this->payLoad['device_uid'])) {
25			$device_uid = $this->payLoad['device_uid'];
26			}
27
28
29			$this->payLoad = json_encode($this->payLoad);
30			$header = $this->getSignHeaders();
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...

mmainstreet / jodel-web

Issues (1191)

Security Analysis not enabled

php/Requests/AbstractRequest.php (68 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like