Issues in JodelAccount.php (master) - Issues in master - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1191)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

php/JodelAccount.php (38 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class JodelAccount
namespace YourVendor;

class YourClass { }
{
    public $accessToken;
    public $expirationDate;
    public $refreshToken;
    public $distinctId;
    public $deviceUid;

    //is the Account a Bot or Spider?
    public $isBot;
    
    // array of voted Jodels
    public $votes;

    //Location of the Account
    public $location;

    function __construct($deviceUid = NULL, $isBot = FALSE)

    {
        if($deviceUid == NULL)
        {
            $this->deviceUid = $this->createAccount();
        }
        else
        {
            $this->deviceUid = $deviceUid;
        }

        $this->isBot        = $isBot;
        $this->location     = $this->getLocation();

        if(!$this->isTokenFresh())
        {
            $this->refreshToken();
        }
        $this->accessToken  = $this->getAccessToken();

       /* if($this->isAccountVerified() != 1)

        {
            $this->showCaptcha();
            //$this->verifyCaptcha();
        }*/
    }

/*

    function showCaptcha()
    {
        $accountCreator = new GetCaptcha();
        $accountCreator->setAccessToken($this->accessToken);
        $captcha = $accountCreator->execute();

        echo $captcha['image_url'];
        echo('<br><img width="100%" src="' . $captcha['image_url'] . '">');
        echo "<br>Key: " . $captcha['key'];
        echo "<br>";

        //Form
        
        echo '<form method="get">';
        echo    '<p>Enter Key (copy pasta from top): <input type="text" value="' . $captcha['key'] . '" name="key" /></p>';
        echo    '<p>Find the Coons (example: they are on picture 3, 4 and 5. You enter 2-3-4. Becouse we start counting at 0): <input type="text" name="solution" /></p>';
        echo    '<input type="hidden" name="deviceUid" value="' . $this->deviceUid . '">';
        echo    '<input type="hidden" name="pw" value="">';
        echo    '<p><input type="submit" /></p>';
        echo '</form>';

        die();
        
    }
    */

    function getCaptcha()

    {
        $accountCreator = new GetCaptcha();
        $accountCreator->setAccessToken($this->accessToken);
        $captcha = $accountCreator->execute();

        return array("image_url" => $captcha['image_url'], "key" => $captcha['key']);
    }

    function isAccountVerified()

    {
        $accountCreator = new GetUserConfig();
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();

        //error_log(print_r($data, true));


        return $data['verified'];
    }

    function getGeocodingToken()

    {
        $config = parse_ini_file('config/config.ini.php');
        if(!isset($config['geocodingToken']) ||
            $config['geocodingToken'] == NULL ||
            $config['geocodingToken'] == '' ||
            $config['geocodingToken'] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')
        {
            error_log("Please set a Google Maps Geocoding Token!");
        }
        else
        {
            return $config['geocodingToken'];
        }
    }

    function locationEquals($city)

    {
        $db = new DatabaseConnect();
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $location = new Location();
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $location->setLat($row['lat']);
                $location->setLng($row['lng']);
                $location->setCityName($row['name']);
            }
        }
        else
        {
            error_log("Error no Location found - getLocation");
        }

        if($location->getCityName() == $city)
        {
            return TRUE;
        }  
        else
        {
            return FALSE;
        }
    }

    function setLocation()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        //Is Channel or City
        if(substr($_GET['city'], 0, 1) === '#')
        {
            return htmlspecialchars($_GET['city']) . " " . $this->location->cityName;
        }                
        else
        {
            $url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=' . $this->getGeocodingToken();
            $result = Requests::post($url);
            if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST')
            {
                return "0 results";
            }
            else
            {
                $name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
                $lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
                $lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];

                $location = new Location();
                $location->setLat($lat);
                $location->setLng($lng);
                $location->setCityName($name);
                $accountCreator = new UpdateLocation();
                $accountCreator->setLocation($location);
                $accountCreator->setAccessToken($this->accessToken);
                $data = $accountCreator->execute();

                //safe location to db
                $db = new DatabaseConnect();

                if($data == 'Success')
                {
                    $result = $db->query("UPDATE accounts 
                            SET name='" . $name . "',
                                lat='" . $lat . "',
                                lng='" . $lng . "'
                            WHERE access_token='" . $this->accessToken . "'");

                    if($result === false)
                    {
                            echo "Updating location failed: (" . $db->errno . ") " . $db->error;
                    }
                    else
                    {
                        user_log('User with JodelDeviceId:' . $this->deviceUid .  ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] changed to Location: ' . $name);
                    }
                }

                return $name;
            }
        }
    }

    function getLocation()

    {
        $db = new DatabaseConnect();
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $location = new Location();
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $location->setLat($row['lat']);
                $location->setLng($row['lng']);
                $location->setCityName($row['name']);
            }
        }
        else
        {
            echo "Error: 0 results";
            error_log("Error no Location found - getLocation");
        }

        return $location;
    }

    function verifyCaptcha()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if(isset($_GET['deviceUid']))
        {
            $deviceUid = $_GET['deviceUid'];
            $jodelAccountForVerify = new JodelAccount($deviceUid);

        }
        else if(isset($_POST['deviceUid']))
        {
            $deviceUid = $_POST['deviceUid'];
            $jodelAccountForVerify = new JodelAccount($deviceUid);
        }
        else
        {
            $deviceUid = $this->deviceUid;
            $jodelAccountForVerify = $this;
        }

        $solution = $_GET['solution'];
        $solution = array_map('intval', explode('-', $solution));

        $accountCreator = new PostCaptcha();
        $accountCreator->setAccessToken($jodelAccountForVerify->accessToken);
        $accountCreator->captchaKey = $_GET['key'];
        $accountCreator->captchaSolution = $solution;
        $verified = $accountCreator->execute();

        if(isset($verified->status_code))
        {
            return $verified->status_code;
        }
        return $verified['verified'];
    }

    //ToDo Spider Check
    function votePostId($postId, $vote)

    {
        if(!$this->isBot)
        {
            if(!$this->isAccountVerified())
            {
                error_log('Account is not Verified! jodelAccount.php Line 279');
                return FALSE;
            }
            else
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
            {
                
            }

            if(!$this->hasVoted($postId))
            {
                if($vote == "up")
                {
                    $accountCreator = new Upvote();
                }
                else if($vote == "down")
                {
                    $accountCreator = new Downvote();
                }

                $accountCreator->setAccessToken($this->accessToken);
                $accountCreator->postId = htmlspecialchars($postId);
                $data = $accountCreator->execute();

                user_log('User voted: ' . print_r($data, true));

                if(array_key_exists('post', $data))
                {
                    $this->addVoteWithPostIdAndType($postId, $vote);
                    return TRUE;
                }
                else if(array_key_exists('error', $data))
                {
                    error_log('Could not vote - Error: ' . $data['error']);
                    return FALSE;
                }
                else
                {
                    error_log('Could not vote: ' . print_r($data, true));
                    return FALSE;
                } 
            }
            else
            {
                return FALSE;
            }
        }
        else
        {
            return FALSE;
        }
    }

    //ToDo Spider Check
    function sendJodel($location, $view)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if($this->isAccountVerified() != 1)
        {
            $this->showCaptcha();
            //$this->verifyCaptcha();

        }

        $accountCreator = new SendJodel();

        if(isset($_POST['ancestor']))
        {
            $ancestor = $_POST['ancestor'];
            $accountCreator->ancestor = $ancestor;
        }
        if(isset($_POST['color']))
        {
            $color = $_POST['color'];
            switch ($color) {
                case '8ABDB0':
                    $color = '8ABDB0';
                    break;
                case '9EC41C':
                    $color = '9EC41C';
                    break;
                case '06A3CB':
                    $color = '06A3CB';
                    break;
                case 'FFBA00':
                    $color = 'FFBA00';
                    break;
                case 'DD5F5F':
                    $color = 'DD5F5F';
                    break;
                case 'FF9908':
                    $color = 'FF9908';
                    break;
                default:
                    $color = '8ABDB0';
                    break;
            }
            $accountCreator->color = $color;
        }

        $accountCreatorLocation = new UpdateLocation();

        $accountCreatorLocation->setLocation($location);
        $accountCreatorLocation->setAccessToken($this->accessToken);
        $data = $accountCreatorLocation->execute();
        
		if($data != 'Success')
		{
			error_log('Could not set location befor Post: ' . print_r($data, true));
		}

        $accountCreator->location = $this->location;

        $image = '';
        if(isset($_FILES['image']) && $_FILES['image']['size'] > 0)
        {
            $image = file_get_contents($_FILES['image']['tmp_name']);
        }
        
        $accountCreator->image = $image;
        
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();

        if(isset($data['error']) && $data['error'] == 'length')
        {
            $errorMsg = 'Error: The input was to long';
            return $errorMsg;
        }

        user_log('User posted: ' . print_r($data, true));

        if(isset($_POST['ancestor']))
        {
            header('Location: ' . $view->toUrl());
            exit;
        }
        else
        {
            header('Location: ' . $view->baseUrl);
            exit;
        }
    }

    function isTokenFresh()

    {
        $db = new DatabaseConnect();  
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid . "'");

        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                    $expiration_date = $row["expiration_date"];
            }
        }
        else
        {
            error_log('0 results');
        }

        if($expiration_date <= time())
        {
           return FALSE;
        }
        
        return TRUE;
    }

    function refreshToken()

    {
        $accountCreator = new CreateUser();
        $accountCreator->setAccessToken($this->accessToken);
        $accountCreator->setDeviceUid($this->deviceUid);
        $accountCreator->setLocation($this->location);
        $data = $accountCreator->execute();

        $access_token = (string)$data[0]['access_token'];
        $expiration_date = $data[0]['expiration_date'];
        $device_uid = (string)$data[1];
        
        $db = new DatabaseConnect();  
        $result = $db->query("UPDATE accounts 
                                SET access_token='" . $access_token . "',
                                    expiration_date='" . $expiration_date . "'
                                WHERE device_uid='" . $device_uid . "'");

        if($result === false){
                error_log("Adding account failed: (" . $db->errno . ") " . $db->error);
        }   
    }



    function getAccessToken()

    {
        $db = new DatabaseConnect();
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $accessToken;
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $accessToken = $row['access_token'];
            }
        }
        else
        {
            error_log('Error: 0 results');
        }

        return $accessToken;
    }


    function getKarma()

    {
        $accountCreator = new GetKarma();
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();
        
        return $data['karma'];
    }

    function hasVoted($postId)

    {
        $db = new DatabaseConnect();

        $postId = $db->real_escape_string($postId);

        $result = $db->query("SELECT id FROM votes WHERE (postId = '" . $postId . "' AND device_uid = '" . $this->deviceUid . "')");
        
        if($result === false)
        {
            $error = db_error();
            echo $error;
            error_log("Adding Vote failed: (" . $result->errno . ") " . $result->error);
        }

        if($result->num_rows == 0)
        {
            return FALSE;
        }
        else
        {
            return TRUE;
        }
    }

    function addVoteWithPostIdAndType($postId, $voteType)

    {
        $db = new DatabaseConnect();

        $postId = $db->real_escape_string($postId);
        $voteType = $db->real_escape_string($voteType);
        
        if($this->hasVoted($postId))
        {
            return "Already voted";
        }

        $result = $db->query("INSERT INTO votes (device_uid, postId, type)
                        VALUES ('" . $this->deviceUid . "','" . $postId . "','" . $voteType . "')");
        
        if($result === false){
                $error = db_error();
                echo $error;
                echo "Adding Vote failed: (" . $result->errno . ") " . $result->error;
        }       
    }

    function registerAccount($location) {

        $accountCreator = new CreateUser();
        $accountCreator->setLocation($location);
        $data = $accountCreator->execute();
        
        $access_token = (string)$data[0]['access_token'];
        $refresh_token = (string)$data[0]['refresh_token'];
        $token_type = (string)$data[0]['token_type'];
        $expires_in = $data[0]['expires_in'];
        $expiration_date = $data[0]['expiration_date'];
        $distinct_id = (string)$data[0]['distinct_id'];
        $device_uid = (string)$data[1];

        $name = $location->cityName;
        $lat = $location->lat;
        $lng = $location->lng;
        
        $db = new DatabaseConnect();  
        $result = $db->query("INSERT INTO accounts (access_token, refresh_token, token_type,
                        expires_in, expiration_date, distinct_id, device_uid, name, lat, lng)
                        VALUES ('" . $access_token . "','" . $refresh_token . "','" . $token_type .
                        "','" .  $expires_in . "','" . $expiration_date . "','" . $distinct_id .
                        "','" . $device_uid . "','" . $name . "','" . $lat . "','" . $lng . "') ");

        $success = TRUE;
        if($result === false){
                $error = $db->error();
                echo $error;
                echo "Adding account failed: (" . $result->errno . ") " . $result->error;
                $success = FALSE;
        }   
        
        return $device_uid;
    }

    function createAccount()

    {
        $config = parse_ini_file('config/config.ini.php');
        $location = new Location();
        $location->setLat($config['default_lat']);
        $location->setLng($config['default_lng']);
        $location->setCityName($config['default_location']);

        $deviceUid = $this->registerAccount($location);

        return $deviceUid;
    }
}

1			<?php
2
3			class JodelAccount
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public $accessToken;
6			public $expirationDate;
7			public $refreshToken;
8			public $distinctId;
9			public $deviceUid;
10
11			//is the Account a Bot or Spider?
12			public $isBot;
13
14			// array of voted Jodels
15			public $votes;
16
17			//Location of the Account
18			public $location;
19
20			function __construct($deviceUid = NULL, $isBot = FALSE)
			0 ignored issues – show Best Practice introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21			{
22			if($deviceUid == NULL)
23			{
24			$this->deviceUid = $this->createAccount();
25			}
26			else
27			{
28			$this->deviceUid = $deviceUid;
29			}
30
31			$this->isBot = $isBot;
32			$this->location = $this->getLocation();
33
34			if(!$this->isTokenFresh())
35			{
36			$this->refreshToken();
37			}
38			$this->accessToken = $this->getAccessToken();

mmainstreet / jodel-web

Issues (1191)

Security Analysis not enabled

php/JodelAccount.php (38 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like