jodel-web.php ➔ botDeviceUidIsSet() - Code Metrics - Inspection of "Merge branch 'master' of https://github.com/mmains..." - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 03720d...6a1f3b )

by mains

created 2017-01-28 09:15 UTC

jodel-web.php ➔ botDeviceUidIsSet() B

↳ Parent: Project

Complexity

Conditions	5
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	5
nc	2
nop	1
dl	0
loc	11
rs	8.8571
c	0
b	0
f	0

<?php

error_reporting(-1);
include 'php/DatabaseConnect.php';
include 'php/Requests/AbstractRequest.php';
include 'php/Requests/CreateUser.php';
include 'php/AccountData.php';
include 'php/Location.php';
include 'php/Requests/GetPosts.php';
include 'php/Requests/GetKarma.php';
include 'php/Requests/UpdateLocation.php';
include 'php/Requests/Upvote.php';
include 'php/Requests/Downvote.php';
include 'php/Requests/GetPostDetails.php';
include 'php/Requests/SendJodel.php';

require_once 'php/Requests/libary/Requests.php';
Requests::register_autoloader();

$lastPostId = '';

function isTokenFresh(Location $location)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE id='1'");
	
	$access_token;
function someFunction() {
    $x = 5;
    echo $x;
}

	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);//$accountData->getAccessToken());
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function isTokenFreshByAccessToken(Location $location, $accessToken)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE access_token='" . $accessToken . "'");
	
	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);//$accountData->getAccessToken());
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function isTokenFreshByDeviceUid(Location $location, $deviceUid)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid . "'");

	$access_token;
function someFunction() {
    $x = 5;
    echo $x;
}

	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function getLocationByAccessToken($accessToken)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE access_token='" . $accessToken  . "'");
	
	$location = new Location();
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$location->setLat($row['lat']);
			$location->setLng($row['lng']);
			$location->setCityName($row['name']);
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $location;
}

function getLocationByDeviceUid($deviceUid)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");
	
	$location = new Location();
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$location->setLat($row['lat']);
			$location->setLng($row['lng']);
			$location->setCityName($row['name']);
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $location;
}

function getAccessTokenByDeviceUid($deviceUid)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");
	
	$accessToken;
function someFunction() {
    $x = 5;
    echo $x;
}
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$accessToken = $row['access_token'];
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $accessToken;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}


function getKarma($accessToken)

{
	$accountCreator = new GetKarma();
	$accountCreator->setAccessToken($accessToken);
	$data = $accountCreator->execute();
	
	return $data["karma"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
}

function registerAccount(Location $location) {
	$accountCreator = new CreateUser();
	$accountCreator->setLocation($location);
	$data = $accountCreator->execute();
	
	$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$refresh_token = (string)$data[0]['refresh_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$token_type = (string)$data[0]['token_type'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$expires_in = $data[0]['expires_in'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$expiration_date = $data[0]['expiration_date'];
	$distinct_id = (string)$data[0]['distinct_id'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";

	$name = $location->cityName;
	$lat = $location->lat;
$a = "a";
$ab = "ab";
$abc = "abc";
	$lng = $location->lng;
$a = "a";
$ab = "ab";
$abc = "abc";
	
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("INSERT INTO accounts (access_token, refresh_token, token_type,
					expires_in, expiration_date, distinct_id, device_uid, name, lat, lng)
					VALUES ('" . $access_token . "','" . $refresh_token . "','" . $token_type .
					"','" .  $expires_in . "','" . $expiration_date . "','" . $distinct_id .
					"','" . $device_uid . "','" . $name . "','" . $lat . "','" . $lng . "') ");

	$success = TRUE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	if($result === false){
			$error = db_error();
			echo $error;
			echo "Adding account failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			$success = FALSE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	}	
	
	return $device_uid;
}

function getPosts($lastPostId, $accessToken, $url, $version = 'v2')
{	
	$accountCreator = new GetPosts();
	$accountCreator->setLastPostId($lastPostId);
	$accountCreator->setAccessToken($accessToken);
	$accountCreator->setUrl($url);
	$accountCreator->version = $version;

	$location = new Location();
	$location->setLat(52.520006);
	$location->setLng(13.404954);
	$location->setCityName('Berlin');
	$accountCreator->location = $location;
	$data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
	
	return $data;
}

function createAccount()
{
	$location = new Location();
	$location->setLat(52.520006);
	$location->setLng(13.404954);
	$location->setCityName('Berlin');

	$device_uid = registerAccount($location);

	return $device_uid;
}

function isUserBot()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	preg_match('/bot|spider|google|twitter^$/i', $_SERVER['HTTP_USER_AGENT'], $matches);

    return (isset($matches[0])) ? false : true;
}

function botDeviceUidIsSet($config)
{
	if(!array_key_exists('botDeviceUid', $config) || !isset($config['botDeviceUid']) || $config['botDeviceUid'] == '' || $config['botDeviceUid'] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')

	{
		return FALSE;
	}
	else
	{
		return TRUE;
	}
}

function jodelToHtml($post, $view = 'time', $isDetailedView = FALSE)
{	//ToDO

	//Replace # with link
	//preg_replace('~(\#)([^\s!,. /()"\'?]+)~', '<a href="tag/$2">#$2</a>', $text);


	//Time to time difference
	$now = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
	$d = new DateTime($post['created_at']);
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff = $now->diff($d);

	$timediff_inSeconds = (string)$timediff->format('%s');
	$timediff_inMinutes = (string)$timediff->format('%i');
	$timediff_inHours = (string)$timediff->format('%h');
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff_inDays = (string)$timediff->format('%d');
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff_inMonth = (string)$timediff->format('%m');
$a = "a";
$ab = "ab";
$abc = "abc";

	if($timediff_inMonth!=0)
	{
			$timediff = $timediff_inMonth . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}
	else
	{
		if($timediff_inDays!=0)
		{
			$timediff = $timediff_inDays . "d";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
		else
		{
			if($timediff_inHours!=0)
			{
				$timediff = $timediff_inHours . "h";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else
			{
				if($timediff_inMinutes!=0)
				{
					$timediff = $timediff_inMinutes . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				}
				else
				{
					$timediff = $timediff_inSeconds . "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				}
			}
		}
	}


	?>
	<article id ="postId-<?php echo $post["post_id"]; ?>" class="jodel" style="background-color: #<?php echo $post["color"];?>;">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		<content>
			<?php 
			if(isset($post["image_url"])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				echo '<img src="' . $post["image_url"] . '">';
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else {
				echo str_replace('  ', ' &nbsp;', nl2br(htmlspecialchars($post["message"])));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			?>
		</content>
		<aside>
			<a href="index.php?vote=up&postID=<?php echo $post["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				<i class="fa fa-angle-up fa-3x"></i>
			</a>	
				<br />
			<?php echo $post["vote_count"];?><br />
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			<a href="index.php?vote=down&postID=<?php echo $post["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				<i class="fa fa-angle-down fa-3x"></i>
			</a>
		</aside>

		<footer>
			<table>
				<tr>
					<td class="time">
						<span class="tip" data-tooltip="Time">
							<i class="fa fa-clock-o"></i>
							<?php echo $timediff;?>
							<span class="tiptext"><?php echo $d->format('Y-m-d H:i:s');?></span>
						</span> 
					</td>
					<td class="comments">
						<?php if(!$isDetailedView) {?>
						<span data-tooltip="Comments">
							<a href="index.php?getPostDetails=true&view=<?php echo $view;?>&postID=<?php echo $post["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								<i class="fa fa-commenting-o"></i>
								<?php if(array_key_exists("child_count", $post)) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
											echo $post["child_count"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										} else echo "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								?>
								</a>
						</span>
						<?php } ?>
					</td>
					<td class="distance">
						<?php
							if($isDetailedView)
							{
								if(isset($post["parent_creator"]) && $post["parent_creator"] == 1)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								{
									?>
									<span data-tooltip="Author">
										<i class="fa fa-user-o"></i> OJ |
									</span>
									<?php 
						  		}
						  		else
						  		{
						  			//Is not parent Jodel in detailed View
									if(!array_key_exists('child_count', $post) && array_key_exists('parent_creator', $post))
									{
							  			?>
							  			<span data-tooltip="Author">
											<i class="fa fa-user-o"></i> #<?php echo $post["user_handle"];?> |
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										</span>
										<?php
									}
						  		}
						  	}
					  		?>

						<span class="tip" data-tooltip="Distance">
							<i class="fa fa-map-marker"></i>
							<?php echo $post['distance'];?> km
							<span class="tiptext"><?php echo $post['location']['name'];?></span>
						</span>
					</td>
				</tr>
			</table>
		</footer>
	</article>
<?php
}

Push — master ( 03720d...6a1f3b )

jodel-web.php ➔ botDeviceUidIsSet() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 21 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		error_reporting(-1);
3		include 'php/DatabaseConnect.php';
4		include 'php/Requests/AbstractRequest.php';
5		include 'php/Requests/CreateUser.php';
6		include 'php/AccountData.php';
7		include 'php/Location.php';
8		include 'php/Requests/GetPosts.php';
9		include 'php/Requests/GetKarma.php';
10		include 'php/Requests/UpdateLocation.php';
11		include 'php/Requests/Upvote.php';
12		include 'php/Requests/Downvote.php';
13		include 'php/Requests/GetPostDetails.php';
14		include 'php/Requests/SendJodel.php';
15
16		require_once 'php/Requests/libary/Requests.php';
17		Requests::register_autoloader();
18
19		$lastPostId = '';
20
21	View Code Duplication	function isTokenFresh(Location $location)
		0 ignored issues – show Duplication introduced 2016-12-07 20:55 UTC by Report Bug Copy Issue Report This function seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Documentation introduced 2016-12-09 16:08 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
22		{
23		$db = new DatabaseConnect();
		0 ignored issues – show Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history... Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24		$result = $db->query("SELECT * FROM accounts WHERE id='1'");
25
26		$access_token;
		0 ignored issues – show Bug introduced 2016-11-20 16:27 UTC by Report Bug Copy Issue Report The variable `$access_token` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
27
28		if ($result->num_rows > 0)
29		{
30		// output data of each row
31		while($row = $result->fetch_assoc()) {
32		//$access_token = $row["access_token"];
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-20 16:27 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33		$expiration_date = $row["expiration_date"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The string literal `expiration_date` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
34		$deviceUid = $row["device_uid"];

mmainstreet / jodel-web

Push — master ( 03720d...6a1f3b )

jodel-web.php ➔ botDeviceUidIsSet() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like