Issues in index.php - Fixed Issues - Inspection of "Add non-www to www redirection" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc3cec...6a6184 )

by mains

created 2016-12-06 13:22 UTC

index.php (3 issues)

Labels

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
error_reporting(-1);
include 'php/jodel-web.php';

	$location = new Location();
	$location->setLat('0.1');
	$location->setLng('0.1');
	$location->setCityName('Munich');

	isTokenFresh($location);

	$result = $db->query("SELECT * FROM accounts WHERE id='1'");
	
	$accessToken;
	$newPositionStatus;
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$accessToken = $row["access_token"];
			$newPositionStatus = $row['name'];
		}
	}
	else
	{
		echo "Error: 0 results";
	}
	
	
	//createAccount();


	//Set View
	if(isset($_GET['view']))
	{
		switch ($_GET['view']) {
			case 'comment':
				$view = 'comment';
				break;
			
			case 'upVote':
				$view = 'upVote';
				break;

			default:
				$view = 'time';
				break;
		}
	}
	else
	{
		$view = 'time';
	}
	
	//Set Location
	if(isset($_GET['city'])) {
		$url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w';
		$result = Requests::post($url);
		if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST')
		{
			$newPositionStatus = "0 results";
		}
		else
		{
			$name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
			$lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
			$lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];

			$location = new Location();
			$location->setLat($lat);
			$location->setLng($lng);
			$location->setCityName($name);
			$accountCreator = new UpdateLocation();
			$accountCreator->setLocation($location);
			$accountCreator->setAccessToken($accessToken);
			$data = $accountCreator->execute();

			//safe location to db
			if($data == "Success")
			{
				$result = $db->query("UPDATE accounts 
						SET name='" . $name . "',
							lat='" . $lat . "',
							lng='" . $lng . "'
						WHERE id='1'");

				if($result === false)
				{
						echo "Updating location failed: (" . $db->errno . ") " . $db->error;
				}
				else
				{
					$newPositionStatus = $name;
				}
			}
		}
	}
	
	//Vote
	if(isset($_GET['vote']) && isset($_GET['postID'])) {
		if($_GET['vote'] == "up") {
			$accountCreator = new Upvote();
		}
		else if($_GET['vote'] == "down") {
			$accountCreator = new Downvote();
		}
		$accountCreator->setAccessToken($accessToken);
		$data = $accountCreator->execute();

		header("Location: index.php#postId-" . htmlspecialchars($_GET['postID']));
		die();
	}
	
	
	//SendJodel
	if(isset($_POST['message'])) {
		$accountCreator = new SendJodel();

		if(isset($_POST['ancestor']))
		{
			$ancestor = $_POST['ancestor'];
			$accountCreator->ancestor = $ancestor;
		}
		if(isset($_POST['color']))
		{
			$color = $_POST['color'];
			switch ($color) {
				case '8ABDB0':
					$color = '8ABDB0';
					break;
				case '9EC41C':
					$color = '9EC41C';
					break;
				case '06A3CB':
					$color = '06A3CB';
					break;
				case 'FFBA00':
					$color = 'FFBA00';
					break;
				case 'DD5F5F':
					$color = 'DD5F5F';
					break;
				case 'FF9908':
					$color = 'FF9908';
					break;
				
				default:
					$color = '8ABDB0';
					break;
			}
			$accountCreator->color = $color;
			echo "Setting color:" . $color;
		}
		
		$location = new Location();
		$location->setLat('0.1');
		$location->setLng('0.1');
		$location->setCityName('Munich');
		
		$accountCreator->location = $location;
		
		$accountCreator->setAccessToken($accessToken);
		$data = $accountCreator->execute();
	}
?>
<!DOCTYPE html>
<html lang="de">
	<head>
		<title>JodelBlue WebClient - </title>
		
		<meta charset="utf8" />
		<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
		<meta http-equiv="x-ua-compatible" content="ie=edge">
		
		<meta name="description" content=""/>
		<meta name="keywords" content=""/>
		
		<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/css/bootstrap.min.css" integrity="sha384-AysaV+vQoT3kOAXZkl02PThvDr8HYKPZhNT5h/CXfBThSRXQ6jW5DO2ekP5ViFdi" crossorigin="anonymous">
		<link rel="stylesheet" href="css/font-awesome.min.css">
		<link rel="stylesheet" href="style.css" type="text/css">
		
		<link rel="shortcut icon" href="img/favicon/favicon.ico" type="image/x-icon">
		<link rel="icon" href="img/favicon/favicon.ico" type="image/x-icon">	
	</head>
	
	<body>
		<header>
			<nav class="navbar navbar-full navbar-dark navbar-fixed-top">
				<div class="container">					
						<?php
							if(isset($_GET['postID']) && isset($_GET['getPostDetails']))
							{
								echo '<a id="comment-back" href="index.php?view=' . $view . '#postId-' . htmlspecialchars($_GET['postID']) . '">';
								echo '<i class="fa fa-angle-left fa-3x"></i>';
								echo '</a>';
								echo '<h1>';
								echo '<a href="index.php?getPostDetails=' . htmlspecialchars($_GET['getPostDetails']) . '&postID=' . htmlspecialchars($_GET['postID']) . '" class="spinnable">';
							}
							else
							{
								echo '<h1>';	
								echo '<a href="index.php" class="spinnable">';
							}
						?>
						JodelBlue <i class="fa fa-refresh fa-1x"></i></a>
					</h1>					
				</div>
			</nav>
		</header>
		
		<div class="mainContent container">		
			<div class="content row">
				<article class="topContent col-sm-8">

					<content id="posts">
						<?php
							$posts;

							//Get Post Details
							if(isset($_GET['postID']) && isset($_GET['getPostDetails']))
							{
								$userHandleBuffer = [];

								$accountCreator = new GetPostDetails();
								$accountCreator->setAccessToken($accessToken);
								$data = $accountCreator->execute();
								
								$posts[0] = $data;
								if(isset($data['children'])) {
									foreach($data['children'] as $key => $child)
									{
										
										if(!$child["parent_creator"] == 1)
										{
											$numberForUser = array_search($child['user_handle'], $userHandleBuffer);
											if($numberForUser === FALSE)
											{
												array_push($userHandleBuffer, $child['user_handle']);
												$data['children'][$key]['user_handle'] = count($userHandleBuffer);
											}
											else
											{
												$data['children'][$key]['user_handle'] = $numberForUser + 1;
											}
										}

										array_push($posts, $data['children'][$key]);
									}
									$loops = $data['child_count'] + 1;
								}
								else $loops = 1;
								$isDetailedView = TRUE;
							}
							//Get Posts
							else
							{
								if($view=='comment')

								{
									$url = "/v2/posts/location/discussed/";
								}
								else
								{
									if($view=='upVote')
									{
										$url = "/v2/posts/location/popular/";
									}
									else
									{
										$url = "/v2/posts/location/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
									}
								}

								$posts = getPosts($lastPostId, $accessToken, $url)['posts'];
$a = "a";
$ab = "ab";
$abc = "abc";
								$loops = 29;
								$isDetailedView = FALSE;
							}
							

							for($i = 0; $i<$loops; $i++)
							{
							
							if(isset($posts[$i]))
							{
								$lastPostId = $posts[$i]['post_id'];

								jodelToHtml($posts[$i], $view, $isDetailedView);
							}
						} ?>

					</content>
					
					<?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?>
						<p id="loading">
							Loading…
						</p>
					<?php } ?>
				</article>
			
				<aside class="topSidebar col-sm-4 sidebar-outer">
					<div class="fixed">
						<article>
							<div>
								<h2>Position</h2>
								<form method="get">
									<input type="text" id="city" name="city" placeholder="<?php if(isset($newPositionStatus)) echo $newPositionStatus; ?>" required>

									<input type="submit" value="Set Location" /> 
								</form>
							</div>
						</article>

						<article>
							<div>
								<h2>Karma</h2>
								<?php echo getKarma($accessToken); ?>
							</div>
						</article>

						<article>
							<div>
								<?php if(isset($_GET['postID']) && isset($_GET['getPostDetails'])) { ?>
								<h2>Comment on Jodel</h2>
								<form method="POST">				
										<input type="hidden" name="ancestor" value="<?php echo htmlspecialchars($_GET['postID']);?>" />
										<textarea id="message" name="message" placeholder="Send a comment on a Jodel to all students within 10km" required></textarea> 
									<br />
									<input type="submit" value="SEND" /> 
								</form>
									<?php } else { ?>
								<h2>New Jodel</h2>
								<form method="POST">
									<textarea id="message" name="message" placeholder="Send a Jodel to all students within 10km" required></textarea> 
									<br />
									<select id="postColorPicker" name="color">
										<option value="06A3CB">Blue</option>
										<option value="8ABDB0">Teal</option>
										<option value="9EC41C">Green</option>
										<option value="FFBA00">Yellow</option>
										<option value="DD5F5F">Red</option>
										<option value="FF9908">Orange</option>
									</select> 
									<br />
									<input type="submit" value="SEND" /> 
								</form>
								<?php } ?>
							</div>
						</article>
							
						<article>
							<div>
								<h2>Login</h2>
							</div>
						</article>
					</div>
				</aside>
			</div>
			<div id="sortJodelBy" class="row">
				<div class="col-sm-12">
					<div class="row">
						<div class="col-sm-3">
							<a href="index.php" <?php if($view=='time') echo 'class="active"';?>><i class="fa fa-clock-o fa-3x"></i></a>
						</div>
						<div class="col-sm-3">
							<a href="index.php?view=comment" <?php if($view=='comment') echo 'class="active"';?>><i class="fa fa-commenting-o fa-3x"></i></a>
						</div>
						<div class="col-sm-3">
							<a href="index.php?view=upVote" <?php if($view=='upVote') echo 'class="active"';?>><i class="fa fa-angle-up fa-3x"></i></a>
						</div>
						<div class="col-sm-3">
							<nav>
								<a href="./impressum.html">Impressum</a> | <a href="./datenschutz.html">Datenschutz</a>
							</nav>
						</div>
					</div>
				</div>	
			</div>
		</div>
		
		
		<!-- jQuery, Tether, Bootstrap JS and own-->
		<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js" integrity="sha384-3ceskX3iaEnIogmQchP8opvBy3Mi7Ce34nWjpBIwVTHfGYWQS9jwHDVRnpKKHJg7" crossorigin="anonymous"></script>
    	<script src="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/js/tether.min.js" integrity="sha384-XTs3FgkjiBgo8qjEjBk0tGmf3wPrWtA6coPfQDfFEY8AnYJwjalXCiosYRBIBZX8" crossorigin="anonymous"></script>
    	<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/js/bootstrap.min.js" integrity="sha384-BLiI7JTZm+JWlgKa0M0kGRpJbF2J8q+qreVrKBC47e3K6BW78kGLrCkeRX6I9RoK" crossorigin="anonymous"></script>
    	<script src="js/jQueryEmoji.js"></script>

		<script>

			$(document).ready(function() {
				//Transform UTF-8 Emoji to img
				$('.jodel > content').Emoji();

				$('a').on('click', function(){
				    $('a').removeClass('selected');
				    $(this).addClass('selected');
				});

				function scrollToAnchor(aid){
				    var aTag = $("article[id='"+ aid +"']");
				    $('html,body').animate({scrollTop: aTag.offset().top-90},'slow');
				}

				<?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?>

				



				var win = $(window);
				var lastPostId = "<?php echo $lastPostId; ?>";
				var view = "<?php echo $view; ?>"
				var old_lastPostId = "";
				var morePostsAvailable = true;

				if(window.location.hash)
				{
					var hash = window.location.hash.slice(1);

					if(!$("article[id='"+ hash +"']").length)
					{
						for (var i = 5; i >= 0; i--)
						{
							if(!$("article[id='"+ hash +"']").length)
							{
								$.ajax({
									url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view,
									dataType: 'html',
									async: false,
									success: function(html) {
										var div = document.createElement('div');
										div.innerHTML = html;
										var elements = div.childNodes;
										old_lastPostId = lastPostId;
										lastPostId = elements[3].textContent;
										lastPostId = lastPostId.replace(/\s+/g, '');
										//alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId);
										if(lastPostId == old_lastPostId) {
											
											//morePostsAvailable = false;
										}
										else {
											//alert(elements[3].textContent);
											$('#posts').append(elements[1].innerHTML);
											$('#posts').hide().show(0);
										}
										$('#loading').hide();
									}
								});

								$('.jodel > content').Emoji();
							}
							
						}
						scrollToAnchor(hash);

					}						
				}

				// Each time the user scrolls
				win.scroll(function() {


					// End of the document reached?
					if (($(document).height() - win.height() == win.scrollTop()) && morePostsAvailable) {
						$('#loading').show();

						
						
						$.ajax({
							url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view,
							dataType: 'html',
							async: false,
							success: function(html) {
								var div = document.createElement('div');
								div.innerHTML = html;
								var elements = div.childNodes;
								old_lastPostId = lastPostId;
								lastPostId = elements[3].textContent;
								lastPostId = lastPostId.replace(/\s+/g, '');
								//alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId);
								if(lastPostId == old_lastPostId)
								{
									
									//morePostsAvailable = false;
								}
								else
								{
									//alert(elements[3].textContent);
									$('#posts').append(elements[1].innerHTML);
								}
								$('#loading').hide();
							}
						});

						$('.jodel > content').Emoji();
					}
				});
			<?php } ?>
			});	

		</script>

	</body>
</html>



1		<?php
2		error_reporting(-1);
3		include 'php/jodel-web.php';
4
5		$location = new Location();
6		$location->setLat('0.1');
7		$location->setLng('0.1');
8		$location->setCityName('Munich');
9
10		isTokenFresh($location);
11
12		$result = $db->query("SELECT * FROM accounts WHERE id='1'");
13
14		$accessToken;
15		$newPositionStatus;
16
17		if ($result->num_rows > 0)
18		{
19		// output data of each row
20		while($row = $result->fetch_assoc())
21		{
22		$accessToken = $row["access_token"];
23		$newPositionStatus = $row['name'];
24		}
25		}
26		else
27		{
28		echo "Error: 0 results";
29		}
30
31
32		//createAccount();
33
34
35		//Set View
36	View Code Duplication	if(isset($_GET['view']))
37		{
38		switch ($_GET['view']) {
39		case 'comment':
40		$view = 'comment';
41		break;
42
43		case 'upVote':
44		$view = 'upVote';
45		break;
46
47		default:
48		$view = 'time';
49		break;
50		}
51		}
52		else
53		{
54		$view = 'time';
55		}
56
57		//Set Location
58		if(isset($_GET['city'])) {
59		$url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w';
60		$result = Requests::post($url);
61		if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' \|\| json_decode($result->body, true)['status'] == 'INVALID_REQUEST')
62		{
63		$newPositionStatus = "0 results";
64		}
65		else
66		{
67		$name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
68		$lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
69		$lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];
70
71		$location = new Location();
72		$location->setLat($lat);
73		$location->setLng($lng);
74		$location->setCityName($name);
75		$accountCreator = new UpdateLocation();
76		$accountCreator->setLocation($location);
77		$accountCreator->setAccessToken($accessToken);
78		$data = $accountCreator->execute();
79
80		//safe location to db
81		if($data == "Success")
82		{
83		$result = $db->query("UPDATE accounts
84		SET name='" . $name . "',
85		lat='" . $lat . "',
86		lng='" . $lng . "'
87		WHERE id='1'");
88
89		if($result === false)
90		{
91		echo "Updating location failed: (" . $db->errno . ") " . $db->error;
92		}
93		else
94		{
95		$newPositionStatus = $name;
96		}
97		}
98		}
99		}
100
101		//Vote
102		if(isset($_GET['vote']) && isset($_GET['postID'])) {
103		if($_GET['vote'] == "up") {
104		$accountCreator = new Upvote();
105		}
106		else if($_GET['vote'] == "down") {
107		$accountCreator = new Downvote();
108		}
109		$accountCreator->setAccessToken($accessToken);
110		$data = $accountCreator->execute();
111
112		header("Location: index.php#postId-" . htmlspecialchars($_GET['postID']));
113		die();
114		}
115
116
117		//SendJodel
118		if(isset($_POST['message'])) {
119		$accountCreator = new SendJodel();
120
121		if(isset($_POST['ancestor']))
122		{
123		$ancestor = $_POST['ancestor'];
124		$accountCreator->ancestor = $ancestor;
125		}
126		if(isset($_POST['color']))
127		{
128		$color = $_POST['color'];
129		switch ($color) {
130		case '8ABDB0':
131		$color = '8ABDB0';
132		break;
133		case '9EC41C':
134		$color = '9EC41C';
135		break;
136		case '06A3CB':
137		$color = '06A3CB';
138		break;
139		case 'FFBA00':
140		$color = 'FFBA00';
141		break;
142		case 'DD5F5F':
143		$color = 'DD5F5F';
144		break;
145		case 'FF9908':
146		$color = 'FF9908';
147		break;
148
149		default:
150		$color = '8ABDB0';
151		break;
152		}
153		$accountCreator->color = $color;
154		echo "Setting color:" . $color;
155		}
156
157		$location = new Location();
158		$location->setLat('0.1');
159		$location->setLng('0.1');
160		$location->setCityName('Munich');
161
162		$accountCreator->location = $location;
163
164		$accountCreator->setAccessToken($accessToken);
165		$data = $accountCreator->execute();
166		}
167		?>
168		<!DOCTYPE html>
169		<html lang="de">
170		<head>
171		<title>JodelBlue WebClient - </title>
172
173		<meta charset="utf8" />
174		<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
175		<meta http-equiv="x-ua-compatible" content="ie=edge">
176
177		<meta name="description" content=""/>
178		<meta name="keywords" content=""/>
179
180		<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/css/bootstrap.min.css" integrity="sha384-AysaV+vQoT3kOAXZkl02PThvDr8HYKPZhNT5h/CXfBThSRXQ6jW5DO2ekP5ViFdi" crossorigin="anonymous">
181		<link rel="stylesheet" href="css/font-awesome.min.css">
182		<link rel="stylesheet" href="style.css" type="text/css">
183
184		<link rel="shortcut icon" href="img/favicon/favicon.ico" type="image/x-icon">
185		<link rel="icon" href="img/favicon/favicon.ico" type="image/x-icon">
186		</head>
187
188		<body>
189		<header>
190		<nav class="navbar navbar-full navbar-dark navbar-fixed-top">
191		<div class="container">
192		<?php
193		if(isset($_GET['postID']) && isset($_GET['getPostDetails']))
194		{
195		echo '<a id="comment-back" href="index.php?view=' . $view . '#postId-' . htmlspecialchars($_GET['postID']) . '">';
196		echo '<i class="fa fa-angle-left fa-3x"></i>';
197		echo '</a>';
198		echo '<h1>';
199		echo '<a href="index.php?getPostDetails=' . htmlspecialchars($_GET['getPostDetails']) . '&postID=' . htmlspecialchars($_GET['postID']) . '" class="spinnable">';
200		}
201		else
202		{
203		echo '<h1>';
204		echo '<a href="index.php" class="spinnable">';
205		}
206		?>
207		JodelBlue <i class="fa fa-refresh fa-1x"></i></a>
208		</h1>
209		</div>
210		</nav>
211		</header>
212
213		<div class="mainContent container">
214		<div class="content row">
215		<article class="topContent col-sm-8">
216
217		<content id="posts">
218		<?php
219		$posts;
220
221		//Get Post Details
222		if(isset($_GET['postID']) && isset($_GET['getPostDetails']))
223		{
224		$userHandleBuffer = [];
225
226		$accountCreator = new GetPostDetails();
227		$accountCreator->setAccessToken($accessToken);
228		$data = $accountCreator->execute();
229
230		$posts[0] = $data;
231		if(isset($data['children'])) {
232		foreach($data['children'] as $key => $child)
233		{
234
235		if(!$child["parent_creator"] == 1)
236		{
237		$numberForUser = array_search($child['user_handle'], $userHandleBuffer);
238		if($numberForUser === FALSE)
239		{
240		array_push($userHandleBuffer, $child['user_handle']);
241		$data['children'][$key]['user_handle'] = count($userHandleBuffer);
242		}
243		else
244		{
245		$data['children'][$key]['user_handle'] = $numberForUser + 1;
246		}
247		}
248
249		array_push($posts, $data['children'][$key]);
250		}
251		$loops = $data['child_count'] + 1;
252		}
253		else $loops = 1;
254		$isDetailedView = TRUE;
255		}
256		//Get Posts
257		else
258		{
259	View Code Duplication	if($view=='comment')
		0 ignored issues – show Duplication introduced 2016-11-26 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
260		{
261		$url = "/v2/posts/location/discussed/";
262		}
263		else
264		{
265		if($view=='upVote')
266		{
267		$url = "/v2/posts/location/popular/";
268		}
269		else
270		{
271		$url = "/v2/posts/location/";
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-26 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `/v2/posts/location/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
272		}
273		}
274
275		$posts = getPosts($lastPostId, $accessToken, $url)['posts'];
		0 ignored issues – show Coding Style introduced 2016-11-30 19:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
276		$loops = 29;
277		$isDetailedView = FALSE;
278		}
279
280
281	View Code Duplication	for($i = 0; $i<$loops; $i++)
282		{
283
284		if(isset($posts[$i]))
285		{
286		$lastPostId = $posts[$i]['post_id'];
287
288		jodelToHtml($posts[$i], $view, $isDetailedView);
289		}
290		} ?>
291
292		</content>
293
294		<?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?>
295		<p id="loading">
296		Loading…
297		</p>
298		<?php } ?>
299		</article>
300
301		<aside class="topSidebar col-sm-4 sidebar-outer">
302		<div class="fixed">
303		<article>
304		<div>
305		<h2>Position</h2>
306		<form method="get">
307		<input type="text" id="city" name="city" placeholder="<?php if(isset($newPositionStatus)) echo $newPositionStatus; ?>" required>
308
309		<input type="submit" value="Set Location" />
310		</form>
311		</div>
312		</article>
313
314		<article>
315		<div>
316		<h2>Karma</h2>
317		<?php echo getKarma($accessToken); ?>
318		</div>
319		</article>
320
321		<article>
322		<div>
323		<?php if(isset($_GET['postID']) && isset($_GET['getPostDetails'])) { ?>
324		<h2>Comment on Jodel</h2>
325		<form method="POST">
326		<input type="hidden" name="ancestor" value="<?php echo htmlspecialchars($_GET['postID']);?>" />
327		<textarea id="message" name="message" placeholder="Send a comment on a Jodel to all students within 10km" required></textarea>
328		<br />
329		<input type="submit" value="SEND" />
330		</form>
331		<?php } else { ?>
332		<h2>New Jodel</h2>
333		<form method="POST">
334		<textarea id="message" name="message" placeholder="Send a Jodel to all students within 10km" required></textarea>
335		<br />
336		<select id="postColorPicker" name="color">
337		<option value="06A3CB">Blue</option>
338		<option value="8ABDB0">Teal</option>
339		<option value="9EC41C">Green</option>
340		<option value="FFBA00">Yellow</option>
341		<option value="DD5F5F">Red</option>
342		<option value="FF9908">Orange</option>
343		</select>
344		<br />
345		<input type="submit" value="SEND" />
346		</form>
347		<?php } ?>
348		</div>
349		</article>
350
351		<article>
352		<div>
353		<h2>Login</h2>
354		</div>
355		</article>
356		</div>
357		</aside>
358		</div>
359		<div id="sortJodelBy" class="row">
360		<div class="col-sm-12">
361		<div class="row">
362		<div class="col-sm-3">
363		<a href="index.php" <?php if($view=='time') echo 'class="active"';?>><i class="fa fa-clock-o fa-3x"></i></a>
364		</div>
365		<div class="col-sm-3">
366		<a href="index.php?view=comment" <?php if($view=='comment') echo 'class="active"';?>><i class="fa fa-commenting-o fa-3x"></i></a>
367		</div>
368		<div class="col-sm-3">
369		<a href="index.php?view=upVote" <?php if($view=='upVote') echo 'class="active"';?>><i class="fa fa-angle-up fa-3x"></i></a>
370		</div>
371		<div class="col-sm-3">
372		<nav>
373		<a href="./impressum.html">Impressum</a> \| <a href="./datenschutz.html">Datenschutz</a>
374		</nav>
375		</div>
376		</div>
377		</div>
378		</div>
379		</div>
380
381
382		<!-- jQuery, Tether, Bootstrap JS and own-->
383		<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js" integrity="sha384-3ceskX3iaEnIogmQchP8opvBy3Mi7Ce34nWjpBIwVTHfGYWQS9jwHDVRnpKKHJg7" crossorigin="anonymous"></script>
384		<script src="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/js/tether.min.js" integrity="sha384-XTs3FgkjiBgo8qjEjBk0tGmf3wPrWtA6coPfQDfFEY8AnYJwjalXCiosYRBIBZX8" crossorigin="anonymous"></script>
385		<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/js/bootstrap.min.js" integrity="sha384-BLiI7JTZm+JWlgKa0M0kGRpJbF2J8q+qreVrKBC47e3K6BW78kGLrCkeRX6I9RoK" crossorigin="anonymous"></script>
386		<script src="js/jQueryEmoji.js"></script>
387
388		<script>
389
390		$(document).ready(function() {
391		//Transform UTF-8 Emoji to img
392		$('.jodel > content').Emoji();
393
394		$('a').on('click', function(){
395		$('a').removeClass('selected');
396		$(this).addClass('selected');
397		});
398
399		function scrollToAnchor(aid){
400		var aTag = $("article[id='"+ aid +"']");
401		$('html,body').animate({scrollTop: aTag.offset().top-90},'slow');
402		}
403
404		<?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?>
405
406
407
408
409
410		var win = $(window);
411		var lastPostId = "<?php echo $lastPostId; ?>";
412		var view = "<?php echo $view; ?>"
413		var old_lastPostId = "";
414		var morePostsAvailable = true;
415
416		if(window.location.hash)
417		{
418		var hash = window.location.hash.slice(1);
419
420		if(!$("article[id='"+ hash +"']").length)
421		{
422		for (var i = 5; i >= 0; i--)
423		{
424		if(!$("article[id='"+ hash +"']").length)
425		{
426		$.ajax({
427		url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view,
428		dataType: 'html',
429		async: false,
430		success: function(html) {
431		var div = document.createElement('div');
432		div.innerHTML = html;
433		var elements = div.childNodes;
434		old_lastPostId = lastPostId;
435		lastPostId = elements[3].textContent;
436		lastPostId = lastPostId.replace(/\s+/g, '');
437		//alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId);
438		if(lastPostId == old_lastPostId) {
439
440		//morePostsAvailable = false;
441		}
442		else {
443		//alert(elements[3].textContent);
444		$('#posts').append(elements[1].innerHTML);
445		$('#posts').hide().show(0);
446		}
447		$('#loading').hide();
448		}
449		});
450
451		$('.jodel > content').Emoji();
452		}
453
454		}
455		scrollToAnchor(hash);
456
457		}
458		}
459
460		// Each time the user scrolls
461		win.scroll(function() {
462
463
464		// End of the document reached?
465		if (($(document).height() - win.height() == win.scrollTop()) && morePostsAvailable) {
466		$('#loading').show();
467
468
469
470		$.ajax({
471		url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view,
472		dataType: 'html',
473		async: false,
474		success: function(html) {
475		var div = document.createElement('div');
476		div.innerHTML = html;
477		var elements = div.childNodes;
478		old_lastPostId = lastPostId;
479		lastPostId = elements[3].textContent;
480		lastPostId = lastPostId.replace(/\s+/g, '');
481		//alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId);
482		if(lastPostId == old_lastPostId)
483		{
484
485		//morePostsAvailable = false;
486		}
487		else
488		{
489		//alert(elements[3].textContent);
490		$('#posts').append(elements[1].innerHTML);
491		}
492		$('#loading').hide();
493		}
494		});
495
496		$('.jodel > content').Emoji();
497		}
498		});
499		<?php } ?>
500		});
501
502		</script>
503
504		</body>
505		</html>
506
507

mmainstreet / jodel-web

Push — master ( dc3cec...6a6184 )

index.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like