AbstractRequest::execute() - Code Metrics - Inspection of "Add non-www to www redirection" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dc3cec...6a6184 )

by mains

created 2016-12-06 13:22 UTC

AbstractRequest::execute() D

↳ Parent: AbstractRequest

Complexity

Conditions	13
Paths	200

Size

Total Lines	76
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	13
eloc	43
nc	200
nop	0
dl	0
loc	76
rs	4.894
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

abstract class AbstractRequest
namespace YourVendor;

class YourClass { }
{	

    CONST CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
$a = "a";
$ab = "ab";
$abc = "abc";
    CONST APIURL = 'https://api.go-tellm.com/api';
$a = "a";
$ab = "ab";
$abc = "abc";
    const SECRET = "dIHNtHWOxFmoFouufSflpTKYjPmCIhWUCQHgbNzR";
$a = "a";
$ab = "ab";
$abc = "abc";
    const USERAGENT = "Jodel/4.29.1 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )";
$a = "a";
$ab = "ab";
$abc = "abc";
    const CLIENT_TYPE = 'android_4.29.1';
    
    private $accessToken = null;
    private $payLoad;
    public $expects = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    public $version = 'v2';

    public function execute()
    {
		$result = new \stdClass();
		        
		$this->payLoad = $this->getPayload();
		$device_uid = "";
$a = "a";
$ab = "ab";
$abc = "abc";
		if(isset($this->payLoad["device_uid"])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			$device_uid = $this->payLoad["device_uid"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
				
				
        $this->payLoad = json_encode($this->payLoad);
        $header = $this->getSignHeaders();
$a = "a";
$ab = "ab";
$abc = "abc";
        $url = $this->getFullUrl();
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($this->getAccessToken()) {
            $header['Authorization'] = "Bearer " . $this->getAccessToken();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        //Comment out to debug the Request:
        /*

        var_dump($url);
        var_dump($header);
        var_dump($this->payLoad);
        */
        

        switch ($this->getMethod()) {
            case 'POST':
                $result = Requests::post($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
            case 'GET':
                if($this->version == 'v3')
                {
                    $result = Requests::get($url, $header);
                }
                else
                {
                    $result = Requests::get($url, $header);
                }
                break;
            case 'PUT':
                $result = Requests::put($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
        }
        switch ($result->status_code) {
            case 200:
                $result = json_decode($result->body, true);
                break;
            case 204:
                $result = "Success";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                break;
            case 401:
				throw new \Exception('Unauthorized');
                break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 404:
                //echo "Es wurde bereits gevoted";
			case 477:
                //echo "Es wurde bereits gevoted";
                //throw  new \Exception('Signing failed!');

                break;
            default:
                throw  new \Exception('Unknown Error: '.$result->status_code);
        }

        if($device_uid != "")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        {
			$result[0] = $result;
			$result[1] = $device_uid;
		}

        /*

        var_dump($result);
        */

        return $result;
    }
    abstract function getPayload();

    /**
     * Gets Sign headers
     * @return array headers

     */
    private function getSignHeaders()
    {
			if($this->getAccessToken() == null) {
				$payload_accessToken = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else {
				$payload_accessToken = $this->getAccessToken();
			}
			
			
        $headers = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            "Connection" => "keep-alive",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Accept-Encoding" => "gzip",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Content-Type" => "application/json; charset=UTF-8",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "User-Agent" => self::USERAGENT
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
        $timestamp = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = $timestamp->format(DateTime::ATOM);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = substr($timestamp, 0, -6);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp .= "Z";
$a = "a";
$ab = "ab";
$abc = "abc";
        $urlParts = parse_url($this->getFullUrl());
$a = "a";
$ab = "ab";
$abc = "abc";
        $url2 = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        $req = [$this->getMethod(),
$a = "a";
$ab = "ab";
$abc = "abc";
            $urlParts['host'],
            "443",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $urlParts['path'],
            $payload_accessToken,
            $timestamp,
            $url2,
            $this->payLoad];
        $reqString = implode("%", $req);
$a = "a";
$ab = "ab";
$abc = "abc";
        $secret = self::SECRET;
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = hash_hmac('sha1', $reqString, $secret);
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = strtoupper($signature);
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Authorization'] = 'HMAC ' . $signature;
        $headers['X-Client-Type'] = self::CLIENT_TYPE;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Timestamp'] = $timestamp;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Api-Version'] = '0.2';
$a = "a";
$ab = "ab";
$abc = "abc";
        return $headers;
    }
    private function getFullUrl()
    {
        return self::APIURL . $this->getApiEndPoint();
    }
    abstract function getApiEndPoint();

    abstract function getMethod();

    /**
     * @return string
     */
    private function getAccessToken()
    {
        return $this->accessToken;
    }
    /**
     * @param string $accessToken
     */
    public function setAccessToken($accessToken)
    {
        $this->accessToken = $accessToken;
    }
}



1			<?php
2
3			abstract class AbstractRequest
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
5			CONST CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
6			CONST APIURL = 'https://api.go-tellm.com/api';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
7			const SECRET = "dIHNtHWOxFmoFouufSflpTKYjPmCIhWUCQHgbNzR";
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2016-11-30 15:52 UTC by Report Bug Copy Issue Report The string literal `dIHNtHWOxFmoFouufSflpTKYjPmCIhWUCQHgbNzR` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
8			const USERAGENT = "Jodel/4.29.1 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )";
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2016-12-06 13:25 UTC by Report Bug Copy Issue Report The string literal `Jodel/4.29.1 Dalvik/2.1....ux; U; Android 5.1.1; )` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
9			const CLIENT_TYPE = 'android_4.29.1';
10
11			private $accessToken = null;
12			private $payLoad;
13			public $expects = "";
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-29 18:32 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
14			public $version = 'v2';
15
16			public function execute()
17			{
18			$result = new \stdClass();
19
20			$this->payLoad = $this->getPayload();
21			$device_uid = "";
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history... Coding Style Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The string literal does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
22			if(isset($this->payLoad["device_uid"])) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The string literal `device_uid` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
23			$device_uid = $this->payLoad["device_uid"];
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The string literal `device_uid` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
24			}
25
26
27			$this->payLoad = json_encode($this->payLoad);
28			$header = $this->getSignHeaders();
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29			$url = $this->getFullUrl();

mmainstreet / jodel-web

Push — master ( dc3cec...6a6184 )

AbstractRequest::execute() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like