AbstractRequest - Code Metrics - Inspection of "Debug locationAPI & comment error" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 62cb27...c16962 )

by mains

created 2017-04-20 22:11 UTC

AbstractRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	212
Duplicated Lines	7.55 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
dl	16
loc	212
rs	10
c	0
b	0
f	0
wmc	27
lcom	1
cbo	1

8 Methods

Rating	Name	Duplication	Size	Complexity
	getPayload()	0	1	?
B	getSignHeaders()	0	40	2
A	getFullUrl()	0	4	1
	getApiEndPoint()	0	1	?
	getMethod()	0	1	?
A	getAccessToken()	0	4	1
A	setAccessToken()	0	4	1
F	execute()	16	132	22

How to fix Duplicated Code

<?php

abstract class AbstractRequest
namespace YourVendor;

class YourClass { }
{	

    const CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
$a = "a";
$ab = "ab";
$abc = "abc";
    const APIURL = 'https://api.go-tellm.com/api';
$a = "a";
$ab = "ab";
$abc = "abc";
    const SECRET = 'hFvMqLauMtnodakokftuKETbIsVLxpqfjAXiRoih';
$a = "a";
$ab = "ab";
$abc = "abc";
    const USERAGENT = 'Jodel/4.41.0 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )';
$a = "a";
$ab = "ab";
$abc = "abc";
    const CLIENT_TYPE = 'android_4.41.0';
    
    private $accessToken = null;
    private $payLoad;
    public $expects = '';
$a = "a";
$ab = "ab";
$abc = "abc";
    public $version = 'v2';
$a = "a";
$ab = "ab";
$abc = "abc";
    public $hasPayload = FALSE;

    public function execute()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $result = new \stdClass();
		        
		$this->payLoad = $this->getPayload();
		$device_uid = '';
$a = "a";
$ab = "ab";
$abc = "abc";
		if(isset($this->payLoad['device_uid'])) {
			$device_uid = $this->payLoad['device_uid'];
		}
				
				
        $this->payLoad = json_encode($this->payLoad);
        $header = $this->getSignHeaders();
$a = "a";
$ab = "ab";
$abc = "abc";
        $url = $this->getFullUrl();
$a = "a";
$ab = "ab";
$abc = "abc";

        if ($this->getAccessToken()) {
            $header['Authorization'] = "Bearer " . $this->getAccessToken();
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        //Comment out to debug the Request:

        /*

        printf("URL: ");
        var_dump($url);
        echo "<br />";
        printf("Header: ");
        var_dump($header);
        echo "<br />";
        printf("Payload: ");
        var_dump($this->payLoad);
        echo "<br />";
        */
        /*

        $options = array(
            'timeout' => 100,
            'connect_timeout' => 100,
            'proxy' => '186.103.169.165:8080',
        );*/

        switch ($this->getMethod()) {
            case 'POST':
                $result = Requests::post($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
            case 'GET':
                if($this->hasPayload)
                {
                    $result = Requests::get($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                }
                else
                {
                    $result = Requests::get($url, $header);
                }
                break;
            case 'PUT':
                $result = Requests::put($url, $header, $this->payLoad);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                break;
        }

        http_response_code($result->status_code);

        switch ($result->status_code) {
            case 200:
                $result = json_decode($result->body, true);
                break;
            case 204:
                $result = 'Success';
                http_response_code(200);
                break;
            case 400:

                $result = json_decode($result->body, true);
                error_log('Error 400 - ' . print_r($result, true));
                break;
            case 401:
                //$result = json_decode($result->body, true);


                if(is_array($result) && $result['error'] == 'length')
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                {

                }
                else
                {
                    error_log('Error 401 - ' . print_r($result, true));
                }
                break;
            case 404:

                error_log('Error 404 - ' . print_r($result, true));
                $result = json_decode($result->body, true);
                break;
			case 477:

                $result = json_decode($result->body, true);
                error_log('Error 477 - ' . print_r($result, true));
                break;
            case 429:

                error_log('Error 429 - Too Many Requests' . print_r(json_decode($result->body, true), true));
            	exit("Error 429: Too Many Requests");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            	break;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            case 403:
                error_log('Error 403 - Access denied:' . print_r(json_decode($result->body, true), true));
                $result = json_decode($result->body, true);
                break;
            case 502:
                error_log('Error 502 - ' . print_r($result, true));
                $result = json_decode($result->body, true);
                header('location:'.$_SERVER['PHP_SELF']);
                break;
            case 503:
                error_log('Error 503 - ' . print_r($result, true));
                $result = json_decode($result->body, true);

                if(array_key_exists('error', $result) && $result['error'] == 'Service Unavailable')
                {
                    header('location:'.$_SERVER['PHP_SELF']); 
                }
                break;
            default:
                error_log('Error '.$result->status_code.' - unknown error');
                $result = json_decode($result->body, true);
        }

        //important for account refresh
        if($device_uid != '')
        {
			$result[0] = $result;
			$result[1] = $device_uid;
        }

        
        /*

        var_dump($result);
        */
        
        return $result;
    }
    abstract function getPayload();

    /**
     * Gets Sign headers
     * @return array headers

     */
    private function getSignHeaders()
    {
			if($this->getAccessToken() == null) {
				$payload_accessToken = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else {
				$payload_accessToken = $this->getAccessToken();
			}
			
			
        $headers = array(
$a = "a";
$ab = "ab";
$abc = "abc";
            "Connection" => "keep-alive",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Accept-Encoding" => "gzip",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "Content-Type" => "application/json; charset=UTF-8",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            "User-Agent" => self::USERAGENT
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        );
        $timestamp = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = $timestamp->format(DateTime::ATOM);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp = substr($timestamp, 0, -6);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timestamp .= "Z";
$a = "a";
$ab = "ab";
$abc = "abc";
        $urlParts = parse_url($this->getFullUrl());
$a = "a";
$ab = "ab";
$abc = "abc";
        $url2 = "";
$a = "a";
$ab = "ab";
$abc = "abc";
        $req = [$this->getMethod(),
$a = "a";
$ab = "ab";
$abc = "abc";
            $urlParts['host'],
            "443",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            $urlParts['path'],
            $payload_accessToken,
            $timestamp,
            $url2,
            $this->payLoad];
        $reqString = implode("%", $req);
$a = "a";
$ab = "ab";
$abc = "abc";
        $secret = self::SECRET;
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = hash_hmac('sha1', $reqString, $secret);
$a = "a";
$ab = "ab";
$abc = "abc";
        $signature = strtoupper($signature);
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Authorization'] = 'HMAC ' . $signature;
        $headers['X-Client-Type'] = self::CLIENT_TYPE;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Timestamp'] = $timestamp;
$a = "a";
$ab = "ab";
$abc = "abc";
        $headers['X-Api-Version'] = '0.2';
$a = "a";
$ab = "ab";
$abc = "abc";
        return $headers;
    }
    private function getFullUrl()
    {
        return self::APIURL . $this->getApiEndPoint();
    }
    abstract function getApiEndPoint();

    abstract function getMethod();

    /**
     * @return string
     */
    private function getAccessToken()
    {
        return $this->accessToken;
    }
    /**
     * @param string $accessToken
     */
    public function setAccessToken($accessToken)
    {
        $this->accessToken = $accessToken;
    }
}



1			<?php
2
3			abstract class AbstractRequest
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The opening class brace should be on a newline by itself. Loading history...
5			const CLIENTID = '81e8a76e-1e02-4d17-9ba0-8a7020261b26';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
6			const APIURL = 'https://api.go-tellm.com/api';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
7			const SECRET = 'hFvMqLauMtnodakokftuKETbIsVLxpqfjAXiRoih';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
8			const USERAGENT = 'Jodel/4.41.0 Dalvik/2.1.0 (Linux; U; Android 5.1.1; )';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
9			const CLIENT_TYPE = 'android_4.41.0';
10
11			private $accessToken = null;
12			private $payLoad;
13			public $expects = '';
			0 ignored issues – show Coding Style introduced 2017-02-11 19:44 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
14			public $version = 'v2';
			0 ignored issues – show Coding Style introduced 2017-02-11 19:44 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
15			public $hasPayload = FALSE;
16
17			public function execute()
			0 ignored issues – show Coding Style introduced 2017-03-02 17:18 UTC by Report Bug Copy Issue Report `execute` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
18			{
19			$result = new \stdClass();
20
21			$this->payLoad = $this->getPayload();
22			$device_uid = '';
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23			if(isset($this->payLoad['device_uid'])) {
24			$device_uid = $this->payLoad['device_uid'];
25			}
26
27
28			$this->payLoad = json_encode($this->payLoad);
29			$header = $this->getSignHeaders();
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...

mmainstreet / jodel-web

Push — master ( 62cb27...c16962 )

AbstractRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like