get-posts-ajax.php ➔ getPosts() - Code Metrics - Inspection of "Try first web push" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3b2729...39ee05 )

by mains

created 2016-11-22 14:29 UTC

get-posts-ajax.php ➔ getPosts() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	28
Code Lines	7

Duplication

Lines	10
Ratio	35.71 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	2
dl	10
loc	28
rs	8.8571
c	0
b	0
f	0

<?php

error_reporting(-1);

include 'php/DatabaseConnect.php';
include 'php/Requests/AbstractRequest.php';
include 'php/Requests/CreateUser.php';
include 'php/AccountData.php';
include 'php/Location.php';
include 'php/Requests/GetPosts.php';
include 'php/Requests/GetKarma.php';
include 'php/Requests/UpdateLocation.php';
include 'php/Requests/Upvote.php';
include 'php/Requests/Downvote.php';
include 'php/Requests/GetPostDetails.php';
include 'php/Requests/SendJodel.php';

require_once 'php/Requests/libary/Requests.php';
Requests::register_autoloader();

function getPosts($lastPostId, $url) {
	$db = new DatabaseConnect();

	if ($db->connect_errno) {
		echo 'Sorry, die Verbindung zu unserem superfetten endgeilen 
					Server ist hops gegangen. Wegen '. $db -> connect_error;
	}
	
	$result = $db->query("SELECT * FROM accounts WHERE id='1'");
	
	if ($result->num_rows > 0) {

		// output data of each row
		while($row = $result->fetch_assoc()) {
			$access_token = $row["access_token"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
	}
	else
	{
		echo "0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}
	
	$accountCreator = new GetPosts();
	$accountCreator->setLastPostID($lastPostId);
	$accountCreator->setUrl($url);
	$accountCreator->setAccessToken($access_token);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	$data = $accountCreator->execute();

	return $data;
}
	$posts;

	if(isset($_GET['commentView']))

	{
		$commentView = true;
		$url = "/posts/location/discussed/";
$a = "a";
$ab = "ab";
$abc = "abc";
	}
	else
	{
		if(isset($_GET['upVoteView']))
		{
			$upVoteView = true;
			$url = "/posts/location/popular/";
$a = "a";
$ab = "ab";
$abc = "abc";
		}
		else
		{
			$timeView = true;
			$url = "/v2/posts";
$a = "a";
$ab = "ab";
$abc = "abc";
		}
	}

	if(isset($_GET['lastPostId'])) {
	
		$lastPostId = $_GET['lastPostId'];
		
		$posts = getPosts($lastPostId, $url)['posts'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$loops = 29;
$a = "a";
$ab = "ab";
$abc = "abc";
		$showCommentIcon = TRUE;
		?>
		<div class="nextPosts">
		<?php
		for($i = 0; $i<$loops; $i++) {
		
			if(isset($posts[$i])) {
				$lastPostId = $posts[$i]['post_id'];

				
				$now = new DateTime();
				$d = new DateTime($posts[$i]["created_at"]);
$a = "a";
$ab = "ab";
$abc = "abc";
				
				
				//Time to time difference
							$timediff = $now->diff($d);

							$timediff_inSeconds = (string)$timediff->format('%s');
							$timediff_inMinutes = (string)$timediff->format('%i');
							$timediff_inHours = (string)$timediff->format('%h');
$a = "a";
$ab = "ab";
$abc = "abc";
							$timediff_inDays = (string)$timediff->format('%d');
$a = "a";
$ab = "ab";
$abc = "abc";
							$timediff_inMonth = (string)$timediff->format('%m');
$a = "a";
$ab = "ab";
$abc = "abc";
							if($timediff_inMonth!=0) {

									$timediff = $timediff_inMonth . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
							}
							else
							{
								if($timediff_inDays!=0)
								{
									$timediff = $timediff_inDays . "d";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								}
								else
								{
									if($timediff_inHours!=0)
									{
										$timediff = $timediff_inHours . "h";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
									}
									else
									{
										if($timediff_inMinutes!=0)
										{
											$timediff = $timediff_inMinutes . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										}
										else
										{
											$timediff = $timediff_inSeconds . "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										}
									}
								}
							}
						?>

				<article class="jodel" style="background-color: #<?php echo $posts[$i]["color"];?>;">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					<content>
						<?php 
						if(isset($posts[$i]["image_url"])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
							echo '<img src="' . $posts[$i]["image_url"] . '">';
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
						}
						else {
							echo nl2br($posts[$i]["message"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
						}
						?>
					</content>
					<aside>
						<a href="index.php?vote=up&postID=<?php echo $posts[$i]["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
							<i class="fa fa-angle-up fa-3x"></i>
						</a>	
							<br />
						<?php echo $posts[$i]["vote_count"];?><br />
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
						<a href="index.php?vote=down&postID=<?php echo $posts[$i]["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
							<i class="fa fa-angle-down fa-3x"></i>
						</a>
					</aside>

					<footer>
						<table>
							<tr>
								<td class="time">
									<span data-tooltip="Time">
										<i class="fa fa-clock-o"></i>
										<?php echo $timediff;?>
									</span> 
								</td>
								<td class="comments">
									<?php if($showCommentIcon) {?>

									<span data-tooltip="Comments">
										<a href="index.php?getPostDetails=true&postID=<?php echo $posts[$i]["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
											<i class="fa fa-commenting-o"></i>
											<?php if(array_key_exists("child_count", $posts[$i])) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
														echo $posts[$i]["child_count"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
													} else echo "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
											?>
											</a>
									</span>
									<?php } ?>
								</td>
								<td class="distance">
									<span data-tooltip="Distance">
										<i class="fa fa-map-marker"></i>
										<?php echo $posts[$i]["distance"];?> km
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
									</span>
								</td>
							</tr>
						</table>
					</footer>
				</article>



				<?php 
			}
		}
		?>
		</div>
		<div class="lastPostId">
		<?php echo $lastPostId; ?>
		</div>
		<?php
	}



1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 20 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		error_reporting(-1);
3
4		include 'php/DatabaseConnect.php';
5		include 'php/Requests/AbstractRequest.php';
6		include 'php/Requests/CreateUser.php';
7		include 'php/AccountData.php';
8		include 'php/Location.php';
9		include 'php/Requests/GetPosts.php';
10		include 'php/Requests/GetKarma.php';
11		include 'php/Requests/UpdateLocation.php';
12		include 'php/Requests/Upvote.php';
13		include 'php/Requests/Downvote.php';
14		include 'php/Requests/GetPostDetails.php';
15		include 'php/Requests/SendJodel.php';
16
17		require_once 'php/Requests/libary/Requests.php';
18		Requests::register_autoloader();
19
20		function getPosts($lastPostId, $url) {
21		$db = new DatabaseConnect();
		0 ignored issues – show Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Avoid variables with short names like $db. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history...
22		if ($db->connect_errno) {
23		echo 'Sorry, die Verbindung zu unserem superfetten endgeilen
24		Server ist hops gegangen. Wegen '. $db -> connect_error;
25		}
26
27		$result = $db->query("SELECT * FROM accounts WHERE id='1'");
28
29	View Code Duplication	if ($result->num_rows > 0) {
		0 ignored issues – show Duplication introduced 2016-11-22 14:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30		// output data of each row
31		while($row = $result->fetch_assoc()) {
32		$access_token = $row["access_token"];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report The string literal `access_token` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
33		}
34		}
35		else
36		{

mmainstreet / jodel-web

Push — master ( 3b2729...39ee05 )

get-posts-ajax.php ➔ getPosts() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like