Issues in vote-ajax.php - Fixed Issues - Inspection of "Fixed admin vote" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 306300...8aacdd )

by mains

created 2017-02-13 01:28 UTC

vote-ajax.php (9 issues)

Labels

Severity

Informational 9

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

$config = parse_ini_file('config/config.ini.php');
if(!isset($_GET['pw']) || $config['pw'] != $_GET['pw'])
{
	error_log($_SERVER['REMOTE_ADDR']  . ' used a wrong password on vote-ajax.php');
	$respone = array("message" => $_SERVER['REMOTE_ADDR']  . ' used a wrong password on vote-ajax.php',"success" => false);
	echo json_encode($response);
	
	die();
}

include 'php/jodel-web.php';

if(isset($_GET['solution']) && isset($_GET['key']) && isset($_POST["accessToken"]))
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
{
	$response = array("success" => verifyCaptcha($_POST["accessToken"]));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	echo json_encode($response);
	die();
}

$message = "";
$success = true;
$token = "";
	if(isset($_POST['vote']) && isset($_POST['postId']))
	{
		$i = 0;
		$result = $db->query("SELECT access_token, device_uid FROM accounts WHERE device_uid NOT IN (SELECT device_uid FROM votes WHERE postId = '" . $_POST['postId'] . "')");

		if($result->num_rows > 0)
		{
			$row = $result->fetch_assoc();
			$accessToken = $row['access_token'];
			$deviceUid = $row['device_uid'];
			
			if(!isAccountVerified($accessToken))
			{
				$message = "This account is not verified. Please verify this account first.";
				$captcha = getCaptcha($accessToken);
				$token = $accessToken;
$a = "a";
$ab = "ab";
$abc = "abc";
				$success = false;
			}
			else {
				
				$location = getLocationByAccessToken($accessToken);

				$accessToken = isTokenFreshByAccessToken($location, $accessToken);


				if($_POST['vote'] == "up") {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$accountCreator = new Upvote();
				}
				else if($_POST['vote'] == "down") {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$accountCreator = new Downvote();
				}

				$accountCreator->setAccessToken($accessToken);
				$accountCreator->postId = $_POST['postId'];
				$data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
				if(array_key_exists('post', $data))
				{
					addVoteWithPostIdAndTypeToDeviceUid($_POST['postId'], $_POST['vote'], $deviceUid);
				}
			}
		}
		else
		{
			$message = 'There is no account available for this jodel. Please create at least one new account to vote this jodel.';
			$success = false;
		}
	}

if (isset($captcha))
{
	$response = array("success" => $success, "message" => $message, "captcha" => $captcha, "accessToken" => $token);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
}
else 
{
	$response = array("success" => $success, "message" => $message);
}
echo json_encode($response);
?>

1		<?php
2
3		$config = parse_ini_file('config/config.ini.php');
4		if(!isset($_GET['pw']) \|\| $config['pw'] != $_GET['pw'])
5		{
6		error_log($_SERVER['REMOTE_ADDR'] . ' used a wrong password on vote-ajax.php');
7		$respone = array("message" => $_SERVER['REMOTE_ADDR'] . ' used a wrong password on vote-ajax.php',"success" => false);
8		echo json_encode($response);
9
10		die();
11		}
12
13		include 'php/jodel-web.php';
14
15		if(isset($_GET['solution']) && isset($_GET['key']) && isset($_POST["accessToken"]))
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `accessToken` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
16		{
17		$response = array("success" => verifyCaptcha($_POST["accessToken"]));
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `success` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history... Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `accessToken` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
18		echo json_encode($response);
19		die();
20		}
21
22		$message = "";
23		$success = true;
24		$token = "";
25		if(isset($_POST['vote']) && isset($_POST['postId']))
26		{
27		$i = 0;
28		$result = $db->query("SELECT access_token, device_uid FROM accounts WHERE device_uid NOT IN (SELECT device_uid FROM votes WHERE postId = '" . $_POST['postId'] . "')");
29
30		if($result->num_rows > 0)
31		{
32		$row = $result->fetch_assoc();
33		$accessToken = $row['access_token'];
34		$deviceUid = $row['device_uid'];
35
36		if(!isAccountVerified($accessToken))
37		{
38		$message = "This account is not verified. Please verify this account first.";
39		$captcha = getCaptcha($accessToken);
40		$token = $accessToken;
		0 ignored issues – show Coding Style introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41		$success = false;
42		}
43		else {
44
45		$location = getLocationByAccessToken($accessToken);
46
47		$accessToken = isTokenFreshByAccessToken($location, $accessToken);
48
49
50	View Code Duplication	if($_POST['vote'] == "up") {
		0 ignored issues – show Duplication introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `up` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
51		$accountCreator = new Upvote();
52		}
53		else if($_POST['vote'] == "down") {
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `down` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
54		$accountCreator = new Downvote();
55		}
56
57		$accountCreator->setAccessToken($accessToken);
58		$accountCreator->postId = $_POST['postId'];
59		$data = $accountCreator->execute();
		0 ignored issues – show Coding Style introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 19 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
60		if(array_key_exists('post', $data))
61		{
62		addVoteWithPostIdAndTypeToDeviceUid($_POST['postId'], $_POST['vote'], $deviceUid);
63		}
64		}
65		}
66		else
67		{
68		$message = 'There is no account available for this jodel. Please create at least one new account to vote this jodel.';
69		$success = false;
70		}
71		}
72
73		if (isset($captcha))
74		{
75		$response = array("success" => $success, "message" => $message, "captcha" => $captcha, "accessToken" => $token);
		0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-10 21:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `accessToken` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
76		}
77		else
78		{
79		$response = array("success" => $success, "message" => $message);
80		}
81		echo json_encode($response);
82		?>

mmainstreet / jodel-web

Push — master ( 306300...8aacdd )

vote-ajax.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like