View::jodelToHtml() - Code Metrics - Inspection of "Add image upload" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5c086a...710747 )

by mains

created 2017-03-02 17:11 UTC

View::jodelToHtml() F

↳ Parent: View

Complexity

Conditions	16
Paths	960

Size

Total Lines	164
Code Lines	88

Duplication

Lines	16
Ratio	9.76 %

Importance

Changes

Metric	Value
cc	16
eloc	88
nc	960
nop	1
dl	16
loc	164
rs	2.3966
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

class View
namespace YourVendor;

class YourClass { }
{
    public $country;
    public $city;
    public $hashtag;
	public $view;
    public $postId;
    public $isDetailedView;
    public $baseUrl;

	public $lastPostId = '';

    function __construct($baseUrl, $country, $city, $hashtag = '%23all', $view = 'time', $postId = '')

    {
        $this->baseUrl = $baseUrl;
        $this->country = $country;
        $this->city = $city;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->hashtag = urldecode($hashtag);
        $this->view = $view;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->postId = $postId;
$a = "a";
$ab = "ab";
$abc = "abc";

        if($postId == '')
        {
            $this->isDetailedView = FALSE;
        }
        else
        {
            $this->isDetailedView = TRUE;
        }
    }
	/**
	 * Compute HTML Code
	 */
 	function jodelToHtml($post)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {   //ToDO

        //Replace # with link
        //preg_replace('~(\#)([^\s!,. /()"\'?]+)~', '<a href="tag/$2">#$2</a>', $text);


        //Time to time difference
        $now = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
        $d = new DateTime($post['created_at']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff = $now->diff($d);

        $timediff_inSeconds = (string)$timediff->format('%s');
        $timediff_inMinutes = (string)$timediff->format('%i');
        $timediff_inHours = (string)$timediff->format('%h');
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff_inDays = (string)$timediff->format('%d');
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff_inMonth = (string)$timediff->format('%m');
$a = "a";
$ab = "ab";
$abc = "abc";

        if($timediff_inMonth!=0)
        {
                $timediff = $timediff_inMonth . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        else
        {
            if($timediff_inDays!=0)
            {
                $timediff = $timediff_inDays . "d";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            else
            {
                if($timediff_inHours!=0)
                {
                    $timediff = $timediff_inHours . "h";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
                else
                {
                    if($timediff_inMinutes!=0)
                    {
                        $timediff = $timediff_inMinutes . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                    else
                    {
                        $timediff = $timediff_inSeconds . "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                }
            }
        }


        ?>
        <article id ="postId-<?php echo $post['post_id']; ?>" class="jodel" style="background-color: #<?php echo $post['color'];?>;">

            <content>
                <?php 
                if(isset($post['image_url']))
                {
                    $regexRest = '/[^\w$ .!?-]+/u';

                    echo '<img src="' . $post['image_url'] . '" alt="' . htmlspecialchars(preg_replace($regexRest, '', $post['message'])) . '">';

                }
                else {
                    echo str_replace('  ', ' &nbsp;', nl2br(htmlspecialchars($post['message'])));
                }
                ?>
            </content>
            <aside>
                <?php
                    if($this->isDetailedView)

                    {?>
                        <a href="index.php?vote=up&getPostDetails=true&postId=<?php echo $post['post_id'];?>&postId_parent=<?php echo htmlspecialchars($_GET['postId']);?>" rel="nofollow">

              <?php }
                    else
                    {?>
                        <a href="index.php?vote=up&postId=<?php echo $post['post_id'];?>" rel="nofollow">
              <?php } ?>
                            <i class="fa fa-angle-up fa-3x"></i>
                        </a>    
                            <br />
                        <?php echo $post["vote_count"];?><br />
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                <?php
                    if($this->isDetailedView)

                    {?>
                        <a href="index.php?vote=down&getPostDetails=true&postId=<?php echo $post['post_id'];?>&postId_parent=<?php echo htmlspecialchars($_GET['postId']);?>" rel="nofollow">

              <?php }
                    else
                    {?>
                        <a href="index.php?vote=down&postId=<?php echo $post['post_id'];?>" rel="nofollow">
              <?php } ?>
                            <i class="fa fa-angle-down fa-3x"></i>
                        </a>
            </aside>

            <footer>
                <span class="wrapper">
                    
                        <span class="time">
                            <span class="tip" data-tooltip="Time">
                                <i class="fa fa-clock-o"></i>
                                <?php echo $timediff;?>
                                <span class="tiptext"><?php echo $d->format('Y-m-d H:i:s');?></span>
                            </span> 
                        </span>
						<?php if(!$this->isDetailedView) {?>
                        <span class="comments">
                            <span data-tooltip="Comments">
                                <a href="<?php echo $this->changePostId($post['post_id'])->toUrl();?>">
                                    <i class="fa fa-commenting-o"></i>
                                    <?php if(array_key_exists("child_count", $post)) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                                echo $post["child_count"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                            } else echo "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    ?>
                                </a>
                            </span>
                            
                        </span>
						<?php
						}															  
						if (isUserAdmin())
						{
						?>
						<span class="voting">
							<a target="_blank" href="admin.php?postId=<?php echo $post['post_id'] ?>">
								<i class="fa fa-thumbs-o-up"></i> Vote
							</a>
						</span>
						<?php
						}
						?>
                        <span class="distance">
                            <?php
                                if($this->isDetailedView)
                                {
                                    if(isset($post["parent_creator"]) && $post["parent_creator"] == 1)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    {
                                        ?>
                                        <span data-tooltip="Author">
                                            <i class="fa fa-user-o"></i> OJ |
                                        </span>
                                        <?php 
                                    }
                                    else
                                    {
                                        //Is not parent Jodel in detailed View
                                        if(!array_key_exists('child_count', $post) && array_key_exists('parent_creator', $post))

                                        {
                                            ?>
                                            <span data-tooltip="Author">
                                                <i class="fa fa-user-o"></i> #<?php echo $post["user_handle"];?> |
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                            </span>
                                            <?php
                                        }
                                    }
                                }
                                ?>

                            <span class="tip" data-tooltip="Distance">
                                <i class="fa fa-map-marker"></i>
                                <?php echo $post['distance'];?> km
                                <span class="tiptext"><?php echo $post['location']['name'];?></span>
                            </span>
                        </span>
                    
                </span>
            </footer>
        </article>
    <?php
    }


	/**
	 * Gets the title.
	 *
	 * @return     string  The title.
	 */
	function getTitle($post = '')

	{
		$title = 'JodelBlue - Top Jodel from ' . htmlspecialchars($this->city) . ' Web-App and Browser-Client';

		if($post != '' && array_key_exists('message', $post) && $post['message'] != '' && $this->isDetailedView)
		{
			$title = 'JodelBlue: ' . substr(htmlspecialchars($post['message']), 0, 44);
		}

		return $title;
	}

	/**
	 * Gets the meta description.
	 *
	 * @return     string  The meta description.
	 */
	function getMetaDescription($post = '')

	{
		$description = 'JodelBlue is a Web-App and Browser-Client for the Jodel App. No registration required! Browse Jodels in ' . htmlspecialchars($this->city) . ' or all over the world.';


		if($post != '' && array_key_exists('message', $post) && $post['message'] != '' && $this->isDetailedView)
		{
			$description = 'On JodelBlue in ' . htmlspecialchars($this->city) .  ' with ' . htmlspecialchars($post['vote_count']) . ' Upvotes: ' . substr(htmlspecialchars($post['message']), 0, 130);

		}

		return $description;
	}

    function toUrl()

    {
        $url = $this->baseUrl . 'index.php?country=DE' .
                            '&city=' . urlencode($this->city) .
                            '&hashtag=' . urlencode($this->hashtag) . 
                            '&view=' . $this->view;
        if($this->postId != '')
        {
            $url .= '&postId=' . $this->postId . 
                    '&getPostDetails=TRUE';
        }

        return $url;
    }

    function changePostId($postId)

    {
        $tempView = clone $this;
$a = "a";
$ab = "ab";
$abc = "abc";
        $tempView->postId = $postId;
$a = "a";
$ab = "ab";
$abc = "abc";
        $tempView->isDetailedView = TRUE;
        return $tempView;
    }

    function back()

    {
        $tempView = clone $this;
$a = "a";
$ab = "ab";
$abc = "abc";
        $tempView->postId = '';
        return $tempView;
    }

    function changeView($view)

    {
        $tempView = clone $this;
$a = "a";
$ab = "ab";
$abc = "abc";
        $tempView->view = $view;
        return $tempView;
    }

	function getPosts($jodelAccount)

	{
        if($this->hashtag != '#all' && $this->hashtag != '' && $this->hashtag != NULL)
        {
            $accountCreator = new GetChannel();
$a = "a";
$ab = "ab";
$abc = "abc";
            $accountCreator->view = $this->view;
            $accountCreator->setAccessToken($jodelAccount->accessToken);
            $accountCreator->channel = $this->hashtag;
$a = "a";
$ab = "ab";
$abc = "abc";
            $accountCreator->lastPostId = $this->lastPostId;
            $data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
        }
        else
        {
            if($this->lastPostId == '' && $this->view == 'combo')
            {
                $url = "/v3/posts/location/combo";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            else
            {
                if($this->view == 'discussed')
                {
                    $url = "/v2/posts/location/discussed/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
                else
                {
                    if($this->view == 'popular')
                    {
                        $url = "/v2/posts/location/popular/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                    else
                    {
                        $url = "/v2/posts/location/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                }
            }

            $accountCreator = new GetPosts();
            $accountCreator->setLastPostId($this->lastPostId);
            $accountCreator->setAccessToken($jodelAccount->accessToken);
            $accountCreator->setUrl($url);
            $accountCreator->version = 'v3';

            $config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
            $location = new Location();
            $location->setLat($config['default_lat']);
            $location->setLng($config['default_lng']);
            $location->setCityName($config['default_location']);
            $accountCreator->location = $location;
            $data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
        }
    	if(array_key_exists('recent', $data) && array_key_exists(0, $data['recent']))
        {
            return $data['recent'];
        }
        else if(array_key_exists('posts', $data)&& array_key_exists(0, $data['posts']))
        {
            return $data['posts'];
        }
        else
        {
            error_log('Could not find Posts in: ' . $this->city . ' Error: ' . print_r($data, true));
            //error_log(print_r($data, true));


            $notFound[0] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                "post_id" => "0",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "discovered_by" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "message" => "No more Posts found",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "created_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "updated_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "pin_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "color" => "5682a3",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "got_thanks" => FALSE,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "post_own" => "friend",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "discovered" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "distance" => 9,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "vote_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                "location" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                array("name" => "Berlin",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                  "loc_coordinates" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                  array(
                    "lat" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    "lng" => 0
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                  ),
                  "loc_accuracy" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                  "country" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                  "city" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ),
                "tags" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                array(),
                "user_handle" => "0"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            );
            return $notFound;
        }
	}
}



1			<?php
2
3			class View
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public $country;
6			public $city;
7			public $hashtag;
8			public $view;
9			public $postId;
10			public $isDetailedView;
11			public $baseUrl;
12
13			public $lastPostId = '';
14
15			function __construct($baseUrl, $country, $city, $hashtag = '%23all', $view = 'time', $postId = '')
			0 ignored issues – show Best Practice introduced 2017-02-15 03:21 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
16			{
17			$this->baseUrl = $baseUrl;
18			$this->country = $country;
19			$this->city = $city;
			0 ignored issues – show Coding Style introduced 2017-02-15 03:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			$this->hashtag = urldecode($hashtag);
21			$this->view = $view;
			0 ignored issues – show Coding Style introduced 2017-02-15 03:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$this->postId = $postId;
			0 ignored issues – show Coding Style introduced 2017-02-15 03:21 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23
24			if($postId == '')
25			{
26			$this->isDetailedView = FALSE;
27			}
28			else
29			{
30			$this->isDetailedView = TRUE;
31			}
32			}
33			/**
34			* Compute HTML Code
35			*/

mmainstreet / jodel-web

Push — master ( 5c086a...710747 )

View::jodelToHtml() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like