JodelAccount - Code Metrics - Inspection of "Fix include footer" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( de7d3d...871cd7 )

by mains

created 2017-02-17 23:08 UTC

JodelAccount C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	490
Duplicated Lines	9.8 %

Coupling/Cohesion

Components	1
Dependencies	13

Importance

Changes

Metric	Value
dl	48
loc	490
rs	6.018
c	0
b	0
f	0
wmc	61
lcom	1
cbo	13

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like JodelAccount often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use JodelAccount, and based on these observations, apply Extract Interface, too.

<?php

class JodelAccount
namespace YourVendor;

class YourClass { }
{
    public $accessToken;
    public $expirationDate;
    public $refreshToken;
    public $distinctId;
    public $deviceUid;

    //is the Account a Bot or Spider?
    public $isBot;
    
    // array of voted Jodels
    public $votes;

    //Location of the Account
    public $location;

    function __construct($deviceUid = NULL, $isBot = FALSE)

    {
        if($deviceUid == NULL)
        {
            $this->deviceUid = $this->createAccount();
        }
        else
        {
            $this->deviceUid = $deviceUid;
        }

        $this->isBot        = $isBot;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->location     = $this->getLocation();
$a = "a";
$ab = "ab";
$abc = "abc";

        if(!$this->isTokenFresh())
        {
            $this->refreshToken();
        }
        $this->accessToken  = $this->getAccessToken();
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    function isAccountVerified()

    {
        $accountCreator = new GetUserConfig();
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();

        return $data['verified'];
    }

    function locationEquals($city)

    {
        $url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($city) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w';
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = Requests::post($url);
        if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST')

        {
            error_log('Error locationEquals');
            return FALSE;
        }
        else
        {
            $name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
            $lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];
$a = "a";
$ab = "ab";
$abc = "abc";
        }

        $db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $location = new Location();
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $location->setLat($row['lat']);
                $location->setLng($row['lng']);
                $location->setCityName($row['name']);
            }
        }
        else
        {
            echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            error_log("Error no Location found - getLocation");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        if($location->getLat() == $lat && $location->getLng() == $lng && $location->getCityName() == $name)
        {
            return TRUE;
        }  
        else
        {
            return FALSE;
        }
    }

    function setLocation()

    {
        //Is Channel or City
        if(substr($_GET['city'], 0, 1) === '#')
        {
            return htmlspecialchars($_GET['city']) . " " . $this->location->cityName;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }                
        else
        {
            $url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w';
$a = "a";
$ab = "ab";
$abc = "abc";
            $result = Requests::post($url);
            if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST')

            {
                return "0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            else
            {
                $name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
                $lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
$a = "a";
$ab = "ab";
$abc = "abc";
                $lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];
$a = "a";
$ab = "ab";
$abc = "abc";

                $location = new Location();
                $location->setLat($lat);
                $location->setLng($lng);
                $location->setCityName($name);
                $accountCreator = new UpdateLocation();
                $accountCreator->setLocation($location);
                $accountCreator->setAccessToken($this->accessToken);
                $data = $accountCreator->execute();

                //safe location to db
                $db = new DatabaseConnect();

                if($data == 'Success')
                {
                    $result = $db->query("UPDATE accounts 
                            SET name='" . $name . "',
                                lat='" . $lat . "',
                                lng='" . $lng . "'
                            WHERE access_token='" . $this->accessToken . "'");

                    if($result === false)
                    {
                            echo "Updating location failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                    else
                    {
                        error_log('User with JodelDeviceId:' . $this->deviceUid .  ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] changed to Location: ' . $name);

                    }
                }

                return $name;
            }
        }
    }

    function getLocation()

    {
        $db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $location = new Location();
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $location->setLat($row['lat']);
                $location->setLng($row['lng']);
                $location->setCityName($row['name']);
            }
        }
        else
        {
            echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            error_log("Error no Location found - getLocation");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        return $location;
    }

    function verifyCaptcha()

    {
        if(isset($_GET['deviceUid']))
        {
            $deviceUid = $_GET['deviceUid'];
        }
        if(isset($_POST['deviceUid']))
        {
            $deviceUid = $_POST['deviceUid'];
        }
        $jodelAccountForVerify = new JodelAccount($deviceUid);

        $solution = $_GET['solution'];
        $solution = array_map('intval', explode('-', $solution));

        $accountCreator = new PostCaptcha();
        $accountCreator->setAccessToken($jodelAccountForVerify->accessToken);
        $accountCreator->captchaKey = $_GET['key'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $accountCreator->captchaSolution = $solution;
        $verified = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";

        if(isset($verified->status_code))
        {
            return $verified->status_code;
        }
        return $verified['verified'];
    }

    //ToDo Spider Check

    function votePostId($postId, $vote)

    {
        if(!$this->isAccountVerified())
        {
            $view = new View();
            $view->showCaptcha($this->accessToken, $this->deviceUid);
        }

        if(!$this->hasVoted($postId))
        {
            if($vote == "up")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            {
                $accountCreator = new Upvote();
            }
            else if($vote == "down")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            {
                $accountCreator = new Downvote();
            }
            $accountCreator->setAccessToken($this->accessToken);
            $accountCreator->postId = htmlspecialchars($postId);
            $data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";

            if(array_key_exists('post', $data))
            {
                $this->addVoteWithPostIdAndType($postId, $vote);
                return TRUE;
            }
            else
            {
                error_log("Could not vote: " . var_dump($data));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                return FALSE;
            } 
        }
        else
        {
            return FALSE;
        }
    }

    //ToDo Spider Check

    function sendJodel($location, $view)

    {
        if(!$this->isAccountVerified())
        {
            showCaptcha($this->accessToken);
        }

        $accountCreator = new SendJodel();

        if(isset($_POST['ancestor']))
        {
            $ancestor = $_POST['ancestor'];
$a = "a";
$ab = "ab";
$abc = "abc";
            $accountCreator->ancestor = $ancestor;
        }
        if(isset($_POST['color']))
        {
            $color = $_POST['color'];
            switch ($color) {
                case '8ABDB0':
                    $color = '8ABDB0';
                    break;
                case '9EC41C':
                    $color = '9EC41C';
                    break;
                case '06A3CB':
                    $color = '06A3CB';
                    break;
                case 'FFBA00':
                    $color = 'FFBA00';
                    break;
                case 'DD5F5F':
                    $color = 'DD5F5F';
                    break;
                case 'FF9908':
                    $color = 'FF9908';
                    break;
                default:
                    $color = '8ABDB0';
                    break;
            }
            $accountCreator->color = $color;
        }

        $accountCreatorLocation = new UpdateLocation();
        $accountCreatorLocation->setLocation($location);
        $accountCreatorLocation->setAccessToken($this->accessToken);
        $data = $accountCreatorLocation->execute();
        
        $accountCreator->location = $this->location;
        
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();

        if(isset($_POST['ancestor']))
        {
            header('Location: ' . $view->toUrl();

            exit;
        }
        else
        {
            header('Location: ' . $baseUrl);
            exit;
        }
    }

    function isTokenFresh()

    {
        $db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid . "'");

        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                    $expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
        }
        else
        {
            error_log('0 results');
        }

        if($expiration_date <= time())
        {
           return FALSE;
        }
        
        return TRUE;
    }

    function refreshToken()

    {
        $accountCreator = new CreateUser();
        $accountCreator->setAccessToken($this->accessToken);
        $accountCreator->setDeviceUid($this->deviceUid);
        $accountCreator->setLocation($this->location);
        $data = $accountCreator->execute();

        $access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $expiration_date = $data[0]['expiration_date'];
        $device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
        
        $db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("UPDATE accounts 
                                SET access_token='" . $access_token . "',
                                    expiration_date='" . $expiration_date . "'
                                WHERE device_uid='" . $device_uid . "'");

        if($result === false){
                error_log("Adding account failed: (" . $db->errno . ") " . $db->error);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }   
    }



    function getAccessToken()

    {
        $db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $this->deviceUid  . "'");
        
        $accessToken;
        
        if ($result->num_rows > 0)
        {
            // output data of each row
            while($row = $result->fetch_assoc())
            {
                $accessToken = $row['access_token'];
            }
        }
        else
        {
            error_log('Error: 0 results');
        }

        return $accessToken;
    }


    function getKarma()

    {
        $accountCreator = new GetKarma();
        $accountCreator->setAccessToken($this->accessToken);
        $data = $accountCreator->execute();
        
        return $data["karma"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
    }

    function hasVoted($postId)

    {
        $db = new DatabaseConnect();

        $postId = $db->real_escape_string($postId);

        $result = $db->query("SELECT id FROM votes WHERE (postId = '" . $postId . "' AND device_uid = '" . $this->deviceUid . "')");

        
        if($result === false)
        {
            $error = db_error();
            echo $error;
            error_log("Adding Vote failed: (" . $result->errno . ") " . $result->error);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        if($result->num_rows == 0)
        {
            return FALSE;
        }
        else
        {
            return TRUE;
        }
    }

    function addVoteWithPostIdAndType($postId, $voteType)

    {
        $db = new DatabaseConnect();  

        $postId = $db->real_escape_string($postId);
$a = "a";
$ab = "ab";
$abc = "abc";
        $voteType = $db->real_escape_string($voteType);
        
        if($this->hasVoted($postId))
        {
            return "Already voted";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }

        $result = $db->query("INSERT INTO votes (device_uid, postId, type)
                        VALUES ('" . $this->deviceUid . "','" . $postId . "','" . $voteType . "')");
        
        if($result === false){
                $error = db_error();
                echo $error;
                echo "Adding Vote failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }       
    }

    function registerAccount($location) {

        $accountCreator = new CreateUser();
        $accountCreator->setLocation($location);
        $data = $accountCreator->execute();
        
        $access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $refresh_token = (string)$data[0]['refresh_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $token_type = (string)$data[0]['token_type'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $expires_in = $data[0]['expires_in'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $expiration_date = $data[0]['expiration_date'];
        $distinct_id = (string)$data[0]['distinct_id'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";

        $name = $location->cityName;
        $lat = $location->lat;
$a = "a";
$ab = "ab";
$abc = "abc";
        $lng = $location->lng;
$a = "a";
$ab = "ab";
$abc = "abc";
        
        $db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
        $result = $db->query("INSERT INTO accounts (access_token, refresh_token, token_type,
                        expires_in, expiration_date, distinct_id, device_uid, name, lat, lng)
                        VALUES ('" . $access_token . "','" . $refresh_token . "','" . $token_type .
                        "','" .  $expires_in . "','" . $expiration_date . "','" . $distinct_id .
                        "','" . $device_uid . "','" . $name . "','" . $lat . "','" . $lng . "') ");

        $success = TRUE;
        if($result === false){
                $error = db_error();
                echo $error;
                echo "Adding account failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                $success = FALSE;
        }   
        
        return $device_uid;
    }

    function createAccount()

    {
        $config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
        $location = new Location();
        $location->setLat($config['default_lat']);
        $location->setLng($config['default_lng']);
        $location->setCityName($config['default_location']);

        $deviceUid = $this->registerAccount($location);

        return $deviceUid;
    }
}

1			<?php
2
3			class JodelAccount
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public $accessToken;
6			public $expirationDate;
7			public $refreshToken;
8			public $distinctId;
9			public $deviceUid;
10
11			//is the Account a Bot or Spider?
12			public $isBot;
13
14			// array of voted Jodels
15			public $votes;
16
17			//Location of the Account
18			public $location;
19
20			function __construct($deviceUid = NULL, $isBot = FALSE)
			0 ignored issues – show Best Practice introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
21			{
22			if($deviceUid == NULL)
23			{
24			$this->deviceUid = $this->createAccount();
25			}
26			else
27			{
28			$this->deviceUid = $deviceUid;
29			}
30
31			$this->isBot = $isBot;
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 8 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32			$this->location = $this->getLocation();
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 1 space but found 5 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33
34			if(!$this->isTokenFresh())
35			{
36			$this->refreshToken();

mmainstreet / jodel-web