These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | error_reporting(-1); |
||
3 | |||
4 | include 'php/jodel-web.php'; |
||
5 | |||
6 | $config = parse_ini_file('config/config.ini.php'); |
||
7 | |||
8 | |||
9 | $location = new Location(); |
||
10 | $location->setLat($config['default_lat']); |
||
11 | $location->setLng($config['default_lng']); |
||
12 | $location->setCityName($config['default_location']); |
||
13 | |||
14 | $accessToken; |
||
15 | $accessToken_forId1; |
||
16 | $deviceUid; |
||
17 | $isSpider = FALSE; |
||
18 | |||
19 | //What is dude doing with my Server? |
||
20 | if($_SERVER['REMOTE_ADDR'] == '94.231.103.52') |
||
21 | { |
||
22 | echo('You are flooting my Server! Pls enable Cookies in your script and contact me: [email protected]'); |
||
23 | die(); |
||
24 | } |
||
25 | |||
26 | |||
27 | //Check if it's a Spider or Google Bot |
||
28 | if(botDeviceUidIsSet($config) && isUserBot()) |
||
29 | { |
||
30 | $isSpider = TRUE; |
||
31 | error_log('Spider or Bot checked in!'); |
||
32 | |||
33 | //Change this to a free device_uid listed in your DB |
||
34 | $deviceUid = $config['botDeviceUid']; |
||
35 | $config = NULL; |
||
0 ignored issues
–
show
|
|||
36 | } |
||
37 | else |
||
38 | { |
||
39 | $config = NULL; |
||
40 | if(!isset($_COOKIE['JodelDeviceId']) || !isDeviceUidInDatabase($db->real_escape_string($_COOKIE['JodelDeviceId']))) |
||
41 | { |
||
42 | $deviceUid = createAccount(); |
||
43 | setcookie('JodelDeviceId', $deviceUid, time()+60*60*24*365*10); |
||
44 | error_log('Created account with JodelDeviceId:' . $deviceUid . ' for [' . $_SERVER ['HTTP_USER_AGENT'] . ']'); |
||
45 | |||
46 | } |
||
47 | else |
||
48 | { |
||
49 | $deviceUid = $db->real_escape_string($_COOKIE['JodelDeviceId']); |
||
50 | } |
||
51 | } |
||
52 | |||
53 | $location = getLocationByDeviceUid($deviceUid); |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
54 | $newPositionStatus = $location->getCityName(); |
||
55 | $accessToken = isTokenFreshByDeviceUid($location, $deviceUid); |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
56 | //Acc is fresh. token and location is set |
||
57 | |||
58 | $accessToken_forId1 = isTokenFresh($location); |
||
59 | $deviceUid_forId1 = getDeviceUidByAccessToken($accessToken_forId1); |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
60 | |||
61 | |||
62 | //Set View |
||
63 | View Code Duplication | if(isset($_GET['view'])) |
|
0 ignored issues
–
show
This code seems to be duplicated across your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. ![]() |
|||
64 | { |
||
65 | switch ($_GET['view']) { |
||
66 | case 'comment': |
||
67 | $view = 'comment'; |
||
68 | break; |
||
69 | |||
70 | case 'upVote': |
||
71 | $view = 'upVote'; |
||
72 | break; |
||
73 | |||
74 | default: |
||
75 | $view = 'time'; |
||
76 | break; |
||
77 | } |
||
78 | } |
||
79 | else |
||
80 | { |
||
81 | $view = 'time'; |
||
82 | } |
||
83 | |||
84 | //Set Location |
||
85 | if(isset($_GET['city'])) { |
||
86 | $url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w'; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
87 | $result = Requests::post($url); |
||
88 | if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST') |
||
0 ignored issues
–
show
|
|||
89 | { |
||
90 | $newPositionStatus = "0 results"; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
0 results does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
91 | } |
||
92 | else |
||
93 | { |
||
94 | $name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name']; |
||
95 | $lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat']; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
96 | $lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng']; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
97 | |||
98 | $location = new Location(); |
||
99 | $location->setLat($lat); |
||
100 | $location->setLng($lng); |
||
101 | $location->setCityName($name); |
||
102 | $accountCreator = new UpdateLocation(); |
||
103 | $accountCreator->setLocation($location); |
||
104 | $accountCreator->setAccessToken($accessToken); |
||
105 | $data = $accountCreator->execute(); |
||
106 | |||
107 | //safe location to db |
||
108 | if($data == 'Success') |
||
109 | { |
||
110 | $result = $db->query("UPDATE accounts |
||
111 | SET name='" . $name . "', |
||
112 | lat='" . $lat . "', |
||
113 | lng='" . $lng . "' |
||
114 | WHERE access_token='" . $accessToken . "'"); |
||
115 | |||
116 | if($result === false) |
||
117 | { |
||
118 | echo "Updating location failed: (" . $db->errno . ") " . $db->error; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
Updating location failed: ( does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() Coding Style
Comprehensibility
introduced
by
The string literal
) does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
119 | } |
||
120 | else |
||
121 | { |
||
122 | $newPositionStatus = $name; |
||
123 | error_log('User with JodelDeviceId:' . $deviceUid . ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] changed to Location: ' . $name); |
||
0 ignored issues
–
show
|
|||
124 | } |
||
125 | } |
||
126 | } |
||
127 | } |
||
128 | |||
129 | //Vote |
||
130 | if(isset($_GET['vote']) && isset($_GET['postID'])) |
||
131 | { |
||
132 | if(!deviceUidHasVotedThisPostId($deviceUid_forId1, $_GET['postID'])) |
||
133 | { |
||
134 | View Code Duplication | if($_GET['vote'] == "up") |
|
0 ignored issues
–
show
This code seems to be duplicated across your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. ![]() Coding Style
Comprehensibility
introduced
by
The string literal
up does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
135 | { |
||
136 | $accountCreator = new Upvote(); |
||
137 | } |
||
138 | else if($_GET['vote'] == "down") |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
down does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
139 | { |
||
140 | $accountCreator = new Downvote(); |
||
141 | } |
||
142 | $accountCreator->setAccessToken($accessToken_forId1); |
||
143 | $accountCreator->postId = htmlspecialchars($_GET['postID']); |
||
144 | $data = $accountCreator->execute(); |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 19 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
145 | |||
146 | |||
147 | addVoteWithPostIdAndTypeToDeviceUid($_GET['postID'], $_GET['vote'], $deviceUid_forId1); |
||
148 | } |
||
149 | |||
150 | |||
151 | if(isset($_GET['getPostDetails']) && isset($_GET['getPostDetails'])) |
||
152 | { |
||
153 | header('Location: index.php?getPostDetails=true&postID=' . htmlspecialchars($_GET['postID_parent']) . '#postId-' . htmlspecialchars($_GET['postID'])); |
||
0 ignored issues
–
show
|
|||
154 | } |
||
155 | else |
||
156 | { |
||
157 | header("Location: index.php#postId-" . htmlspecialchars($_GET['postID'])); |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
Location: index.php#postId- does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
158 | } |
||
159 | die(); |
||
160 | } |
||
161 | |||
162 | |||
163 | //SendJodel |
||
164 | if(isset($_POST['message'])) |
||
165 | { |
||
166 | $accountCreator = new SendJodel(); |
||
167 | |||
168 | if(isset($_POST['ancestor'])) |
||
169 | { |
||
170 | $ancestor = $_POST['ancestor']; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 17 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
171 | $accountCreator->ancestor = $ancestor; |
||
172 | } |
||
173 | if(isset($_POST['color'])) |
||
174 | { |
||
175 | $color = $_POST['color']; |
||
176 | switch ($color) { |
||
177 | case '8ABDB0': |
||
178 | $color = '8ABDB0'; |
||
179 | break; |
||
180 | case '9EC41C': |
||
181 | $color = '9EC41C'; |
||
182 | break; |
||
183 | case '06A3CB': |
||
184 | $color = '06A3CB'; |
||
185 | break; |
||
186 | case 'FFBA00': |
||
187 | $color = 'FFBA00'; |
||
188 | break; |
||
189 | case 'DD5F5F': |
||
190 | $color = 'DD5F5F'; |
||
191 | break; |
||
192 | case 'FF9908': |
||
193 | $color = 'FF9908'; |
||
194 | break; |
||
195 | |||
196 | default: |
||
197 | $color = '8ABDB0'; |
||
198 | break; |
||
199 | } |
||
200 | $accountCreator->color = $color; |
||
201 | } |
||
202 | |||
203 | //$location = getLocationByAccessToken($accessToken); |
||
0 ignored issues
–
show
Unused Code
Comprehensibility
introduced
by
56% of this comment could be valid code. Did you maybe forget this after debugging?
Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. ![]() |
|||
204 | |||
205 | $accountCreatorLocation = new UpdateLocation(); |
||
206 | $accountCreatorLocation->setLocation($location); |
||
207 | $accountCreatorLocation->setAccessToken($accessToken_forId1); |
||
208 | $data = $accountCreatorLocation->execute(); |
||
209 | |||
210 | $accountCreator->location = $location; |
||
211 | |||
212 | $accountCreator->setAccessToken($accessToken_forId1); |
||
213 | $data = $accountCreator->execute(); |
||
214 | |||
215 | if(isset($_POST['ancestor'])) |
||
216 | { |
||
217 | $actual_link = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI']; |
||
218 | header('Location: ' . $actual_link . '#postId-' . htmlspecialchars($data['post_id'])); |
||
219 | exit; |
||
220 | } |
||
221 | else |
||
222 | { |
||
223 | header('Location: ./'); |
||
224 | exit; |
||
225 | } |
||
226 | } |
||
227 | ?> |
||
228 | <!DOCTYPE html> |
||
229 | <html lang="en"> |
||
230 | <head> |
||
231 | <title>JodelBlue - Web-App and Browser-Client</title> |
||
232 | |||
233 | <meta charset="utf-8"> |
||
234 | <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no"> |
||
235 | <meta http-equiv="x-ua-compatible" content="ie=edge"> |
||
236 | |||
237 | <meta name="description" content="JodelBlue is a Web-App and Browser-Client for the Jodel App. No registration required! Browse Jodels all over the world. Send your own Jodels or upvote others."> |
||
0 ignored issues
–
show
|
|||
238 | <meta name="keywords" content="jodelblue, jodel, blue, webclient, web, client, web-app, browser, app"> |
||
239 | |||
240 | <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/css/bootstrap.min.css" integrity="sha384-AysaV+vQoT3kOAXZkl02PThvDr8HYKPZhNT5h/CXfBThSRXQ6jW5DO2ekP5ViFdi" crossorigin="anonymous"> |
||
0 ignored issues
–
show
|
|||
241 | <link rel="stylesheet" href="css/font-awesome.min.css"> |
||
242 | <link rel="stylesheet" href="style.css" type="text/css"> |
||
243 | |||
244 | <link rel="shortcut icon" type="image/x-icon" href="./img/favicon/favicon.ico"> |
||
245 | <link rel="icon" type="image/x-icon" href="./img/favicon/favicon.ico"> |
||
246 | <link rel="icon" type="image/gif" href="./img/favicon/favicon.gif"> |
||
247 | <link rel="icon" type="image/png" href="./img/favicon/favicon.png"> |
||
248 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon.png"> |
||
249 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-57x57.png" sizes="57x57"> |
||
250 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-60x60.png" sizes="60x60"> |
||
251 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-72x72.png" sizes="72x72"> |
||
252 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-76x76.png" sizes="76x76"> |
||
253 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-114x114.png" sizes="114x114"> |
||
254 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-120x120.png" sizes="120x120"> |
||
255 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-128x128.png" sizes="128x128"> |
||
256 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-144x144.png" sizes="144x144"> |
||
257 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-152x152.png" sizes="152x152"> |
||
258 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-180x180.png" sizes="180x180"> |
||
259 | <link rel="apple-touch-icon" href="./img/favicon/apple-touch-icon-precomposed.png"> |
||
260 | <link rel="icon" type="image/png" href="./img/favicon/favicon-16x16.png" sizes="16x16"> |
||
261 | <link rel="icon" type="image/png" href="./img/favicon/favicon-32x32.png" sizes="32x32"> |
||
262 | <link rel="icon" type="image/png" href="./img/favicon/favicon-96x96.png" sizes="96x96"> |
||
263 | <link rel="icon" type="image/png" href="./img/favicon/favicon-160x160.png" sizes="160x160"> |
||
264 | <link rel="icon" type="image/png" href="./img/favicon/favicon-192x192.png" sizes="192x192"> |
||
265 | <link rel="icon" type="image/png" href="./img/favicon/favicon-196x196.png" sizes="196x196"> |
||
266 | <meta name="msapplication-TileImage" content="./img/favicon/win8-tile-144x144.png"> |
||
267 | <meta name="msapplication-TileColor" content="#5682a3"> |
||
268 | <meta name="msapplication-navbutton-color" content="#5682a3"> |
||
269 | <meta name="application-name" content="JodelBlue"/> |
||
270 | <meta name="msapplication-tooltip" content="JodelBlue"/> |
||
271 | <meta name="apple-mobile-web-app-title" content="JodelBlue"/> |
||
272 | <meta name="msapplication-square70x70logo" content="./img/favicon/win8-tile-70x70.png"> |
||
273 | <meta name="msapplication-square144x144logo" content="./img/favicon/win8-tile-144x144.png"> |
||
274 | <meta name="msapplication-square150x150logo" content="./img/favicon/win8-tile-150x150.png"> |
||
275 | <meta name="msapplication-wide310x150logo" content="./img/favicon/win8-tile-310x150.png"> |
||
276 | <meta name="msapplication-square310x310logo" content="./img/favicon/win8-tile-310x310.png"> |
||
277 | </head> |
||
278 | |||
279 | <body> |
||
280 | <header> |
||
281 | <nav class="navbar navbar-full navbar-dark navbar-fixed-top"> |
||
282 | <div class="container"> |
||
283 | <?php |
||
284 | if(isset($_GET['postID']) && isset($_GET['getPostDetails'])) |
||
285 | { |
||
286 | echo '<a id="comment-back" href="index.php?view=' . $view . '#postId-' . htmlspecialchars($_GET['postID']) . '">'; |
||
0 ignored issues
–
show
|
|||
287 | echo '<i class="fa fa-angle-left fa-3x"></i>'; |
||
288 | echo '</a>'; |
||
289 | echo '<h1>'; |
||
290 | echo '<a href="index.php?getPostDetails=' . htmlspecialchars($_GET['getPostDetails']) . '&postID=' . htmlspecialchars($_GET['postID']) . '" class="spinnable">'; |
||
0 ignored issues
–
show
|
|||
291 | } |
||
292 | else |
||
293 | { |
||
294 | echo '<h1>'; |
||
295 | echo '<a href="./" class="spinnable">'; |
||
296 | } |
||
297 | ?> |
||
298 | JodelBlue <i class="fa fa-refresh fa-1x"></i></a> |
||
299 | </h1> |
||
300 | |||
301 | <div id="location_mobile" class="hidden-sm-up"> |
||
302 | <form method="get"> |
||
303 | <input type="text" id="city_mobile" name="city" placeholder="<?php if(isset($newPositionStatus)) echo $newPositionStatus; ?>" required> |
||
0 ignored issues
–
show
|
|||
304 | |||
305 | <input type="submit" id="submit_mobile" class="fa" value="" /> |
||
306 | </form> |
||
307 | </div> |
||
308 | </div> |
||
309 | </nav> |
||
310 | </header> |
||
311 | |||
312 | <div class="mainContent container"> |
||
313 | <div class="content row"> |
||
314 | <article class="topContent col-sm-8"> |
||
315 | |||
316 | <content id="posts"> |
||
317 | <?php |
||
318 | $posts; |
||
319 | |||
320 | //Get Post Details |
||
321 | if(isset($_GET['postID']) && isset($_GET['getPostDetails'])) |
||
322 | { |
||
323 | $userHandleBuffer = []; |
||
324 | |||
325 | $accountCreator = new GetPostDetails(); |
||
326 | $accountCreator->setAccessToken($accessToken); |
||
327 | $data = $accountCreator->execute(); |
||
328 | |||
329 | $posts[0] = $data; |
||
330 | if(array_key_exists('children', $data)) { |
||
331 | foreach($data['children'] as $key => $child) |
||
332 | { |
||
333 | |||
334 | if(!$child["parent_creator"] == 1) |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
parent_creator does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
335 | { |
||
336 | $numberForUser = array_search($child['user_handle'], $userHandleBuffer); |
||
337 | if($numberForUser === FALSE) |
||
338 | { |
||
339 | array_push($userHandleBuffer, $child['user_handle']); |
||
340 | $data['children'][$key]['user_handle'] = count($userHandleBuffer); |
||
341 | } |
||
342 | else |
||
343 | { |
||
344 | $data['children'][$key]['user_handle'] = $numberForUser + 1; |
||
345 | } |
||
346 | } |
||
347 | |||
348 | array_push($posts, $data['children'][$key]); |
||
349 | } |
||
350 | $loops = $data['child_count'] + 1; |
||
351 | } |
||
352 | else |
||
353 | { |
||
354 | $loops = 1; |
||
355 | } |
||
356 | $isDetailedView = TRUE; |
||
357 | } |
||
358 | //Get Posts |
||
359 | else |
||
360 | { |
||
361 | $version = 'v2'; |
||
362 | if($view=='comment') |
||
363 | { |
||
364 | $url = "/v2/posts/location/discussed/"; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
/v2/posts/location/discussed/ does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
365 | } |
||
366 | else |
||
367 | { |
||
368 | if($view=='upVote') |
||
369 | { |
||
370 | $url = "/v2/posts/location/popular/"; |
||
0 ignored issues
–
show
Coding Style
Comprehensibility
introduced
by
The string literal
/v2/posts/location/popular/ does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
371 | } |
||
372 | else |
||
373 | { |
||
374 | $url = "/v3/posts/location/combo/"; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() Coding Style
Comprehensibility
introduced
by
The string literal
/v3/posts/location/combo/ does not require double quotes, as per coding-style, please use single quotes.
PHP provides two ways to mark string literals. Either with single quotes String literals in single quotes on the other hand are evaluated very literally and the only two
characters that needs escaping in the literal are the single quote itself ( Double quoted string literals may contain other variables or more complex escape sequences. <?php
$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";
print $doubleQuoted;
will print an indented: If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. ![]() |
|||
375 | $version = 'v3'; |
||
376 | } |
||
377 | } |
||
378 | |||
379 | if($version == 'v3') |
||
380 | { |
||
381 | $posts = getPosts($lastPostId, $accessToken, $url, $version)['recent']; |
||
382 | } |
||
383 | else |
||
384 | { |
||
385 | $posts = getPosts($lastPostId, $accessToken, $url, $version)['posts']; |
||
386 | } |
||
387 | $loops = 29; |
||
0 ignored issues
–
show
Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a";
$ab = "ab";
$abc = "abc";
will produce issues in the first and second line, while this second example $a = "a";
$ab = "ab";
$abc = "abc";
will produce no issues. ![]() |
|||
388 | $isDetailedView = FALSE; |
||
389 | } |
||
390 | |||
391 | |||
392 | for($i = 0; $i<$loops; $i++) |
||
393 | { |
||
394 | if(array_key_exists($i, $posts) && array_key_exists('post_id', $posts[$i]) && isset($posts[$i]['post_id'])) |
||
395 | { |
||
396 | $lastPostId = $posts[$i]['post_id']; |
||
397 | |||
398 | jodelToHtml($posts[$i], $view, $isDetailedView); |
||
399 | } |
||
400 | } ?> |
||
401 | |||
402 | </content> |
||
403 | |||
404 | <?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?> |
||
405 | <p id="loading"> |
||
406 | Loading… |
||
407 | </p> |
||
408 | <?php } ?> |
||
409 | </article> |
||
410 | |||
411 | <aside class="topSidebar col-sm-4 sidebar-outer"> |
||
412 | <div class="fixed"> |
||
413 | <article> |
||
414 | <div> |
||
415 | <h2>Position</h2> |
||
416 | <form method="get"> |
||
417 | <input type="text" id="city" name="city" placeholder="<?php if(isset($newPositionStatus)) echo $newPositionStatus; ?>" required> |
||
0 ignored issues
–
show
|
|||
418 | |||
419 | <input type="submit" value="Set Location" /> |
||
420 | </form> |
||
421 | </div> |
||
422 | </article> |
||
423 | |||
424 | <article> |
||
425 | <div> |
||
426 | <h2>Karma</h2> |
||
427 | <?php echo getKarma($accessToken_forId1); ?> |
||
428 | </div> |
||
429 | </article> |
||
430 | |||
431 | <article> |
||
432 | <div> |
||
433 | <?php if(isset($_GET['postID']) && isset($_GET['getPostDetails'])) { ?> |
||
434 | <h2>Comment on Jodel</h2> |
||
435 | <form method="POST"> |
||
436 | <input type="hidden" name="ancestor" value="<?php echo htmlspecialchars($_GET['postID']);?>" /> |
||
437 | <textarea id="message" name="message" placeholder="Send a comment on a Jodel to all students within 10km" required></textarea> |
||
0 ignored issues
–
show
|
|||
438 | <br /> |
||
439 | <input type="submit" value="SEND" /> |
||
440 | </form> |
||
441 | <?php } else { ?> |
||
442 | <h2>New Jodel</h2> |
||
443 | <form method="POST"> |
||
444 | <textarea id="message" name="message" placeholder="Send a Jodel to all students within 10km" required></textarea> |
||
0 ignored issues
–
show
|
|||
445 | <br /> |
||
446 | <select id="postColorPicker" name="color"> |
||
447 | <option value="06A3CB">Blue</option> |
||
448 | <option value="8ABDB0">Teal</option> |
||
449 | <option value="9EC41C">Green</option> |
||
450 | <option value="FFBA00">Yellow</option> |
||
451 | <option value="DD5F5F">Red</option> |
||
452 | <option value="FF9908">Orange</option> |
||
453 | </select> |
||
454 | <br /> |
||
455 | <input type="submit" value="SEND" /> |
||
456 | </form> |
||
457 | <?php } ?> |
||
458 | </div> |
||
459 | </article> |
||
460 | |||
461 | <article> |
||
462 | <div> |
||
463 | <h2>Login</h2> |
||
464 | </div> |
||
465 | </article> |
||
466 | </div> |
||
467 | </aside> |
||
468 | </div> |
||
469 | <div id="sortJodelBy" class="row"> |
||
470 | <div class="col-xs-12"> |
||
471 | <div class="row"> |
||
472 | <div class="col-xs-3"> |
||
473 | <a href="index.php" <?php if($view=='time') echo 'class="active"';?>><i class="fa fa-clock-o fa-3x"></i></a> |
||
474 | </div> |
||
475 | <div class="col-xs-3"> |
||
476 | <a href="index.php?view=comment" <?php if($view=='comment') echo 'class="active"';?>><i class="fa fa-commenting-o fa-3x"></i></a> |
||
0 ignored issues
–
show
|
|||
477 | </div> |
||
478 | <div class="col-xs-3"> |
||
479 | <a href="index.php?view=upVote" <?php if($view=='upVote') echo 'class="active"';?>><i class="fa fa-angle-up fa-3x"></i></a> |
||
0 ignored issues
–
show
|
|||
480 | </div> |
||
481 | <div class="col-xs-3"> |
||
482 | <nav> |
||
483 | <a href="./about-us.html">about us</a> |
||
484 | </nav> |
||
485 | </div> |
||
486 | </div> |
||
487 | </div> |
||
488 | </div> |
||
489 | </div> |
||
490 | |||
491 | |||
492 | <!-- jQuery, Tether, Bootstrap JS and own--> |
||
493 | <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.1.1/jquery.min.js" integrity="sha384-3ceskX3iaEnIogmQchP8opvBy3Mi7Ce34nWjpBIwVTHfGYWQS9jwHDVRnpKKHJg7" crossorigin="anonymous"></script> |
||
0 ignored issues
–
show
|
|||
494 | <script src="https://cdnjs.cloudflare.com/ajax/libs/tether/1.3.7/js/tether.min.js" integrity="sha384-XTs3FgkjiBgo8qjEjBk0tGmf3wPrWtA6coPfQDfFEY8AnYJwjalXCiosYRBIBZX8" crossorigin="anonymous"></script> |
||
0 ignored issues
–
show
|
|||
495 | <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.5/js/bootstrap.min.js" integrity="sha384-BLiI7JTZm+JWlgKa0M0kGRpJbF2J8q+qreVrKBC47e3K6BW78kGLrCkeRX6I9RoK" crossorigin="anonymous"></script> |
||
0 ignored issues
–
show
|
|||
496 | <script src="js/jQueryEmoji.js"></script> |
||
497 | |||
498 | <script> |
||
499 | //BackButton |
||
500 | function goBack() |
||
501 | { |
||
502 | window.history.back(); |
||
503 | } |
||
504 | |||
505 | $(document).ready(function() |
||
506 | { |
||
507 | |||
508 | |||
509 | //Transform UTF-8 Emoji to img |
||
510 | $('.jodel > content').Emoji(); |
||
511 | |||
512 | $('a').on('click', function(){ |
||
513 | $('a').removeClass('selected'); |
||
514 | $(this).addClass('selected'); |
||
515 | }); |
||
516 | |||
517 | function scrollToAnchor(aid){ |
||
518 | var aTag = $("article[id='"+ aid +"']"); |
||
519 | $('html,body').animate({scrollTop: aTag.offset().top-90},'slow'); |
||
520 | } |
||
521 | |||
522 | <?php if(!isset($_GET['postID']) && !isset($_GET['getPostDetails'])) { ?> |
||
523 | |||
524 | |||
525 | |||
526 | |||
527 | |||
528 | var win = $(window); |
||
529 | var lastPostId = "<?php echo $lastPostId; ?>"; |
||
530 | var view = "<?php echo $view; ?>" |
||
531 | var old_lastPostId = ""; |
||
532 | var morePostsAvailable = true; |
||
533 | |||
534 | if(window.location.hash) |
||
535 | { |
||
536 | var hash = window.location.hash.slice(1); |
||
537 | |||
538 | if(!$("article[id='"+ hash +"']").length) |
||
539 | { |
||
540 | for (var i = 5; i >= 0; i--) |
||
541 | { |
||
542 | if(!$("article[id='"+ hash +"']").length) |
||
543 | { |
||
544 | $.ajax({ |
||
545 | url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view, |
||
546 | dataType: 'html', |
||
547 | async: false, |
||
548 | success: function(html) { |
||
549 | var div = document.createElement('div'); |
||
550 | div.innerHTML = html; |
||
551 | var elements = div.childNodes; |
||
552 | old_lastPostId = lastPostId; |
||
553 | lastPostId = elements[3].textContent; |
||
554 | lastPostId = lastPostId.replace(/\s+/g, ''); |
||
555 | //alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId); |
||
556 | if(lastPostId == old_lastPostId) { |
||
557 | |||
558 | //morePostsAvailable = false; |
||
559 | } |
||
560 | else { |
||
561 | //alert(elements[3].textContent); |
||
562 | $('#posts').append(elements[1].innerHTML); |
||
563 | $('#posts').hide().show(0); |
||
564 | } |
||
565 | $('#loading').hide(); |
||
566 | } |
||
567 | }); |
||
568 | |||
569 | $('.jodel > content').Emoji(); |
||
570 | } |
||
571 | |||
572 | } |
||
573 | scrollToAnchor(hash); |
||
574 | |||
575 | } |
||
576 | } |
||
577 | |||
578 | // Each time the user scrolls |
||
579 | win.scroll(function() { |
||
580 | |||
581 | |||
582 | // End of the document reached? |
||
583 | if ($(window).scrollTop() + $(window).height() > $(document).height() - 100 && morePostsAvailable) |
||
584 | { |
||
585 | $('#loading').show(); |
||
586 | |||
587 | $.ajax({ |
||
588 | url: 'get-posts-ajax.php?lastPostId=' + lastPostId + '&view=' + view, |
||
589 | dataType: 'html', |
||
590 | async: false, |
||
591 | success: function(html) { |
||
592 | var div = document.createElement('div'); |
||
593 | div.innerHTML = html; |
||
594 | var elements = div.childNodes; |
||
595 | old_lastPostId = lastPostId; |
||
596 | lastPostId = elements[3].textContent; |
||
597 | lastPostId = lastPostId.replace(/\s+/g, ''); |
||
598 | //alert('Neu: ' + lastPostId + " Alt: " + old_lastPostId); |
||
599 | if(lastPostId == old_lastPostId) |
||
600 | { |
||
601 | |||
602 | //morePostsAvailable = false; |
||
603 | } |
||
604 | else |
||
605 | { |
||
606 | //alert(elements[3].textContent); |
||
607 | $('#posts').append(elements[1].innerHTML); |
||
608 | } |
||
609 | $('#loading').hide(); |
||
610 | } |
||
611 | }); |
||
612 | |||
613 | $('.jodel > content').Emoji(); |
||
614 | } |
||
615 | }); |
||
616 | <?php } ?> |
||
617 | }); |
||
618 | |||
619 | </script> |
||
620 | </body> |
||
621 | </html> |
||
622 | |||
0 ignored issues
–
show
|
|||
623 |
This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line.
To visualize
will produce issues in the first and second line, while this second example
will produce no issues.