Issues in get-posts-ajax.php - All Issues - Inspection of "Add saving vote type in database" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#8)

unknown

created 2017-02-03 21:52 UTC

get-posts-ajax.php (12 issues)

Labels

Severity

Informational 12

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
error_reporting(-1);

include 'php/jodel-web.php';

$config = parse_ini_file('config/config.ini.php');

$location = new Location();
$location->setLat($config['default_lat']);
$location->setLng($config['default_lng']);
$location->setCityName($config['default_location']);

$accessToken;
$accessToken_forId1;
$deviceUid;


if(!isset($_COOKIE["JodelDeviceId"]))
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
{
	$deviceUid = createAccount();
	setcookie("JodelDeviceId", $deviceUid, time()+60*60*24*365*10);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	
}
else
{
	$deviceUid = $db->real_escape_string($_COOKIE["JodelDeviceId"]);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
}

$location = getLocationByDeviceUid($deviceUid);
$a = "a";
$ab = "ab";
$abc = "abc";
$newPositionStatus = $location->getCityName();
$accessToken = isTokenFreshByDeviceUid($location, $deviceUid);
$a = "a";
$ab = "ab";
$abc = "abc";
//Acc is fresh. token and location is set

$accessToken_forId1 = isTokenFresh($location);



	if(isset($_GET['view']))

	{
		switch ($_GET['view']) {
			case 'comment':
				$view = 'comment';
				break;
			
			case 'upVote':
				$view = 'upVote';
				break;

			default:
				$view = 'time';
				break;
		}
	}
	else
	{
		$view = 'time';
	}

	if($view=='comment')
	{
		$url = "/v2/posts/location/discussed/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}
	else
	{
		if($view=='upVote')
		{
			$url = "/v2/posts/location/popular/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
		else
		{
			$url = "/v2/posts/location/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
	}

	if(isset($_GET['lastPostId']))
	{
		$lastPostId = htmlspecialchars($_GET['lastPostId']);
		
		$posts = getPosts($lastPostId, $accessToken, $url)['posts'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$loops = 29;
$a = "a";
$ab = "ab";
$abc = "abc";
		$showCommentIcon = TRUE;
		?>
		<div class="nextPosts">
		<?php
		for($i = 0; $i<$loops; $i++)
		{
			if(isset($posts[$i]))
			{
				$lastPostId = $posts[$i]['post_id'];
				jodelToHtml($posts[$i], $view);	
			}
		}
		?>
		</div>
		<div class="lastPostId">
		<?php echo $lastPostId; ?>
		</div>
		<?php
	}



1		<?php
2		error_reporting(-1);
3
4		include 'php/jodel-web.php';
5
6		$config = parse_ini_file('config/config.ini.php');
7
8		$location = new Location();
9		$location->setLat($config['default_lat']);
10		$location->setLng($config['default_lng']);
11		$location->setCityName($config['default_location']);
12
13		$accessToken;
14		$accessToken_forId1;
15		$deviceUid;
16
17
18		if(!isset($_COOKIE["JodelDeviceId"]))
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-09 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `JodelDeviceId` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
19		{
20		$deviceUid = createAccount();
21		setcookie("JodelDeviceId", $deviceUid, time()+60602436510);
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-09 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `JodelDeviceId` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
22
23		}
24		else
25		{
26		$deviceUid = $db->real_escape_string($_COOKIE["JodelDeviceId"]);
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-09 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `JodelDeviceId` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
27		}
28
29		$location = getLocationByDeviceUid($deviceUid);
		0 ignored issues – show Coding Style introduced 2016-12-09 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
30		$newPositionStatus = $location->getCityName();
31		$accessToken = isTokenFreshByDeviceUid($location, $deviceUid);
		0 ignored issues – show Coding Style introduced 2016-12-09 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
32		//Acc is fresh. token and location is set
33
34		$accessToken_forId1 = isTokenFresh($location);
35
36
37
38	View Code Duplication	if(isset($_GET['view']))
		0 ignored issues – show Duplication introduced 2016-11-20 16:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
39		{
40		switch ($_GET['view']) {
41		case 'comment':
42		$view = 'comment';
43		break;
44
45		case 'upVote':
46		$view = 'upVote';
47		break;
48
49		default:
50		$view = 'time';
51		break;
52		}
53		}
54		else
55		{
56		$view = 'time';
57		}
58
59		if($view=='comment')
60		{
61		$url = "/v2/posts/location/discussed/";
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-26 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `/v2/posts/location/discussed/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
62		}
63		else
64		{
65		if($view=='upVote')
66		{
67		$url = "/v2/posts/location/popular/";
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-26 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `/v2/posts/location/popular/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
68		}
69		else
70		{
71		$url = "/v2/posts/location/";
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-11-26 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `/v2/posts/location/` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
72		}
73		}
74
75		if(isset($_GET['lastPostId']))
76		{
77		$lastPostId = htmlspecialchars($_GET['lastPostId']);
78
79		$posts = getPosts($lastPostId, $accessToken, $url)['posts'];
		0 ignored issues – show Coding Style introduced 2016-11-30 19:24 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
80		$loops = 29;
		0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
81		$showCommentIcon = TRUE;
82		?>
83		<div class="nextPosts">
84		<?php
85		for($i = 0; $i<$loops; $i++)
86		{
87		if(isset($posts[$i]))
88		{
89		$lastPostId = $posts[$i]['post_id'];
90		jodelToHtml($posts[$i], $view);
91		}
92		}
93		?>
94		</div>
95		<div class="lastPostId">
96		<?php echo $lastPostId; ?>
97		</div>
98		<?php
99		}
		0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
100

mmainstreet / jodel-web

Pull Request — master (#8)

get-posts-ajax.php (12 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like