mmainstreet / jodel-web

php/Requests/SetLocation.php

Braces +2 added lines, -1 removed lines

@@ -1,7 +1,8 @@
 <?php
 
 
-class SetLocation extends AbstractRequest {
+class SetLocation extends AbstractRequest
+{
 		 /**
      * @var Location
      */

Indentation +30 added lines, -30 removed lines

@@ -3,37 +3,37 @@
 
 class SetLocation extends AbstractRequest {
 		 /**
-     * @var Location
-     */
-    public $location;
-    /**
-     * @return Location
-     */
-    public function getLocation()
-    {
-        return $this->location;
-    }
-    /**
-     * @param Location $location
-     */
-    public function setLocation($location)
-    {
-        $this->location = $location;
-    }
+		  * @var Location
+		  */
+	public $location;
+	/**
+	 * @return Location
+	 */
+	public function getLocation()
+	{
+		return $this->location;
+	}
+	/**
+	 * @param Location $location
+	 */
+	public function setLocation($location)
+	{
+		$this->location = $location;
+	}
 		
-    function getApiEndPoint()
-    {
-        return '/v2/users/location';
-    }
-    function getPayload()
-    {
-        return array(
+	function getApiEndPoint()
+	{
+		return '/v2/users/location';
+	}
+	function getPayload()
+	{
+		return array(
 			"location" => $this->getLocation()->toArray(),
-        );
-    }
-    function getMethod()
-    {
-        return 'PUT';
-    }
+		);
+	}
+	function getMethod()
+	{
+		return 'PUT';
+	}
 }
 

php/Requests/libary/Requests/Cookie/Jar.php

Spacing +10 added lines, -10 removed lines

@@ -36,7 +36,7 @@ 
 	 * @return Requests_Cookie
 	 */
 	public function normalize_cookie($cookie, $key = null) {
-		if ($cookie instanceof Requests_Cookie) {
+		if($cookie instanceof Requests_Cookie) {
 			return $cookie;
 		}
 
@@ -71,7 +71,7 @@ 
 	 * @return string Item value
 	 */
 	public function offsetGet($key) {
-		if (!isset($this->cookies[$key])) {
+		if(!isset($this->cookies[$key])) {
 			return null;
 		}
 
@@ -87,7 +87,7 @@ 
 	 * @param string $value Item value
 	 */
 	public function offsetSet($key, $value) {
-		if ($key === null) {
+		if($key === null) {
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 
@@ -134,21 +134,21 @@ 
 	 * @param array $options
 	 */
 	public function before_request($url, &$headers, &$data, &$type, &$options) {
-		if (!$url instanceof Requests_IRI) {
+		if(!$url instanceof Requests_IRI) {
 			$url = new Requests_IRI($url);
 		}
 
-		if (!empty($this->cookies)) {
+		if(!empty($this->cookies)) {
 			$cookies = array();
-			foreach ($this->cookies as $key => $cookie) {
+			foreach($this->cookies as $key => $cookie) {
 				$cookie = $this->normalize_cookie($cookie, $key);
 
 				// Skip expired cookies
-				if ($cookie->is_expired()) {
+				if($cookie->is_expired()) {
 					continue;
 				}
 
-				if ($cookie->domain_matches($url->host)) {
+				if($cookie->domain_matches($url->host)) {
 					$cookies[] = $cookie->format_for_header();
 				}
 			}
@@ -162,9 +162,9 @@ 
 	 *
 	 * @var Requests_Response $response
 	 */
-	public function before_redirect_check(Requests_Response &$return) {
+	public function before_redirect_check(Requests_Response&$return) {
 		$url = $return->url;
-		if (!$url instanceof Requests_IRI) {
+		if(!$url instanceof Requests_IRI) {
 			$url = new Requests_IRI($url);
 		}
 

Braces +40 added lines, -20 removed lines

@@ -25,7 +25,8 @@ 
 	 *
 	 * @param array $cookies Existing cookie values
 	 */
-	public function __construct($cookies = array()) {
+	public function __construct($cookies = array())
+	{
 		$this->cookies = $cookies;
 	}
 
@@ -35,8 +36,10 @@ 
 	 * @param string|Requests_Cookie $cookie
 	 * @return Requests_Cookie
 	 */
-	public function normalize_cookie($cookie, $key = null) {
-		if ($cookie instanceof Requests_Cookie) {
+	public function normalize_cookie($cookie, $key = null)
+	{
+		if ($cookie instanceof Requests_Cookie)
+		{
 			return $cookie;
 		}
 
@@ -50,7 +53,8 @@ 
 	 * @deprecated Use {@see Requests_Cookie_Jar::normalize_cookie}
 	 * @return Requests_Cookie
 	 */
-	public function normalizeCookie($cookie, $key = null) {
+	public function normalizeCookie($cookie, $key = null)
+	{
 		return $this->normalize_cookie($cookie, $key);
 	}
 
@@ -60,7 +64,8 @@ 
 	 * @param string $key Item key
 	 * @return boolean Does the item exist?
 	 */
-	public function offsetExists($key) {
+	public function offsetExists($key)
+	{
 		return isset($this->cookies[$key]);
 	}
 
@@ -70,8 +75,10 @@ 
 	 * @param string $key Item key
 	 * @return string Item value
 	 */
-	public function offsetGet($key) {
-		if (!isset($this->cookies[$key])) {
+	public function offsetGet($key)
+	{
+		if (!isset($this->cookies[$key]))
+		{
 			return null;
 		}
 
@@ -86,8 +93,10 @@ 
 	 * @param string $key Item name
 	 * @param string $value Item value
 	 */
-	public function offsetSet($key, $value) {
-		if ($key === null) {
+	public function offsetSet($key, $value)
+	{
+		if ($key === null)
+		{
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 
@@ -99,7 +108,8 @@ 
 	 *
 	 * @param string $key
 	 */
-	public function offsetUnset($key) {
+	public function offsetUnset($key)
+	{
 		unset($this->cookies[$key]);
 	}
 
@@ -108,7 +118,8 @@ 
 	 *
 	 * @return ArrayIterator
 	 */
-	public function getIterator() {
+	public function getIterator()
+	{
 		return new ArrayIterator($this->cookies);
 	}
 
@@ -117,7 +128,8 @@ 
 	 *
 	 * @param Requests_Hooker $hooks Hooking system
 	 */
-	public function register(Requests_Hooker $hooks) {
+	public function register(Requests_Hooker $hooks)
+	{
 		$hooks->register('requests.before_request', array($this, 'before_request'));
 		$hooks->register('requests.before_redirect_check', array($this, 'before_redirect_check'));
 	}
@@ -133,22 +145,28 @@ 
 	 * @param string $type
 	 * @param array $options
 	 */
-	public function before_request($url, &$headers, &$data, &$type, &$options) {
-		if (!$url instanceof Requests_IRI) {
+	public function before_request($url, &$headers, &$data, &$type, &$options)
+	{
+		if (!$url instanceof Requests_IRI)
+		{
 			$url = new Requests_IRI($url);
 		}
 
-		if (!empty($this->cookies)) {
+		if (!empty($this->cookies))
+		{
 			$cookies = array();
-			foreach ($this->cookies as $key => $cookie) {
+			foreach ($this->cookies as $key => $cookie)
+			{
 				$cookie = $this->normalize_cookie($cookie, $key);
 
 				// Skip expired cookies
-				if ($cookie->is_expired()) {
+				if ($cookie->is_expired())
+				{
 					continue;
 				}
 
-				if ($cookie->domain_matches($url->host)) {
+				if ($cookie->domain_matches($url->host))
+				{
 					$cookies[] = $cookie->format_for_header();
 				}
 			}
@@ -162,9 +180,11 @@ 
 	 *
 	 * @var Requests_Response $response
 	 */
-	public function before_redirect_check(Requests_Response &$return) {
+	public function before_redirect_check(Requests_Response &$return)
+	{
 		$url = $return->url;
-		if (!$url instanceof Requests_IRI) {
+		if (!$url instanceof Requests_IRI)
+		{
 			$url = new Requests_IRI($url);
 		}
 

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -35,7 +35,7 @@ 
 	 * @param string|Requests_Cookie $cookie
 	 * @return Requests_Cookie
 	 */
-	public function normalize_cookie($cookie, $key = null) {
+	public function normalize_cookie($cookie, $key = NULL) {
 		if ($cookie instanceof Requests_Cookie) {
 			return $cookie;
 		}
@@ -50,7 +50,7 @@ 
 	 * @deprecated Use {@see Requests_Cookie_Jar::normalize_cookie}
 	 * @return Requests_Cookie
 	 */
-	public function normalizeCookie($cookie, $key = null) {
+	public function normalizeCookie($cookie, $key = NULL) {
 		return $this->normalize_cookie($cookie, $key);
 	}
 
@@ -72,7 +72,7 @@ 
 	 */
 	public function offsetGet($key) {
 		if (!isset($this->cookies[$key])) {
-			return null;
+			return NULL;
 		}
 
 		return $this->cookies[$key];
@@ -87,7 +87,7 @@ 
 	 * @param string $value Item value
 	 */
 	public function offsetSet($key, $value) {
-		if ($key === null) {
+		if ($key === NULL) {
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 

php/Requests/libary/Requests/Proxy/HTTP.php

Spacing +7 added lines, -7 removed lines

@@ -55,14 +55,14 @@ 
 	 * @param array|null $args Array of user and password. Must have exactly two elements
 	 */
 	public function __construct($args = null) {
-		if (is_string($args)) {
+		if(is_string($args)) {
 			$this->proxy = $args;
 		}
-		elseif (is_array($args)) {
-			if (count($args) == 1) {
+		elseif(is_array($args)) {
+			if(count($args) == 1) {
 				list($this->proxy) = $args;
 			}
-			elseif (count($args) == 3) {
+			elseif(count($args) == 3) {
 				list($this->proxy, $this->user, $this->pass) = $args;
 				$this->use_authentication = true;
 			}
@@ -82,12 +82,12 @@ 
 	 * @see fsockopen_header
 	 * @param Requests_Hooks $hooks Hook system
 	 */
-	public function register(Requests_Hooks &$hooks) {
+	public function register(Requests_Hooks&$hooks) {
 		$hooks->register('curl.before_send', array(&$this, 'curl_before_send'));
 
 		$hooks->register('fsockopen.remote_socket', array(&$this, 'fsockopen_remote_socket'));
 		$hooks->register('fsockopen.remote_host_path', array(&$this, 'fsockopen_remote_host_path'));
-		if ($this->use_authentication) {
+		if($this->use_authentication) {
 			$hooks->register('fsockopen.after_headers', array(&$this, 'fsockopen_header'));
 		}
 	}
@@ -102,7 +102,7 @@ 
 		curl_setopt($handle, CURLOPT_PROXYTYPE, CURLPROXY_HTTP);
 		curl_setopt($handle, CURLOPT_PROXY, $this->proxy);
 
-		if ($this->use_authentication) {
+		if($this->use_authentication) {
 			curl_setopt($handle, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
 			curl_setopt($handle, CURLOPT_PROXYUSERPWD, $this->get_auth_string());
 		}

Braces +30 added lines, -15 removed lines

@@ -16,7 +16,8 @@ 
  * @subpackage Proxy
  * @since 1.6
  */
-class Requests_Proxy_HTTP implements Requests_Proxy {
+class Requests_Proxy_HTTP implements Requests_Proxy
+{
 	/**
 	 * Proxy host and port
 	 *
@@ -54,19 +55,25 @@ 
 	 * @throws Requests_Exception On incorrect number of arguments (`authbasicbadargs`)
 	 * @param array|null $args Array of user and password. Must have exactly two elements
 	 */
-	public function __construct($args = null) {
-		if (is_string($args)) {
+	public function __construct($args = null)
+	{
+		if (is_string($args))
+		{
 			$this->proxy = $args;
 		}
-		elseif (is_array($args)) {
-			if (count($args) == 1) {
+		elseif (is_array($args))
+		{
+			if (count($args) == 1)
+			{
 				list($this->proxy) = $args;
 			}
-			elseif (count($args) == 3) {
+			elseif (count($args) == 3)
+			{
 				list($this->proxy, $this->user, $this->pass) = $args;
 				$this->use_authentication = true;
 			}
-			else {
+			else
+			{
 				throw new Requests_Exception('Invalid number of arguments', 'proxyhttpbadargs');
 			}
 		}
@@ -82,12 +89,14 @@ 
 	 * @see fsockopen_header
 	 * @param Requests_Hooks $hooks Hook system
 	 */
-	public function register(Requests_Hooks &$hooks) {
+	public function register(Requests_Hooks &$hooks)
+	{
 		$hooks->register('curl.before_send', array(&$this, 'curl_before_send'));
 
 		$hooks->register('fsockopen.remote_socket', array(&$this, 'fsockopen_remote_socket'));
 		$hooks->register('fsockopen.remote_host_path', array(&$this, 'fsockopen_remote_host_path'));
-		if ($this->use_authentication) {
+		if ($this->use_authentication)
+		{
 			$hooks->register('fsockopen.after_headers', array(&$this, 'fsockopen_header'));
 		}
 	}
@@ -98,11 +107,13 @@ 
 	 * @since 1.6
 	 * @param resource $handle cURL resource
 	 */
-	public function curl_before_send(&$handle) {
+	public function curl_before_send(&$handle)
+	{
 		curl_setopt($handle, CURLOPT_PROXYTYPE, CURLPROXY_HTTP);
 		curl_setopt($handle, CURLOPT_PROXY, $this->proxy);
 
-		if ($this->use_authentication) {
+		if ($this->use_authentication)
+		{
 			curl_setopt($handle, CURLOPT_PROXYAUTH, CURLAUTH_ANY);
 			curl_setopt($handle, CURLOPT_PROXYUSERPWD, $this->get_auth_string());
 		}
@@ -114,7 +125,8 @@ 
 	 * @since 1.6
 	 * @param string $remote_socket Socket connection string
 	 */
-	public function fsockopen_remote_socket(&$remote_socket) {
+	public function fsockopen_remote_socket(&$remote_socket)
+	{
 		$remote_socket = $this->proxy;
 	}
 
@@ -125,7 +137,8 @@ 
 	 * @param string $path Path to send in HTTP request string ("GET ...")
 	 * @param string $url Full URL we're requesting
 	 */
-	public function fsockopen_remote_host_path(&$path, $url) {
+	public function fsockopen_remote_host_path(&$path, $url)
+	{
 		$path = $url;
 	}
 
@@ -135,7 +148,8 @@ 
 	 * @since 1.6
 	 * @param string $out HTTP header string
 	 */
-	public function fsockopen_header(&$out) {
+	public function fsockopen_header(&$out)
+	{
 		$out .= sprintf("Proxy-Authorization: Basic %s\r\n", base64_encode($this->get_auth_string()));
 	}
 
@@ -145,7 +159,8 @@ 
 	 * @since 1.6
 	 * @return string
 	 */
-	public function get_auth_string() {
+	public function get_auth_string()
+	{
 		return $this->user . ':' . $this->pass;
 	}
 }
\ No newline at end of file

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
 	 * @throws Requests_Exception On incorrect number of arguments (`authbasicbadargs`)
 	 * @param array|null $args Array of user and password. Must have exactly two elements
 	 */
-	public function __construct($args = null) {
+	public function __construct($args = NULL) {
 		if (is_string($args)) {
 			$this->proxy = $args;
 		}
@@ -64,7 +64,7 @@ 
 			}
 			elseif (count($args) == 3) {
 				list($this->proxy, $this->user, $this->pass) = $args;
-				$this->use_authentication = true;
+				$this->use_authentication = TRUE;
 			}
 			else {
 				throw new Requests_Exception('Invalid number of arguments', 'proxyhttpbadargs');

php/Requests/libary/Requests/Transport/cURL.php

Spacing +50 added lines, -50 removed lines

@@ -96,14 +96,14 @@ 
 
 		curl_setopt($this->handle, CURLOPT_HEADER, false);
 		curl_setopt($this->handle, CURLOPT_RETURNTRANSFER, 1);
-		if ($this->version >= self::CURL_7_10_5) {
+		if($this->version >= self::CURL_7_10_5) {
 			curl_setopt($this->handle, CURLOPT_ENCODING, '');
 		}
-		if (defined('CURLOPT_PROTOCOLS')) {
-			curl_setopt($this->handle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS);
+		if(defined('CURLOPT_PROTOCOLS')) {
+			curl_setopt($this->handle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP|CURLPROTO_HTTPS);
 		}
-		if (defined('CURLOPT_REDIR_PROTOCOLS')) {
-			curl_setopt($this->handle, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS);
+		if(defined('CURLOPT_REDIR_PROTOCOLS')) {
+			curl_setopt($this->handle, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP|CURLPROTO_HTTPS);
 		}
 	}
 
@@ -111,7 +111,7 @@ 
 	 * Destructor
 	 */
 	public function __destruct() {
-		if (is_resource($this->handle)) {
+		if(is_resource($this->handle)) {
 			curl_close($this->handle);
 		}
 	}
@@ -134,28 +134,28 @@ 
 
 		$options['hooks']->dispatch('curl.before_send', array(&$this->handle));
 
-		if ($options['filename'] !== false) {
+		if($options['filename'] !== false) {
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
 		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		if($options['max_bytes'] !== false) {
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 
-		if (isset($options['verify'])) {
-			if ($options['verify'] === false) {
+		if(isset($options['verify'])) {
+			if($options['verify'] === false) {
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYPEER, 0);
 			}
-			elseif (is_string($options['verify'])) {
+			elseif(is_string($options['verify'])) {
 				curl_setopt($this->handle, CURLOPT_CAINFO, $options['verify']);
 			}
 		}
 
-		if (isset($options['verifyname']) && $options['verifyname'] === false) {
+		if(isset($options['verifyname']) && $options['verifyname'] === false) {
 			curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 		}
 
@@ -164,7 +164,7 @@ 
 
 		$options['hooks']->dispatch('curl.after_send', array());
 
-		if (curl_errno($this->handle) === 23 || curl_errno($this->handle) === 61) {
+		if(curl_errno($this->handle) === 23 || curl_errno($this->handle) === 61) {
 			// Reset encoding and try again
 			curl_setopt($this->handle, CURLOPT_ENCODING, 'none');
 
@@ -193,7 +193,7 @@ 
 	 */
 	public function request_multiple($requests, $options) {
 		// If you're not requesting, we can't get any responses ¯\_(ツ)_/¯
-		if (empty($requests)) {
+		if(empty($requests)) {
 			return array();
 		}
 
@@ -202,7 +202,7 @@ 
 		$subhandles = array();
 
 		$class = get_class($this);
-		foreach ($requests as $id => $request) {
+		foreach($requests as $id => $request) {
 			$subrequests[$id] = new $class();
 			$subhandles[$id] = $subrequests[$id]->get_subrequest_handle($request['url'], $request['headers'], $request['data'], $request['options']);
 			$request['options']['hooks']->dispatch('curl.before_multi_add', array(&$subhandles[$id]));
@@ -220,22 +220,22 @@ 
 			do {
 				$status = curl_multi_exec($multihandle, $active);
 			}
-			while ($status === CURLM_CALL_MULTI_PERFORM);
+			while($status === CURLM_CALL_MULTI_PERFORM);
 
 			$to_process = array();
 
 			// Read the information as needed
-			while ($done = curl_multi_info_read($multihandle)) {
+			while($done = curl_multi_info_read($multihandle)) {
 				$key = array_search($done['handle'], $subhandles, true);
-				if (!isset($to_process[$key])) {
+				if(!isset($to_process[$key])) {
 					$to_process[$key] = $done;
 				}
 			}
 
 			// Parse the finished requests before we start getting the new ones
-			foreach ($to_process as $key => $done) {
+			foreach($to_process as $key => $done) {
 				$options = $requests[$key]['options'];
-				if (CURLE_OK !== $done['result']) {
+				if(CURLE_OK !== $done['result']) {
 					//get error string for handle.
 					$reason = curl_error($done['handle']);
 					$exception = new Requests_Exception_Transport_cURL(
@@ -256,13 +256,13 @@ 
 				curl_multi_remove_handle($multihandle, $done['handle']);
 				curl_close($done['handle']);
 
-				if (!is_string($responses[$key])) {
+				if(!is_string($responses[$key])) {
 					$options['hooks']->dispatch('multiple.request.complete', array(&$responses[$key], $key));
 				}
 				$completed++;
 			}
 		}
-		while ($active || $completed < count($subrequests));
+		while($active || $completed < count($subrequests));
 
 		$request['options']['hooks']->dispatch('curl.after_multi_exec', array(&$multihandle));
 
@@ -283,14 +283,14 @@ 
 	public function &get_subrequest_handle($url, $headers, $data, $options) {
 		$this->setup_handle($url, $headers, $data, $options);
 
-		if ($options['filename'] !== false) {
+		if($options['filename'] !== false) {
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
 		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		if($options['max_bytes'] !== false) {
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 		$this->hooks = $options['hooks'];
@@ -310,25 +310,25 @@ 
 		$options['hooks']->dispatch('curl.before_request', array(&$this->handle));
 
 		// Force closing the connection for old versions of cURL (<7.22).
-		if ( ! isset( $headers['Connection'] ) ) {
+		if(!isset($headers['Connection'])) {
 			$headers['Connection'] = 'close';
 		}
 
 		$headers = Requests::flatten($headers);
 
-		if (!empty($data)) {
+		if(!empty($data)) {
 			$data_format = $options['data_format'];
 
-			if ($data_format === 'query') {
+			if($data_format === 'query') {
 				$url = self::format_get($url, $data);
 				$data = '';
 			}
-			elseif (!is_string($data)) {
+			elseif(!is_string($data)) {
 				$data = http_build_query($data, null, '&');
 			}
 		}
 
-		switch ($options['type']) {
+		switch($options['type']) {
 			case Requests::POST:
 				curl_setopt($this->handle, CURLOPT_POST, true);
 				curl_setopt($this->handle, CURLOPT_POSTFIELDS, $data);
@@ -346,7 +346,7 @@ 
 			case Requests::OPTIONS:
 			default:
 				curl_setopt($this->handle, CURLOPT_CUSTOMREQUEST, $options['type']);
-				if (!empty($data)) {
+				if(!empty($data)) {
 					curl_setopt($this->handle, CURLOPT_POSTFIELDS, $data);
 				}
 		}
@@ -359,14 +359,14 @@ 
 		// https://github.com/curl/curl/blob/4f45240bc84a9aa648c8f7243be7b79e9f9323a5/lib/hostip.c#L606-L609
 		$timeout = max($options['timeout'], 1);
 
-		if (is_int($timeout) || $this->version < self::CURL_7_16_2) {
+		if(is_int($timeout) || $this->version < self::CURL_7_16_2) {
 			curl_setopt($this->handle, CURLOPT_TIMEOUT, ceil($timeout));
 		}
 		else {
 			curl_setopt($this->handle, CURLOPT_TIMEOUT_MS, round($timeout * 1000));
 		}
 
-		if (is_int($options['connect_timeout']) || $this->version < self::CURL_7_16_2) {
+		if(is_int($options['connect_timeout']) || $this->version < self::CURL_7_16_2) {
 			curl_setopt($this->handle, CURLOPT_CONNECTTIMEOUT, ceil($options['connect_timeout']));
 		}
 		else {
@@ -375,17 +375,17 @@ 
 		curl_setopt($this->handle, CURLOPT_URL, $url);
 		curl_setopt($this->handle, CURLOPT_REFERER, $url);
 		curl_setopt($this->handle, CURLOPT_USERAGENT, $options['useragent']);
-		if (!empty($headers)) {
+		if(!empty($headers)) {
 			curl_setopt($this->handle, CURLOPT_HTTPHEADER, $headers);
 		}
-		if ($options['protocol_version'] === 1.1) {
+		if($options['protocol_version'] === 1.1) {
 			curl_setopt($this->handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
 		}
 		else {
 			curl_setopt($this->handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
 		}
 
-		if (true === $options['blocking']) {
+		if(true === $options['blocking']) {
 			curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, array(&$this, 'stream_headers'));
 			curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, array(&$this, 'stream_body'));
 			curl_setopt($this->handle, CURLOPT_BUFFERSIZE, Requests::BUFFER_SIZE);
@@ -400,12 +400,12 @@ 
 	 * @return string HTTP response data including headers
 	 */
 	public function process_response($response, $options) {
-		if ($options['blocking'] === false) {
+		if($options['blocking'] === false) {
 			$fake_headers = '';
 			$options['hooks']->dispatch('curl.after_request', array(&$fake_headers));
 			return false;
 		}
-		if ($options['filename'] !== false) {
+		if($options['filename'] !== false) {
 			fclose($this->stream_handle);
 			$this->headers = trim($this->headers);
 		}
@@ -413,7 +413,7 @@ 
 			$this->headers .= $response;
 		}
 
-		if (curl_errno($this->handle)) {
+		if(curl_errno($this->handle)) {
 			$error = sprintf(
 				'cURL error %s: %s',
 				curl_errno($this->handle),
@@ -438,13 +438,13 @@ 
 		// Why do we do this? cURL will send both the final response and any
 		// interim responses, such as a 100 Continue. We don't need that.
 		// (We may want to keep this somewhere just in case)
-		if ($this->done_headers) {
+		if($this->done_headers) {
 			$this->headers = '';
 			$this->done_headers = false;
 		}
 		$this->headers .= $headers;
 
-		if ($headers === "\r\n") {
+		if($headers === "\r\n") {
 			$this->done_headers = true;
 		}
 		return strlen($headers);
@@ -464,20 +464,20 @@ 
 		$data_length = strlen($data);
 
 		// Are we limiting the response size?
-		if ($this->response_byte_limit) {
-			if ($this->response_bytes === $this->response_byte_limit) {
+		if($this->response_byte_limit) {
+			if($this->response_bytes === $this->response_byte_limit) {
 				// Already at maximum, move on
 				return $data_length;
 			}
 
-			if (($this->response_bytes + $data_length) > $this->response_byte_limit) {
+			if(($this->response_bytes + $data_length) > $this->response_byte_limit) {
 				// Limit the length
 				$limited_length = ($this->response_byte_limit - $this->response_bytes);
 				$data = substr($data, 0, $limited_length);
 			}
 		}
 
-		if ($this->stream_handle) {
+		if($this->stream_handle) {
 			fwrite($this->stream_handle, $data);
 		}
 		else {
@@ -496,9 +496,9 @@ 
 	 * @return string URL with data
 	 */
 	protected static function format_get($url, $data) {
-		if (!empty($data)) {
+		if(!empty($data)) {
 			$url_parts = parse_url($url);
-			if (empty($url_parts['query'])) {
+			if(empty($url_parts['query'])) {
 				$query = $url_parts['query'] = '';
 			}
 			else {
@@ -508,7 +508,7 @@ 
 			$query .= '&' . http_build_query($data, null, '&');
 			$query = trim($query, '&');
 
-			if (empty($url_parts['query'])) {
+			if(empty($url_parts['query'])) {
 				$url .= '?' . $query;
 			}
 			else {
@@ -525,14 +525,14 @@ 
 	 * @return boolean True if the transport is valid, false otherwise.
 	 */
 	public static function test($capabilities = array()) {
-		if (!function_exists('curl_init') || !function_exists('curl_exec')) {
+		if(!function_exists('curl_init') || !function_exists('curl_exec')) {
 			return false;
 		}
 
 		// If needed, check that our installed curl version supports SSL
-		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
+		if(isset($capabilities['ssl']) && $capabilities['ssl']) {
 			$curl_version = curl_version();
-			if (!(CURL_VERSION_SSL & $curl_version['features'])) {
+			if(!(CURL_VERSION_SSL&$curl_version['features'])) {
 				return false;
 			}
 		}

Braces +134 added lines, -67 removed lines

@@ -12,7 +12,8 @@ 
  * @package Requests
  * @subpackage Transport
  */
-class Requests_Transport_cURL implements Requests_Transport {
+class Requests_Transport_cURL implements Requests_Transport
+{
 	const CURL_7_10_5 = 0x070A05;
 	const CURL_7_16_2 = 0x071002;
 
@@ -89,20 +90,24 @@ 
 	/**
 	 * Constructor
 	 */
-	public function __construct() {
+	public function __construct()
+	{
 		$curl = curl_version();
 		$this->version = $curl['version_number'];
 		$this->handle = curl_init();
 
 		curl_setopt($this->handle, CURLOPT_HEADER, false);
 		curl_setopt($this->handle, CURLOPT_RETURNTRANSFER, 1);
-		if ($this->version >= self::CURL_7_10_5) {
+		if ($this->version >= self::CURL_7_10_5)
+		{
 			curl_setopt($this->handle, CURLOPT_ENCODING, '');
 		}
-		if (defined('CURLOPT_PROTOCOLS')) {
+		if (defined('CURLOPT_PROTOCOLS'))
+		{
 			curl_setopt($this->handle, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS);
 		}
-		if (defined('CURLOPT_REDIR_PROTOCOLS')) {
+		if (defined('CURLOPT_REDIR_PROTOCOLS'))
+		{
 			curl_setopt($this->handle, CURLOPT_REDIR_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS);
 		}
 	}
@@ -110,8 +115,10 @@ 
 	/**
 	 * Destructor
 	 */
-	public function __destruct() {
-		if (is_resource($this->handle)) {
+	public function __destruct()
+	{
+		if (is_resource($this->handle))
+		{
 			curl_close($this->handle);
 		}
 	}
@@ -127,35 +134,42 @@ 
 	 * @param array $options Request options, see {@see Requests::response()} for documentation
 	 * @return string Raw HTTP result
 	 */
-	public function request($url, $headers = array(), $data = array(), $options = array()) {
+	public function request($url, $headers = array(), $data = array(), $options = array())
+	{
 		$this->hooks = $options['hooks'];
 
 		$this->setup_handle($url, $headers, $data, $options);
 
 		$options['hooks']->dispatch('curl.before_send', array(&$this->handle));
 
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== false)
+		{
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
 		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		if ($options['max_bytes'] !== false)
+		{
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 
-		if (isset($options['verify'])) {
-			if ($options['verify'] === false) {
+		if (isset($options['verify']))
+		{
+			if ($options['verify'] === false)
+			{
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYPEER, 0);
 			}
-			elseif (is_string($options['verify'])) {
+			elseif (is_string($options['verify']))
+			{
 				curl_setopt($this->handle, CURLOPT_CAINFO, $options['verify']);
 			}
 		}
 
-		if (isset($options['verifyname']) && $options['verifyname'] === false) {
+		if (isset($options['verifyname']) && $options['verifyname'] === false)
+		{
 			curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 		}
 
@@ -164,7 +178,8 @@ 
 
 		$options['hooks']->dispatch('curl.after_send', array());
 
-		if (curl_errno($this->handle) === 23 || curl_errno($this->handle) === 61) {
+		if (curl_errno($this->handle) === 23 || curl_errno($this->handle) === 61)
+		{
 			// Reset encoding and try again
 			curl_setopt($this->handle, CURLOPT_ENCODING, 'none');
 
@@ -191,9 +206,11 @@ 
 	 * @param array $options Global options
 	 * @return array Array of Requests_Response objects (may contain Requests_Exception or string responses as well)
 	 */
-	public function request_multiple($requests, $options) {
+	public function request_multiple($requests, $options)
+	{
 		// If you're not requesting, we can't get any responses ¯\_(ツ)_/¯
-		if (empty($requests)) {
+		if (empty($requests))
+		{
 			return array();
 		}
 
@@ -202,7 +219,8 @@ 
 		$subhandles = array();
 
 		$class = get_class($this);
-		foreach ($requests as $id => $request) {
+		foreach ($requests as $id => $request)
+		{
 			$subrequests[$id] = new $class();
 			$subhandles[$id] = $subrequests[$id]->get_subrequest_handle($request['url'], $request['headers'], $request['data'], $request['options']);
 			$request['options']['hooks']->dispatch('curl.before_multi_add', array(&$subhandles[$id]));
@@ -214,10 +232,12 @@ 
 
 		$request['options']['hooks']->dispatch('curl.before_multi_exec', array(&$multihandle));
 
-		do {
+		do
+		{
 			$active = false;
 
-			do {
+			do
+			{
 				$status = curl_multi_exec($multihandle, $active);
 			}
 			while ($status === CURLM_CALL_MULTI_PERFORM);
@@ -225,17 +245,21 @@ 
 			$to_process = array();
 
 			// Read the information as needed
-			while ($done = curl_multi_info_read($multihandle)) {
+			while ($done = curl_multi_info_read($multihandle))
+			{
 				$key = array_search($done['handle'], $subhandles, true);
-				if (!isset($to_process[$key])) {
+				if (!isset($to_process[$key]))
+				{
 					$to_process[$key] = $done;
 				}
 			}
 
 			// Parse the finished requests before we start getting the new ones
-			foreach ($to_process as $key => $done) {
+			foreach ($to_process as $key => $done)
+			{
 				$options = $requests[$key]['options'];
-				if (CURLE_OK !== $done['result']) {
+				if (CURLE_OK !== $done['result'])
+				{
 					//get error string for handle.
 					$reason = curl_error($done['handle']);
 					$exception = new Requests_Exception_Transport_cURL(
@@ -247,7 +271,8 @@ 
 					$responses[$key] = $exception;
 					$options['hooks']->dispatch('transport.internal.parse_error', array(&$responses[$key], $requests[$key]));
 				}
-				else {
+				else
+				{
 					$responses[$key] = $subrequests[$key]->process_response($subrequests[$key]->response_data, $options);
 
 					$options['hooks']->dispatch('transport.internal.parse_response', array(&$responses[$key], $requests[$key]));
@@ -256,7 +281,8 @@ 
 				curl_multi_remove_handle($multihandle, $done['handle']);
 				curl_close($done['handle']);
 
-				if (!is_string($responses[$key])) {
+				if (!is_string($responses[$key]))
+				{
 					$options['hooks']->dispatch('multiple.request.complete', array(&$responses[$key], $key));
 				}
 				$completed++;
@@ -283,14 +309,16 @@ 
 	public function &get_subrequest_handle($url, $headers, $data, $options) {
 		$this->setup_handle($url, $headers, $data, $options);
 
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== false)
+		{
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
 		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		if ($options['max_bytes'] !== false)
+		{
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 		$this->hooks = $options['hooks'];
@@ -306,29 +334,35 @@ 
 	 * @param string|array $data Data to send either as the POST body, or as parameters in the URL for a GET/HEAD
 	 * @param array $options Request options, see {@see Requests::response()} for documentation
 	 */
-	protected function setup_handle($url, $headers, $data, $options) {
+	protected function setup_handle($url, $headers, $data, $options)
+	{
 		$options['hooks']->dispatch('curl.before_request', array(&$this->handle));
 
 		// Force closing the connection for old versions of cURL (<7.22).
-		if ( ! isset( $headers['Connection'] ) ) {
+		if ( ! isset( $headers['Connection'] ) )
+		{
 			$headers['Connection'] = 'close';
 		}
 
 		$headers = Requests::flatten($headers);
 
-		if (!empty($data)) {
+		if (!empty($data))
+		{
 			$data_format = $options['data_format'];
 
-			if ($data_format === 'query') {
+			if ($data_format === 'query')
+			{
 				$url = self::format_get($url, $data);
 				$data = '';
 			}
-			elseif (!is_string($data)) {
+			elseif (!is_string($data))
+			{
 				$data = http_build_query($data, null, '&');
 			}
 		}
 
-		switch ($options['type']) {
+		switch ($options['type'])
+		{
 			case Requests::POST:
 				curl_setopt($this->handle, CURLOPT_POST, true);
 				curl_setopt($this->handle, CURLOPT_POSTFIELDS, $data);
@@ -346,7 +380,8 @@ 
 			case Requests::OPTIONS:
 			default:
 				curl_setopt($this->handle, CURLOPT_CUSTOMREQUEST, $options['type']);
-				if (!empty($data)) {
+				if (!empty($data))
+				{
 					curl_setopt($this->handle, CURLOPT_POSTFIELDS, $data);
 				}
 		}
@@ -359,33 +394,41 @@ 
 		// https://github.com/curl/curl/blob/4f45240bc84a9aa648c8f7243be7b79e9f9323a5/lib/hostip.c#L606-L609
 		$timeout = max($options['timeout'], 1);
 
-		if (is_int($timeout) || $this->version < self::CURL_7_16_2) {
+		if (is_int($timeout) || $this->version < self::CURL_7_16_2)
+		{
 			curl_setopt($this->handle, CURLOPT_TIMEOUT, ceil($timeout));
 		}
-		else {
+		else
+		{
 			curl_setopt($this->handle, CURLOPT_TIMEOUT_MS, round($timeout * 1000));
 		}
 
-		if (is_int($options['connect_timeout']) || $this->version < self::CURL_7_16_2) {
+		if (is_int($options['connect_timeout']) || $this->version < self::CURL_7_16_2)
+		{
 			curl_setopt($this->handle, CURLOPT_CONNECTTIMEOUT, ceil($options['connect_timeout']));
 		}
-		else {
+		else
+		{
 			curl_setopt($this->handle, CURLOPT_CONNECTTIMEOUT_MS, round($options['connect_timeout'] * 1000));
 		}
 		curl_setopt($this->handle, CURLOPT_URL, $url);
 		curl_setopt($this->handle, CURLOPT_REFERER, $url);
 		curl_setopt($this->handle, CURLOPT_USERAGENT, $options['useragent']);
-		if (!empty($headers)) {
+		if (!empty($headers))
+		{
 			curl_setopt($this->handle, CURLOPT_HTTPHEADER, $headers);
 		}
-		if ($options['protocol_version'] === 1.1) {
+		if ($options['protocol_version'] === 1.1)
+		{
 			curl_setopt($this->handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
 		}
-		else {
+		else
+		{
 			curl_setopt($this->handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
 		}
 
-		if (true === $options['blocking']) {
+		if (true === $options['blocking'])
+		{
 			curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, array(&$this, 'stream_headers'));
 			curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, array(&$this, 'stream_body'));
 			curl_setopt($this->handle, CURLOPT_BUFFERSIZE, Requests::BUFFER_SIZE);
@@ -399,21 +442,26 @@ 
 	 * @param array $options Request options
 	 * @return string HTTP response data including headers
 	 */
-	public function process_response($response, $options) {
-		if ($options['blocking'] === false) {
+	public function process_response($response, $options)
+	{
+		if ($options['blocking'] === false)
+		{
 			$fake_headers = '';
 			$options['hooks']->dispatch('curl.after_request', array(&$fake_headers));
 			return false;
 		}
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== false)
+		{
 			fclose($this->stream_handle);
 			$this->headers = trim($this->headers);
 		}
-		else {
+		else
+		{
 			$this->headers .= $response;
 		}
 
-		if (curl_errno($this->handle)) {
+		if (curl_errno($this->handle))
+		{
 			$error = sprintf(
 				'cURL error %s: %s',
 				curl_errno($this->handle),
@@ -434,17 +482,20 @@ 
 	 * @param string $headers Header string
 	 * @return integer Length of provided header
 	 */
-	public function stream_headers($handle, $headers) {
+	public function stream_headers($handle, $headers)
+	{
 		// Why do we do this? cURL will send both the final response and any
 		// interim responses, such as a 100 Continue. We don't need that.
 		// (We may want to keep this somewhere just in case)
-		if ($this->done_headers) {
+		if ($this->done_headers)
+		{
 			$this->headers = '';
 			$this->done_headers = false;
 		}
 		$this->headers .= $headers;
 
-		if ($headers === "\r\n") {
+		if ($headers === "\r\n")
+		{
 			$this->done_headers = true;
 		}
 		return strlen($headers);
@@ -459,28 +510,34 @@ 
 	 * @param string $data Body data
 	 * @return integer Length of provided data
 	 */
-	public function stream_body($handle, $data) {
+	public function stream_body($handle, $data)
+	{
 		$this->hooks->dispatch('request.progress', array($data, $this->response_bytes, $this->response_byte_limit));
 		$data_length = strlen($data);
 
 		// Are we limiting the response size?
-		if ($this->response_byte_limit) {
-			if ($this->response_bytes === $this->response_byte_limit) {
+		if ($this->response_byte_limit)
+		{
+			if ($this->response_bytes === $this->response_byte_limit)
+			{
 				// Already at maximum, move on
 				return $data_length;
 			}
 
-			if (($this->response_bytes + $data_length) > $this->response_byte_limit) {
+			if (($this->response_bytes + $data_length) > $this->response_byte_limit)
+			{
 				// Limit the length
 				$limited_length = ($this->response_byte_limit - $this->response_bytes);
 				$data = substr($data, 0, $limited_length);
 			}
 		}
 
-		if ($this->stream_handle) {
+		if ($this->stream_handle)
+		{
 			fwrite($this->stream_handle, $data);
 		}
-		else {
+		else
+		{
 			$this->response_data .= $data;
 		}
 
@@ -495,23 +552,29 @@ 
 	 * @param array|object $data Data to build query using, see {@see https://secure.php.net/http_build_query}
 	 * @return string URL with data
 	 */
-	protected static function format_get($url, $data) {
-		if (!empty($data)) {
+	protected static function format_get($url, $data)
+	{
+		if (!empty($data))
+		{
 			$url_parts = parse_url($url);
-			if (empty($url_parts['query'])) {
+			if (empty($url_parts['query']))
+			{
 				$query = $url_parts['query'] = '';
 			}
-			else {
+			else
+			{
 				$query = $url_parts['query'];
 			}
 
 			$query .= '&' . http_build_query($data, null, '&');
 			$query = trim($query, '&');
 
-			if (empty($url_parts['query'])) {
+			if (empty($url_parts['query']))
+			{
 				$url .= '?' . $query;
 			}
-			else {
+			else
+			{
 				$url = str_replace($url_parts['query'], $query, $url);
 			}
 		}
@@ -524,15 +587,19 @@ 
 	 * @codeCoverageIgnore
 	 * @return boolean True if the transport is valid, false otherwise.
 	 */
-	public static function test($capabilities = array()) {
-		if (!function_exists('curl_init') || !function_exists('curl_exec')) {
+	public static function test($capabilities = array())
+	{
+		if (!function_exists('curl_init') || !function_exists('curl_exec'))
+		{
 			return false;
 		}
 
 		// If needed, check that our installed curl version supports SSL
-		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
+		if (isset($capabilities['ssl']) && $capabilities['ssl'])
+		{
 			$curl_version = curl_version();
-			if (!(CURL_VERSION_SSL & $curl_version['features'])) {
+			if (!(CURL_VERSION_SSL & $curl_version['features']))
+			{
 				return false;
 			}
 		}

Upper-Lower-Casing +27 added lines, -27 removed lines

@@ -63,7 +63,7 @@ 
 	 *
 	 * @var boolean
 	 */
-	protected $done_headers = false;
+	protected $done_headers = FALSE;
 
 	/**
 	 * If streaming to a file, keep the file pointer
@@ -94,7 +94,7 @@ 
 		$this->version = $curl['version_number'];
 		$this->handle = curl_init();
 
-		curl_setopt($this->handle, CURLOPT_HEADER, false);
+		curl_setopt($this->handle, CURLOPT_HEADER, FALSE);
 		curl_setopt($this->handle, CURLOPT_RETURNTRANSFER, 1);
 		if ($this->version >= self::CURL_7_10_5) {
 			curl_setopt($this->handle, CURLOPT_ENCODING, '');
@@ -134,19 +134,19 @@ 
 
 		$options['hooks']->dispatch('curl.before_send', array(&$this->handle));
 
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== FALSE) {
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
-		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		$this->response_byte_limit = FALSE;
+		if ($options['max_bytes'] !== FALSE) {
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 
 		if (isset($options['verify'])) {
-			if ($options['verify'] === false) {
+			if ($options['verify'] === FALSE) {
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 				curl_setopt($this->handle, CURLOPT_SSL_VERIFYPEER, 0);
 			}
@@ -155,7 +155,7 @@ 
 			}
 		}
 
-		if (isset($options['verifyname']) && $options['verifyname'] === false) {
+		if (isset($options['verifyname']) && $options['verifyname'] === FALSE) {
 			curl_setopt($this->handle, CURLOPT_SSL_VERIFYHOST, 0);
 		}
 
@@ -178,8 +178,8 @@ 
 
 		// Need to remove the $this reference from the curl handle.
 		// Otherwise Requests_Transport_cURL wont be garbage collected and the curl_close() will never be called.
-		curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, null);
-		curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, null);
+		curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, NULL);
+		curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, NULL);
 
 		return $this->headers;
 	}
@@ -215,7 +215,7 @@ 
 		$request['options']['hooks']->dispatch('curl.before_multi_exec', array(&$multihandle));
 
 		do {
-			$active = false;
+			$active = FALSE;
 
 			do {
 				$status = curl_multi_exec($multihandle, $active);
@@ -226,7 +226,7 @@ 
 
 			// Read the information as needed
 			while ($done = curl_multi_info_read($multihandle)) {
-				$key = array_search($done['handle'], $subhandles, true);
+				$key = array_search($done['handle'], $subhandles, TRUE);
 				if (!isset($to_process[$key])) {
 					$to_process[$key] = $done;
 				}
@@ -283,14 +283,14 @@ 
 	public function &get_subrequest_handle($url, $headers, $data, $options) {
 		$this->setup_handle($url, $headers, $data, $options);
 
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== FALSE) {
 			$this->stream_handle = fopen($options['filename'], 'wb');
 		}
 
 		$this->response_data = '';
 		$this->response_bytes = 0;
-		$this->response_byte_limit = false;
-		if ($options['max_bytes'] !== false) {
+		$this->response_byte_limit = FALSE;
+		if ($options['max_bytes'] !== FALSE) {
 			$this->response_byte_limit = $options['max_bytes'];
 		}
 		$this->hooks = $options['hooks'];
@@ -324,18 +324,18 @@ 
 				$data = '';
 			}
 			elseif (!is_string($data)) {
-				$data = http_build_query($data, null, '&');
+				$data = http_build_query($data, NULL, '&');
 			}
 		}
 
 		switch ($options['type']) {
 			case Requests::POST:
-				curl_setopt($this->handle, CURLOPT_POST, true);
+				curl_setopt($this->handle, CURLOPT_POST, TRUE);
 				curl_setopt($this->handle, CURLOPT_POSTFIELDS, $data);
 				break;
 			case Requests::HEAD:
 				curl_setopt($this->handle, CURLOPT_CUSTOMREQUEST, $options['type']);
-				curl_setopt($this->handle, CURLOPT_NOBODY, true);
+				curl_setopt($this->handle, CURLOPT_NOBODY, TRUE);
 				break;
 			case Requests::TRACE:
 				curl_setopt($this->handle, CURLOPT_CUSTOMREQUEST, $options['type']);
@@ -385,7 +385,7 @@ 
 			curl_setopt($this->handle, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_0);
 		}
 
-		if (true === $options['blocking']) {
+		if (TRUE === $options['blocking']) {
 			curl_setopt($this->handle, CURLOPT_HEADERFUNCTION, array(&$this, 'stream_headers'));
 			curl_setopt($this->handle, CURLOPT_WRITEFUNCTION, array(&$this, 'stream_body'));
 			curl_setopt($this->handle, CURLOPT_BUFFERSIZE, Requests::BUFFER_SIZE);
@@ -400,12 +400,12 @@ 
 	 * @return string HTTP response data including headers
 	 */
 	public function process_response($response, $options) {
-		if ($options['blocking'] === false) {
+		if ($options['blocking'] === FALSE) {
 			$fake_headers = '';
 			$options['hooks']->dispatch('curl.after_request', array(&$fake_headers));
-			return false;
+			return FALSE;
 		}
-		if ($options['filename'] !== false) {
+		if ($options['filename'] !== FALSE) {
 			fclose($this->stream_handle);
 			$this->headers = trim($this->headers);
 		}
@@ -440,12 +440,12 @@ 
 		// (We may want to keep this somewhere just in case)
 		if ($this->done_headers) {
 			$this->headers = '';
-			$this->done_headers = false;
+			$this->done_headers = FALSE;
 		}
 		$this->headers .= $headers;
 
 		if ($headers === "\r\n") {
-			$this->done_headers = true;
+			$this->done_headers = TRUE;
 		}
 		return strlen($headers);
 	}
@@ -505,7 +505,7 @@ 
 				$query = $url_parts['query'];
 			}
 
-			$query .= '&' . http_build_query($data, null, '&');
+			$query .= '&' . http_build_query($data, NULL, '&');
 			$query = trim($query, '&');
 
 			if (empty($url_parts['query'])) {
@@ -526,17 +526,17 @@ 
 	 */
 	public static function test($capabilities = array()) {
 		if (!function_exists('curl_init') || !function_exists('curl_exec')) {
-			return false;
+			return FALSE;
 		}
 
 		// If needed, check that our installed curl version supports SSL
 		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
 			$curl_version = curl_version();
 			if (!(CURL_VERSION_SSL & $curl_version['features'])) {
-				return false;
+				return FALSE;
 			}
 		}
 
-		return true;
+		return TRUE;
 	}
 }

php/Requests/libary/Requests/Transport/fsockopen.php

Spacing +56 added lines, -56 removed lines

@@ -59,7 +59,7 @@ 
 		$options['hooks']->dispatch('fsockopen.before_request');
 
 		$url_parts = parse_url($url);
-		if (empty($url_parts)) {
+		if(empty($url_parts)) {
 			throw new Requests_Exception('Invalid URL.', 'invalidurl', $url);
 		}
 		$host = $url_parts['host'];
@@ -68,9 +68,9 @@ 
 		$case_insensitive_headers = new Requests_Utility_CaseInsensitiveDictionary($headers);
 
 		// HTTPS support
-		if (isset($url_parts['scheme']) && strtolower($url_parts['scheme']) === 'https') {
+		if(isset($url_parts['scheme']) && strtolower($url_parts['scheme']) === 'https') {
 			$remote_socket = 'ssl://' . $host;
-			if (!isset($url_parts['port'])) {
+			if(!isset($url_parts['port'])) {
 				$url_parts['port'] = 443;
 			}
 
@@ -82,23 +82,23 @@ 
 			$verifyname = true;
 
 			// SNI, if enabled (OpenSSL >=0.9.8j)
-			if (defined('OPENSSL_TLSEXT_SERVER_NAME') && OPENSSL_TLSEXT_SERVER_NAME) {
+			if(defined('OPENSSL_TLSEXT_SERVER_NAME') && OPENSSL_TLSEXT_SERVER_NAME) {
 				$context_options['SNI_enabled'] = true;
-				if (isset($options['verifyname']) && $options['verifyname'] === false) {
+				if(isset($options['verifyname']) && $options['verifyname'] === false) {
 					$context_options['SNI_enabled'] = false;
 				}
 			}
 
-			if (isset($options['verify'])) {
-				if ($options['verify'] === false) {
+			if(isset($options['verify'])) {
+				if($options['verify'] === false) {
 					$context_options['verify_peer'] = false;
 				}
-				elseif (is_string($options['verify'])) {
+				elseif(is_string($options['verify'])) {
 					$context_options['cafile'] = $options['verify'];
 				}
 			}
 
-			if (isset($options['verifyname']) && $options['verifyname'] === false) {
+			if(isset($options['verifyname']) && $options['verifyname'] === false) {
 				$context_options['verify_peer_name'] = false;
 				$verifyname = false;
 			}
@@ -111,12 +111,12 @@ 
 
 		$this->max_bytes = $options['max_bytes'];
 
-		if (!isset($url_parts['port'])) {
+		if(!isset($url_parts['port'])) {
 			$url_parts['port'] = 80;
 		}
 		$remote_socket .= ':' . $url_parts['port'];
 
-		set_error_handler(array($this, 'connect_error_handler'), E_WARNING | E_NOTICE);
+		set_error_handler(array($this, 'connect_error_handler'), E_WARNING|E_NOTICE);
 
 		$options['hooks']->dispatch('fsockopen.remote_socket', array(&$remote_socket));
 
@@ -124,12 +124,12 @@ 
 
 		restore_error_handler();
 
-		if ($verifyname && !$this->verify_certificate_from_context($host, $context)) {
+		if($verifyname && !$this->verify_certificate_from_context($host, $context)) {
 			throw new Requests_Exception('SSL certificate did not match the requested domain name', 'ssl.no_match');
 		}
 
-		if (!$socket) {
-			if ($errno === 0) {
+		if(!$socket) {
+			if($errno === 0) {
 				// Connection issue
 				throw new Requests_Exception(rtrim($this->connect_error), 'fsockopen.connect_error');
 			}
@@ -139,7 +139,7 @@ 
 
 		$data_format = $options['data_format'];
 
-		if ($data_format === 'query') {
+		if($data_format === 'query') {
 			$path = self::format_get($url_parts, $data);
 			$data = '';
 		}
@@ -152,56 +152,56 @@ 
 		$request_body = '';
 		$out = sprintf("%s %s HTTP/%.1f\r\n", $options['type'], $path, $options['protocol_version']);
 
-		if ($options['type'] !== Requests::TRACE) {
-			if (is_array($data)) {
+		if($options['type'] !== Requests::TRACE) {
+			if(is_array($data)) {
 				$request_body = http_build_query($data, null, '&');
 			}
 			else {
 				$request_body = $data;
 			}
 
-			if (!empty($data)) {
-				if (!isset($case_insensitive_headers['Content-Length'])) {
+			if(!empty($data)) {
+				if(!isset($case_insensitive_headers['Content-Length'])) {
 					$headers['Content-Length'] = strlen($request_body);
 				}
 
-				if (!isset($case_insensitive_headers['Content-Type'])) {
+				if(!isset($case_insensitive_headers['Content-Type'])) {
 					$headers['Content-Type'] = 'application/x-www-form-urlencoded; charset=UTF-8';
 				}
 			}
 		}
 
-		if (!isset($case_insensitive_headers['Host'])) {
+		if(!isset($case_insensitive_headers['Host'])) {
 			$out .= sprintf('Host: %s', $url_parts['host']);
 
-			if (( 'http' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 80 ) || ( 'https' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 443 )) {
+			if(('http' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 80) || ('https' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 443)) {
 				$out .= ':' . $url_parts['port'];
 			}
 			$out .= "\r\n";
 		}
 
-		if (!isset($case_insensitive_headers['User-Agent'])) {
+		if(!isset($case_insensitive_headers['User-Agent'])) {
 			$out .= sprintf("User-Agent: %s\r\n", $options['useragent']);
 		}
 
 		$accept_encoding = $this->accept_encoding();
-		if (!isset($case_insensitive_headers['Accept-Encoding']) && !empty($accept_encoding)) {
+		if(!isset($case_insensitive_headers['Accept-Encoding']) && !empty($accept_encoding)) {
 			$out .= sprintf("Accept-Encoding: %s\r\n", $accept_encoding);
 		}
 
 		$headers = Requests::flatten($headers);
 
-		if (!empty($headers)) {
+		if(!empty($headers)) {
 			$out .= implode($headers, "\r\n") . "\r\n";
 		}
 
 		$options['hooks']->dispatch('fsockopen.after_headers', array(&$out));
 
-		if (substr($out, -2) !== "\r\n") {
+		if(substr($out, -2) !== "\r\n") {
 			$out .= "\r\n";
 		}
 
-		if (!isset($case_insensitive_headers['Connection'])) {
+		if(!isset($case_insensitive_headers['Connection'])) {
 			$out .= "Connection: Close\r\n";
 		}
 
@@ -212,15 +212,15 @@ 
 		fwrite($socket, $out);
 		$options['hooks']->dispatch('fsockopen.after_send', array($out));
 
-		if (!$options['blocking']) {
+		if(!$options['blocking']) {
 			fclose($socket);
 			$fake_headers = '';
 			$options['hooks']->dispatch('fsockopen.after_request', array(&$fake_headers));
 			return '';
 		}
 
-		$timeout_sec = (int) floor($options['timeout']);
-		if ($timeout_sec == $options['timeout']) {
+		$timeout_sec = (int)floor($options['timeout']);
+		if($timeout_sec == $options['timeout']) {
 			$timeout_msec = 0;
 		}
 		else {
@@ -233,35 +233,35 @@ 
 		$size = 0;
 		$doingbody = false;
 		$download = false;
-		if ($options['filename']) {
+		if($options['filename']) {
 			$download = fopen($options['filename'], 'wb');
 		}
 
-		while (!feof($socket)) {
+		while(!feof($socket)) {
 			$this->info = stream_get_meta_data($socket);
-			if ($this->info['timed_out']) {
+			if($this->info['timed_out']) {
 				throw new Requests_Exception('fsocket timed out', 'timeout');
 			}
 
 			$block = fread($socket, Requests::BUFFER_SIZE);
-			if (!$doingbody) {
+			if(!$doingbody) {
 				$response .= $block;
-				if (strpos($response, "\r\n\r\n")) {
+				if(strpos($response, "\r\n\r\n")) {
 					list($headers, $block) = explode("\r\n\r\n", $response, 2);
 					$doingbody = true;
 				}
 			}
 
 			// Are we in body mode now?
-			if ($doingbody) {
+			if($doingbody) {
 				$options['hooks']->dispatch('request.progress', array($block, $size, $this->max_bytes));
 				$data_length = strlen($block);
-				if ($this->max_bytes) {
+				if($this->max_bytes) {
 					// Have we already hit a limit?
-					if ($size === $this->max_bytes) {
+					if($size === $this->max_bytes) {
 						continue;
 					}
-					if (($size + $data_length) > $this->max_bytes) {
+					if(($size + $data_length) > $this->max_bytes) {
 						// Limit the length
 						$limited_length = ($this->max_bytes - $size);
 						$block = substr($block, 0, $limited_length);
@@ -269,7 +269,7 @@ 
 				}
 
 				$size += strlen($block);
-				if ($download) {
+				if($download) {
 					fwrite($download, $block);
 				}
 				else {
@@ -279,7 +279,7 @@ 
 		}
 		$this->headers = $headers;
 
-		if ($download) {
+		if($download) {
 			fclose($download);
 		}
 		else {
@@ -301,18 +301,18 @@ 
 	public function request_multiple($requests, $options) {
 		$responses = array();
 		$class = get_class($this);
-		foreach ($requests as $id => $request) {
+		foreach($requests as $id => $request) {
 			try {
 				$handler = new $class();
 				$responses[$id] = $handler->request($request['url'], $request['headers'], $request['data'], $request['options']);
 
 				$request['options']['hooks']->dispatch('transport.internal.parse_response', array(&$responses[$id], $request));
 			}
-			catch (Requests_Exception $e) {
+			catch(Requests_Exception $e) {
 				$responses[$id] = $e;
 			}
 
-			if (!is_string($responses[$id])) {
+			if(!is_string($responses[$id])) {
 				$request['options']['hooks']->dispatch('multiple.request.complete', array(&$responses[$id], $id));
 			}
 		}
@@ -327,11 +327,11 @@ 
 	 */
 	protected static function accept_encoding() {
 		$type = array();
-		if (function_exists('gzinflate')) {
+		if(function_exists('gzinflate')) {
 			$type[] = 'deflate;q=1.0';
 		}
 
-		if (function_exists('gzuncompress')) {
+		if(function_exists('gzuncompress')) {
 			$type[] = 'compress;q=0.5';
 		}
 
@@ -348,16 +348,16 @@ 
 	 * @return string URL with data
 	 */
 	protected static function format_get($url_parts, $data) {
-		if (!empty($data)) {
-			if (empty($url_parts['query'])) {
+		if(!empty($data)) {
+			if(empty($url_parts['query'])) {
 				$url_parts['query'] = '';
 			}
 
 			$url_parts['query'] .= '&' . http_build_query($data, null, '&');
 			$url_parts['query'] = trim($url_parts['query'], '&');
 		}
-		if (isset($url_parts['path'])) {
-			if (isset($url_parts['query'])) {
+		if(isset($url_parts['path'])) {
+			if(isset($url_parts['query'])) {
 				$get = $url_parts['path'] . '?' . $url_parts['query'];
 			}
 			else {
@@ -378,7 +378,7 @@ 
 	 */
 	public function connect_error_handler($errno, $errstr) {
 		// Double-check we can handle it
-		if (($errno & E_WARNING) === 0 && ($errno & E_NOTICE) === 0) {
+		if(($errno&E_WARNING) === 0 && ($errno&E_NOTICE) === 0) {
 			// Return false to indicate the default error handler should engage
 			return false;
 		}
@@ -407,7 +407,7 @@ 
 
 		// If we don't have SSL options, then we couldn't make the connection at
 		// all
-		if (empty($meta) || empty($meta['ssl']) || empty($meta['ssl']['peer_certificate'])) {
+		if(empty($meta) || empty($meta['ssl']) || empty($meta['ssl']['peer_certificate'])) {
 			throw new Requests_Exception(rtrim($this->connect_error), 'ssl.connect_error');
 		}
 
@@ -423,18 +423,18 @@ 
 	 * @return boolean True if the transport is valid, false otherwise.
 	 */
 	public static function test($capabilities = array()) {
-		if (!function_exists('fsockopen')) {
+		if(!function_exists('fsockopen')) {
 			return false;
 		}
 
 		// If needed, check that streams support SSL
-		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
-			if (!extension_loaded('openssl') || !function_exists('openssl_x509_parse')) {
+		if(isset($capabilities['ssl']) && $capabilities['ssl']) {
+			if(!extension_loaded('openssl') || !function_exists('openssl_x509_parse')) {
 				return false;
 			}
 
 			// Currently broken, thanks to https://github.com/facebook/hhvm/issues/2156
-			if (defined('HHVM_VERSION')) {
+			if(defined('HHVM_VERSION')) {
 				return false;
 			}
 		}

Braces +142 added lines, -71 removed lines

@@ -12,7 +12,8 @@ 
  * @package Requests
  * @subpackage Transport
  */
-class Requests_Transport_fsockopen implements Requests_Transport {
+class Requests_Transport_fsockopen implements Requests_Transport
+{
 	/**
 	 * Second to microsecond conversion
 	 *
@@ -55,11 +56,13 @@ 
 	 * @param array $options Request options, see {@see Requests::response()} for documentation
 	 * @return string Raw HTTP result
 	 */
-	public function request($url, $headers = array(), $data = array(), $options = array()) {
+	public function request($url, $headers = array(), $data = array(), $options = array())
+	{
 		$options['hooks']->dispatch('fsockopen.before_request');
 
 		$url_parts = parse_url($url);
-		if (empty($url_parts)) {
+		if (empty($url_parts))
+		{
 			throw new Requests_Exception('Invalid URL.', 'invalidurl', $url);
 		}
 		$host = $url_parts['host'];
@@ -68,9 +71,11 @@ 
 		$case_insensitive_headers = new Requests_Utility_CaseInsensitiveDictionary($headers);
 
 		// HTTPS support
-		if (isset($url_parts['scheme']) && strtolower($url_parts['scheme']) === 'https') {
+		if (isset($url_parts['scheme']) && strtolower($url_parts['scheme']) === 'https')
+		{
 			$remote_socket = 'ssl://' . $host;
-			if (!isset($url_parts['port'])) {
+			if (!isset($url_parts['port']))
+			{
 				$url_parts['port'] = 443;
 			}
 
@@ -82,36 +87,44 @@ 
 			$verifyname = true;
 
 			// SNI, if enabled (OpenSSL >=0.9.8j)
-			if (defined('OPENSSL_TLSEXT_SERVER_NAME') && OPENSSL_TLSEXT_SERVER_NAME) {
+			if (defined('OPENSSL_TLSEXT_SERVER_NAME') && OPENSSL_TLSEXT_SERVER_NAME)
+			{
 				$context_options['SNI_enabled'] = true;
-				if (isset($options['verifyname']) && $options['verifyname'] === false) {
+				if (isset($options['verifyname']) && $options['verifyname'] === false)
+				{
 					$context_options['SNI_enabled'] = false;
 				}
 			}
 
-			if (isset($options['verify'])) {
-				if ($options['verify'] === false) {
+			if (isset($options['verify']))
+			{
+				if ($options['verify'] === false)
+				{
 					$context_options['verify_peer'] = false;
 				}
-				elseif (is_string($options['verify'])) {
+				elseif (is_string($options['verify']))
+				{
 					$context_options['cafile'] = $options['verify'];
 				}
 			}
 
-			if (isset($options['verifyname']) && $options['verifyname'] === false) {
+			if (isset($options['verifyname']) && $options['verifyname'] === false)
+			{
 				$context_options['verify_peer_name'] = false;
 				$verifyname = false;
 			}
 
 			stream_context_set_option($context, array('ssl' => $context_options));
 		}
-		else {
+		else
+		{
 			$remote_socket = 'tcp://' . $host;
 		}
 
 		$this->max_bytes = $options['max_bytes'];
 
-		if (!isset($url_parts['port'])) {
+		if (!isset($url_parts['port']))
+		{
 			$url_parts['port'] = 80;
 		}
 		$remote_socket .= ':' . $url_parts['port'];
@@ -124,12 +137,15 @@ 
 
 		restore_error_handler();
 
-		if ($verifyname && !$this->verify_certificate_from_context($host, $context)) {
+		if ($verifyname && !$this->verify_certificate_from_context($host, $context))
+		{
 			throw new Requests_Exception('SSL certificate did not match the requested domain name', 'ssl.no_match');
 		}
 
-		if (!$socket) {
-			if ($errno === 0) {
+		if (!$socket)
+		{
+			if ($errno === 0)
+			{
 				// Connection issue
 				throw new Requests_Exception(rtrim($this->connect_error), 'fsockopen.connect_error');
 			}
@@ -139,11 +155,13 @@ 
 
 		$data_format = $options['data_format'];
 
-		if ($data_format === 'query') {
+		if ($data_format === 'query')
+		{
 			$path = self::format_get($url_parts, $data);
 			$data = '';
 		}
-		else {
+		else
+		{
 			$path = self::format_get($url_parts, array());
 		}
 
@@ -152,56 +170,69 @@ 
 		$request_body = '';
 		$out = sprintf("%s %s HTTP/%.1f\r\n", $options['type'], $path, $options['protocol_version']);
 
-		if ($options['type'] !== Requests::TRACE) {
-			if (is_array($data)) {
+		if ($options['type'] !== Requests::TRACE)
+		{
+			if (is_array($data))
+			{
 				$request_body = http_build_query($data, null, '&');
 			}
-			else {
+			else
+			{
 				$request_body = $data;
 			}
 
-			if (!empty($data)) {
-				if (!isset($case_insensitive_headers['Content-Length'])) {
+			if (!empty($data))
+			{
+				if (!isset($case_insensitive_headers['Content-Length']))
+				{
 					$headers['Content-Length'] = strlen($request_body);
 				}
 
-				if (!isset($case_insensitive_headers['Content-Type'])) {
+				if (!isset($case_insensitive_headers['Content-Type']))
+				{
 					$headers['Content-Type'] = 'application/x-www-form-urlencoded; charset=UTF-8';
 				}
 			}
 		}
 
-		if (!isset($case_insensitive_headers['Host'])) {
+		if (!isset($case_insensitive_headers['Host']))
+		{
 			$out .= sprintf('Host: %s', $url_parts['host']);
 
-			if (( 'http' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 80 ) || ( 'https' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 443 )) {
+			if (( 'http' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 80 ) || ( 'https' === strtolower($url_parts['scheme']) && $url_parts['port'] !== 443 ))
+			{
 				$out .= ':' . $url_parts['port'];
 			}
 			$out .= "\r\n";
 		}
 
-		if (!isset($case_insensitive_headers['User-Agent'])) {
+		if (!isset($case_insensitive_headers['User-Agent']))
+		{
 			$out .= sprintf("User-Agent: %s\r\n", $options['useragent']);
 		}
 
 		$accept_encoding = $this->accept_encoding();
-		if (!isset($case_insensitive_headers['Accept-Encoding']) && !empty($accept_encoding)) {
+		if (!isset($case_insensitive_headers['Accept-Encoding']) && !empty($accept_encoding))
+		{
 			$out .= sprintf("Accept-Encoding: %s\r\n", $accept_encoding);
 		}
 
 		$headers = Requests::flatten($headers);
 
-		if (!empty($headers)) {
+		if (!empty($headers))
+		{
 			$out .= implode($headers, "\r\n") . "\r\n";
 		}
 
 		$options['hooks']->dispatch('fsockopen.after_headers', array(&$out));
 
-		if (substr($out, -2) !== "\r\n") {
+		if (substr($out, -2) !== "\r\n")
+		{
 			$out .= "\r\n";
 		}
 
-		if (!isset($case_insensitive_headers['Connection'])) {
+		if (!isset($case_insensitive_headers['Connection']))
+		{
 			$out .= "Connection: Close\r\n";
 		}
 
@@ -212,7 +243,8 @@ 
 		fwrite($socket, $out);
 		$options['hooks']->dispatch('fsockopen.after_send', array($out));
 
-		if (!$options['blocking']) {
+		if (!$options['blocking'])
+		{
 			fclose($socket);
 			$fake_headers = '';
 			$options['hooks']->dispatch('fsockopen.after_request', array(&$fake_headers));
@@ -220,10 +252,12 @@ 
 		}
 
 		$timeout_sec = (int) floor($options['timeout']);
-		if ($timeout_sec == $options['timeout']) {
+		if ($timeout_sec == $options['timeout'])
+		{
 			$timeout_msec = 0;
 		}
-		else {
+		else
+		{
 			$timeout_msec = self::SECOND_IN_MICROSECONDS * $options['timeout'] % self::SECOND_IN_MICROSECONDS;
 		}
 		stream_set_timeout($socket, $timeout_sec, $timeout_msec);
@@ -233,35 +267,44 @@ 
 		$size = 0;
 		$doingbody = false;
 		$download = false;
-		if ($options['filename']) {
+		if ($options['filename'])
+		{
 			$download = fopen($options['filename'], 'wb');
 		}
 
-		while (!feof($socket)) {
+		while (!feof($socket))
+		{
 			$this->info = stream_get_meta_data($socket);
-			if ($this->info['timed_out']) {
+			if ($this->info['timed_out'])
+			{
 				throw new Requests_Exception('fsocket timed out', 'timeout');
 			}
 
 			$block = fread($socket, Requests::BUFFER_SIZE);
-			if (!$doingbody) {
+			if (!$doingbody)
+			{
 				$response .= $block;
-				if (strpos($response, "\r\n\r\n")) {
+				if (strpos($response, "\r\n\r\n"))
+				{
 					list($headers, $block) = explode("\r\n\r\n", $response, 2);
 					$doingbody = true;
 				}
 			}
 
 			// Are we in body mode now?
-			if ($doingbody) {
+			if ($doingbody)
+			{
 				$options['hooks']->dispatch('request.progress', array($block, $size, $this->max_bytes));
 				$data_length = strlen($block);
-				if ($this->max_bytes) {
+				if ($this->max_bytes)
+				{
 					// Have we already hit a limit?
-					if ($size === $this->max_bytes) {
+					if ($size === $this->max_bytes)
+					{
 						continue;
 					}
-					if (($size + $data_length) > $this->max_bytes) {
+					if (($size + $data_length) > $this->max_bytes)
+					{
 						// Limit the length
 						$limited_length = ($this->max_bytes - $size);
 						$block = substr($block, 0, $limited_length);
@@ -269,20 +312,24 @@ 
 				}
 
 				$size += strlen($block);
-				if ($download) {
+				if ($download)
+				{
 					fwrite($download, $block);
 				}
-				else {
+				else
+				{
 					$body .= $block;
 				}
 			}
 		}
 		$this->headers = $headers;
 
-		if ($download) {
+		if ($download)
+		{
 			fclose($download);
 		}
-		else {
+		else
+		{
 			$this->headers .= "\r\n\r\n" . $body;
 		}
 		fclose($socket);
@@ -298,21 +345,26 @@ 
 	 * @param array $options Global options, see {@see Requests::response()} for documentation
 	 * @return array Array of Requests_Response objects (may contain Requests_Exception or string responses as well)
 	 */
-	public function request_multiple($requests, $options) {
+	public function request_multiple($requests, $options)
+	{
 		$responses = array();
 		$class = get_class($this);
-		foreach ($requests as $id => $request) {
-			try {
+		foreach ($requests as $id => $request)
+		{
+			try
+			{
 				$handler = new $class();
 				$responses[$id] = $handler->request($request['url'], $request['headers'], $request['data'], $request['options']);
 
 				$request['options']['hooks']->dispatch('transport.internal.parse_response', array(&$responses[$id], $request));
 			}
-			catch (Requests_Exception $e) {
+			catch (Requests_Exception $e)
+			{
 				$responses[$id] = $e;
 			}
 
-			if (!is_string($responses[$id])) {
+			if (!is_string($responses[$id]))
+			{
 				$request['options']['hooks']->dispatch('multiple.request.complete', array(&$responses[$id], $id));
 			}
 		}
@@ -325,13 +377,16 @@ 
 	 *
 	 * @return string Accept-Encoding header value
 	 */
-	protected static function accept_encoding() {
+	protected static function accept_encoding()
+	{
 		$type = array();
-		if (function_exists('gzinflate')) {
+		if (function_exists('gzinflate'))
+		{
 			$type[] = 'deflate;q=1.0';
 		}
 
-		if (function_exists('gzuncompress')) {
+		if (function_exists('gzuncompress'))
+		{
 			$type[] = 'compress;q=0.5';
 		}
 
@@ -347,24 +402,31 @@ 
 	 * @param array|object $data Data to build query using, see {@see https://secure.php.net/http_build_query}
 	 * @return string URL with data
 	 */
-	protected static function format_get($url_parts, $data) {
-		if (!empty($data)) {
-			if (empty($url_parts['query'])) {
+	protected static function format_get($url_parts, $data)
+	{
+		if (!empty($data))
+		{
+			if (empty($url_parts['query']))
+			{
 				$url_parts['query'] = '';
 			}
 
 			$url_parts['query'] .= '&' . http_build_query($data, null, '&');
 			$url_parts['query'] = trim($url_parts['query'], '&');
 		}
-		if (isset($url_parts['path'])) {
-			if (isset($url_parts['query'])) {
+		if (isset($url_parts['path']))
+		{
+			if (isset($url_parts['query']))
+			{
 				$get = $url_parts['path'] . '?' . $url_parts['query'];
 			}
-			else {
+			else
+			{
 				$get = $url_parts['path'];
 			}
 		}
-		else {
+		else
+		{
 			$get = '/';
 		}
 		return $get;
@@ -376,9 +438,11 @@ 
 	 * @param int $errno Error number (e.g. E_WARNING)
 	 * @param string $errstr Error message
 	 */
-	public function connect_error_handler($errno, $errstr) {
+	public function connect_error_handler($errno, $errstr)
+	{
 		// Double-check we can handle it
-		if (($errno & E_WARNING) === 0 && ($errno & E_NOTICE) === 0) {
+		if (($errno & E_WARNING) === 0 && ($errno & E_NOTICE) === 0)
+		{
 			// Return false to indicate the default error handler should engage
 			return false;
 		}
@@ -402,12 +466,14 @@ 
 	 * @param resource $context Stream context
 	 * @return bool
 	 */
-	public function verify_certificate_from_context($host, $context) {
+	public function verify_certificate_from_context($host, $context)
+	{
 		$meta = stream_context_get_options($context);
 
 		// If we don't have SSL options, then we couldn't make the connection at
 		// all
-		if (empty($meta) || empty($meta['ssl']) || empty($meta['ssl']['peer_certificate'])) {
+		if (empty($meta) || empty($meta['ssl']) || empty($meta['ssl']['peer_certificate']))
+		{
 			throw new Requests_Exception(rtrim($this->connect_error), 'ssl.connect_error');
 		}
 
@@ -422,19 +488,24 @@ 
 	 * @codeCoverageIgnore
 	 * @return boolean True if the transport is valid, false otherwise.
 	 */
-	public static function test($capabilities = array()) {
-		if (!function_exists('fsockopen')) {
+	public static function test($capabilities = array())
+	{
+		if (!function_exists('fsockopen'))
+		{
 			return false;
 		}
 
 		// If needed, check that streams support SSL
-		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
-			if (!extension_loaded('openssl') || !function_exists('openssl_x509_parse')) {
+		if (isset($capabilities['ssl']) && $capabilities['ssl'])
+		{
+			if (!extension_loaded('openssl') || !function_exists('openssl_x509_parse'))
+			{
 				return false;
 			}
 
 			// Currently broken, thanks to https://github.com/facebook/hhvm/issues/2156
-			if (defined('HHVM_VERSION')) {
+			if (defined('HHVM_VERSION'))
+			{
 				return false;
 			}
 		}

Upper-Lower-Casing +25 added lines, -25 removed lines

@@ -39,7 +39,7 @@ 
 	 *
 	 * @var int|bool Byte count, or false if no limit.
 	 */
-	protected $max_bytes = false;
+	protected $max_bytes = FALSE;
 
 	protected $connect_error = '';
 
@@ -64,7 +64,7 @@ 
 		}
 		$host = $url_parts['host'];
 		$context = stream_context_create();
-		$verifyname = false;
+		$verifyname = FALSE;
 		$case_insensitive_headers = new Requests_Utility_CaseInsensitiveDictionary($headers);
 
 		// HTTPS support
@@ -75,32 +75,32 @@ 
 			}
 
 			$context_options = array(
-				'verify_peer' => true,
+				'verify_peer' => TRUE,
 				// 'CN_match' => $host,
-				'capture_peer_cert' => true
+				'capture_peer_cert' => TRUE
 			);
-			$verifyname = true;
+			$verifyname = TRUE;
 
 			// SNI, if enabled (OpenSSL >=0.9.8j)
 			if (defined('OPENSSL_TLSEXT_SERVER_NAME') && OPENSSL_TLSEXT_SERVER_NAME) {
-				$context_options['SNI_enabled'] = true;
-				if (isset($options['verifyname']) && $options['verifyname'] === false) {
-					$context_options['SNI_enabled'] = false;
+				$context_options['SNI_enabled'] = TRUE;
+				if (isset($options['verifyname']) && $options['verifyname'] === FALSE) {
+					$context_options['SNI_enabled'] = FALSE;
 				}
 			}
 
 			if (isset($options['verify'])) {
-				if ($options['verify'] === false) {
-					$context_options['verify_peer'] = false;
+				if ($options['verify'] === FALSE) {
+					$context_options['verify_peer'] = FALSE;
 				}
 				elseif (is_string($options['verify'])) {
 					$context_options['cafile'] = $options['verify'];
 				}
 			}
 
-			if (isset($options['verifyname']) && $options['verifyname'] === false) {
-				$context_options['verify_peer_name'] = false;
-				$verifyname = false;
+			if (isset($options['verifyname']) && $options['verifyname'] === FALSE) {
+				$context_options['verify_peer_name'] = FALSE;
+				$verifyname = FALSE;
 			}
 
 			stream_context_set_option($context, array('ssl' => $context_options));
@@ -134,7 +134,7 @@ 
 				throw new Requests_Exception(rtrim($this->connect_error), 'fsockopen.connect_error');
 			}
 
-			throw new Requests_Exception($errstr, 'fsockopenerror', null, $errno);
+			throw new Requests_Exception($errstr, 'fsockopenerror', NULL, $errno);
 		}
 
 		$data_format = $options['data_format'];
@@ -154,7 +154,7 @@ 
 
 		if ($options['type'] !== Requests::TRACE) {
 			if (is_array($data)) {
-				$request_body = http_build_query($data, null, '&');
+				$request_body = http_build_query($data, NULL, '&');
 			}
 			else {
 				$request_body = $data;
@@ -231,8 +231,8 @@ 
 		$response = $body = $headers = '';
 		$this->info = stream_get_meta_data($socket);
 		$size = 0;
-		$doingbody = false;
-		$download = false;
+		$doingbody = FALSE;
+		$download = FALSE;
 		if ($options['filename']) {
 			$download = fopen($options['filename'], 'wb');
 		}
@@ -248,7 +248,7 @@ 
 				$response .= $block;
 				if (strpos($response, "\r\n\r\n")) {
 					list($headers, $block) = explode("\r\n\r\n", $response, 2);
-					$doingbody = true;
+					$doingbody = TRUE;
 				}
 			}
 
@@ -353,7 +353,7 @@ 
 				$url_parts['query'] = '';
 			}
 
-			$url_parts['query'] .= '&' . http_build_query($data, null, '&');
+			$url_parts['query'] .= '&' . http_build_query($data, NULL, '&');
 			$url_parts['query'] = trim($url_parts['query'], '&');
 		}
 		if (isset($url_parts['path'])) {
@@ -380,11 +380,11 @@ 
 		// Double-check we can handle it
 		if (($errno & E_WARNING) === 0 && ($errno & E_NOTICE) === 0) {
 			// Return false to indicate the default error handler should engage
-			return false;
+			return FALSE;
 		}
 
 		$this->connect_error .= $errstr . "\n";
-		return true;
+		return TRUE;
 	}
 
 	/**
@@ -424,21 +424,21 @@ 
 	 */
 	public static function test($capabilities = array()) {
 		if (!function_exists('fsockopen')) {
-			return false;
+			return FALSE;
 		}
 
 		// If needed, check that streams support SSL
 		if (isset($capabilities['ssl']) && $capabilities['ssl']) {
 			if (!extension_loaded('openssl') || !function_exists('openssl_x509_parse')) {
-				return false;
+				return FALSE;
 			}
 
 			// Currently broken, thanks to https://github.com/facebook/hhvm/issues/2156
 			if (defined('HHVM_VERSION')) {
-				return false;
+				return FALSE;
 			}
 		}
 
-		return true;
+		return TRUE;
 	}
 }

php/Requests/libary/Requests/Transport.php

Braces +2 added lines, -1 removed lines

@@ -12,7 +12,8 @@
  * @package Requests
  * @subpackage Transport
  */
-interface Requests_Transport {
+interface Requests_Transport
+{
 	/**
 	 * Perform a request
 	 *

php/Requests/libary/Requests/Utility/CaseInsensitiveDictionary.php

Spacing +3 added lines, -3 removed lines

@@ -26,7 +26,7 @@ 
 	 * @param array $data Dictionary/map to convert to case-insensitive
 	 */
 	public function __construct(array $data = array()) {
-		foreach ($data as $key => $value) {
+		foreach($data as $key => $value) {
 			$this->offsetSet($key, $value);
 		}
 	}
@@ -50,7 +50,7 @@ 
 	 */
 	public function offsetGet($key) {
 		$key = strtolower($key);
-		if (!isset($this->data[$key])) {
+		if(!isset($this->data[$key])) {
 			return null;
 		}
 
@@ -66,7 +66,7 @@ 
 	 * @param string $value Item value
 	 */
 	public function offsetSet($key, $value) {
-		if ($key === null) {
+		if($key === null) {
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 

Braces +20 added lines, -10 removed lines

@@ -25,8 +25,10 @@ 
 	 *
 	 * @param array $data Dictionary/map to convert to case-insensitive
 	 */
-	public function __construct(array $data = array()) {
-		foreach ($data as $key => $value) {
+	public function __construct(array $data = array())
+	{
+		foreach ($data as $key => $value)
+		{
 			$this->offsetSet($key, $value);
 		}
 	}
@@ -37,7 +39,8 @@ 
 	 * @param string $key Item key
 	 * @return boolean Does the item exist?
 	 */
-	public function offsetExists($key) {
+	public function offsetExists($key)
+	{
 		$key = strtolower($key);
 		return isset($this->data[$key]);
 	}
@@ -48,9 +51,11 @@ 
 	 * @param string $key Item key
 	 * @return string Item value
 	 */
-	public function offsetGet($key) {
+	public function offsetGet($key)
+	{
 		$key = strtolower($key);
-		if (!isset($this->data[$key])) {
+		if (!isset($this->data[$key]))
+		{
 			return null;
 		}
 
@@ -65,8 +70,10 @@ 
 	 * @param string $key Item name
 	 * @param string $value Item value
 	 */
-	public function offsetSet($key, $value) {
-		if ($key === null) {
+	public function offsetSet($key, $value)
+	{
+		if ($key === null)
+		{
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 
@@ -79,7 +86,8 @@ 
 	 *
 	 * @param string $key
 	 */
-	public function offsetUnset($key) {
+	public function offsetUnset($key)
+	{
 		unset($this->data[strtolower($key)]);
 	}
 
@@ -88,7 +96,8 @@ 
 	 *
 	 * @return ArrayIterator
 	 */
-	public function getIterator() {
+	public function getIterator()
+	{
 		return new ArrayIterator($this->data);
 	}
 
@@ -97,7 +106,8 @@ 
 	 *
 	 * @return array Header data
 	 */
-	public function getAll() {
+	public function getAll()
+	{
 		return $this->data;
 	}
 }

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
 	public function offsetGet($key) {
 		$key = strtolower($key);
 		if (!isset($this->data[$key])) {
-			return null;
+			return NULL;
 		}
 
 		return $this->data[$key];
@@ -66,7 +66,7 @@ 
 	 * @param string $value Item value
 	 */
 	public function offsetSet($key, $value) {
-		if ($key === null) {
+		if ($key === NULL) {
 			throw new Requests_Exception('Object is a dictionary, not a list', 'invalidset');
 		}
 

php/Requests/libary/Requests/Utility/FilteredIterator.php

Braces +6 added lines, -3 removed lines

@@ -12,7 +12,8 @@ 
  * @package Requests
  * @subpackage Utilities
  */
-class Requests_Utility_FilteredIterator extends ArrayIterator {
+class Requests_Utility_FilteredIterator extends ArrayIterator
+{
 	/**
 	 * Callback to run as a filter
 	 *
@@ -26,7 +27,8 @@ 
 	 * @param array $data
 	 * @param callable $callback Callback to be called on each value
 	 */
-	public function __construct($data, $callback) {
+	public function __construct($data, $callback)
+	{
 		parent::__construct($data);
 
 		$this->callback = $callback;
@@ -37,7 +39,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function current() {
+	public function current()
+	{
 		$value = parent::current();
 		$value = call_user_func($this->callback, $value);
 		return $value;

php/Requests/libary/Requests/Exception/Transport.php

Braces +2 added lines, -1 removed lines

@@ -1,5 +1,6 @@
 <?php
 
-class Requests_Exception_Transport extends Requests_Exception {
+class Requests_Exception_Transport extends Requests_Exception
+{
 
 }