jodel-web.php ➔ sendJodel() - Code Metrics - Inspection of "Fixed Vote and Post for normal users" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ae0f54...3a96c8 )

by mains

created 2017-02-10 19:10 UTC

jodel-web.php ➔ sendJodel() C

↳ Parent: Project

Complexity

Conditions	11
Paths	64

Size

Total Lines	65
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	11
eloc	46
nc	64
nop	2
dl	0
loc	65
rs	5.9999
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

error_reporting(-1);
include 'php/DatabaseConnect.php';
include 'php/Requests/AbstractRequest.php';
include 'php/Requests/CreateUser.php';
include 'php/AccountData.php';
include 'php/Location.php';
include 'php/Requests/GetPosts.php';
include 'php/Requests/GetKarma.php';
include 'php/Requests/UpdateLocation.php';
include 'php/Requests/Upvote.php';
include 'php/Requests/Downvote.php';
include 'php/Requests/GetPostDetails.php';
include 'php/Requests/SendJodel.php';
include 'php/Requests/GetCaptcha.php';
include 'php/Requests/PostCaptcha.php';
include 'php/Requests/GetUserConfig.php';

require_once 'php/Requests/libary/Requests.php';
Requests::register_autoloader();

$lastPostId = '';

function isAccountVerified($accessToken_forId1)

{
	$accountCreator = new GetUserConfig();
	$accountCreator->setAccessToken($accessToken_forId1);
	$data = $accountCreator->execute();

	return $data['verified'];
}

function showCaptcha($accessToken_forId1)
{
	$accountCreator = new GetCaptcha();
	$accountCreator->setAccessToken($accessToken_forId1);
	$captcha = $accountCreator->execute();

	echo $captcha['image_url'];
	echo('<br><img width="100%" src="' . $captcha['image_url'] . '">');
	echo "<br>Key: " . $captcha['key'];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	echo "<br>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

	//Form
	
	echo '<form method="get">';
	echo	'<p>Enter Key (copy pasta from top): <input type="text" name="key" /></p>';
	echo	'<p>Find the Coons (example: they are on picture 3, 4 and 5. You enter 2-3-4. Becouse we start counting at 0): <input type="text" name="solution" /></p>';

	echo	'<p><input type="submit" /></p>';
	echo '</form>';

	die();

	
}

function verifyCaptcha($accessToken_forId1)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	$solution = $_GET['solution'];
	$solution = array_map('intval', explode('-', $solution));

	$accountCreator = new PostCaptcha();
	$accountCreator->setAccessToken($accessToken_forId1);
	$accountCreator->captchaKey = $_GET['key'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$accountCreator->captchaSolution = $solution;
	$verified = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";

	return $verified['verified'];
}

function setLocation($accessToken, $deviceUid)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	$url = 'https://maps.googleapis.com/maps/api/geocode/json?address=' . htmlspecialchars($_GET['city']) . '&key=AIzaSyCwhnja-or07012HqrhPW7prHEDuSvFT4w';
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = Requests::post($url);
	if(json_decode($result->body, true)['status'] == 'ZERO_RESULTS' || json_decode($result->body, true)['status'] == 'INVALID_REQUEST')

	{
		return "0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}
	else
	{
		$name = json_decode($result->body, true)['results']['0']['address_components']['0']['long_name'];
		$lat = json_decode($result->body, true)['results']['0']['geometry']['location']['lat'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$lng = json_decode($result->body, true)['results']['0']['geometry']['location']['lng'];
$a = "a";
$ab = "ab";
$abc = "abc";

		$location = new Location();
		$location->setLat($lat);
		$location->setLng($lng);
		$location->setCityName($name);
		$accountCreator = new UpdateLocation();
		$accountCreator->setLocation($location);
		$accountCreator->setAccessToken($accessToken);
		$data = $accountCreator->execute();

		//safe location to db
		$db = new DatabaseConnect();


		if($data == 'Success')
		{
			$result = $db->query("UPDATE accounts 
					SET name='" . $name . "',
						lat='" . $lat . "',
						lng='" . $lng . "'
					WHERE access_token='" . $accessToken . "'");

			if($result === false)
			{
					echo "Updating location failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else
			{
				error_log('User with JodelDeviceId:' . $deviceUid .  ' [' . $_SERVER['REMOTE_ADDR'] . '][' . $_SERVER ['HTTP_USER_AGENT'] . '] changed to Location: ' . $name);

			}
		}

		return $name;
	}
}

function votePostId($deviceUid_forId1, $accessToken_forId1)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	if(!isAccountVerified($accessToken_forId1))
	{
		showCaptcha($accessToken_forId1);
	}

	if(!deviceUidHasVotedThisPostId($deviceUid_forId1, $_GET['postID']))
	{
		if($_GET['vote'] == "up")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		{
			$accountCreator = new Upvote();
		}
		else if($_GET['vote'] == "down")
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		{
			$accountCreator = new Downvote();
		}
		$accountCreator->setAccessToken($accessToken_forId1);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->postId = htmlspecialchars($_GET['postID']);
		$data = $accountCreator->execute();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}


		addVoteWithPostIdAndTypeToDeviceUid($_GET['postID'], $_GET['vote'], $deviceUid_forId1);
	}

	
	if(isset($_GET['getPostDetails']) && isset($_GET['getPostDetails']))
	{
		header('Location: index.php?getPostDetails=true&postID=' . htmlspecialchars($_GET['postID_parent']) . '#postId-' . htmlspecialchars($_GET['postID']));

	}
	else
	{
		header("Location: index.php#postId-" . htmlspecialchars($_GET['postID']));
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}	
	die();

}

function sendJodel($location, $accessToken_forId1)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	if(!isAccountVerified($accessToken_forId1))
	{
		showCaptcha($accessToken_forId1);
	}

	$accountCreator = new SendJodel();

	if(isset($_POST['ancestor']))
	{
		$ancestor = $_POST['ancestor'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$accountCreator->ancestor = $ancestor;
	}
	if(isset($_POST['color']))
	{
		$color = $_POST['color'];
		switch ($color) {
			case '8ABDB0':
				$color = '8ABDB0';
				break;
			case '9EC41C':
				$color = '9EC41C';
				break;
			case '06A3CB':
				$color = '06A3CB';
				break;
			case 'FFBA00':
				$color = 'FFBA00';
				break;
			case 'DD5F5F':
				$color = 'DD5F5F';
				break;
			case 'FF9908':
				$color = 'FF9908';
				break;
			default:
				$color = '8ABDB0';
				break;
		}
		$accountCreator->color = $color;
	}

	$accountCreatorLocation = new UpdateLocation();

	$accountCreatorLocation->setLocation($location);
	$accountCreatorLocation->setAccessToken($accessToken_forId1);
	$data = $accountCreatorLocation->execute();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	
	$accountCreator->location = $location;
	
	$accountCreator->setAccessToken($accessToken_forId1);
	$data = $accountCreator->execute();

	if(isset($_POST['ancestor']))
	{
		$actual_link = 'http://' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'];
		header('Location: ' . $actual_link . '#postId-' . htmlspecialchars($data['post_id']));
		exit;

	}
	else
	{
		header('Location: ./#');
		exit;

	}
}

function isDeviceUidInDatabase($deviceUid)
{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");

	if ($result->num_rows > 0)

	{
		return TRUE;
	}
	else
	{
		return FALSE;
	}
}

function isTokenFresh(Location $location)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE id='1'");
	
	$access_token;
function someFunction() {
    $x = 5;
    echo $x;
}

	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);//$accountData->getAccessToken());
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function isTokenFreshByAccessToken(Location $location, $accessToken)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE access_token='" . $accessToken . "'");
	
	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);//$accountData->getAccessToken());
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function isTokenFreshByDeviceUid(Location $location, $deviceUid)

{
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid . "'");

	$access_token;
function someFunction() {
    $x = 5;
    echo $x;
}

	if ($result->num_rows > 0)
	{
			// output data of each row
			while($row = $result->fetch_assoc()) {
					//$access_token = $row["access_token"];

					$expiration_date = $row["expiration_date"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					$deviceUid = $row["device_uid"];
$a = "a";
$ab = "ab";
$abc = "abc";
					$access_token = $row["access_token"];
$a = "a";
$ab = "ab";
$abc = "abc";
			}
	}
	else
	{
			echo '0 results';
	}

	if($expiration_date <= time()) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator = new CreateUser();
		$accountCreator->setAccessToken($access_token);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
		$accountCreator->setDeviceUid($deviceUid);
		$accountCreator->setLocation($location);
		$data = $accountCreator->execute();

		$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
		$expiration_date = $data[0]['expiration_date'];
		$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";
		
		$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
		$result = $db->query("UPDATE accounts 
								SET access_token='" . $access_token . "',
									expiration_date='" . $expiration_date . "'
								WHERE device_uid='" . $device_uid . "'");

		if($result === false){
				echo "Adding account failed: (" . $db->errno . ") " . $db->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}	
	}
	
	return $access_token;
}

function getLocationByAccessToken($accessToken)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE access_token='" . $accessToken  . "'");
	
	$location = new Location();
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$location->setLat($row['lat']);
			$location->setLng($row['lng']);
			$location->setCityName($row['name']);
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $location;
}

function getLocationByDeviceUid($deviceUid)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");
	
	$location = new Location();
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$location->setLat($row['lat']);
			$location->setLng($row['lng']);
			$location->setCityName($row['name']);
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $location;
}

function getDeviceUidByAccessToken($accesstoken)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT device_uid FROM accounts WHERE access_token='" . $accesstoken  . "'");
	
	$deviceUid;
function someFunction() {
    $x = 5;
    echo $x;
}
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$deviceUid = $row['device_uid'];
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $deviceUid;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

function getAccessTokenByDeviceUid($deviceUid)

{
	$db = new DatabaseConnect();
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");
	
	$accessToken;
function someFunction() {
    $x = 5;
    echo $x;
}
	
	if ($result->num_rows > 0)
	{
		// output data of each row
		while($row = $result->fetch_assoc())
		{
			$accessToken = $row['access_token'];
		}
	}
	else
	{
		echo "Error: 0 results";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	return $accessToken;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}


function getKarma($accessToken)

{
	$accountCreator = new GetKarma();
	$accountCreator->setAccessToken($accessToken);
	$data = $accountCreator->execute();
	
	return $data["karma"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
}

function deviceUidHasVotedThisPostId($deviceUid, $postId)
{
	$db = new DatabaseConnect();


	$postId = $db->real_escape_string($postId);


	$result = $db->query("SELECT id
						  FROM votes
						  WHERE (postId = '" . $postId . "' AND device_uid = '" . $deviceUid . "')");
	
	if($result === false)

	{
		$error = db_error();
		echo $error;
		echo "Adding Vote failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	if($result->num_rows == 0)

	{
	    return FALSE;
	}
	else
	{
	    return TRUE;
	}
}

function addVoteWithPostIdAndTypeToDeviceUid($postId, $voteType, $device_uid)
{
	$db = new DatabaseConnect();  


	$postId = $db->real_escape_string($postId);
$a = "a";
$ab = "ab";
$abc = "abc";
	$voteType = $db->real_escape_string($voteType);

	
	if(deviceUidHasVotedThisPostId($device_uid, $postId))
	{
		return "Already voted";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	$result = $db->query("INSERT INTO votes (device_uid, postId, type)
					VALUES ('" . $device_uid . "','" . $postId . "','" . $voteType . "')");
	
	if($result === false){

			$error = db_error();
			echo $error;
			echo "Adding Vote failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}		
}

function registerAccount(Location $location) {
	$accountCreator = new CreateUser();
	$accountCreator->setLocation($location);
	$data = $accountCreator->execute();
	
	$access_token = (string)$data[0]['access_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$refresh_token = (string)$data[0]['refresh_token'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$token_type = (string)$data[0]['token_type'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$expires_in = $data[0]['expires_in'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$expiration_date = $data[0]['expiration_date'];
	$distinct_id = (string)$data[0]['distinct_id'];
$a = "a";
$ab = "ab";
$abc = "abc";
	$device_uid = (string)$data[1];
$a = "a";
$ab = "ab";
$abc = "abc";

	$name = $location->cityName;
	$lat = $location->lat;
$a = "a";
$ab = "ab";
$abc = "abc";
	$lng = $location->lng;
$a = "a";
$ab = "ab";
$abc = "abc";
	
	$db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
	$result = $db->query("INSERT INTO accounts (access_token, refresh_token, token_type,
					expires_in, expiration_date, distinct_id, device_uid, name, lat, lng)
					VALUES ('" . $access_token . "','" . $refresh_token . "','" . $token_type .
					"','" .  $expires_in . "','" . $expiration_date . "','" . $distinct_id .
					"','" . $device_uid . "','" . $name . "','" . $lat . "','" . $lng . "') ");

	$success = TRUE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	if($result === false){

			$error = db_error();
			echo $error;
			echo "Adding account failed: (" . $result->errno . ") " . $result->error;
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			$success = FALSE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
	}	
	
	return $device_uid;
}

function getPosts($lastPostId, $accessToken, $url, $version = 'v2')
{	
	$accountCreator = new GetPosts();
	$accountCreator->setLastPostId($lastPostId);
	$accountCreator->setAccessToken($accessToken);
	$accountCreator->setUrl($url);
	$accountCreator->version = $version;

	$config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
	$location = new Location();
	$location->setLat($config['default_lat']);
	$location->setLng($config['default_lng']);
	$location->setCityName($config['default_location']);
	$accountCreator->location = $location;
	$data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
	
	return $data;
}

function createAccount()
{
	$config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
	$location = new Location();
	$location->setLat($config['default_lat']);
	$location->setLng($config['default_lng']);
	$location->setCityName($config['default_location']);

	$device_uid = registerAccount($location);

	return $device_uid;
}

function isUserBot()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
	preg_match('/bot|spider|google|twitter/i', $_SERVER['HTTP_USER_AGENT'], $matches);

    return (isset($matches[0])) ? true : false;
}

function botDeviceUidIsSet($config)
{
	if(!array_key_exists('botDeviceUid', $config) || !isset($config['botDeviceUid']) || $config['botDeviceUid'] == '' || $config['botDeviceUid'] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')

	{
		return FALSE;
	}
	else
	{
		return TRUE;
	}
}

/**
 * Compute HTML Code
 */

/**
 * Gets the title.
 *
 * @return     string  The title.
 */
function getTitle($post, $view = 'time', $isDetailedView = FALSE)

{
	$title = 'JodelBlue - Web-App and Browser-Client';

	if($isDetailedView)
	{
		$title = 'JodelBlue: ' . substr(htmlspecialchars($post['message']), 0, 44);
	}

	return $title;
}

/**
 * Gets the meta description.
 *
 * @return     string  The meta description.
 */
function getMetaDescription($post, $view = 'time', $isDetailedView = FALSE)

{
	$description = 'JodelBlue is a Web-App and Browser-Client for the Jodel App. No registration required! Browse Jodels all over the world. Send your own Jodels or upvote others.';


	if($isDetailedView)
	{
		$description = 'On JodelBlue with ' . htmlspecialchars($post['vote_count']) . ' Upvotes: ' . substr(htmlspecialchars($post['message']), 0, 140);

	}

	return $description;
}

function jodelToHtml($post, $view = 'time', $isDetailedView = FALSE)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{	//ToDO

	//Replace # with link
	//preg_replace('~(\#)([^\s!,. /()"\'?]+)~', '<a href="tag/$2">#$2</a>', $text);


	//Time to time difference
	$now = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
	$d = new DateTime($post['created_at']);
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff = $now->diff($d);

	$timediff_inSeconds = (string)$timediff->format('%s');
	$timediff_inMinutes = (string)$timediff->format('%i');
	$timediff_inHours = (string)$timediff->format('%h');
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff_inDays = (string)$timediff->format('%d');
$a = "a";
$ab = "ab";
$abc = "abc";
	$timediff_inMonth = (string)$timediff->format('%m');
$a = "a";
$ab = "ab";
$abc = "abc";

	if($timediff_inMonth!=0)
	{
			$timediff = $timediff_inMonth . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}
	else
	{
		if($timediff_inDays!=0)
		{
			$timediff = $timediff_inDays . "d";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}
		else
		{
			if($timediff_inHours!=0)
			{
				$timediff = $timediff_inHours . "h";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else
			{
				if($timediff_inMinutes!=0)
				{
					$timediff = $timediff_inMinutes . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				}
				else
				{
					$timediff = $timediff_inSeconds . "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				}
			}
		}
	}


	?>
	<article id ="postId-<?php echo $post['post_id']; ?>" class="jodel" style="background-color: #<?php echo $post['color'];?>;">

		<content>
			<?php 
			if(isset($post['image_url']))
			{
			    $regexRest = '/[^\w$ .!?-]+/u';

				echo '<img src="' . $post['image_url'] . '" alt="' . htmlspecialchars(preg_replace($regexRest, '', $post['message'])) . '">';

			}
			else {
				echo str_replace('  ', ' &nbsp;', nl2br(htmlspecialchars($post['message'])));
			}
			?>
		</content>
		<aside>
			<?php
				if($isDetailedView)

				{?>
					<a href="index.php?vote=up&getPostDetails=true&postID=<?php echo $post['post_id'];?>&postID_parent=<?php echo htmlspecialchars($_GET['postID']);?>" rel="nofollow">

		  <?php }
				else
				{?>
					<a href="index.php?vote=up&postID=<?php echo $post['post_id'];?>" rel="nofollow">
		  <?php } ?>
						<i class="fa fa-angle-up fa-3x"></i>
					</a>	
						<br />
					<?php echo $post["vote_count"];?><br />
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			<?php
				if($isDetailedView)

				{?>
					<a href="index.php?vote=down&getPostDetails=true&postID=<?php echo $post['post_id'];?>&postID_parent=<?php echo htmlspecialchars($_GET['postID']);?>" rel="nofollow">

		  <?php }
				else
				{?>
					<a href="index.php?vote=down&postID=<?php echo $post['post_id'];?>" rel="nofollow">
		  <?php } ?>
						<i class="fa fa-angle-down fa-3x"></i>
					</a>
		</aside>

		<footer>
			<table>
				<tr>
					<td class="time">
						<span class="tip" data-tooltip="Time">
							<i class="fa fa-clock-o"></i>
							<?php echo $timediff;?>
							<span class="tiptext"><?php echo $d->format('Y-m-d H:i:s');?></span>
						</span> 
					</td>
					<td class="comments">
						<?php if(!$isDetailedView) {?>
						<span data-tooltip="Comments">
							<a href="index.php?getPostDetails=true&view=<?php echo $view;?>&postID=<?php echo $post["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								<i class="fa fa-commenting-o"></i>
								<?php if(array_key_exists("child_count", $post)) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
											echo $post["child_count"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										} else echo "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								?>
								</a>
						</span>
						<?php } ?>
					</td>
					<td class="distance">
						<?php
							if($isDetailedView)
							{
								if(isset($post["parent_creator"]) && $post["parent_creator"] == 1)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
								{
									?>
									<span data-tooltip="Author">
										<i class="fa fa-user-o"></i> OJ |
									</span>
									<?php 
						  		}
						  		else
						  		{
						  			//Is not parent Jodel in detailed View
									if(!array_key_exists('child_count', $post) && array_key_exists('parent_creator', $post))
									{
							  			?>
							  			<span data-tooltip="Author">
											<i class="fa fa-user-o"></i> #<?php echo $post["user_handle"];?> |
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
										</span>
										<?php
									}
						  		}
						  	}
					  		?>

						<span class="tip" data-tooltip="Distance">
							<i class="fa fa-map-marker"></i>
							<?php echo $post['distance'];?> km
							<span class="tiptext"><?php echo $post['location']['name'];?></span>
						</span>
					</td>
				</tr>
			</table>
		</footer>
	</article>
<?php
}



Push — master ( ae0f54...3a96c8 )

jodel-web.php ➔ sendJodel() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 24 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			error_reporting(-1);
3			include 'php/DatabaseConnect.php';
4			include 'php/Requests/AbstractRequest.php';
5			include 'php/Requests/CreateUser.php';
6			include 'php/AccountData.php';
7			include 'php/Location.php';
8			include 'php/Requests/GetPosts.php';
9			include 'php/Requests/GetKarma.php';
10			include 'php/Requests/UpdateLocation.php';
11			include 'php/Requests/Upvote.php';
12			include 'php/Requests/Downvote.php';
13			include 'php/Requests/GetPostDetails.php';
14			include 'php/Requests/SendJodel.php';
15			include 'php/Requests/GetCaptcha.php';
16			include 'php/Requests/PostCaptcha.php';
17			include 'php/Requests/GetUserConfig.php';
18
19			require_once 'php/Requests/libary/Requests.php';
20			Requests::register_autoloader();
21
22			$lastPostId = '';
23
24			function isAccountVerified($accessToken_forId1)
			0 ignored issues – show Documentation introduced 2017-02-10 19:12 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
25			{
26			$accountCreator = new GetUserConfig();
27			$accountCreator->setAccessToken($accessToken_forId1);
28			$data = $accountCreator->execute();
29
30			return $data['verified'];
31			}
32
33			function showCaptcha($accessToken_forId1)
34			{
35			$accountCreator = new GetCaptcha();
36			$accountCreator->setAccessToken($accessToken_forId1);
37			$captcha = $accountCreator->execute();
38

mmainstreet / jodel-web

Push — master ( ae0f54...3a96c8 )

jodel-web.php ➔ sendJodel() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like