Inspection of "Fix Location return type" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e50ac8...3d5f6a )

by mains

created 2016-11-22 14:18 UTC

Status

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -40,6 +40,6 @@
 block discarded – undo
 			 ) DEFAULT CHARSET=utf8";
   if(!$db->query($query))
   {
-    throw new Exception($db->error($mysqli));
+	throw new Exception($db->error($mysqli));
   }
 

Please login to merge, or discard this patch.

php/Requests/GetKarma.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -3,18 +3,18 @@
 block discarded – undo
 
 class GetKarma extends AbstractRequest {
 		
-    function getApiEndPoint()
-    {
-        return '/v2/users/karma';
-    }
-    function getPayload()
-    {
-        return array(
-        );
-    }
-    function getMethod()
-    {
-        return 'GET';
-    }
+	function getApiEndPoint()
+	{
+		return '/v2/users/karma';
+	}
+	function getPayload()
+	{
+		return array(
+		);
+	}
+	function getMethod()
+	{
+		return 'GET';
+	}
 }
 

Please login to merge, or discard this patch.

php/Requests/GetPosts.php 1 patch

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

@@ -5,20 +5,20 @@  discard block
 block discarded – undo
 {
 	public $lastPostId;
 
-    public $url;
+	public $url;
         
-    function setUrl ($url)
-    {
-            $this->url = $url;
-    }
+	function setUrl ($url)
+	{
+			$this->url = $url;
+	}
     
-    function getUrl ()
-    {
-        return $this->url;
-    }
+	function getUrl ()
+	{
+		return $this->url;
+	}
 		
-    function setLastPostId ($lastPostId)
-    {
+	function setLastPostId ($lastPostId)
+	{
 			$this->lastPostId = $lastPostId;
 	}
 	
@@ -27,22 +27,22 @@  discard block
 block discarded – undo
 		return $this->lastPostId;
 	}
     
-    function getApiEndPoint()
-    {
-        $apiEndPoint = $this->getUrl();
-        //echo $GLOBALS['lastPostId'];
-        if ($this->getLastPostId() != "") {
+	function getApiEndPoint()
+	{
+		$apiEndPoint = $this->getUrl();
+		//echo $GLOBALS['lastPostId'];
+		if ($this->getLastPostId() != "") {
 			$apiEndPoint = $this->getUrl() . '/location/?after=' . $this->getLastPostId();
 		}
-        return $apiEndPoint;
-    }
-    function getPayload()
-    {
-        return array(
-        );
-    }
-    function getMethod()
-    {
-        return 'GET';
-    }
+		return $apiEndPoint;
+	}
+	function getPayload()
+	{
+		return array(
+		);
+	}
+	function getMethod()
+	{
+		return 'GET';
+	}
 }

Please login to merge, or discard this patch.

php/Requests/Upvote.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -3,19 +3,19 @@
 block discarded – undo
 
 class Upvote extends AbstractRequest {
 		
-    function getApiEndPoint()
-    {
-        return '/v2/posts/' . $_GET['postID'] . '/upvote';
-    }
-    function getPayload()
-    {
-        return array(
+	function getApiEndPoint()
+	{
+		return '/v2/posts/' . $_GET['postID'] . '/upvote';
+	}
+	function getPayload()
+	{
+		return array(
 					"reason_code" => -1,
-        );
-    }
-    function getMethod()
-    {
-        return 'PUT';
-    }
+		);
+	}
+	function getMethod()
+	{
+		return 'PUT';
+	}
 }
 

Please login to merge, or discard this patch.

php/Requests/GetPostDetails.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -3,18 +3,18 @@
 block discarded – undo
 
 class GetPostDetails extends AbstractRequest {
 		
-    function getApiEndPoint()
-    {
-        return '/v2/posts/' . $_GET['postID'];
-    }
-    function getPayload()
-    {
-        return array(
-        );
-    }
-    function getMethod()
-    {
-        return 'GET';
-    }
+	function getApiEndPoint()
+	{
+		return '/v2/posts/' . $_GET['postID'];
+	}
+	function getPayload()
+	{
+		return array(
+		);
+	}
+	function getMethod()
+	{
+		return 'GET';
+	}
 }
 

Please login to merge, or discard this patch.

php/Requests/SendJodel.php 1 patch

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

@@ -1,59 +1,59 @@
 block discarded – undo
 <?php
 
 class SendJodel extends AbstractRequest {
-     /**
-     * @var Location
-     */
-    public $location;
-    /**
-     * @return Location
-     */
-    public function getLocation(): Location
-    {
-        return $this->location;
-    }
-    /**
-     * @param Location $location
-     */
-    public function setLocation(Location $location)
-    {
-        $this->location = $location;
-    }
+	 /**
+	  * @var Location
+	  */
+	public $location;
+	/**
+	 * @return Location
+	 */
+	public function getLocation(): Location
+	{
+		return $this->location;
+	}
+	/**
+	 * @param Location $location
+	 */
+	public function setLocation(Location $location)
+	{
+		$this->location = $location;
+	}
     
-    public $ancestor;
-    /**
-     * @return Location
-     */
-    public function getAncestor()
-    {
-        return $this->ancestor;
-    }
-    /**
-     * @param Location $location
-     */
-    public function setAncestor($ancestor)
-    {
-        if(isset($ancestor) && $ancestor != "")
-        {
+	public $ancestor;
+	/**
+	 * @return Location
+	 */
+	public function getAncestor()
+	{
+		return $this->ancestor;
+	}
+	/**
+	 * @param Location $location
+	 */
+	public function setAncestor($ancestor)
+	{
+		if(isset($ancestor) && $ancestor != "")
+		{
 					$this->ancestor = $ancestor;
 				}
-    }
+	}
     
-    function getApiEndPoint()
-    {
-        return '/v3/posts/';
-    }
-    function getPayload()
-    {
-        return array(
+	function getApiEndPoint()
+	{
+		return '/v3/posts/';
+	}
+	function getPayload()
+	{
+		return array(
 						"ancestor" => $this->getAncestor(),
 						"color" => "9EC41C",
-            "location" => $this->getLocation()->toArray(),
-            "message" => $_POST['message'],
-        );
-    }
-    function getMethod()
-    {
-        return 'POST';
-    }
+			"location" => $this->getLocation()->toArray(),
+			"message" => $_POST['message'],
+		);
+	}
+	function getMethod()
+	{
+		return 'POST';
+	}
 }

Please login to merge, or discard this patch.

php/Requests/Downvote.php 1 patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -3,18 +3,18 @@
 block discarded – undo
 
 class Downvote extends AbstractRequest {
 		
-    function getApiEndPoint()
-    {
-        return '/v2/posts/' . $_GET['postID'] . '/downvote';
-    }
-    function getPayload()
-    {
-        return array(
-        );
-    }
-    function getMethod()
-    {
-        return 'PUT';
-    }
+	function getApiEndPoint()
+	{
+		return '/v2/posts/' . $_GET['postID'] . '/downvote';
+	}
+	function getPayload()
+	{
+		return array(
+		);
+	}
+	function getMethod()
+	{
+		return 'PUT';
+	}
 }
 

Please login to merge, or discard this patch.

php/Requests/UpdateLocation.php 1 patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -3,37 +3,37 @@
 block discarded – undo
 
 class UpdateLocation extends AbstractRequest {
 		 /**
-     * @var Location
-     */
-    public $location;
-    /**
-     * @return Location
-     */
-    public function getLocation(): Location
-    {
-        return $this->location;
-    }
-    /**
-     * @param Location $location
-     */
-    public function setLocation(Location $location)
-    {
-        $this->location = $location;
-    }
+		  * @var Location
+		  */
+	public $location;
+	/**
+	 * @return Location
+	 */
+	public function getLocation(): Location
+	{
+		return $this->location;
+	}
+	/**
+	 * @param Location $location
+	 */
+	public function setLocation(Location $location)
+	{
+		$this->location = $location;
+	}
 		
-    function getApiEndPoint()
-    {
-        return '/v2/users/location';
-    }
-    function getPayload()
-    {
-        return array(
+	function getApiEndPoint()
+	{
+		return '/v2/users/location';
+	}
+	function getPayload()
+	{
+		return array(
 					"location" => $this->getLocation()->toArray(),
-        );
-    }
-    function getMethod()
-    {
-        return 'PUT';
-    }
+		);
+	}
+	function getMethod()
+	{
+		return 'PUT';
+	}
 }
 

Please login to merge, or discard this patch.

php/Requests/SetLocation.php 1 patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

@@ -3,37 +3,37 @@
 block discarded – undo
 
 class UpdateLocation extends AbstractRequest {
 		 /**
-     * @var Location
-     */
-    public $location;
-    /**
-     * @return Location
-     */
-    public function getLocation(): Location
-    {
-        return $this->location;
-    }
-    /**
-     * @param Location $location
-     */
-    public function setLocation(Location $location)
-    {
-        $this->location = $location;
-    }
+		  * @var Location
+		  */
+	public $location;
+	/**
+	 * @return Location
+	 */
+	public function getLocation(): Location
+	{
+		return $this->location;
+	}
+	/**
+	 * @param Location $location
+	 */
+	public function setLocation(Location $location)
+	{
+		$this->location = $location;
+	}
 		
-    function getApiEndPoint()
-    {
-        return '/v2/users/location';
-    }
-    function getPayload()
-    {
-        return array(
+	function getApiEndPoint()
+	{
+		return '/v2/users/location';
+	}
+	function getPayload()
+	{
+		return array(
 					"location" => $this->getLocation()->toArray(),
-        );
-    }
-    function getMethod()
-    {
-        return 'PUT';
-    }
+		);
+	}
+	function getMethod()
+	{
+		return 'PUT';
+	}
 }
 

Please login to merge, or discard this patch.

		@@ -40,6 +40,6 @@
		block discarded – undo
40	40	) DEFAULT CHARSET=utf8";
41	41	if(!$db->query($query))
42	42	{
43		- throw new Exception($db->error($mysqli));
	43	+ throw new Exception($db->error($mysqli));
44	44	}
45	45

		@@ -3,18 +3,18 @@
		block discarded – undo
3	3
4	4	class GetKarma extends AbstractRequest {
5	5
6		- function getApiEndPoint()
7		- {
8		- return '/v2/users/karma';
9		- }
10		- function getPayload()
11		- {
12		- return array(
13		- );
14		- }
15		- function getMethod()
16		- {
17		- return 'GET';
18		- }
	6	+ function getApiEndPoint()
	7	+ {
	8	+ return '/v2/users/karma';
	9	+ }
	10	+ function getPayload()
	11	+ {
	12	+ return array(
	13	+ );
	14	+ }
	15	+ function getMethod()
	16	+ {
	17	+ return 'GET';
	18	+ }
19	19	}
20	20

		@@ -5,20 +5,20 @@ discard block
		block discarded – undo
5	5	{
6	6	public $lastPostId;
7	7
8		- public $url;
	8	+ public $url;
9	9
10		- function setUrl ($url)
11		- {
12		- $this->url = $url;
13		- }
	10	+ function setUrl ($url)
	11	+ {
	12	+ $this->url = $url;
	13	+ }
14	14
15		- function getUrl ()
16		- {
17		- return $this->url;
18		- }
	15	+ function getUrl ()
	16	+ {
	17	+ return $this->url;
	18	+ }
19	19
20		- function setLastPostId ($lastPostId)
21		- {
	20	+ function setLastPostId ($lastPostId)
	21	+ {
22	22	$this->lastPostId = $lastPostId;
23	23	}
24	24
		@@ -27,22 +27,22 @@ discard block
		block discarded – undo
27	27	return $this->lastPostId;
28	28	}
29	29
30		- function getApiEndPoint()
31		- {
32		- $apiEndPoint = $this->getUrl();
33		- //echo $GLOBALS['lastPostId'];
34		- if ($this->getLastPostId() != "") {
	30	+ function getApiEndPoint()
	31	+ {
	32	+ $apiEndPoint = $this->getUrl();
	33	+ //echo $GLOBALS['lastPostId'];
	34	+ if ($this->getLastPostId() != "") {
35	35	$apiEndPoint = $this->getUrl() . '/location/?after=' . $this->getLastPostId();
36	36	}
37		- return $apiEndPoint;
38		- }
39		- function getPayload()
40		- {
41		- return array(
42		- );
43		- }
44		- function getMethod()
45		- {
46		- return 'GET';
47		- }
	37	+ return $apiEndPoint;
	38	+ }
	39	+ function getPayload()
	40	+ {
	41	+ return array(
	42	+ );
	43	+ }
	44	+ function getMethod()
	45	+ {
	46	+ return 'GET';
	47	+ }
48	48	}

		@@ -3,19 +3,19 @@
		block discarded – undo
3	3
4	4	class Upvote extends AbstractRequest {
5	5
6		- function getApiEndPoint()
7		- {
8		- return '/v2/posts/' . $_GET['postID'] . '/upvote';
9		- }
10		- function getPayload()
11		- {
12		- return array(
	6	+ function getApiEndPoint()
	7	+ {
	8	+ return '/v2/posts/' . $_GET['postID'] . '/upvote';
	9	+ }
	10	+ function getPayload()
	11	+ {
	12	+ return array(
13	13	"reason_code" => -1,
14		- );
15		- }
16		- function getMethod()
17		- {
18		- return 'PUT';
19		- }
	14	+ );
	15	+ }
	16	+ function getMethod()
	17	+ {
	18	+ return 'PUT';
	19	+ }
20	20	}
21	21

		@@ -3,18 +3,18 @@
		block discarded – undo
3	3
4	4	class GetPostDetails extends AbstractRequest {
5	5
6		- function getApiEndPoint()
7		- {
8		- return '/v2/posts/' . $_GET['postID'];
9		- }
10		- function getPayload()
11		- {
12		- return array(
13		- );
14		- }
15		- function getMethod()
16		- {
17		- return 'GET';
18		- }
	6	+ function getApiEndPoint()
	7	+ {
	8	+ return '/v2/posts/' . $_GET['postID'];
	9	+ }
	10	+ function getPayload()
	11	+ {
	12	+ return array(
	13	+ );
	14	+ }
	15	+ function getMethod()
	16	+ {
	17	+ return 'GET';
	18	+ }
19	19	}
20	20

		@@ -1,59 +1,59 @@
		block discarded – undo
1	1	<?php
2	2
3	3	class SendJodel extends AbstractRequest {
4		- /**
5		- * @var Location
6		- */
7		- public $location;
8		- /**
9		- * @return Location
10		- */
11		- public function getLocation(): Location
12		- {
13		- return $this->location;
14		- }
15		- /**
16		- * @param Location $location
17		- */
18		- public function setLocation(Location $location)
19		- {
20		- $this->location = $location;
21		- }
	4	+ /**
	5	+ * @var Location
	6	+ */
	7	+ public $location;
	8	+ /**
	9	+ * @return Location
	10	+ */
	11	+ public function getLocation(): Location
	12	+ {
	13	+ return $this->location;
	14	+ }
	15	+ /**
	16	+ * @param Location $location
	17	+ */
	18	+ public function setLocation(Location $location)
	19	+ {
	20	+ $this->location = $location;
	21	+ }
22	22
23		- public $ancestor;
24		- /**
25		- * @return Location
26		- */
27		- public function getAncestor()
28		- {
29		- return $this->ancestor;
30		- }
31		- /**
32		- * @param Location $location
33		- */
34		- public function setAncestor($ancestor)
35		- {
36		- if(isset($ancestor) && $ancestor != "")
37		- {
	23	+ public $ancestor;
	24	+ /**
	25	+ * @return Location
	26	+ */
	27	+ public function getAncestor()
	28	+ {
	29	+ return $this->ancestor;
	30	+ }
	31	+ /**
	32	+ * @param Location $location
	33	+ */
	34	+ public function setAncestor($ancestor)
	35	+ {
	36	+ if(isset($ancestor) && $ancestor != "")
	37	+ {
38	38	$this->ancestor = $ancestor;
39	39	}
40		- }
	40	+ }
41	41
42		- function getApiEndPoint()
43		- {
44		- return '/v3/posts/';
45		- }
46		- function getPayload()
47		- {
48		- return array(
	42	+ function getApiEndPoint()
	43	+ {
	44	+ return '/v3/posts/';
	45	+ }
	46	+ function getPayload()
	47	+ {
	48	+ return array(
49	49	"ancestor" => $this->getAncestor(),
50	50	"color" => "9EC41C",
51		- "location" => $this->getLocation()->toArray(),
52		- "message" => $_POST['message'],
53		- );
54		- }
55		- function getMethod()
56		- {
57		- return 'POST';
58		- }
	51	+ "location" => $this->getLocation()->toArray(),
	52	+ "message" => $_POST['message'],
	53	+ );
	54	+ }
	55	+ function getMethod()
	56	+ {
	57	+ return 'POST';
	58	+ }
59	59	}

		@@ -3,18 +3,18 @@
		block discarded – undo
3	3
4	4	class Downvote extends AbstractRequest {
5	5
6		- function getApiEndPoint()
7		- {
8		- return '/v2/posts/' . $_GET['postID'] . '/downvote';
9		- }
10		- function getPayload()
11		- {
12		- return array(
13		- );
14		- }
15		- function getMethod()
16		- {
17		- return 'PUT';
18		- }
	6	+ function getApiEndPoint()
	7	+ {
	8	+ return '/v2/posts/' . $_GET['postID'] . '/downvote';
	9	+ }
	10	+ function getPayload()
	11	+ {
	12	+ return array(
	13	+ );
	14	+ }
	15	+ function getMethod()
	16	+ {
	17	+ return 'PUT';
	18	+ }
19	19	}
20	20

		@@ -3,37 +3,37 @@
		block discarded – undo
3	3
4	4	class UpdateLocation extends AbstractRequest {
5	5	/**
6		- * @var Location
7		- */
8		- public $location;
9		- /**
10		- * @return Location
11		- */
12		- public function getLocation(): Location
13		- {
14		- return $this->location;
15		- }
16		- /**
17		- * @param Location $location
18		- */
19		- public function setLocation(Location $location)
20		- {
21		- $this->location = $location;
22		- }
	6	+ * @var Location
	7	+ */
	8	+ public $location;
	9	+ /**
	10	+ * @return Location
	11	+ */
	12	+ public function getLocation(): Location
	13	+ {
	14	+ return $this->location;
	15	+ }
	16	+ /**
	17	+ * @param Location $location
	18	+ */
	19	+ public function setLocation(Location $location)
	20	+ {
	21	+ $this->location = $location;
	22	+ }
23	23
24		- function getApiEndPoint()
25		- {
26		- return '/v2/users/location';
27		- }
28		- function getPayload()
29		- {
30		- return array(
	24	+ function getApiEndPoint()
	25	+ {
	26	+ return '/v2/users/location';
	27	+ }
	28	+ function getPayload()
	29	+ {
	30	+ return array(
31	31	"location" => $this->getLocation()->toArray(),
32		- );
33		- }
34		- function getMethod()
35		- {
36		- return 'PUT';
37		- }
	32	+ );
	33	+ }
	34	+ function getMethod()
	35	+ {
	36	+ return 'PUT';
	37	+ }
38	38	}
39	39

mmainstreet / jodel-web

Push — master ( e50ac8...3d5f6a )

Status

Category

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +27 added lines, -27 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +49 added lines, -49 removed lines patch added patch discarded remove patch

Indentation +13 added lines, -13 removed lines patch added patch discarded remove patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch

Indentation +30 added lines, -30 removed lines patch added patch discarded remove patch