jodel-web.php ➔ configPropertyExists() - Code Metrics - Inspection of "Code refactoring" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc7130...f4e497 )

by mains

created 2017-02-12 22:07 UTC

jodel-web.php ➔ configPropertyExists() B

↳ Parent: Project

Complexity

Conditions	5
Paths	2

Size

Total Lines	11
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	5
nc	2
nop	2
dl	0
loc	11
rs	8.8571
c	0
b	0
f	0

<?php


include 'php/DatabaseConnect.php';
include 'php/Location.php';
include 'php/JodelAccount.php';
include 'php/Jodel.php';
include 'php/View.php';

include 'php/Requests/AbstractRequest.php';
include 'php/Requests/CreateUser.php';
include 'php/Requests/GetPosts.php';
include 'php/Requests/GetKarma.php';
include 'php/Requests/UpdateLocation.php';
include 'php/Requests/Upvote.php';
include 'php/Requests/Downvote.php';
include 'php/Requests/GetPostDetails.php';
include 'php/Requests/SendJodel.php';
include 'php/Requests/GetCaptcha.php';
include 'php/Requests/PostCaptcha.php';
include 'php/Requests/GetUserConfig.php';
include 'php/Requests/GetChannel.php';

require_once 'php/Requests/libary/Requests.php';
Requests::register_autoloader();

$config = parse_ini_file('config/config.ini.php');

$location = new Location();
$location->setLat($config['default_lat']);
$location->setLng($config['default_lng']);
$location->setCityName($config['default_location']);

$lastPostId = '';

//What is dude doing with my Server?
if($_SERVER['REMOTE_ADDR'] == '94.231.103.52')
{
	echo('You are flooting my Server! Pls enable Cookies in your script and contact me: [email protected]');
	die();
}

function isUserBot()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    preg_match('/bot|spider|google|twitter/i', $_SERVER['HTTP_USER_AGENT'], $matches);

    return (isset($matches[0])) ? true : false;
}

function configPropertyExists($config, $property)
{
    if(!array_key_exists($property, $config) || !isset($config[$property]) || $config[$property] == '' || $config[$property] == 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx')

    {
        return FALSE;
    }
    else
    {
        return TRUE;
    }
}

function isDeviceUidInDatabase($deviceUid)
{
    $db = new DatabaseConnect();  
$a = "a";
$ab = "ab";
$abc = "abc";
    $result = $db->query("SELECT * FROM accounts WHERE device_uid='" . $deviceUid  . "'");

    if ($result->num_rows > 0)

    {
        return TRUE;
    }
    else
    {
        return FALSE;
    }
}

	//Check if it's a Spider or Google Bot
	if(configPropertyExists($config, 'botDeviceUid') && isUserBot())
	{
		error_log('Spider or Bot checked in!');
		
		$jodelAccountForView = new JodelAccount($config['botDeviceUid'], TRUE);
	}
	else
	{
		if(!isset($_COOKIE['JodelDeviceId']) || !isDeviceUidInDatabase($_COOKIE['JodelDeviceId']))
		{
			//$deviceUid = createAccount();

			$jodelAccountForView = new JodelAccount();
			setcookie('JodelDeviceId', $jodelAccountForView->deviceUid, time()+60*60*24*365*10);
			error_log('Created account with JodelDeviceId:' . $jodelAccountForView->deviceUid .  ' for [' . $_SERVER ['HTTP_USER_AGENT'] . ']');

			
		}
		else
		{
			$jodelAccountForView = new JodelAccount($_COOKIE['JodelDeviceId']);
		}
		
	}
	
	if(configPropertyExists($config, 'karmaDeviceUid'))
    {
    	$jodelAccountForKarma = new JodelAccount($config['botDeviceUid']);
    }
    else
    {
    	error_log("No Karma deviceUid set in config file");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$jodelAccountForKarma = new JodelAccount($deviceUid);
    }

	$newPositionStatus = $jodelAccountForView->location->getCityName();

	//Cunstruct View
	$viewTest = new View();

	//Set View
	if(isset($_GET['view']))

	{
		switch ($_GET['view']) {
			case 'comment':
				$view = 'comment';
				break;
			
			case 'upVote':
				$view = 'upVote';
				break;

			default:
				$view = 'time';
				break;
		}
	}
	else
	{
		$view = 'time';
	}
	
	//Verify Account
	if(isset($_GET['solution']) && isset($_GET['key']))
	{
		$jodelAccountForKarma->verifyCaptcha();
	}

	//Set Location
	if(isset($_GET['city']))
	{
		$newPositionStatus = $jodelAccountForView->setLocation();
	}
	
	//Vote
	if(isset($_GET['vote']) && isset($_GET['postID']))
	{
		$jodelAccountForKarma->votePostId();
	}
	
	//SendJodel
	if(isset($_POST['message']))
	{
		$jodelAccountForKarma->sendJodel();
	}


	function getPosts($lastPostId, $accessToken, $url, $version = 'v2')

	{	
		$accountCreator = new GetPosts();
		$accountCreator->setLastPostId($lastPostId);
		$accountCreator->setAccessToken($accessToken);
		$accountCreator->setUrl($url);
		$accountCreator->version = $version;

		$config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
		$location = new Location();
		$location->setLat($config['default_lat']);
		$location->setLng($config['default_lng']);
		$location->setCityName($config['default_location']);
		$accountCreator->location = $location;
		$data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
		
		return $data;
	}

	$posts;
	//Is Channel or City
	if(isset($_GET['city']) && substr($_GET['city'], 0, 1) === '#')
	{
		$channel = substr($_GET['city'], 1);

		$accountCreator = new GetChannel();
		$accountCreator->setAccessToken($jodelAccountForView->accessToken);
		$accountCreator->channel = $channel;
		$posts = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
		if(array_key_exists('recent', $posts))
		{
			$posts = $posts['recent'];
			if(!array_key_exists(0, $posts))

			{
				$posts[0] = array(
			    "post_id" => "0",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "discovered_by" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "message" => "Not found",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "created_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "updated_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "pin_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "color" => "FFBA00",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "got_thanks" => FALSE,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "post_own" => "friend",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "discovered" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "distance" => 9,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "vote_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "location" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    array("name" => "Berlin",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "loc_coordinates" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      array(
			        "lat" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			        "lng" => 0
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      ),
			      "loc_accuracy" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "country" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "city" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    ),
			    "tags" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    array(),
			    "user_handle" => "0"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			 );
			}
		}
		else

		{
			$posts = array();
$a = "a";
$ab = "ab";
$abc = "abc";
			$posts[0] = 
			array(
			    "post_id" => "0",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "discovered_by" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "message" => "Bad Request",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "created_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "updated_at" => "2017-02-11T16:44:50.385Z",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "pin_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "color" => "FFBA00",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "got_thanks" => FALSE,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "post_own" => "friend",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "discovered" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "distance" => 9,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "vote_count" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    "location" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    array("name" => "Berlin",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "loc_coordinates" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      array(
			        "lat" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			        "lng" => 0
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      ),
			      "loc_accuracy" => 0,
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "country" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			      "city" => "",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    ),
			    "tags" =>
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			    array(),
			    "user_handle" => "0"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			 );


		}
		$loops = 29;
$a = "a";
$ab = "ab";
$abc = "abc";
		$isDetailedView = FALSE;
	}
	else
	{
		//Get Post Details
		if(isset($_GET['postID']) && isset($_GET['getPostDetails']))
		{
			$userHandleBuffer = [];

			$accountCreator = new GetPostDetails();
			$accountCreator->setAccessToken($jodelAccountForView->accessToken);
			$data = $accountCreator->execute();

			if(array_key_exists('status_code', $data) && $data->status_code == 404)
			{
				header('HTTP/1.1 410 Gone');
				include './error-pages/410.html';
				exit;
			}

			$posts[0] = $data;

			if(array_key_exists('children', $data)) {
				foreach($data['children'] as $key => $child)
				{
					
					if(!$child["parent_creator"] == 1)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					{
						$numberForUser = array_search($child['user_handle'], $userHandleBuffer);
						if($numberForUser === FALSE)
						{
							array_push($userHandleBuffer, $child['user_handle']);
							$data['children'][$key]['user_handle'] = count($userHandleBuffer);
						}
						else
						{
							$data['children'][$key]['user_handle'] = $numberForUser + 1;
						}
					}

					array_push($posts, $data['children'][$key]);
				}
				$loops = $data['child_count'] + 1;
			}
			else
			{
				$loops = 1;
			}
			$isDetailedView = TRUE;
		}
		//Get Posts
		else
		{
			$version = 'v2';
			if($view=='comment')
			{
				$url = "/v2/posts/location/discussed/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else
			{
				if($view=='upVote')
				{
					$url = "/v2/posts/location/popular/";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				}
				else
				{
					$url = "/v3/posts/location/combo/";
$a = "a";
$ab = "ab";
$abc = "abc";
					$version = 'v3';
				}
			}

			if($version == 'v3')
			{
				$posts = getPosts($lastPostId, $jodelAccountForView->accessToken, $url, $version)['recent'];
			}
			else
			{
				$posts = getPosts($lastPostId, $jodelAccountForView->accessToken, $url, $version)['posts'];
			}
			$loops = 29;
$a = "a";
$ab = "ab";
$abc = "abc";
			$isDetailedView = FALSE;
		}
	}
?>


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 42 and the first side effect is on line 3. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			include 'php/DatabaseConnect.php';
4			include 'php/Location.php';
5			include 'php/JodelAccount.php';
6			include 'php/Jodel.php';
7			include 'php/View.php';
8
9			include 'php/Requests/AbstractRequest.php';
10			include 'php/Requests/CreateUser.php';
11			include 'php/Requests/GetPosts.php';
12			include 'php/Requests/GetKarma.php';
13			include 'php/Requests/UpdateLocation.php';
14			include 'php/Requests/Upvote.php';
15			include 'php/Requests/Downvote.php';
16			include 'php/Requests/GetPostDetails.php';
17			include 'php/Requests/SendJodel.php';
18			include 'php/Requests/GetCaptcha.php';
19			include 'php/Requests/PostCaptcha.php';
20			include 'php/Requests/GetUserConfig.php';
21			include 'php/Requests/GetChannel.php';
22
23			require_once 'php/Requests/libary/Requests.php';
24			Requests::register_autoloader();
25
26			$config = parse_ini_file('config/config.ini.php');
27
28			$location = new Location();
29			$location->setLat($config['default_lat']);
30			$location->setLng($config['default_lng']);
31			$location->setCityName($config['default_location']);
32
33			$lastPostId = '';
34
35			//What is dude doing with my Server?
36			if($_SERVER['REMOTE_ADDR'] == '94.231.103.52')
37			{
38			echo('You are flooting my Server! Pls enable Cookies in your script and contact me: [email protected]');
39			die();

mmainstreet / jodel-web

Push — master ( fc7130...f4e497 )

jodel-web.php ➔ configPropertyExists() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like