View::jodelToHtml() - Code Metrics - Inspection of "Code refactoring" - mmainstreet/jodel-web - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc7130...f4e497 )

by mains

created 2017-02-12 22:07 UTC

View::jodelToHtml() F

↳ Parent: View

Complexity

Conditions	15
Paths	480

Size

Total Lines	151
Code Lines	82

Duplication

Lines	16
Ratio	10.6 %

Importance

Changes

Metric	Value
cc	15
eloc	82
nc	480
nop	3
dl	16
loc	151
rs	3.2563
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

class View
namespace YourVendor;

class YourClass { }
{
	public $view;
	public $lastPostId = '';

	/**
	 * Compute HTML Code
	 */
 	function jodelToHtml($post, $view = 'time', $isDetailedView = FALSE)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {   //ToDO

        //Replace # with link
        //preg_replace('~(\#)([^\s!,. /()"\'?]+)~', '<a href="tag/$2">#$2</a>', $text);


        //Time to time difference
        $now = new DateTime();
$a = "a";
$ab = "ab";
$abc = "abc";
        $d = new DateTime($post['created_at']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff = $now->diff($d);

        $timediff_inSeconds = (string)$timediff->format('%s');
        $timediff_inMinutes = (string)$timediff->format('%i');
        $timediff_inHours = (string)$timediff->format('%h');
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff_inDays = (string)$timediff->format('%d');
$a = "a";
$ab = "ab";
$abc = "abc";
        $timediff_inMonth = (string)$timediff->format('%m');
$a = "a";
$ab = "ab";
$abc = "abc";

        if($timediff_inMonth!=0)
        {
                $timediff = $timediff_inMonth . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        }
        else
        {
            if($timediff_inDays!=0)
            {
                $timediff = $timediff_inDays . "d";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            }
            else
            {
                if($timediff_inHours!=0)
                {
                    $timediff = $timediff_inHours . "h";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                }
                else
                {
                    if($timediff_inMinutes!=0)
                    {
                        $timediff = $timediff_inMinutes . "m";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                    else
                    {
                        $timediff = $timediff_inSeconds . "s";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    }
                }
            }
        }


        ?>
        <article id ="postId-<?php echo $post['post_id']; ?>" class="jodel" style="background-color: #<?php echo $post['color'];?>;">

            <content>
                <?php 
                if(isset($post['image_url']))
                {
                    $regexRest = '/[^\w$ .!?-]+/u';

                    echo '<img src="' . $post['image_url'] . '" alt="' . htmlspecialchars(preg_replace($regexRest, '', $post['message'])) . '">';

                }
                else {
                    echo str_replace('  ', ' &nbsp;', nl2br(htmlspecialchars($post['message'])));
                }
                ?>
            </content>
            <aside>
                <?php
                    if($isDetailedView)

                    {?>
                        <a href="index.php?vote=up&getPostDetails=true&postID=<?php echo $post['post_id'];?>&postID_parent=<?php echo htmlspecialchars($_GET['postID']);?>" rel="nofollow">

              <?php }
                    else
                    {?>
                        <a href="index.php?vote=up&postID=<?php echo $post['post_id'];?>" rel="nofollow">
              <?php } ?>
                            <i class="fa fa-angle-up fa-3x"></i>
                        </a>    
                            <br />
                        <?php echo $post["vote_count"];?><br />
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                <?php
                    if($isDetailedView)

                    {?>
                        <a href="index.php?vote=down&getPostDetails=true&postID=<?php echo $post['post_id'];?>&postID_parent=<?php echo htmlspecialchars($_GET['postID']);?>" rel="nofollow">

              <?php }
                    else
                    {?>
                        <a href="index.php?vote=down&postID=<?php echo $post['post_id'];?>" rel="nofollow">
              <?php } ?>
                            <i class="fa fa-angle-down fa-3x"></i>
                        </a>
            </aside>

            <footer>
                <table>
                    <tr>
                        <td class="time">
                            <span class="tip" data-tooltip="Time">
                                <i class="fa fa-clock-o"></i>
                                <?php echo $timediff;?>
                                <span class="tiptext"><?php echo $d->format('Y-m-d H:i:s');?></span>
                            </span> 
                        </td>
                        <td class="comments">
                            <?php if(!$isDetailedView) {?>
                            <span data-tooltip="Comments">
                                <a href="index.php?getPostDetails=true&view=<?php echo $view;?>&postID=<?php echo $post["post_id"];?>">
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    <i class="fa fa-commenting-o"></i>
                                    <?php if(array_key_exists("child_count", $post)) {
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                                echo $post["child_count"];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                            } else echo "0";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    ?>
                                    </a>
                            </span>
                            <?php } ?>
                        </td>
                        <td class="distance">
                            <?php
                                if($isDetailedView)
                                {
                                    if(isset($post["parent_creator"]) && $post["parent_creator"] == 1)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                    {
                                        ?>
                                        <span data-tooltip="Author">
                                            <i class="fa fa-user-o"></i> OJ |
                                        </span>
                                        <?php 
                                    }
                                    else
                                    {
                                        //Is not parent Jodel in detailed View
                                        if(!array_key_exists('child_count', $post) && array_key_exists('parent_creator', $post))

                                        {
                                            ?>
                                            <span data-tooltip="Author">
                                                <i class="fa fa-user-o"></i> #<?php echo $post["user_handle"];?> |
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                                            </span>
                                            <?php
                                        }
                                    }
                                }
                                ?>

                            <span class="tip" data-tooltip="Distance">
                                <i class="fa fa-map-marker"></i>
                                <?php echo $post['distance'];?> km
                                <span class="tiptext"><?php echo $post['location']['name'];?></span>
                            </span>
                        </td>
                    </tr>
                </table>
            </footer>
        </article>
    <?php
    }


	/**
	 * Gets the title.
	 *
	 * @return     string  The title.
	 */
	function getTitle($post, $view = 'time', $isDetailedView = FALSE)

	{
		$title = 'JodelBlue - Web-App and Browser-Client';

		if($isDetailedView)
		{
			$title = 'JodelBlue: ' . substr(htmlspecialchars($post['message']), 0, 44);
		}

		return $title;
	}

	/**
	 * Gets the meta description.
	 *
	 * @return     string  The meta description.
	 */
	function getMetaDescription($post, $view = 'time', $isDetailedView = FALSE)

	{
		$description = 'JodelBlue is a Web-App and Browser-Client for the Jodel App. No registration required! Browse Jodels all over the world. Send your own Jodels or upvote others.';


		if($isDetailedView)
		{
			$description = 'On JodelBlue with ' . htmlspecialchars($post['vote_count']) . ' Upvotes: ' . substr(htmlspecialchars($post['message']), 0, 140);

		}

		return $description;
	}

	function getCaptcha($accessToken)

	{
		$accountCreator = new GetCaptcha();
		$accountCreator->setAccessToken($accessToken);
		$captcha = $accountCreator->execute();

		return array("image_url" => $captcha['image_url'], "key" => $captcha['key']);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
	}

	function showCaptcha($accessToken)

	{
		$accountCreator = new GetCaptcha();
		$accountCreator->setAccessToken($accessToken);
		$captcha = $accountCreator->execute();

		echo $captcha['image_url'];
		echo('<br><img width="100%" src="' . $captcha['image_url'] . '">');
		echo "<br>Key: " . $captcha['key'];
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		echo "<br>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

		//Form
		
		echo '<form method="get">';
		echo	'<p>Enter Key (copy pasta from top): <input type="text" value="' . $captcha['key'] . '" name="key" /></p>';
		echo	'<p>Find the Coons (example: they are on picture 3, 4 and 5. You enter 2-3-4. Becouse we start counting at 0): <input type="text" name="solution" /></p>';

		echo	'<p><input type="submit" /></p>';
		echo '</form>';

		die();

		
	}

	function getPosts($lastPostId, $accessToken, $url, $version = 'v2')

	{	
		$accountCreator = new GetPosts();
		$accountCreator->setLastPostId($lastPostId);
		$accountCreator->setAccessToken($accessToken);
		$accountCreator->setUrl($url);
		$accountCreator->version = $version;

		$config = parse_ini_file('config/config.ini.php');
$a = "a";
$ab = "ab";
$abc = "abc";
		$location = new Location();
		$location->setLat($config['default_lat']);
		$location->setLng($config['default_lng']);
		$location->setCityName($config['default_location']);
		$accountCreator->location = $location;
		$data = $accountCreator->execute();
$a = "a";
$ab = "ab";
$abc = "abc";
		
		return $data;
	}


}

1			<?php
2
3			class View
			0 ignored issues – show Coding Style Compatibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public $view;
6			public $lastPostId = '';
7
8			/**
9			* Compute HTML Code
10			*/
11			function jodelToHtml($post, $view = 'time', $isDetailedView = FALSE)
			0 ignored issues – show Best Practice introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report `jodelToHtml` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
12			{ //ToDO
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Comment refers to a TODO task This check looks `TODO` comments that have been left in the code. ``TODO``s show that something is left unfinished and should be attended to. Loading history...
13			//Replace # with link
14			//preg_replace('~(\#)([^\s!,. /()"\'?]+)~', '<a href="tag/$2">#$2</a>', $text);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-30 19:24 UTC by Report Bug Copy Issue Report `44%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
15
16			//Time to time difference
17			$now = new DateTime();
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
18			$d = new DateTime($post['created_at']);
			0 ignored issues – show Comprehensibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Avoid variables with short names like $d. Configured minimum length is 3. Short variable names may make your code harder to understand. Variable names should be self-descriptive. This check looks for variable names who are shorter than a configured minimum. Loading history... Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19			$timediff = $now->diff($d);
20
21			$timediff_inSeconds = (string)$timediff->format('%s');
22			$timediff_inMinutes = (string)$timediff->format('%i');
23			$timediff_inHours = (string)$timediff->format('%h');
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
24			$timediff_inDays = (string)$timediff->format('%d');
			0 ignored issues – show Coding Style introduced 2016-11-20 17:06 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
25			$timediff_inMonth = (string)$timediff->format('%m');
			0 ignored issues – show Coding Style introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26
27			if($timediff_inMonth!=0)
28			{
29			$timediff = $timediff_inMonth . "m";
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-02-12 22:10 UTC by Report Bug Copy Issue Report The string literal `m` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
30			}

mmainstreet / jodel-web

Push — master ( fc7130...f4e497 )

View::jodelToHtml() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like