CreateUser

Complexity

Total Complexity

11

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	getLocation()	0	4	1
A	setLocation()	0	4	1
A	getDeviceUid()	0	4	1
A	setDeviceUid()	0	4	1
A	generateDeviceUid()	0	4	1
A	getMethod()	0	4	1
A	random_str()	0	9	2
A	getApiEndPoint()	0	4	1
A	getPayload()	0	13	2

<?php

class CreateUser extends AbstractRequest {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

    /**
     * @var Location
     */
    private $location;
    private $deviceUid;
    /**
     * @return Location
     */
    private function getLocation()
    {
        return $this->location;
    }
    /**
     * @param Location $location
     */
    public function setLocation(Location $location)
    {
        $this->location = $location;
    }
    private function getDeviceUid()

The return type could not be reliably inferred; please add a @return annotation.

    {
		return $this->deviceUid;
	}
	public function setDeviceUid($deviceUid)
    {
			$this->deviceUid = $deviceUid;
	}
    private function generateDeviceUid()
    {
        return $this->random_str(64, 'abcdef0123456789');
    }
    
    private function random_str($length, $keyspace = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ')

This method is not in camel caps format.

    {
        $str = '';
        $max = mb_strlen($keyspace, '8bit') - 1;
        for ($i = 0; $i < $length; ++$i) {
            $str .= $keyspace[rand(0, $max)];
        }
        return $str;
    }
    public function getApiEndPoint()
    {
        return '/v2/users';
    }
    public function getPayload()
    {
			if(!isset($this->deviceUid))
			{
				$this->setDeviceUid($this->generateDeviceUid());
			}

			return array(
					"location" => $this->getLocation()->toArray(),

The string literal location does not require double quotes, as per coding-style, please use single quotes.

					"client_id" => self::CLIENTID,

The string literal client_id does not require double quotes, as per coding-style, please use single quotes.

					"device_uid" => $this->getDeviceUid(),

The string literal device_uid does not require double quotes, as per coding-style, please use single quotes.

			);
    }
    public function getMethod()
    {
        return 'POST';
    }
}

As per coding style, files should not end with a newline character.