AbstractRange::getRangeType() - Code Metrics - Inspection of "Merge pull request #51 from mlocati/remove-code-du..." - mlocati/ip-lib - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f6f67...f7d4f6 )

by Michele

created 2020-09-30 15:09 UTC

AbstractRange::getRangeType() B

↳ Parent: AbstractRange

Complexity

Conditions	10
Paths	29

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	10

Importance

Changes

Metric	Value
dl	0
loc	32
ccs	20
cts	20
cp	1
rs	7.6666
c	0
b	0
f	0
cc	10
nc	29
nop	0
crap	10

How to fix Complexity

<?php

namespace IPLib\Range;

use IPLib\Address\AddressInterface;
use IPLib\Address\IPv4;
use IPLib\Address\IPv6;
use IPLib\Address\Type as AddressType;
use IPLib\Factory;

abstract class AbstractRange implements RangeInterface
{
    /**
     * {@inheritdoc}
     *
     * @see \IPLib\Range\RangeInterface::getRangeType()
     */
    public function getRangeType()
    {
        if ($this->rangeType === null) {
            $addressType = $this->getAddressType();
            if ($addressType === AddressType::T_IPv6 && Subnet::get6to4()->containsRange($this)) {
                $this->rangeType = Factory::rangeFromBoundaries($this->fromAddress->toIPv4(), $this->toAddress->toIPv4())->getRangeType();
class MyClass { }

$x = new MyClass();
$x->foo = true;
            } else {
                switch ($addressType) {
                    case AddressType::T_IPv4:
                        $defaultType = IPv4::getDefaultReservedRangeType();
                        $reservedRanges = IPv4::getReservedRanges();
                        break;
                    case AddressType::T_IPv6:
                        $defaultType = IPv6::getDefaultReservedRangeType();
                        $reservedRanges = IPv6::getReservedRanges();
                        break;
                    default:
                        throw new \Exception('@todo'); // @codeCoverageIgnore
                }
                $rangeType = null;
                foreach ($reservedRanges as $reservedRange) {
                    $rangeType = $reservedRange->getRangeType($this);
                    if ($rangeType !== null) {
                        break;
                    }
                }
                $this->rangeType = $rangeType === null ? $defaultType : $rangeType;
            }
        }

        return $this->rangeType === false ? null : $this->rangeType;
    }

    /**
     * {@inheritdoc}
     *
     * @see \IPLib\Range\RangeInterface::contains()
     */
    public function contains(AddressInterface $address)

    {
        $result = false;
        if ($address->getAddressType() === $this->getAddressType()) {
            $cmp = $address->getComparableString();
            $from = $this->getComparableStartString();
            if ($cmp >= $from) {
                $to = $this->getComparableEndString();
                if ($cmp <= $to) {
                    $result = true;
                }
            }
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     *
     * @see \IPLib\Range\RangeInterface::containsRange()
     */
    public function containsRange(RangeInterface $range)

    {
        $result = false;
        if ($range->getAddressType() === $this->getAddressType()) {
            $myStart = $this->getComparableStartString();
            $itsStart = $range->getComparableStartString();
            if ($itsStart >= $myStart) {
                $myEnd = $this->getComparableEndString();
                $itsEnd = $range->getComparableEndString();
                if ($itsEnd <= $myEnd) {
                    $result = true;
                }
            }
        }

        return $result;
    }
}


1			<?php
2
3			namespace IPLib\Range;
4
5			use IPLib\Address\AddressInterface;
6			use IPLib\Address\IPv4;
7			use IPLib\Address\IPv6;
8			use IPLib\Address\Type as AddressType;
9			use IPLib\Factory;
10
11			abstract class AbstractRange implements RangeInterface
12			{
13			/**
14			* {@inheritdoc}
15			*
16			* @see \IPLib\Range\RangeInterface::getRangeType()
17			*/
18	242		public function getRangeType()
19			{
20	242		if ($this->rangeType === null) {
21	242		$addressType = $this->getAddressType();
22	242		if ($addressType === AddressType::T_IPv6 && Subnet::get6to4()->containsRange($this)) {
23	9		$this->rangeType = Factory::rangeFromBoundaries($this->fromAddress->toIPv4(), $this->toAddress->toIPv4())->getRangeType();
			0 ignored issues – show Bug introduced 2020-09-30 15:00 UTC by Report Bug Copy Issue Report The property `rangeType` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-09-30 15:00 UTC by Report Bug Copy Issue Report The property `fromAddress` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-09-30 15:00 UTC by Report Bug Copy Issue Report The property `toAddress` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			} else {
25			switch ($addressType) {
26	233		case AddressType::T_IPv4:
27	170		$defaultType = IPv4::getDefaultReservedRangeType();
28	170		$reservedRanges = IPv4::getReservedRanges();
29	170		break;
30	63		case AddressType::T_IPv6:
31	63		$defaultType = IPv6::getDefaultReservedRangeType();
32	63		$reservedRanges = IPv6::getReservedRanges();
33	63		break;
34			default:
35			throw new \Exception('@todo'); // @codeCoverageIgnore
36			}
37	233		$rangeType = null;
38	233		foreach ($reservedRanges as $reservedRange) {
39	233		$rangeType = $reservedRange->getRangeType($this);
40	233		if ($rangeType !== null) {
41	233		break;
42			}
43			}
44	233		$this->rangeType = $rangeType === null ? $defaultType : $rangeType;
45			}
46			}
47
48	242		return $this->rangeType === false ? null : $this->rangeType;
49			}
50
51			/**
52			* {@inheritdoc}
53			*
54			* @see \IPLib\Range\RangeInterface::contains()
55			*/
56	241	View Code Duplication	public function contains(AddressInterface $address)
			0 ignored issues – show Duplication introduced 2017-08-29 09:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57			{
58	241		$result = false;
59	241		if ($address->getAddressType() === $this->getAddressType()) {
60	241		$cmp = $address->getComparableString();
61	241		$from = $this->getComparableStartString();
62	241		if ($cmp >= $from) {
63	237		$to = $this->getComparableEndString();
64	237		if ($cmp <= $to) {
65	195		$result = true;
66			}
67			}
68			}
69
70	241		return $result;
71			}
72
73			/**
74			* {@inheritdoc}
75			*
76			* @see \IPLib\Range\RangeInterface::containsRange()
77			*/
78	79	View Code Duplication	public function containsRange(RangeInterface $range)
			0 ignored issues – show Duplication introduced 2017-12-16 23:20 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79			{
80	79		$result = false;
81	79		if ($range->getAddressType() === $this->getAddressType()) {
82	79		$myStart = $this->getComparableStartString();
83	79		$itsStart = $range->getComparableStartString();
84	79		if ($itsStart >= $myStart) {
85	42		$myEnd = $this->getComparableEndString();
86	42		$itsEnd = $range->getComparableEndString();
87	42		if ($itsEnd <= $myEnd) {
88	14		$result = true;
89			}
90			}
91			}
92
93	79		return $result;
94			}
95			}
96

mlocati / ip-lib

Push — master ( 7f6f67...f7d4f6 )

AbstractRange::getRangeType() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like