Issues (25)

Security Analysis    no request data  

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Section/MSCompressedSection.php (3 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
namespace CHMLib\Section;
4
5
use Exception;
6
use CHMLib\CHM;
7
use CHMLib\Reader\StringReader;
8
use CHMLib\Reader\BitReader;
9
use CHMLib\Header\LZXC;
10
use CHMLib\LZX\Inflater;
11
use CHMLib\LZX\LRUCache;
12
13
/**
14
 * Represent a LXZ-compressed section of data in a CHM file.
15
 */
16
class MSCompressedSection extends Section
17
{
18
    /**
19
     * The LZX reset interval.
20
     *
21
     * @var int
22
     */
23
    protected $resetInterval;
24
25
    /**
26
     * The window size.
27
     *
28
     * @var int
29
     */
30
    protected $windowSize;
31
32
    /**
33
     * The size of the uncompressed data.
34
     *
35
     * @var int
36
     */
37
    protected $uncompressedLength;
38
39
    /**
40
     * The size of the compressed data.
41
     *
42
     * @var int
43
     */
44
    protected $compressedLength;
45
46
    /**
47
     * The block size.
48
     *
49
     * @var int
50
     */
51
    protected $blockSize;
52
53
    /**
54
     * The address table.
55
     *
56
     * @var int[]
57
     */
58
    protected $addressTable;
59
60
    /**
61
     * The currently cached blocks.
62
     *
63
     * @var \CHMLib\LZX\LRUCache
64
     */
65
    protected $cachedBlocks;
66
67
    /**
68
     * Initializes the instance.
69
     *
70
     * @param CHM $chm The parent CHM file.
71
     *
72
     * @throws Exception Throws an Exception in case of errors.
73
     */
74 4
    public function __construct(CHM $chm)
75
    {
76 4
        parent::__construct($chm);
77 4
        $controlDataEntry = $chm->getEntryByPath('::DataSpace/Storage/MSCompressed/ControlData');
78 4
        if ($controlDataEntry === null) {
79
            throw new Exception("Missing required entry: '::DataSpace/Storage/MSCompressed/ControlData'");
80
        }
81 4
        if ($controlDataEntry->getContentSectionIndex() !== 0) {
82
            throw new Exception("The content of the entry '{$controlDataEntry->getPath()}' should be in section 0, but it's in section {$controlDataEntry->getContentSectionIndex()}");
83
        }
84 4
        $controlDataReader = new StringReader($controlDataEntry->getContents());
85 4
        $lzxc = new LZXC($controlDataReader);
86 4
        $this->resetInterval = $lzxc->getResetInterval();
87 4
        $this->windowSize = $lzxc->getWindowSize() * 32768;
88 4
        $this->cachedBlocks = new LRUCache((1 + $lzxc->getCacheSize()) << 2);
89 4
        $resetTableEntry = $chm->getEntryByPath('::DataSpace/Storage/MSCompressed/Transform/{7FC28940-9D31-11D0-9B27-00A0C91E9C7C}/InstanceData/ResetTable');
90 4
        if ($resetTableEntry === null) {
91
            throw new Exception("Missing required entry: '::DataSpace/Storage/MSCompressed/Transform/{7FC28940-9D31-11D0-9B27-00A0C91E9C7C}/InstanceData/ResetTable'");
92
        }
93 4
        if ($resetTableEntry->getContentSectionIndex() !== 0) {
94
            throw new Exception("The content of the entry '{$resetTableEntry->getPath()}' should be in section 0, but it's in section {$resetTableEntry->getContentSectionIndex()}");
95
        }
96 4
        $resetTableReader = new StringReader($resetTableEntry->getContents());
97 4
        $resetTableVersion = $resetTableReader->readUInt32();
98 4
        if ($resetTableVersion !== 2) {
99
            throw new Exception("Unsupported LZX Reset Table version: $resetTableVersion");
100
        }
101 4
        $addressTableSize = $resetTableReader->readUInt32();
102 4
        /* Size of table entry (8) */ $resetTableReader->readUInt32();
103 4
        /* Header length (40) */ $resetTableReader->readUInt32();
104 4
        $this->uncompressedLength = $resetTableReader->readUInt64();
0 ignored issues
show
Documentation Bug introduced by
It seems like $resetTableReader->readUInt64() can also be of type double. However, the property $uncompressedLength is declared as type integer. Maybe add an additional type check?

Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.

For example, imagine you have a variable $accountId that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the id property of an instance of the Account class. This class holds a proper account, so the id value must no longer be false.

Either this assignment is in error or a type check should be added for that assignment.

class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
Loading history...
105 4
        $this->compressedLength = $resetTableReader->readUInt64();
0 ignored issues
show
Documentation Bug introduced by
It seems like $resetTableReader->readUInt64() can also be of type double. However, the property $compressedLength is declared as type integer. Maybe add an additional type check?

Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.

For example, imagine you have a variable $accountId that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the id property of an instance of the Account class. This class holds a proper account, so the id value must no longer be false.

Either this assignment is in error or a type check should be added for that assignment.

class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
Loading history...
106 4
        $this->blockSize = $resetTableReader->readUInt64(); // We do not support block sizes bigger than 32-bit integers
0 ignored issues
show
Documentation Bug introduced by
It seems like $resetTableReader->readUInt64() can also be of type double. However, the property $blockSize is declared as type integer. Maybe add an additional type check?

Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.

For example, imagine you have a variable $accountId that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the id property of an instance of the Account class. This class holds a proper account, so the id value must no longer be false.

Either this assignment is in error or a type check should be added for that assignment.

class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
Loading history...
107 4
        $this->addressTable = array();
108 4
        for ($i = 0; $i < $addressTableSize; ++$i) {
109 4
            $this->addressTable[$i] = $resetTableReader->readUInt64();
110
        }
111 4
        $contentEntry = $chm->getEntryByPath('::DataSpace/Storage/MSCompressed/Content');
112 4
        if ($contentEntry === null) {
113
            throw new Exception("Missing required entry: '::DataSpace/Storage/MSCompressed/Content");
114
        }
115 4
        if ($this->compressedLength > $contentEntry->getLength()) {
116
            throw new Exception("Compressed section size should be {$this->compressedLength}, but it's {$contentEntry->getLength()}");
117
        }
118 4
        $this->sectionOffset = $chm->getITSF()->getContentOffset() + $contentEntry->getOffset();
119 4
    }
120
121
    /**
122
     * {@inheritdoc}
123
     *
124
     * @see Section::getContents()
125
     */
126 485
    public function getContents($offset, $length)
127
    {
128 485
        $result = '';
129 485
        if ($length > 0) {
130 483
            $startBlockNo = (int) ($offset / $this->blockSize);
131 483
            $startOffset = $offset % $this->blockSize;
132 483
            $endBlockNo = (int) (($offset + $length) / $this->blockSize);
133 483
            $endOffset = (int) (($offset + $length) % $this->blockSize);
134 483
            if ($endOffset === 0 && $endBlockNo > $startBlockNo) {
135
                $endOffset = $this->blockSize;
136
                --$endBlockNo;
137
            }
138 483
            $blockNo = $startBlockNo - $startBlockNo % $this->resetInterval;
139 483
            $inflater = new Inflater($this->windowSize);
140
141 483
            $pos = 0;
142 483
            $bytesLeft = 0;
143 483
            $reader = $this->chm->getReader();
144 483
            while ($bytesLeft > 0 || $blockNo <= $endBlockNo) {
145 483
                $data = '';
146 483
                while ($bytesLeft <= 0) {
147
                    // Read block
148 483
                    if ($blockNo > $endBlockNo) {
149
                        throw new Exception('Read after last data block');
150
                    }
151 483
                    $cacheNo = (int) ($blockNo / $this->resetInterval);
152 483
                    $cache = $this->cachedBlocks->get($cacheNo);
153 483
                    if ($cache === null) {
154 26
                        $this->cachedBlocks->prune();
155 26
                        $cache = array();
156 26
                        $resetBlockNo = $blockNo - $blockNo % $this->resetInterval;
157 26
                        for ($i = 0; $i < $this->resetInterval && $resetBlockNo + $i < count($this->addressTable); ++$i) {
158 26
                            $thisBlockNo = $resetBlockNo + $i;
159 26
                            $len = ($thisBlockNo + 1 < count($this->addressTable)) ?
160 23
                                ($this->addressTable[$thisBlockNo + 1] - $this->addressTable[$thisBlockNo])
161
                                :
162 26
                                ($this->compressedLength - $this->addressTable[$thisBlockNo]);
163 26
                            $reader->setPosition($this->sectionOffset + $this->addressTable[$thisBlockNo]);
164 26
                            $bitReader = new BitReader($reader->readString($len));
165 26
                            $cache[$i] = $inflater->inflate(
166 26
                                $i === 0,
167 26
                                $bitReader,
168 26
                                $this->blockSize
169
                            );
170
                        }
171 26
                        $this->cachedBlocks->put($cacheNo, $cache);
172
                    }
173 483
                    $data = $cache[$blockNo % $this->resetInterval];
174
                    // the start block has special pos value
175 483
                    $pos = ($blockNo === $startBlockNo) ? $startOffset : 0;
176
                    // the end block has special length
177 483
                    $bytesLeft = ($blockNo < $startBlockNo) ? 0 : (($blockNo < $endBlockNo) ? $this->blockSize : $endOffset);
178 483
                    $bytesLeft -= $pos;
179 483
                    ++$blockNo;
180
                }
181 483
                $togo = $bytesLeft;
182 483
                $result .= substr($data, $pos, $togo);
183 483
                $pos += $togo;
184 483
                $bytesLeft -= $togo;
185
            }
186
        }
187
188 485
        return $result;
189
    }
190
}
191