anonymous//Tests/Unit/SubscribedProcessor/UserDataAppendingTest.php$0 - Code Metrics - Inspection of "Add raven handler test, improve handler" - mleczakm/monolog-sentry-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 419f51...37bf86 )

by Michał

created 2018-08-14 21:25 UTC

0 A

↳ Parent: UserDataAppendingTest::appendToLogsUsernameIfUserHasToStringMethod()

Complexity

Total Complexity

Size/Duplication

Total Lines	6
Duplicated Lines	100 %

Coupling/Cohesion

Dependencies

Importance

Changes

Metric	Value
wmc	1
cbo	0
dl	6
loc	6
rs	10
c	0
b	0
f	0

How to fix Duplicated Code

<?php

declare(strict_types=1);

namespace Dziki\MonologSentryBundle\Tests\Unit\SubscribedProcessor;

use Dziki\MonologSentryBundle\SubscribedProcessor\UserDataAppending;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\HttpKernel\KernelEvents;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
use Symfony\Component\Security\Core\User\UserInterface;

class UserDataAppendingTest extends TestCase
{
    /**
     * @test
     */
    public function isSubscribedToKernelRequest(): void
    {
        $subscribedEvents = UserDataAppending::getSubscribedEvents();
        $this->assertArrayHasKey(KernelEvents::REQUEST, $subscribedEvents);
        $this->assertSame(['onKernelRequest', 7], $subscribedEvents[KernelEvents::REQUEST]);
    }

    /**
     * @test
     */
    public function doNothingIfMissingToken(): void
    {
        /** @var TokenStorageInterface $tokenStorage */
        $tokenStorage = $this->createMock(TokenStorageInterface::class);
        $userDataAppendingProcessor = new UserDataAppending($tokenStorage);

        $userDataAppendingProcessor->onKernelRequest();

        $record = $userDataAppendingProcessor([]);

        $this->assertSame([], $record);
    }

    /**
     * @test
     */
    public function obtainUsernameIfUserImplementsUserInterface(): void
    {
        $user = $this->createMock(UserInterface::class);
        $user
            ->expects($this->once())
            ->method('getUsername')
            ->willReturn('user')
        ;

        $token = $this->createMock(TokenInterface::class);
        $token
            ->method('getUser')
            ->willReturn($user)
        ;

        /** @var TokenStorageInterface|MockObject $tokenStorage */
        $tokenStorage = $this->createMock(TokenStorageInterface::class);
        $tokenStorage

            ->method('getToken')
            ->willReturn($token)
        ;

        $userDataAppendingProcessor = new UserDataAppending($tokenStorage);
        $userDataAppendingProcessor->onKernelRequest();
    }

    /**
     * @test
     */
    public function appendToLogsUsernameIfUserIsString(): void

    {
        $user = 'user';

        $token = $this->createMock(TokenInterface::class);
        $token
            ->method('getUser')
            ->willReturn($user)
        ;

        /** @var TokenStorageInterface|MockObject $tokenStorage */
        $tokenStorage = $this->createMock(TokenStorageInterface::class);
        $tokenStorage

            ->method('getToken')
            ->willReturn($token)
        ;

        $userDataAppendingProcessor = new UserDataAppending($tokenStorage);

        $userDataAppendingProcessor->onKernelRequest();

        $record = $userDataAppendingProcessor([]);

        $this->assertSame(
            ['context' => [
                'user' => [
                    'username' => 'user',
                ],
            ],
            ],
            $record
        );
    }

    /**
     * @test
     */
    public function appendToLogsUsernameIfUserHasToStringMethod(): void

    {
        $user = new class() {
            public function __toString()
            {
                return 'user';
            }
        };

        $token = $this->createMock(TokenInterface::class);
        $token
            ->method('getUser')
            ->willReturn($user)
        ;

        /** @var TokenStorageInterface|MockObject $tokenStorage */
        $tokenStorage = $this->createMock(TokenStorageInterface::class);
        $tokenStorage

            ->method('getToken')
            ->willReturn($token)
        ;

        $userDataAppendingProcessor = new UserDataAppending($tokenStorage);
        $userDataAppendingProcessor->onKernelRequest();

        $record = $userDataAppendingProcessor([]);

        $this->assertSame(
            ['context' => [
                'user' => [
                    'username' => 'user',
                ],
            ],
            ],
            $record
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Dziki\MonologSentryBundle\Tests\Unit\SubscribedProcessor;
6
7		use Dziki\MonologSentryBundle\SubscribedProcessor\UserDataAppending;
8		use PHPUnit\Framework\MockObject\MockObject;
9		use PHPUnit\Framework\TestCase;
10		use Symfony\Component\HttpKernel\KernelEvents;
11		use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
12		use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
13		use Symfony\Component\Security\Core\User\UserInterface;
14
15		class UserDataAppendingTest extends TestCase
16		{
17		/**
18		* @test
19		*/
20		public function isSubscribedToKernelRequest(): void
21		{
22		$subscribedEvents = UserDataAppending::getSubscribedEvents();
23		$this->assertArrayHasKey(KernelEvents::REQUEST, $subscribedEvents);
24		$this->assertSame(['onKernelRequest', 7], $subscribedEvents[KernelEvents::REQUEST]);
25		}
26
27		/**
28		* @test
29		*/
30		public function doNothingIfMissingToken(): void
31		{
32		/** @var TokenStorageInterface $tokenStorage */
33		$tokenStorage = $this->createMock(TokenStorageInterface::class);
34		$userDataAppendingProcessor = new UserDataAppending($tokenStorage);
35
36		$userDataAppendingProcessor->onKernelRequest();
37
38		$record = $userDataAppendingProcessor([]);
39
40		$this->assertSame([], $record);
41		}
42
43		/**
44		* @test
45		*/
46		public function obtainUsernameIfUserImplementsUserInterface(): void
47		{
48		$user = $this->createMock(UserInterface::class);
49		$user
50		->expects($this->once())
51		->method('getUsername')
52		->willReturn('user')
53		;
54
55		$token = $this->createMock(TokenInterface::class);
56		$token
57		->method('getUser')
58		->willReturn($user)
59		;
60
61		/** @var TokenStorageInterface\|MockObject $tokenStorage */
62		$tokenStorage = $this->createMock(TokenStorageInterface::class);
63		$tokenStorage
		0 ignored issues – show Bug introduced 2018-08-14 21:33 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Symfony\Component...\TokenStorageInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
64		->method('getToken')
65		->willReturn($token)
66		;
67
68		$userDataAppendingProcessor = new UserDataAppending($tokenStorage);
69		$userDataAppendingProcessor->onKernelRequest();
70		}
71
72		/**
73		* @test
74		*/
75	View Code Duplication	public function appendToLogsUsernameIfUserIsString(): void
		0 ignored issues – show Duplication introduced 2018-08-14 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
76		{
77		$user = 'user';
78
79		$token = $this->createMock(TokenInterface::class);
80		$token
81		->method('getUser')
82		->willReturn($user)
83		;
84
85		/** @var TokenStorageInterface\|MockObject $tokenStorage */
86		$tokenStorage = $this->createMock(TokenStorageInterface::class);
87		$tokenStorage
		0 ignored issues – show Bug introduced 2018-08-14 21:33 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Symfony\Component...\TokenStorageInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
88		->method('getToken')
89		->willReturn($token)
90		;
91
92		$userDataAppendingProcessor = new UserDataAppending($tokenStorage);
93
94		$userDataAppendingProcessor->onKernelRequest();
95
96		$record = $userDataAppendingProcessor([]);
97
98		$this->assertSame(
99		['context' => [
100		'user' => [
101		'username' => 'user',
102		],
103		],
104		],
105		$record
106		);
107		}
108
109		/**
110		* @test
111		*/
112	View Code Duplication	public function appendToLogsUsernameIfUserHasToStringMethod(): void
		0 ignored issues – show Duplication introduced 2018-08-14 21:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113		{
114		$user = new class() {
115		public function __toString()
116		{
117		return 'user';
118		}
119		};
120
121		$token = $this->createMock(TokenInterface::class);
122		$token
123		->method('getUser')
124		->willReturn($user)
125		;
126
127		/** @var TokenStorageInterface\|MockObject $tokenStorage */
128		$tokenStorage = $this->createMock(TokenStorageInterface::class);
129		$tokenStorage
		0 ignored issues – show Bug introduced 2018-08-14 21:33 UTC by Report Bug Copy Issue Report The method `method()` does not seem to exist on `object<Symfony\Component...\TokenStorageInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
130		->method('getToken')
131		->willReturn($token)
132		;
133
134		$userDataAppendingProcessor = new UserDataAppending($tokenStorage);
135		$userDataAppendingProcessor->onKernelRequest();
136
137		$record = $userDataAppendingProcessor([]);
138
139		$this->assertSame(
140		['context' => [
141		'user' => [
142		'username' => 'user',
143		],
144		],
145		],
146		$record
147		);
148		}
149		}
150

mleczakm / monolog-sentry-bundle

Push — master ( 419f51...37bf86 )

0 A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like