Issues in Parser.php (master) - Issues in master - mkusher/padawan.php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (114)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Padawan/Parser/Parser.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Padawan\Parser;

use Padawan\Domain\Project\FQN;
use Padawan\Domain\Project\Node\Uses;
use Padawan\Framework\Utils\PathResolver;
use PhpParser\ParserFactory;
use PhpParser\NodeTraverser as Traverser;
use Psr\Log\LoggerInterface;
use Padawan\Parser\NamespaceParser;

class Parser
{

    public function __construct(
        ParserFactory $parserFactory,
        Traverser $traverser,
        UseParser $useParser,
        NamespaceParser $namespaceParser,
        LoggerInterface $logger
    ) {
        $this->parserFactory    = $parserFactory;
        $this->traverser        = $traverser;
        $this->useParser        = $useParser;
        $this->namespaceParser  = $namespaceParser;
        $this->walker           = [];
        $this->astPool          = [];
        $this->logger           = $logger;
    }
    public function parseContent($file, $content, Uses $uses = null)
    {
        if (!$uses instanceof Uses) {
            $uses = new Uses(new FQN);
        }
        $this->setUses($uses);
        $this->setFileInfo($uses, $file);
        try {
            $parser = $this->parserFactory->create(ParserFactory::PREFER_PHP5);
            $ast = $parser->parse($content);
        } catch (\Exception $e) {
            $this->logger->error(sprintf("Parsing failed in file %s\n", $file));
            $this->logger->error($e);
            $this->clearWalkers();
            return;
        }
        $this->logger->addInfo(sprintf("Traversing with %s walkers",
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            count($this->walkers)

        ));
        $this->traverser->traverse($ast);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $nodes = $this->getResultScopes();
        $this->clearWalkers();
        return $nodes;
    }
    public function setUses(Uses $uses)
    {
        $this->uses = $uses;
        $this->useParser->setUses($uses);
        $this->namespaceParser->setUses($uses);
    }
    public function getUses()
    {
        return $this->uses;
    }
    public function parseFQCN($fqcn)
    {
        return $this->useParser->parseFQCN($fqcn);
    }
    public function addWalker($walker)
    {
        $this->walkers[] = $walker;

        $this->traverser->addVisitor($walker);
    }
    public function clearWalkers() {
        foreach ($this->walkers AS $walker) {

            $this->traverser->removeVisitor($walker);
        }
        $this->walkers = [];

    }
    public function getResultScopes()
    {
        $nodes = [];
        foreach ($this->walkers as $walker) {

            $nodes[] = $walker->getResultScope();
        }
        if (count($nodes) === 1) {
            return array_pop($nodes);
        }
        return $nodes;
    }
    public function setIndex($index)
    {
        foreach ($this->walkers as $walker) {

            $walker->setIndex($index);
        }
    }

    protected function setFileInfo(Uses $uses, $file)
    {
        foreach ($this->walkers as $walker) {

            $walker->updateFileInfo($uses, $file);
        }
    }

    private $parsedClasses = [];

    /** @var ParserFactory */
    private $parserFactory;
    /** @var Traverser */
    private $traverser;
    /** @var Walker\WalkerInterface[] */
    private $walker;
    private $astPool;
    private $logger;
    /** @var NamespaceParser */
    private $namespaceParser;
    private $useParser;
    private $uses;
}


1			<?php
2
3			namespace Padawan\Parser;
4
5			use Padawan\Domain\Project\FQN;
6			use Padawan\Domain\Project\Node\Uses;
7			use Padawan\Framework\Utils\PathResolver;
8			use PhpParser\ParserFactory;
9			use PhpParser\NodeTraverser as Traverser;
10			use Psr\Log\LoggerInterface;
11			use Padawan\Parser\NamespaceParser;
12
13			class Parser
14			{
15
16			public function __construct(
17			ParserFactory $parserFactory,
18			Traverser $traverser,
19			UseParser $useParser,
20			NamespaceParser $namespaceParser,
21			LoggerInterface $logger
22			) {
23			$this->parserFactory = $parserFactory;
24			$this->traverser = $traverser;
25			$this->useParser = $useParser;
26			$this->namespaceParser = $namespaceParser;
27			$this->walker = [];
28			$this->astPool = [];
29			$this->logger = $logger;
30			}
31			public function parseContent($file, $content, Uses $uses = null)
32			{
33			if (!$uses instanceof Uses) {
34			$uses = new Uses(new FQN);
35			}
36			$this->setUses($uses);
37			$this->setFileInfo($uses, $file);
38			try {
39			$parser = $this->parserFactory->create(ParserFactory::PREFER_PHP5);
40			$ast = $parser->parse($content);
41			} catch (\Exception $e) {
42			$this->logger->error(sprintf("Parsing failed in file %s\n", $file));
43			$this->logger->error($e);
44			$this->clearWalkers();
45			return;
46			}
47			$this->logger->addInfo(sprintf("Traversing with %s walkers",
			0 ignored issues – show Bug introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Psr\Log\LoggerInterface` as the method `addInfo()` does only exist in the following implementations of said interface: `Monolog\Logger`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
48			count($this->walkers)
			0 ignored issues – show Bug introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
49			));
50			$this->traverser->traverse($ast);
			0 ignored issues – show Bug introduced 2016-08-07 08:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$ast` defined by `$parser->parse($content)` on line `40` can also be of type `null`; however, `PhpParser\NodeTraverser::traverse()` does only seem to accept `array<integer,object<PhpParser\Node>>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
51			$nodes = $this->getResultScopes();
52			$this->clearWalkers();
53			return $nodes;
54			}
55			public function setUses(Uses $uses)
56			{
57			$this->uses = $uses;
58			$this->useParser->setUses($uses);
59			$this->namespaceParser->setUses($uses);
60			}
61			public function getUses()
62			{
63			return $this->uses;
64			}
65			public function parseFQCN($fqcn)
66			{
67			return $this->useParser->parseFQCN($fqcn);
68			}
69			public function addWalker($walker)
70			{
71			$this->walkers[] = $walker;
			0 ignored issues – show Bug introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
72			$this->traverser->addVisitor($walker);
73			}
74			public function clearWalkers() {
75			foreach ($this->walkers AS $walker) {
			0 ignored issues – show Bug introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
76			$this->traverser->removeVisitor($walker);
77			}
78			$this->walkers = [];
			0 ignored issues – show Bug introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
79			}
80			public function getResultScopes()
81			{
82			$nodes = [];
83			foreach ($this->walkers as $walker) {
			0 ignored issues – show Bug introduced 2016-05-18 10:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
84			$nodes[] = $walker->getResultScope();
85			}
86			if (count($nodes) === 1) {
87			return array_pop($nodes);
88			}
89			return $nodes;
90			}
91			public function setIndex($index)
92			{
93			foreach ($this->walkers as $walker) {
			0 ignored issues – show Bug introduced 2016-05-18 10:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
94			$walker->setIndex($index);
95			}
96			}
97
98			protected function setFileInfo(Uses $uses, $file)
99			{
100			foreach ($this->walkers as $walker) {
			0 ignored issues – show Bug introduced 2016-05-18 10:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `walkers` does not seem to exist. Did you mean `walker`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
101			$walker->updateFileInfo($uses, $file);
102			}
103			}
104
105			private $parsedClasses = [];
			0 ignored issues – show Unused Code introduced 2015-11-27 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$parsedClasses` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
106			/** @var ParserFactory */
107			private $parserFactory;
108			/** @var Traverser */
109			private $traverser;
110			/** @var Walker\WalkerInterface[] */
111			private $walker;
112			private $astPool;
113			private $logger;
114			/** @var NamespaceParser */
115			private $namespaceParser;
116			private $useParser;
117			private $uses;
118			}
119

mkusher / padawan.php

Issues (114)

Security Analysis no request data

src/Padawan/Parser/Parser.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like