ListCommand::execute() - Code Metrics - Inspection of "Project Persist with Amp" - mkusher/padawan.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#29)

by Aleh

created 2016-04-23 12:49 UTC

ListCommand::execute() A

↳ Parent: ListCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	17
rs	9.4285
cc	2
eloc	11
nc	2
nop	2

<?php

namespace Padawan\Command;

use Padawan\Domain\ProjectRepository;
use Padawan\Domain\Core\Project;
use Padawan\Domain\Core\Node\ClassData;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class ListCommand
 */
class ListCommand extends AsyncCommand
{
    protected function configure()
    {
        $this->setName("list")
            ->setDescription("Shows all classes with filepath")
            ->addArgument(
                "path",
                InputArgument::REQUIRED,
                "Path to the project root"
            );
    }
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $path = $input->getArgument("path");
        $container = $this->getContainer();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $projectRepository = $this->getContainer()->get(ProjectRepository::class);
        /** @var Project */
        $project = $projectRepository->findByPath($path);
        $classesList = [];
        foreach ($project->getIndex()->getClasses() as $class) {
            $classesList[] = [
                'fqcn' => $class->fqcn->toString(),
                'filepath' => $class->file
            ];
        }
        yield $output->write(json_encode($classesList));
    }
}


1			<?php
2
3			namespace Padawan\Command;
4
5			use Padawan\Domain\ProjectRepository;
6			use Padawan\Domain\Core\Project;
7			use Padawan\Domain\Core\Node\ClassData;
8			use Symfony\Component\Console\Input\InputInterface;
9			use Symfony\Component\Console\Input\InputArgument;
10			use Symfony\Component\Console\Output\OutputInterface;
11
12			/**
13			* Class ListCommand
14			*/
15			class ListCommand extends AsyncCommand
16			{
17			protected function configure()
18			{
19			$this->setName("list")
20			->setDescription("Shows all classes with filepath")
21			->addArgument(
22			"path",
23			InputArgument::REQUIRED,
24			"Path to the project root"
25			);
26			}
27			protected function execute(InputInterface $input, OutputInterface $output)
28			{
29			$path = $input->getArgument("path");
30			$container = $this->getContainer();
			0 ignored issues – show Unused Code introduced 2016-04-21 15:55 UTC by Report Bug Copy Issue Report `$container` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31
32			$projectRepository = $this->getContainer()->get(ProjectRepository::class);
33			/** @var Project */
34			$project = $projectRepository->findByPath($path);
35			$classesList = [];
36			foreach ($project->getIndex()->getClasses() as $class) {
37			$classesList[] = [
38			'fqcn' => $class->fqcn->toString(),
39			'filepath' => $class->file
40			];
41			}
42			yield $output->write(json_encode($classesList));
43			}
44			}
45

mkusher / padawan.php

Pull Request — master (#29)

ListCommand::execute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like