Padawan\Domain\Project\Collection\MethodsCollection

Complexity

Total Complexity

21

Size/Duplication

Total Lines	81
Duplicated Lines	25.93 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	add()	0	3	1
A	remove()	0	5	2
D	get()	15	31	9
C	all()	6	33	8

<?php

namespace Padawan\Domain\Project\Collection;

use Padawan\Domain\Project\Node\MethodData;
use Padawan\Domain\Project\Node\ClassData;
use Padawan\Domain\Project\Node\InterfaceData;

class MethodsCollection {
    private $methods = [];
    /** @property ClassData */
    private $class;

    public function __construct($class) {
        $this->class = $class;
    }
    public function add(MethodData $method) {
        $this->methods[$method->name] = $method;
    }
    public function remove(MethodData $method) {
        if (array_key_exists($method->name, $this->methods)) {
            unset($this->methods[$method->name]);
        }
    }
    public function get($name, Specification $spec = null) {
        if ($spec === null) {
            $spec = new Specification('private', 2, true);

2 is of type integer, but the function expects a boolean.

        }
        if (array_key_exists($name, $this->methods)) {

This code seems to be duplicated across your project.

            $method = $this->methods[$name];
            if ($spec->satisfy($method)) {
                return $method;
            }
            return null;
        }
        $parentSpec = new Specification(
            $spec->getParentMode(),
            $spec->isStatic(),
            $spec->isMagic()
        );
        if ($this->class instanceof ClassData) {
            $parent = $this->class->getParent();
            if ($parent instanceof ClassData) {
                return $parent->methods->get($name, $parentSpec);

The property $methods is declared private in Padawan\Domain\Project\Node\ClassData. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

            }
        }
        foreach ($this->class->getInterfaces() as $interface) {

This code seems to be duplicated across your project.

            if ($interface instanceof InterfaceData) {
                $method = $interface->methods->get($name, $parentSpec);
                if ($method instanceof MethodData) {
                    return $method;
                }
            }
        }
    }
    public function all(Specification $spec = null) {
        if ($spec === null) {
            $spec = new Specification;
        }
        $methods = [];
        foreach ($this->methods AS $method) {
            if ($spec->satisfy($method)) {
                $methods[$method->name] = $method;
            }
        }
        $parentSpec = new Specification(
            $spec->getParentMode(),
            $spec->isStatic(),
            $spec->isMagic()
        );
        if ($this->class instanceof ClassData) {
            $parent = $this->class->getParent();
            if ($parent instanceof ClassData) {
                $parentM = $parent->methods->all($parentSpec);

The property $methods is declared private in Padawan\Domain\Project\Node\ClassData. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

                $methods = array_merge(
                    $parentM,
                    $methods
                );
            }
        }
        foreach ($this->class->getInterfaces() as $interface) {

This code seems to be duplicated across your project.

            if ($interface instanceof InterfaceData) {
                $parentM = $interface->methods->all($parentSpec);
                $methods = array_merge($parentM, $methods);
            }
        }
        return $methods;
    }
}