MethodScope::__construct() - Code Metrics - mkusher/padawan.php - Measure and Improve Code Quality continuously with Scrutinizer

MethodScope::__construct() A
last analyzed 2016-12-29 09:07 UTC

↳ Parent: MethodScope

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	2

<?php

namespace Padawan\Domain\Scope;

use Padawan\Domain\Project\Node\MethodData;
use Padawan\Domain\Scope;

class MethodScope extends AbstractChildScope
{
    /** @var MethodData */
    private $method;
    public function __construct(Scope $scope, MethodData $method)
    {
        parent::__construct($scope);
        $this->addVar($this->getParent()->getVar('this'));
        $this->method = $method;
        foreach ($method->arguments as $param) {
            $this->addVar($param);
        }
    }
    public function getFQCN()
    {
        return $this->getParent()->getFQCN();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
    public function getClass()
    {
        return $this->getParent()->getClass();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


MethodScope::__construct() A
last analyzed 2016-12-29 09:07 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			namespace Padawan\Domain\Scope;
4
5			use Padawan\Domain\Project\Node\MethodData;
6			use Padawan\Domain\Scope;
7
8			class MethodScope extends AbstractChildScope
9			{
10			/** @var MethodData */
11			private $method;
12			public function __construct(Scope $scope, MethodData $method)
13			{
14			parent::__construct($scope);
15			$this->addVar($this->getParent()->getVar('this'));
16			$this->method = $method;
17			foreach ($method->arguments as $param) {
18			$this->addVar($param);
19			}
20			}
21			public function getFQCN()
22			{
23			return $this->getParent()->getFQCN();
			0 ignored issues – show Bug introduced 2016-05-08 10:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Padawan\Domain\Scope` as the method `getFQCN()` does only exist in the following implementations of said interface: `Padawan\Domain\Scope\ClassScope`, `Padawan\Domain\Scope\MethodScope`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
24			}
25			public function getClass()
26			{
27			return $this->getParent()->getClass();
			0 ignored issues – show Bug introduced 2016-05-08 10:22 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Padawan\Domain\Scope` as the method `getClass()` does only exist in the following implementations of said interface: `Padawan\Domain\Scope\ClassScope`, `Padawan\Domain\Scope\FileScope`, `Padawan\Domain\Scope\MethodScope`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
28			}
29			}
30

mkusher / padawan.php

MethodScope::__construct() A last analyzed 2016-12-29 09:07 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

MethodScope::__construct() A
last analyzed 2016-12-29 09:07 UTC