Filesystem - Code Metrics - mkungla/libhowi-filesystem - Measure and Improve Code Quality continuously with Scrutinizer

Filesystem B
last analyzed 2016-06-24 13:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	189
Duplicated Lines	100 %

Coupling/Cohesion

Components	3
Dependencies	11

Test Coverage

Coverage

91.74%

Importance

Changes	3
Bugs	0	Features	1

Metric	Value
c	3
b	0
f	1
dl	189
loc	189
ccs	100
cts	109
cp	0.9174
rs	8.3396
wmc	44
lcom	3
cbo	11

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	2
C	dir()	54	54	11
C	file()	34	34	14
D	infoObject()	28	28	9
A	tmp()	10	10	4
A	link()	10	10	4

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Filesystem often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Filesystem, and based on these observations, apply Extract Interface, too.

<?php
/********************************************************************
 * Created by:	Marko Kungla @ OkramLabs on Aug 6, 2012 - 9:21:34
 * Contact:		[email protected] - https://okramlabs.com
 * @copyright:	2015 OkramLabs - https://okramlabs.com
 * @license		MIT
 *
 * Package name:libhowi-filesystem
 * @category	HOWI3
 * @package		libhowi
 * @subpackage	filesystem
 * 
 * Lang:		PHP
 * Encoding:	UTF-8
 * File:		Filesystem.inc
 * @link		https://
 ********************************************************************
 * Contributors:
 * @author		Marko Kungla <[email protected]>
 *  	Github:	https://github.com/mkungla
 ********************************************************************
 * Comments:
 */
namespace HOWI3\libhowi\Filesystem\php7;

use \HOWI3\libhowi\Filesystem\Commons\AbstractFilesystem;
use \HOWI3\libhowi\Filesystem\Commons\FilesystemInterface;
use \HOWI3\libhowi\Filesystem\Commons\SharedMethodsInterface;
use \HOWI3\libhowi\Filesystem\Commons\TraitForResponse;
use \HOWI3\libhowi\Filesystem\php7\Objects\DirectoryPlaceholderObject;
use \HOWI3\libhowi\Filesystem\php7\Objects\DirectoryTreeObject;
use \HOWI3\libhowi\Filesystem\php7\Objects\FileObject;
use \HOWI3\libhowi\Filesystem\php7\Objects\InfoObject;
use \HOWI3\libhowi\Filesystem\php7\Objects\TmpObject;
use \HOWI3\libhowi\Filesystem\php7\Objects\LinkObject;
use \HOWI3\libhowi\Filesystem\php7\TraitForFileSystem;
use \HOWI3\libhowi\Filesystem\php7\TraitForSharedMethods;

class Filesystem extends AbstractFilesystem implements FilesystemInterface, SharedMethodsInterface

{
    use TraitForResponse;
    use TraitForFileSystem;
    use TraitForSharedMethods;

    /**
     *
     * {@inheritDoc}
     *
     */
    public function __construct($setCwd = false)
    {
        $this->debug(801);
        $this->setStatus(true);
        if (! $this->setCwd($setCwd)) {
            $append = error_get_last();
            $this->warning(500, $append['message']);
        }
        
        $this->tmp()->setTmp();
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function dir($directory = false, $dirname = false, $recursive = true, $mode = false, $context = false)
    {
        if (empty($directory)) {
            return false;
        }
        // ///////////
        $this->debug(807);
        if (array_key_exists($directory, $this->dirkeys) &&
             array_key_exists($this->dirkeys[$directory], $this->dirs) &&
             is_object($this->dirs[$this->dirkeys[$directory]])) {
            $response = $this->dirs[$this->dirkeys[$directory]];
            $this->response = $this->dirs[$this->dirkeys[$directory]]->response();
        } elseif (! empty($directory) && ! empty($dirname)) {
            
            $dir = $this->makeAbsolute($dirname . DIRECTORY_SEPARATOR . $directory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $HID = md5($dir);
            $this->dirkeys[$directory] = $HID;
            $this->dirs[$HID] = $this->isDir($dir) ? new DirectoryTreeObject($dir, 
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                DirectoryTreeObject::SKIP_DOTS) : new DirectoryPlaceholderObject($dir, $recursive, $mode, 
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                $context, $this->getLogFile(), $this->getLogLevel(), $this->getUID(), $this->getUsername());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            
            if ($this->dirs[$HID] instanceof DirectoryPlaceholderObject) {
                $this->setStatus($this->dirs[$HID]->getStatus());
                $this->setCode($this->dirs[$HID]->getCode());
            }
            
            if ($this->dirs[$HID] instanceof DirectoryTreeObject) {
                $this->dirs[$HID]->setFileClass('\HOWI3\libhowi\Filesystem\php7\Objects\FileObject');
                $this->dirs[$HID]->setInfoClass('\HOWI3\libhowi\Filesystem\php7\Objects\InfoObject');
                $this->dirs[$HID]->setLogFile($this->getLogFile());
                $this->dirs[$HID]->setLogLevel($this->getLogLevel());
                $this->dirs[$HID]->setUID($this->getUID());
                $this->dirs[$HID]->setUsername($this->getUsername());
                
                $this->response->setStatus(true);
            } else {
                
                /* We don't need DirectoryPlaceholderObject anymore for this directory */
                if ($this->isDir($dir)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    
                    $this->dirs[$HID] = new DirectoryTreeObject($dir, DirectoryTreeObject::SKIP_DOTS);
                    $this->dirs[$HID]->setFileClass('\HOWI3\libhowi\Filesystem\php7\Objects\FileObject');
                    $this->dirs[$HID]->setInfoClass('\HOWI3\libhowi\Filesystem\php7\Objects\InfoObject');
                    $this->dirs[$HID]->setLogFile($this->getLogFile());
                    $this->dirs[$HID]->setLogLevel($this->getLogLevel());
                    $this->dirs[$HID]->setUID($this->getUID());
                    $this->dirs[$HID]->setUsername($this->getUsername());
                }
            }
            
            $response = $this->dirs[$HID];
        }
        return $response;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function file($filename = false, $dirname = false, $data = '', $flags = FILE_APPEND, $context = null)

    {
        if (! empty($filename) && array_key_exists($filename, $this->files) &&
             is_object($this->files[$filename]))
            return $this->files[$filename];
        
        $this->debug(808);
        if (empty($filename)) {
            $this->notice(601);
            return false;
        }
        
        $dirname = empty($dirname) ? $this->getCwd() : $this->makeAbsolute($dirname);
        $real = $dirname . DIRECTORY_SEPARATOR . $filename;
        $real = str_replace(DIRECTORY_SEPARATOR . DIRECTORY_SEPARATOR, DIRECTORY_SEPARATOR, $real);
        
        if (! $this->exists($real) && ! $this->isWritable(dirname($real))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->warning(503, $real);
            return false;
        } elseif (! $this->exists($real) && $this->isWritable(dirname($real))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $result = empty($context) || ! is_resource($context) ? file_put_contents($real, $data, $flags) : file_put_contents(
                $real, $data, $flags, $context);
            $result = $result !== false ? $this->info(703, $real) : $this->warning(504, $real);
        }
        
        if ($this->exists($real)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->files[$filename] = new FileObject($real, 'r+');
            $this->files[$filename]->setFileClass('\HOWI3\libhowi\Filesystem\php7\Objects\FileObject');
            $this->files[$filename]->setInfoClass("\HOWI3\libhowi\Filesystem\php7\Objects\InfoObject");
            $result = $this->files[$filename];
        }
        
        return $result;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function infoObject($basename = false, $directory = false)

    {
        if (! empty($basename) && array_key_exists($basename, $this->infos) && is_object(
            $this->infos[$basename]))
            return $this->infos[$basename];
        
        $this->debug(809);
        if (empty($basename)) {
            $this->notice(602);
            return false;
        }
        
        $dirname = empty($directory) ? $this->getCwd() : $this->makeAbsolute($directory);
        $real = $dirname . DIRECTORY_SEPARATOR . $basename;
        $real = str_replace(DIRECTORY_SEPARATOR . DIRECTORY_SEPARATOR, DIRECTORY_SEPARATOR, $real);
        
        
        if (! $this->exists($real) && ! $this->isReadable($real)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->warning(504, $real);
            $result = false;
        } elseif ($this->exists($real)) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->infos[$basename] = new InfoObject($real);
            $this->infos[$basename]->setFileClass('\HOWI3\libhowi\Filesystem\php7\Objects\FileObject');
            $this->infos[$basename]->setInfoClass("\HOWI3\libhowi\Filesystem\php7\Objects\InfoObject");
            $result = $this->infos[$basename];
        }
        return $result;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function tmp($keyword = 'tmp')

    {
        if (array_key_exists($keyword, $this->tmp) && is_object($this->tmp[$keyword]) &&
             $this->tmp[$keyword] instanceof \HOWI3\libhowi\Filesystem\Commons\ObjectInterfaces\TmpInterface) {
            return $this->tmp[$keyword];
        } else {
            $this->tmp[$keyword] = new TmpObject();
            return $this->tmp[$keyword];
        }
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function link($keyword = 'link')

    {
        if (array_key_exists($keyword, $this->link) && is_object($this->link[$keyword]) &&
             $this->link[$keyword] instanceof \HOWI3\libhowi\Filesystem\Commons\ObjectInterfaces\LinkInterface) {
            return $this->link[$keyword];
        } else {
            $this->link[$keyword] = new LinkObject();
            return $this->link[$keyword];
        }
    }
}


Filesystem B
last analyzed 2016-06-24 13:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/********************************************************************
3		* Created by: Marko Kungla @ OkramLabs on Aug 6, 2012 - 9:21:34
4		* Contact: [email protected] - https://okramlabs.com
5		* @copyright: 2015 OkramLabs - https://okramlabs.com
6		* @license MIT
7		*
8		* Package name:libhowi-filesystem
9		* @category HOWI3
10		* @package libhowi
11		* @subpackage filesystem
12		*
13		* Lang: PHP
14		* Encoding: UTF-8
15		* File: Filesystem.inc
16		* @link https://
17		********************************************************************
18		* Contributors:
19		* @author Marko Kungla <[email protected]>
20		* Github: https://github.com/mkungla
21		********************************************************************
22		* Comments:
23		*/
24		namespace HOWI3\libhowi\Filesystem\php7;
25
26		use \HOWI3\libhowi\Filesystem\Commons\AbstractFilesystem;
27		use \HOWI3\libhowi\Filesystem\Commons\FilesystemInterface;
28		use \HOWI3\libhowi\Filesystem\Commons\SharedMethodsInterface;
29		use \HOWI3\libhowi\Filesystem\Commons\TraitForResponse;
30		use \HOWI3\libhowi\Filesystem\php7\Objects\DirectoryPlaceholderObject;
31		use \HOWI3\libhowi\Filesystem\php7\Objects\DirectoryTreeObject;
32		use \HOWI3\libhowi\Filesystem\php7\Objects\FileObject;
33		use \HOWI3\libhowi\Filesystem\php7\Objects\InfoObject;
34		use \HOWI3\libhowi\Filesystem\php7\Objects\TmpObject;
35		use \HOWI3\libhowi\Filesystem\php7\Objects\LinkObject;
36		use \HOWI3\libhowi\Filesystem\php7\TraitForFileSystem;
37		use \HOWI3\libhowi\Filesystem\php7\TraitForSharedMethods;
38
39	View Code Duplication	class Filesystem extends AbstractFilesystem implements FilesystemInterface, SharedMethodsInterface
		0 ignored issues – show Duplication introduced 2016-05-09 21:48 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...

mkungla / libhowi-filesystem

Filesystem B last analyzed 2016-06-24 13:20 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

How to fix Duplicated Code Complexity

Duplicated Code

Complex Class

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Filesystem B
last analyzed 2016-06-24 13:20 UTC