TraitForFileSystem - Code Metrics - mkungla/libhowi-filesystem - Measure and Improve Code Quality continuously with Scrutinizer

TraitForFileSystem D
last analyzed 2016-06-24 13:20 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	413
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	413
loc	413
ccs	185
cts	185
cp	1
rs	4.8717
wmc	82
lcom	1
cbo	0

22 Methods

Rating	Name	Duplication	Size	Complexity
A	cd()	4	4	1
C	rm()	29	29	8
A	scandir()	4	4	3
A	stat()	5	5	3
B	getDiskTotalSpace()	28	28	3
B	getDiskFreeSpace()	36	36	4
A	chgrp()	5	5	3
A	chmod()	8	8	4
A	chown()	8	8	3
A	clearstatcache()	7	7	3
C	copy()	46	46	13
A	mv()	13	13	4
A	namePatternMatch()	10	10	3
A	getGlob()	4	4	1
A	isUploadedFile()	5	5	1
A	getRealpathCache()	4	4	1
A	getRealpathCacheSize()	4	4	1
B	close()	15	15	6
A	touch()	12	12	4
A	getDirKeys()	4	4	1
A	getFileKeys()	4	4	1
C	createStructure()	22	22	11

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like TraitForFileSystem often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use TraitForFileSystem, and based on these observations, apply Extract Interface, too.

<?php
/*******************************************************************
 * Created by:  Marko Kungla @ OkramLabs on Aug 6, 2012 - 9:36:42
 * Contact:     [email protected] - https://okramlabs.com
 * @copyright   2015 OkramLabs - https://okramlabs.com
 * @license     MIT
 *
 * Package name: libhowi-filesystem
 * @category     HOWI3
 * @package      libhowi
 * @subpackage   filesystem
 * 
 * Lang:      PHP
 * Encoding:  UTF-8
 * File:      TraitForFileSystem.inc
 * @link      https://
 ********************************************************************
 * Contributors:
 * @author Marko Kungla <[email protected]>
 *           Github: https://github.com/mkungla
 ********************************************************************
 * Comments:
 */
namespace HOWI3\libhowi\Filesystem\php5;

use \RecursiveIteratorIterator;
use \HOWI3\libhowi\Filesystem\php5\Objects\DirectoryTreeObject;

trait TraitForFileSystem

{

    /**
     *
     * {@inheritDoc}
     *
     */
    public function cd($path = false, $validate_dir_name = false)

    {
        return $this->setCwd($path, $validate_dir_name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * rmdir
     *
     * {@inheritDoc}
     *
     */
    public function rm($pathname, $shred = false)
    {
        $pathname = $this->makeAbsolute($pathname);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $response = false;
        if (is_dir($pathname)) {
            
            $files = array_diff(scandir($pathname), 
                array(
                    '.',
                    '..'
                ));
            foreach ($files as $file) {
                
                (is_dir("$pathname/$file") ? $this->rm("$pathname/$file", $shred) : (! empty($shred) &&
                     ! $this->isLink($pathname . DIRECTORY_SEPARATOR . $file) ? exec(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
                        "shred -fzu $pathname" . DIRECTORY_SEPARATOR . "$file") : $this->rm(
                        $pathname . DIRECTORY_SEPARATOR . $file, $shred)));
            }
            
            $response = rmdir($pathname);
            $this->info(702, $pathname);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->response()->setStatus($response);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        } else {
            $this->info(702, $pathname);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->response()->setStatus($response);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            (! empty($shred) && ! $this->isLink($pathname) ? exec("shred -fzu $pathname") : unlink($pathname));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        return $response;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function scandir($path = false)
    {
        return ! empty($path) && is_dir($this->makeAbsolute($path)) ? scandir($this->makeAbsolute($path)) : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function stat($filename = false)
    {
        return ! empty($filename) && file_exists($this->makeAbsolute($filename)) ? stat(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->makeAbsolute($filename)) : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getDiskTotalSpace($partition_location = false, $convert = false)
    {
        if (empty($partition_location))
            $partition_location = $this->getCwd();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if (empty($convert))
            return disk_total_space($partition_location);
        
        $bytestotal = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $suffixes = array(
            'B',
            'kB',
            'MB',
            'GB',
            'TB',
            'PB',
            'EB',
            'ZB',
            'YB'
        );
        $bytestotal = disk_total_space($partition_location);
        
        $base = log($bytestotal, 1024);
        return array(
            round(pow(1024, $base - floor($base)), 2),
            $suffixes[floor($base)]
        );
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getDiskFreeSpace($partition_location = false, $convert = false)
    {
        if (empty($partition_location))
            $partition_location = $this->getCwd();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if (empty($convert))
            return disk_free_space($partition_location);
        
        $result = [
            0,
            'B'
        ];
        $bytestotal = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $suffixes = array(
            'B',
            'kB',
            'MB',
            'GB',
            'TB',
            'PB',
            'EB',
            'ZB',
            'YB'
        );
        $bytestotal = disk_free_space($partition_location);
        
        $base = log($bytestotal, 1024);
        
        if ($bytestotal > 0) {
            $result = array(
                round(pow(1024, $base - floor($base)), 2),
                $suffixes[floor($base)]
            );
        }
        return $result;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function chgrp($filename = false, $group = false)
    {
        return ! empty($filename) && $this->exists($this->makeAbsolute($filename)) ? chgrp(
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->makeAbsolute($filename), $group) : false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function chmod($filename = false, $mode = false)
    {
        $filename = $this->makeAbsolute($filename);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if (file_exists($filename) && ! empty($mode) && is_int($mode))
            return chmod($filename, octdec(str_pad($mode, 4, 0, STR_PAD_LEFT)));
        else
            return false;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function chown($filename = false, $user = false)
    {
        $filename = $this->makeAbsolute($filename);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if (file_exists($filename) && ! empty($user))
            return chown($filename, $user);
        else
            return false;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function clearstatcache($clear_realpath_cache = false, $filename = false)
    {
        if (! empty($filename) && ! empty($clear_realpath_cache))
            clearstatcache($clear_realpath_cache, $this->makeAbsolute($filename));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        else
            clearstatcache();
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function copy($source = false, $dest = false, $context = false)
    {
        $source = $this->makeAbsolute($source);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $dest = $this->makeAbsolute($dest);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if (! empty($source) && ! empty($dest) && ! is_dir($source)) {
            
            if (empty($context))
                return copy($source, $dest);
            else
                return copy($source, $dest, $context);
        } elseif ((! empty($source) && ! empty($dest)) && is_dir($source) && ! file_exists($dest)) {
            
            $tmp_key = basename($source);
            $tmp_key2 = basename($dest);
            $tmp_src_key = $this->dir($tmp_key, dirname($source));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            
            $this->dir($tmp_key2, dirname($dest), false, $tmp_src_key->getPerms());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->close($tmp_key);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $this->close($tmp_key2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            
            foreach ($iterator = new RecursiveIteratorIterator(
                new \RecursiveDirectoryIterator($source, \RecursiveDirectoryIterator::SKIP_DOTS),  // DirectoryTreeObject::CURRENT_AS_FILEINFO
                \RecursiveIteratorIterator::SELF_FIRST) as $item) {
                if ($item->isDir()) {
                    if (empty($context)) {
                        mkdir($dest . DIRECTORY_SEPARATOR . $iterator->getSubPathName(), 
                            octdec(str_pad($iterator->getPerms(), 4, 0, STR_PAD_LEFT)));
                    } 

                    else
                        mkdir($dest . DIRECTORY_SEPARATOR . $iterator->getSubPathName(), 
                            octdec(str_pad($iterator->getPerms(), 4, 0, STR_PAD_LEFT)), false, $context);
                } else {
                    if (empty($context))
                        $this->copy($item, $dest . DIRECTORY_SEPARATOR . $iterator->getSubPathName());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    else
                        $this->copy($item, $dest . DIRECTORY_SEPARATOR . $iterator->getSubPathName(), 
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                            $context);
                }
            }
            
            return true;
        } else
            return false;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function mv($oldname = false, $newname = false, $context = false)
    {
        if (empty($oldname) || empty($newname))
            return false;
        
        $oldname = $this->makeAbsolute($oldname);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        $newname = $this->makeAbsolute($newname);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if (! empty($context))
            return rename($oldname, $newname, $context);
        
        return rename($oldname, $newname);
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function namePatternMatch($pattern = false, $string = false, $flags = false)
    {
        if (empty($pattern))
            return false;
        
        if (! empty($flags))
            return fnmatch($pattern, $string, $flags);
        else
            return fnmatch($pattern, $string);
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getGlob($pattern = false, $flags = 0)
    {
        return glob($pattern, $flags);
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function isUploadedFile($filename = false)
    {
        $filename = $this->makeAbsolute($filename);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return is_uploaded_file($filename);
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getRealpathCache()
    {
        return realpath_cache_get();
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getRealpathCacheSize()
    {
        return realpath_cache_size();
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function close($keyword = false)
    {
        if (!empty($keyword) && array_key_exists($keyword, $this->dirkeys) &&
class MyClass { }

$x = new MyClass();
$x->foo = true;
             array_key_exists($this->dirkeys[$keyword], $this->dirs)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            unset($this->dirs[$this->dirkeys[$keyword]]);
            unset($this->dirkeys[$keyword]);
            return true;
        } elseif(!empty($keyword) && array_key_exists($keyword,$this->files)) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->files[$keyword] = null;
            unset($this->files[$keyword]);
            return true;
        } else {
            return false;
        }
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function touch($filename = false, $time = false, $atime = false)
    {
        if (empty($filename))
            return false;
        
        $filename = $this->makeAbsolute($filename);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        $time = ! empty($time) ? $time : time();
        $atime = ! empty($atime) ? $atime : time();
        
        return touch($filename, $time, $atime);
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getDirKeys()

    {
        return $this->dirkeys;
    }

    /**
     *
     * {@inheritDoc}
     *
     */
    public function getFileKeys()

    {
        return $this->files;
    }
    
    /**
     *
     * {@inheritDoc}
     *
     */
    public function createStructure($rootpath, $data_array, $skip_debug = false)
    {
        $absolute_path = $this->makeAbsolute($rootpath);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if (empty($skip_debug))
            $this->debug(810);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        if (empty($rootpath) || ! is_array($data_array) ||
             (! $this->isWritable($absolute_path) && ! $this->isWritable(dirname($absolute_path))))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->warning(506) && false;
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        
        if (! $this->isDir($absolute_path))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            mkdir($absolute_path, 0755, true);
        
        foreach ($data_array as $key => $val) {
            if (is_array($val))
                ! $this->createStructure($absolute_path . DIRECTORY_SEPARATOR . $key, $val, true);
            else
                touch($absolute_path . DIRECTORY_SEPARATOR . $val);
        }
        if (empty($skip_debug))
            $this->info(704, $rootpath);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        return true;
    }
}


1			<?php
2			/*******************************************************************
3			* Created by: Marko Kungla @ OkramLabs on Aug 6, 2012 - 9:36:42
4			* Contact: [email protected] - https://okramlabs.com
5			* @copyright 2015 OkramLabs - https://okramlabs.com
6			* @license MIT
7			*
8			* Package name: libhowi-filesystem
9			* @category HOWI3
10			* @package libhowi
11			* @subpackage filesystem
12			*
13			* Lang: PHP
14			* Encoding: UTF-8
15			* File: TraitForFileSystem.inc
16			* @link https://
17			********************************************************************
18			* Contributors:
19			* @author Marko Kungla <[email protected]>
20			* Github: https://github.com/mkungla
21			********************************************************************
22			* Comments:
23			*/
24			namespace HOWI3\libhowi\Filesystem\php5;
25
26			use \RecursiveIteratorIterator;
27			use \HOWI3\libhowi\Filesystem\php5\Objects\DirectoryTreeObject;
28
29		View Code Duplication	trait TraitForFileSystem
			0 ignored issues – show Duplication introduced 2016-05-09 21:48 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
30			{
31
32			/**
33			*
34			* {@inheritDoc}
35			*
36			*/
37	12		public function cd($path = false, $validate_dir_name = false)
			0 ignored issues – show Documentation introduced 2016-06-24 12:50 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
38			{

mkungla / libhowi-filesystem

TraitForFileSystem D last analyzed 2016-06-24 13:20 UTC