Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
41 | class Entity implements EntityInterface |
||
42 | { |
||
43 | use MeshAttributes; |
||
44 | |||
45 | /** |
||
46 | * Array of used components |
||
47 | * |
||
48 | * @var array |
||
49 | */ |
||
50 | protected $components = array(); |
||
51 | |||
52 | /** |
||
53 | * Array of used animations |
||
54 | * |
||
55 | * @var array |
||
56 | */ |
||
57 | protected $animations = array(); |
||
58 | |||
59 | /** |
||
60 | * Dom element attributes |
||
61 | * |
||
62 | * @var unknown |
||
63 | */ |
||
64 | protected $attrs = array(); |
||
65 | |||
66 | /** |
||
67 | * Children Factory |
||
68 | * |
||
69 | * @var EntityChildrenFactory |
||
70 | */ |
||
71 | protected $childrenFactory; |
||
72 | |||
73 | /** |
||
74 | * Indent used when rendering formated outout |
||
75 | * |
||
76 | * @var unknown |
||
77 | */ |
||
78 | private $indentation = 0; |
||
79 | |||
80 | /** |
||
81 | * Constructor |
||
82 | * |
||
83 | * @param string $id |
||
84 | */ |
||
85 | 80 | public function __construct(string $id = 'untitled') |
|
92 | |||
93 | /** |
||
94 | * Reset primitive default attributtes |
||
95 | * |
||
96 | * {@inheritdoc} |
||
97 | * |
||
98 | * @return void |
||
99 | */ |
||
100 | 75 | public function reset() |
|
107 | |||
108 | /** |
||
109 | * Set DOM attributes |
||
110 | * |
||
111 | * @param string $attr |
||
112 | * @param string $val |
||
113 | * @return void |
||
114 | */ |
||
115 | 80 | public function attr(string $attr, string $val) |
|
119 | |||
120 | /** |
||
121 | * Child entity / primitive |
||
122 | * |
||
123 | * @return EntityChildrenFactory |
||
|
|||
124 | */ |
||
125 | 5 | public function child(): EntityChildrenFactory |
|
129 | |||
130 | /** |
||
131 | * Position component |
||
132 | * |
||
133 | * All entities inherently have the position component. |
||
134 | * |
||
135 | * @param int|float $x_axis |
||
136 | * @param int|float $y_axis |
||
137 | * @param int|float $z_axis |
||
138 | * @return EntityInterface |
||
139 | */ |
||
140 | 4 | public function position(float $x_axis = 0, float $y_axis = 0, float $z_axis = 0): EntityInterface |
|
147 | |||
148 | /** |
||
149 | * Rotation component |
||
150 | * |
||
151 | * All entities inherently have the rotation component. |
||
152 | * |
||
153 | * @param int|float $roll |
||
154 | * @param int|float $pitch |
||
155 | * @param int|float $yaw |
||
156 | * @return EntityInterface |
||
157 | */ |
||
158 | 4 | public function rotation(float $roll = 0, float $pitch = 0, float $yaw = 0): EntityInterface |
|
165 | |||
166 | /** |
||
167 | * Scale component |
||
168 | * |
||
169 | * All entities inherently have the scale component. |
||
170 | * |
||
171 | * @param int|float $scale_x |
||
172 | * @param int|float $scale_y |
||
173 | * @param int|float $scale_z |
||
174 | * @return EntityInterface |
||
175 | */ |
||
176 | 6 | public function scale(float $scale_x = 1, float $scale_y = 1, float $scale_z = 1): EntityInterface |
|
183 | |||
184 | /** |
||
185 | * Animations |
||
186 | * |
||
187 | * @param mixed $name |
||
188 | * @return \AframeVR\Interfaces\AnimationInterface |
||
189 | */ |
||
190 | 2 | public function animation($name = 'untitled'): AnimationInterface |
|
194 | |||
195 | /** |
||
196 | * Set mixin attribute |
||
197 | * |
||
198 | * @param string $id |
||
199 | * @return \AframeVR\Core\Entity |
||
200 | */ |
||
201 | 1 | public function mixin(string $id) |
|
202 | { |
||
203 | 1 | $this->attr('mixin', $id); |
|
204 | 1 | return $this; |
|
205 | } |
||
206 | |||
207 | /** |
||
208 | * Load component for this entity |
||
209 | * |
||
210 | * @param string $component_name |
||
211 | * @throws \AframeVR\Core\Exceptions\BadComponentCallException |
||
212 | * @return object|null |
||
213 | */ |
||
214 | 80 | View Code Duplication | public function component(string $component_name) |
228 | |||
229 | /** |
||
230 | * Handle entity components |
||
231 | * |
||
232 | * Since we might need to customize these to have |
||
233 | * custom components loaded as $this->methosd aswell therefore |
||
234 | * we have these placeholder magic methods here |
||
235 | * |
||
236 | * @param string $component_name |
||
237 | * @param array $args |
||
238 | */ |
||
239 | 30 | View Code Duplication | public function __call(string $component_name, array $args) |
250 | |||
251 | /** |
||
252 | * Create and add DOM element of the entity |
||
253 | * |
||
254 | * @param \DOMDocument $aframe_dom |
||
255 | * @return \DOMElement |
||
256 | */ |
||
257 | 13 | public function domElement(\DOMDocument &$aframe_dom): DOMElement |
|
276 | |||
277 | /** |
||
278 | * Append DOM attributes no set by components |
||
279 | * |
||
280 | * @param \DOMElement $a_entity |
||
281 | */ |
||
282 | 13 | private function appendAttributes(\DOMElement &$a_entity) |
|
288 | |||
289 | 13 | View Code Duplication | private function setAttribute(&$a_entity, $attr, $val) |
296 | |||
297 | /** |
||
298 | * Append childern to entities DOM element |
||
299 | * |
||
300 | * @param \DOMDocument $aframe_dom |
||
301 | * @param \DOMElement $a_entity |
||
302 | */ |
||
303 | 13 | private function appendChildren(\DOMDocument &$aframe_dom, \DOMElement &$a_entity) |
|
313 | |||
314 | /** |
||
315 | * Append childern to entities DOM element |
||
316 | * |
||
317 | * @param \DOMDocument $aframe_dom |
||
318 | * @param \DOMElement $a_entity |
||
319 | */ |
||
320 | 13 | private function appendAnimations(\DOMDocument &$aframe_dom, \DOMElement &$a_entity) |
|
328 | |||
329 | /** |
||
330 | * Add format comment |
||
331 | * |
||
332 | * @param \DOMDocument $aframe_dom |
||
333 | * @param \DOMElement $a_entity |
||
334 | * @param string $content |
||
335 | */ |
||
336 | 3 | private function addFormatComment(\DOMDocument &$aframe_dom, \DOMElement &$a_entity, string $content) |
|
343 | } |
||
344 |
This check compares the return type specified in the
@return
annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.