Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 26 | View Code Duplication | class DefaultMethods |
|
|
|
|||
| 27 | { |
||
| 28 | /** |
||
| 29 | * When any position component methods are called then init others |
||
| 30 | * |
||
| 31 | * @param array $dom_attributes |
||
| 32 | * @return void |
||
| 33 | */ |
||
| 34 | 15 | private function init(array &$dom_attributes) |
|
| 40 | |||
| 41 | /** |
||
| 42 | * Negative X axis extends left. |
||
| 43 | * Positive X Axis extends right. |
||
| 44 | * |
||
| 45 | * @param array $dom_attributes |
||
| 46 | * @param double $x_axis |
||
| 47 | * @return void |
||
| 48 | */ |
||
| 49 | 15 | public function positionX(array &$dom_attributes, float $x_axis) |
|
| 54 | |||
| 55 | /** |
||
| 56 | * Negative Y axis extends up. |
||
| 57 | * Positive Y Axis extends down. |
||
| 58 | * |
||
| 59 | * @param array $dom_attributes |
||
| 60 | * @param double $y_axis |
||
| 61 | * @return void |
||
| 62 | */ |
||
| 63 | 14 | public function positionY(array &$dom_attributes, float $y_axis) |
|
| 68 | |||
| 69 | /** |
||
| 70 | * Negative Z axis extends in. |
||
| 71 | * Positive Z Axis extends out. |
||
| 72 | * |
||
| 73 | * @param array $dom_attributes |
||
| 74 | * @param double $z_axis |
||
| 75 | * @return void |
||
| 76 | */ |
||
| 77 | 14 | public function positionZ(array &$dom_attributes, float $z_axis) |
|
| 82 | } |
||
| 83 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.